* Added the ability to drag and drop any atom reference to a `AtomReference` without the need to manually select the type through the 3 dot button on inspector
- I also refactored the `AtomBaseReferenceDrawer` script so that it's easier to read/maintain.
- The class `BaseAtomInstancer` is needed to be able to auto reference instancers. Because when we drag a `GameObject` we need to get it's `AtomInstancer` component to determine the reference type. Also, the class represents something similiar to `BaseAtom` for `ScriptableObjects` but for `MonoBehaviors`, so it makes sense to have it.
* Addressed some of the key points @soraphis made and fixed the issues I mentioned on the #442 pull
- Solved the probelms that arise when a `GameObject` has multiple different instancers in it (mentioned in the #442 pull)
- Removed `UsageIndex` class as it is not needed
* Fixed file name not matching the class name
* Addressed @soraphis issue of `GuiData` not being a struct, so I changed it and modified the `AtomBaseReferenceDrawer` to handle it as a struct
* Fixed `GuiData` isn't updated even though `position` and `label` parameters of the `OnGUI` are.
* Reversed the for loops order because the order of the components inside the `GameObject` are more important than the order of the "usages" so it fixes that problem
- Also cleaned the code a bit
* Missed a line that could be simplified
- Made `Set/GetUsageIndex` into static because we can
* Fixed issue mentioned in #442 > "you only get the first component, when dragging in a game object, so there could be the case where selecting the type manually and dragging into it will swap the field"
The issue is when there are multiple instancer components in a single `GameObject` then when you drag said `GameObject` then the atom reference will switch to the first instancer (via usage index) no matter the intent of the user. However, the intent of the user could be to pick the 2nd or 3rd reference, so he could manually select the usage type using the 3 dots button, but it won't work if he decides to drag and drop a `GameObject` that has multiple instancers that the reference could switch to automatically, which will always be the first instancer of the dragged `GameObject`, which bascially makes the experience frustrating to that particular scenario. Now, you can guess that the issue is hyper specific just because of how hard it is to me to explain it in text, so don't worry if you didn't get it on the first read. If you would like me to showcase it, I will gladly share a video example of what I mean.
* Fixed index out of range exception (I forgot that I set the usage index at the end of this method and it could be -1 because of this line)
* Redone the previous push because it was incorrect
* Response to @AdamRamberg to try to make the code section clearer by refactoring it
* * Minor cosmetic changes
* Replace switch expression to be backwards compatible (for example to be able to run the unity-atoms-example project)
* Always remove the last greater than symbol in GetPropertyTypeName to take into account generic types
* Added comment to IAtomInstancer
---------
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* fix: handling dead references when resetting objects. (#417)
* fix: wrong state checked in AtomEvent reset (#403)
* fix: make AtomValueList compatible with disabled domain reload (#419)
fix: AtomValueList now resets runtime modifications (#418)
* fix: handling dead references when resetting objects for AtomValueList. (#417)
* removed the dead-reference handling (#417)
- this will be addressed in (#421)
compacted the Playmode state change
* Remove Atom types from their _instances lists OnDisable()
* Added disclaimer / comment regarding the solution
---------
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* fix: wrong state checked in AtomEvent reset (#403)
* fix: make AtomValueList compatible with disabled domain reload (#419)
fix: AtomValueList now resets runtime modifications (#418)
* fix: handling dead references when resetting objects for AtomValueList. (#417)
* removed the dead-reference handling (#417)
- this will be addressed in (#421)
compacted the Playmode state change
* [Added] Feature for #67 event name suggestion initial version
* [Refactored] Cleaned naming code to its own class
* [Fixed] c# range is not supported in 2019.4 LTS
* * Simplified logic for suggested name in AtomDrawer
* Simplified CleanPropertyName - first if-block was catched by second block
* Replaced FilterLastIndexOf with typeof(T).Name
---------
Co-authored-by: Thimo de Ram <tdram@esites.local>
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* * Remove generateDocs.js
* Update PUBLISHING.md
* Remove generated md files
* Remove all package.json deps in root since they are not needed anymore
* Remove all refs to api folder in website
* Replaced header link to API with link to the first tutorial
* Tutorial -> Tutorials
* Clean up
* fix: event replay buffer persisting if domain reload disabled
* fix: clearing event registrations when changing playmode stage.
* feat: add philosophy as separate section
* feat: added section about pre-change transformers
* made overview a bit slimmer and less intimidating.
* feat: added a page about tags
* revert file to state of canary
* * Removed everything that talks about implementations in the Philopsophy section.
* Added notes from Ryan Hipple's talk to the philosophy section
* Reintroduced the old overview page with changes from #416, since I believe it is
* Removed all Admonitions, since they are not working in docusaurus v1
* Proof read and made corrections to variables transformers and tags pages.
* Added changes in "creating atoms" from #416
* Replaced old ref / link to "Overview and philosophy"
---------
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* fix: pasting FullQualifiedName in the generators text field, not picking up the actual type
* fix: replaced TryAdd call to support lower .NET versions
* prevent null reference exceptions in editor when using not-serializable types
* - Draw warning helpbox only once in AtomVariableEditor.cs
- Minor clean up
* Revert unintended removed line
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* removed ondisable method, to fix#349
* Remove _changed and _changedInstantiatedAtRuntime since they are not used anymore
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* fix: #353 while keeping #289 fixed
* Fix height of popup (was covering click area of expanded type's properties)
Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
* Update CHANGELOG
* Update version in documentation to 4.4.4
* Remove reference to Examples directory
* Update package-lock.json
* Update API documentation
When using an Event Reference Listener with a variable, GetOrCreateEvent() is sometimes called after TriggerInitialEvents(). This commit solves this issue.
