Commit Graph

5 Commits

Author SHA1 Message Date
Adam Ramberg
37364196d8 Fixes to PR #38 2019-05-04 17:08:26 +02:00
Soraphis
42ef1682c0 Removed event generic parameters from ScriptableObjectReference
- they are not needed and hinder the implementation if a type does not have events
2019-05-04 11:49:35 +02:00
Jeff Campbell
24eee05851 Removed redundant code
* Removed redundant interfaces IWithValue<T> and IWithOldValue<T> as they and their methods are unused.
* Removed redundant extensions and util classes/methods as they are unused by anything in the library
* Created AssemblyInfo.cs file to contain [assembly] attributes to expose internal types and methods to the UnityAtomsEditor assembly. This makes it easier to keep non-user facing code as internal, but still expose it for Editor usage.
* Removed AtomsLogger as this class does not add any value to the library. Some situations where it was being used in to warn of missing components such as OnButtonClickHook were doing so to warn of a missing component when it was already guaranteed to be there via the [RequireComponent] attribute (situation could never occur where it was not present). In some cases it was being used situationally like an Assert for situations where an NRE or other exception would immediately follow. Replacing these with an Assert accomplishes the same goal of removing these logging checks for non-editor builds while at the same time forcefully throwing an error with a more user-friendly error if a non-descript error would immediately be thrown.
* Where logs were being made previously with AtomsLogger, if not replaced with an Assert or removed entirely they are now being made with a const LogPrefix in new internal static class RuntimeConstants
2019-04-15 23:26:43 +02:00
Adam Ramberg
29a3207d9d Move editor specific code into logger 2019-04-12 09:17:47 +02:00
Soraphis
fa2d55fcf7 Refactored all type-related folders into an folder "Types" 2019-04-08 17:25:32 +02:00