caleb-brown/unity-atoms
1
0
Fork 0
mirror of https://github.com/unity-atoms/unity-atoms.git synced 2025-01-22 08:08:51 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Lazy stacktrace toString conversion (#238)

Browse Source 
when disabling atoms debug mode, StackTraceEntries are allocated, but their strings are never used.
This commit is contained in:
Oliver Biwer 2021-01-27 12:57:45 +01:00 committed by Adam Ramberg
parent 58b52427c8
commit 6727645890
1 changed files with 34 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
Packages/Core/Runtime/StackTrace/StackTraceEntry.cs
View File

@ -8,9 +8,21 @@ namespace UnityAtoms
{
private readonly Guid _id;
private readonly int _frameCount;
private readonly string _stackTrace;
private string _stackTrace;
private readonly object _value;
private readonly bool _constructedWithValue = false;
private StackTrace _trace;
private StackTraceEntry(StackTrace trace)
{
_id = Guid.NewGuid();
_trace = trace;
if (Application.isPlaying)
{
_frameCount = Time.frameCount;
}
}
private StackTraceEntry(string stackTrace)
{
@ -35,9 +47,22 @@ namespace UnityAtoms
}
}
public static StackTraceEntry Create(object obj, int skipFrames = 0) => new StackTraceEntry(new StackTrace(skipFrames).ToString(), obj);
private StackTraceEntry(StackTrace trace, object value)
{
_value = value;
_constructedWithValue = true;
_id = Guid.NewGuid();
_trace = trace;
public static StackTraceEntry Create(int skipFrames = 0) => new StackTraceEntry(new StackTrace(skipFrames).ToString());
if (Application.isPlaying)
{
_frameCount = Time.frameCount;
}
}
public static StackTraceEntry Create(object obj, int skipFrames = 0) => new StackTraceEntry(new StackTrace(skipFrames), obj);
public static StackTraceEntry Create(int skipFrames = 0) => new StackTraceEntry(new StackTrace(skipFrames));
public override bool Equals(object obj) => Equals(obj as StackTraceEntry);
@ -49,17 +74,14 @@ namespace UnityAtoms
public override string ToString()
{
string stringifiedValue = "";
if (_constructedWithValue)
if (_stackTrace == null)
{
try
{
stringifiedValue = $"[{(_value == null ? "null" : _value.ToString())}]";
}
catch { /* Ignore error */ }
_stackTrace = _trace.ToString();
}
return $"{_frameCount} {stringifiedValue}{_stackTrace}";
return _constructedWithValue
? $"{_frameCount} [{(_value == null ? "null" : _value.ToString())}] {_stackTrace}"
: $"{_frameCount} {_stackTrace}";
}
}
}
}