caleb-brown/unity-atoms
1
0
Fork 0
mirror of https://github.com/unity-atoms/unity-atoms.git synced 2025-01-22 08:08:51 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

removed the dead-reference handling (#417)

Browse Source 
- this will be addressed in (#421)
compacted the Playmode state change
This commit is contained in:
Oliver Biwer 2023-08-03 19:16:59 +02:00
parent 6e51c70f33
commit 108ad1a2d8
2 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Packages/Core/Runtime/Events/AtomEvent.cs
View File

@ -62,15 +62,8 @@ namespace UnityAtoms
#if UNITY_EDITOR #if UNITY_EDITOR
private static void HandlePlayModeStateChange(PlayModeStateChange state) private static void HandlePlayModeStateChange(PlayModeStateChange state)
{ {
if (state == PlayModeStateChange.ExitingEditMode) // BEFORE any GO is initialized: if (state == PlayModeStateChange.ExitingEditMode // BEFORE any GO is initialized:
{ || state == PlayModeStateChange.EnteredEditMode) // AFTER Playmode stopped
foreach (var instance in _instances)
{
instance._replayBuffer.Clear();
instance.UnregisterAll();
}
}
else if (state == PlayModeStateChange.EnteredEditMode) // AFTER Playmode stopped
{ {
foreach (var instance in _instances) foreach (var instance in _instances)
{ {

10
Packages/Core/Runtime/ValueLists/AtomValueList.cs
View File

@ -74,11 +74,6 @@ namespace UnityAtoms
{ {
foreach (var instance in _instances) foreach (var instance in _instances)
{ {
if (instance == null)
{
_instances.Remove(instance);
continue;
}
if(instance._startCleared) instance.list.Clear(); if(instance._startCleared) instance.list.Clear();
instance._initial = instance.list.ToList(); instance._initial = instance.list.ToList();
} }
@ -87,11 +82,6 @@ namespace UnityAtoms
{ {
foreach (var instance in _instances) foreach (var instance in _instances)
{ {
if (instance == null) // might be for UnityEngine.Objects
{
_instances.Remove(instance);
continue;
}
instance.list = instance._initial; instance.list = instance._initial;
} }
} }