mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-22 16:18:28 -05:00
61b7e5916d
The new module redact test will fail with valgrind:
```
[err]: modules can redact arguments in tests/unit/moduleapi/auth.tcl
Expected 'slowlog reset' to be equal to 'auth.redact 1 (redacted) 3 (redacted)' (context: type eval line 12 cmd {assert_equal {slowlog reset} [lindex [lindex [r slowlog get] 2] 3]} proc ::test)
```
The reason is that with `slowlog-log-slower-than 10000`,
`slowlog get` will have a chance to exceed 10ms.
Made two changes to avoid failure:
1. change `slowlog-log-slower-than` from 10000 to -1, distable it.
2. assert to use the previous execution result.
In theory, the second one can actually be left unchanged, but i
think it will be better if it is changed.
91 lines
3.0 KiB
Tcl
91 lines
3.0 KiB
Tcl
set testmodule [file normalize tests/modules/auth.so]
|
|
|
|
start_server {tags {"modules"}} {
|
|
r module load $testmodule
|
|
|
|
test {Modules can create a user that can be authenticated} {
|
|
# Make sure we start authenticated with default user
|
|
r auth default ""
|
|
assert_equal [r acl whoami] "default"
|
|
r auth.createmoduleuser
|
|
|
|
set id [r auth.authmoduleuser]
|
|
assert_equal [r client id] $id
|
|
|
|
# Verify returned id is the same as our current id and
|
|
# we are authenticated with the specified user
|
|
assert_equal [r acl whoami] "global"
|
|
}
|
|
|
|
test {De-authenticating clients is tracked and kills clients} {
|
|
assert_equal [r auth.changecount] 0
|
|
r auth.createmoduleuser
|
|
|
|
# Catch the I/O exception that was thrown when Redis
|
|
# disconnected with us.
|
|
catch { [r ping] } e
|
|
assert_match {*I/O*} $e
|
|
|
|
# Check that a user change was registered
|
|
assert_equal [r auth.changecount] 1
|
|
}
|
|
|
|
test {Modules can't authenticate with ACLs users that dont exist} {
|
|
catch { [r auth.authrealuser auth-module-test-fake] } e
|
|
assert_match {*Invalid user*} $e
|
|
}
|
|
|
|
test {Modules can authenticate with ACL users} {
|
|
assert_equal [r acl whoami] "default"
|
|
|
|
# Create user to auth into
|
|
r acl setuser auth-module-test on allkeys allcommands
|
|
|
|
set id [r auth.authrealuser auth-module-test]
|
|
|
|
# Verify returned id is the same as our current id and
|
|
# we are authenticated with the specified user
|
|
assert_equal [r client id] $id
|
|
assert_equal [r acl whoami] "auth-module-test"
|
|
}
|
|
|
|
test {Client callback is called on user switch} {
|
|
assert_equal [r auth.changecount] 0
|
|
|
|
# Auth again and validate change count
|
|
r auth.authrealuser auth-module-test
|
|
assert_equal [r auth.changecount] 1
|
|
|
|
# Re-auth with the default user
|
|
r auth default ""
|
|
assert_equal [r auth.changecount] 1
|
|
assert_equal [r acl whoami] "default"
|
|
|
|
# Re-auth with the default user again, to
|
|
# verify the callback isn't fired again
|
|
r auth default ""
|
|
assert_equal [r auth.changecount] 0
|
|
assert_equal [r acl whoami] "default"
|
|
}
|
|
|
|
test {modules can redact arguments} {
|
|
r config set slowlog-log-slower-than 0
|
|
r slowlog reset
|
|
r auth.redact 1 2 3 4
|
|
r auth.redact 1 2 3
|
|
r config set slowlog-log-slower-than -1
|
|
set slowlog_resp [r slowlog get]
|
|
|
|
# There will be 3 records, slowlog reset and the
|
|
# two auth redact calls.
|
|
assert_equal 3 [llength $slowlog_resp]
|
|
assert_equal {slowlog reset} [lindex [lindex $slowlog_resp 2] 3]
|
|
assert_equal {auth.redact 1 (redacted) 3 (redacted)} [lindex [lindex $slowlog_resp 1] 3]
|
|
assert_equal {auth.redact (redacted) 2 (redacted)} [lindex [lindex $slowlog_resp 0] 3]
|
|
}
|
|
|
|
test "Unload the module - testacl" {
|
|
assert_equal {OK} [r module unload testacl]
|
|
}
|
|
}
|