mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-23 08:38:27 -05:00
a89bf734a9
The scan key module API provides the scan callback with the current field name and value (if it exists). Those arguments are RedisModuleString* which means it supposes to point to robj which is encoded as a string. Using createStringObjectFromLongLong function might return robj that points to an integer and so break a module that tries for example to use RedisModule_StringPtrLen on the given field/value. The PR introduces a fix that uses the createObject function and sdsfromlonglong function. Using those function promise that the field and value pass to the to the scan callback will be Strings. The PR also changes the Scan test module to use RedisModule_StringPtrLen to catch the issue. without this, the issue is hidden because RedisModule_ReplyWithString knows to handle integer encoding of the given robj (RedisModuleString). The PR also introduces a new test to verify the issue is solved.
53 lines
1.4 KiB
Tcl
53 lines
1.4 KiB
Tcl
set testmodule [file normalize tests/modules/scan.so]
|
|
|
|
start_server {tags {"modules"}} {
|
|
r module load $testmodule
|
|
|
|
test {Module scan keyspace} {
|
|
# the module create a scan command with filtering which also return values
|
|
r set x 1
|
|
r set y 2
|
|
r set z 3
|
|
r hset h f v
|
|
lsort [r scan.scan_strings]
|
|
} {{x 1} {y 2} {z 3}}
|
|
|
|
test {Module scan hash ziplist} {
|
|
r hmset hh f1 v1 f2 v2
|
|
lsort [r scan.scan_key hh]
|
|
} {{f1 v1} {f2 v2}}
|
|
|
|
test {Module scan hash dict with int value} {
|
|
r hmset hh1 f1 1
|
|
lsort [r scan.scan_key hh1]
|
|
} {{f1 1}}
|
|
|
|
test {Module scan hash dict} {
|
|
r config set hash-max-ziplist-entries 2
|
|
r hmset hh f3 v3
|
|
lsort [r scan.scan_key hh]
|
|
} {{f1 v1} {f2 v2} {f3 v3}}
|
|
|
|
test {Module scan zset ziplist} {
|
|
r zadd zz 1 f1 2 f2
|
|
lsort [r scan.scan_key zz]
|
|
} {{f1 1} {f2 2}}
|
|
|
|
test {Module scan zset dict} {
|
|
r config set zset-max-ziplist-entries 2
|
|
r zadd zz 3 f3
|
|
lsort [r scan.scan_key zz]
|
|
} {{f1 1} {f2 2} {f3 3}}
|
|
|
|
test {Module scan set intset} {
|
|
r sadd ss 1 2
|
|
lsort [r scan.scan_key ss]
|
|
} {{1 {}} {2 {}}}
|
|
|
|
test {Module scan set dict} {
|
|
r config set set-max-intset-entries 2
|
|
r sadd ss 3
|
|
lsort [r scan.scan_key ss]
|
|
} {{1 {}} {2 {}} {3 {}}}
|
|
}
|