mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-23 00:28:26 -05:00
b91d8b289b
- Added sanitizer support. `address`, `undefined` and `thread` sanitizers are available. - To build Redis with desired sanitizer : `make SANITIZER=undefined` - There were some sanitizer findings, cleaned up codebase - Added tests with address and undefined behavior sanitizers to daily CI. - Added tests with address sanitizer to the per-PR CI (smoke out mem leaks sooner). Basically, there are three types of issues : **1- Unaligned load/store** : Most probably, this issue may cause a crash on a platform that does not support unaligned access. Redis does unaligned access only on supported platforms. **2- Signed integer overflow.** Although, signed overflow issue can be problematic time to time and change how compiler generates code, current findings mostly about signed shift or simple addition overflow. For most platforms Redis can be compiled for, this wouldn't cause any issue as far as I can tell (checked generated code on godbolt.org). **3 -Minor leak** (redis-cli), **use-after-free**(just before calling exit()); UB means nothing guaranteed and risky to reason about program behavior but I don't think any of the fixes here worth backporting. As sanitizers are now part of the CI, preventing new issues will be the real benefit.
69 lines
2.1 KiB
Tcl
69 lines
2.1 KiB
Tcl
tags {"external:skip"} {
|
|
|
|
set system_name [string tolower [exec uname -s]]
|
|
set backtrace_supported 0
|
|
|
|
# We only support darwin or Linux with glibc
|
|
if {$system_name eq {darwin}} {
|
|
set backtrace_supported 1
|
|
} elseif {$system_name eq {linux}} {
|
|
# Avoid the test on libmusl, which does not support backtrace
|
|
set ldd [exec ldd src/redis-server]
|
|
if {![string match {*libc.musl*} $ldd]} {
|
|
set backtrace_supported 1
|
|
}
|
|
}
|
|
|
|
if {$backtrace_supported} {
|
|
set server_path [tmpdir server.log]
|
|
start_server [list overrides [list dir $server_path]] {
|
|
test "Server is able to generate a stack trace on selected systems" {
|
|
r config set watchdog-period 200
|
|
r debug sleep 1
|
|
set pattern "*debugCommand*"
|
|
set retry 10
|
|
while {$retry} {
|
|
set result [exec tail -100 < [srv 0 stdout]]
|
|
if {[string match $pattern $result]} {
|
|
break
|
|
}
|
|
incr retry -1
|
|
after 1000
|
|
}
|
|
if {$retry == 0} {
|
|
error "assertion:expected stack trace not found into log file"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
# Valgrind will complain that the process terminated by a signal, skip it.
|
|
if {!$::valgrind} {
|
|
if {$backtrace_supported} {
|
|
set crash_pattern "*STACK TRACE*"
|
|
} else {
|
|
set crash_pattern "*crashed by signal*"
|
|
}
|
|
|
|
set server_path [tmpdir server1.log]
|
|
start_server [list overrides [list dir $server_path]] {
|
|
test "Crash report generated on SIGABRT" {
|
|
set pid [s process_id]
|
|
exec kill -SIGABRT $pid
|
|
set result [exec tail -1000 < [srv 0 stdout]]
|
|
assert {[string match $crash_pattern $result]}
|
|
}
|
|
}
|
|
|
|
set server_path [tmpdir server2.log]
|
|
start_server [list overrides [list dir $server_path]] {
|
|
test "Crash report generated on DEBUG SEGFAULT" {
|
|
catch {r debug segfault}
|
|
set result [exec tail -1000 < [srv 0 stdout]]
|
|
assert {[string match $crash_pattern $result]}
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|