mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-22 16:18:28 -05:00
ce5f4ea3a9
When `RM_ZsetAdd()`/`RM_ZsetIncrby()`/`RM_StreamAdd()` fails, if a new key happens to be created using `moduleCreateEmptyKey()`, we should clean up the empty key. ## Test 1) Add new module commands(`zset.add` and `zset.incrby`) to cover `RM_ZsetAdd()`/`RM_ZsetIncrby()`. 2) Add a large-memory test to cover `RM_StreamAdd()`.
92 lines
3.3 KiB
C
92 lines
3.3 KiB
C
#include "redismodule.h"
|
|
#include <math.h>
|
|
#include <errno.h>
|
|
|
|
/* ZSET.REM key element
|
|
*
|
|
* Removes an occurrence of an element from a sorted set. Replies with the
|
|
* number of removed elements (0 or 1).
|
|
*/
|
|
int zset_rem(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
|
|
if (argc != 3) return RedisModule_WrongArity(ctx);
|
|
RedisModule_AutoMemory(ctx);
|
|
int keymode = REDISMODULE_READ | REDISMODULE_WRITE;
|
|
RedisModuleKey *key = RedisModule_OpenKey(ctx, argv[1], keymode);
|
|
int deleted;
|
|
if (RedisModule_ZsetRem(key, argv[2], &deleted) == REDISMODULE_OK)
|
|
return RedisModule_ReplyWithLongLong(ctx, deleted);
|
|
else
|
|
return RedisModule_ReplyWithError(ctx, "ERR ZsetRem failed");
|
|
}
|
|
|
|
/* ZSET.ADD key score member
|
|
*
|
|
* Adds a specified member with the specified score to the sorted
|
|
* set stored at key.
|
|
*/
|
|
int zset_add(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
|
|
if (argc != 4) return RedisModule_WrongArity(ctx);
|
|
RedisModule_AutoMemory(ctx);
|
|
int keymode = REDISMODULE_READ | REDISMODULE_WRITE;
|
|
RedisModuleKey *key = RedisModule_OpenKey(ctx, argv[1], keymode);
|
|
|
|
size_t len;
|
|
double score;
|
|
char *endptr;
|
|
const char *str = RedisModule_StringPtrLen(argv[2], &len);
|
|
score = strtod(str, &endptr);
|
|
if (*endptr != '\0' || errno == ERANGE)
|
|
return RedisModule_ReplyWithError(ctx, "value is not a valid float");
|
|
|
|
if (RedisModule_ZsetAdd(key, score, argv[3], NULL) == REDISMODULE_OK)
|
|
return RedisModule_ReplyWithSimpleString(ctx, "OK");
|
|
else
|
|
return RedisModule_ReplyWithError(ctx, "ERR ZsetAdd failed");
|
|
}
|
|
|
|
/* ZSET.INCRBY key member increment
|
|
*
|
|
* Increments the score stored at member in the sorted set stored at key by increment.
|
|
* Replies with the new score of this element.
|
|
*/
|
|
int zset_incrby(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
|
|
if (argc != 4) return RedisModule_WrongArity(ctx);
|
|
RedisModule_AutoMemory(ctx);
|
|
int keymode = REDISMODULE_READ | REDISMODULE_WRITE;
|
|
RedisModuleKey *key = RedisModule_OpenKey(ctx, argv[1], keymode);
|
|
|
|
size_t len;
|
|
double score, newscore;
|
|
char *endptr;
|
|
const char *str = RedisModule_StringPtrLen(argv[3], &len);
|
|
score = strtod(str, &endptr);
|
|
if (*endptr != '\0' || errno == ERANGE)
|
|
return RedisModule_ReplyWithError(ctx, "value is not a valid float");
|
|
|
|
if (RedisModule_ZsetIncrby(key, score, argv[2], NULL, &newscore) == REDISMODULE_OK)
|
|
return RedisModule_ReplyWithDouble(ctx, newscore);
|
|
else
|
|
return RedisModule_ReplyWithError(ctx, "ERR ZsetIncrby failed");
|
|
}
|
|
|
|
int RedisModule_OnLoad(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) {
|
|
REDISMODULE_NOT_USED(argv);
|
|
REDISMODULE_NOT_USED(argc);
|
|
if (RedisModule_Init(ctx, "zset", 1, REDISMODULE_APIVER_1) == REDISMODULE_ERR)
|
|
return REDISMODULE_ERR;
|
|
|
|
if (RedisModule_CreateCommand(ctx, "zset.rem", zset_rem, "write",
|
|
1, 1, 1) == REDISMODULE_ERR)
|
|
return REDISMODULE_ERR;
|
|
|
|
if (RedisModule_CreateCommand(ctx, "zset.add", zset_add, "write",
|
|
1, 1, 1) == REDISMODULE_ERR)
|
|
return REDISMODULE_ERR;
|
|
|
|
if (RedisModule_CreateCommand(ctx, "zset.incrby", zset_incrby, "write",
|
|
1, 1, 1) == REDISMODULE_ERR)
|
|
return REDISMODULE_ERR;
|
|
|
|
return REDISMODULE_OK;
|
|
}
|