mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-22 16:18:28 -05:00
8a86bca5ed
This commit revives the improves the ability to run the test suite against external servers, instead of launching and managing `redis-server` processes as part of the test fixture. This capability existed in the past, using the `--host` and `--port` options. However, it was quite limited and mostly useful when running a specific tests. Attempting to run larger chunks of the test suite experienced many issues: * Many tests depend on being able to start and control `redis-server` themselves, and there's no clear distinction between external server compatible and other tests. * Cluster mode is not supported (resulting with `CROSSSLOT` errors). This PR cleans up many things and makes it possible to run the entire test suite against an external server. It also provides more fine grained controls to handle cases where the external server supports a subset of the Redis commands, limited number of databases, cluster mode, etc. The tests directory now contains a `README.md` file that describes how this works. This commit also includes additional cleanups and fixes: * Tests can now be tagged. * Tag-based selection is now unified across `start_server`, `tags` and `test`. * More information is provided about skipped or ignored tests. * Repeated patterns in tests have been extracted to common procedures, both at a global level and on a per-test file basis. * Cleaned up some cases where test setup was based on a previous test executing (a major anti-pattern that repeats itself in many places). * Cleaned up some cases where test teardown was not part of a test (in the future we should have dedicated teardown code that executes even when tests fail). * Fixed some tests that were flaky running on external servers.
83 lines
2.8 KiB
Tcl
83 lines
2.8 KiB
Tcl
# Issue 3899 regression test.
|
|
# We create a chain of three instances: master -> slave -> slave2
|
|
# and continuously break the link while traffic is generated by
|
|
# redis-benchmark. At the end we check that the data is the same
|
|
# everywhere.
|
|
|
|
start_server {tags {"psync2 external:skip"}} {
|
|
start_server {} {
|
|
start_server {} {
|
|
# Config
|
|
set debug_msg 0 ; # Enable additional debug messages
|
|
|
|
set no_exit 0 ; # Do not exit at end of the test
|
|
|
|
set duration 20 ; # Total test seconds
|
|
|
|
for {set j 0} {$j < 3} {incr j} {
|
|
set R($j) [srv [expr 0-$j] client]
|
|
set R_host($j) [srv [expr 0-$j] host]
|
|
set R_port($j) [srv [expr 0-$j] port]
|
|
set R_unixsocket($j) [srv [expr 0-$j] unixsocket]
|
|
if {$debug_msg} {puts "Log file: [srv [expr 0-$j] stdout]"}
|
|
}
|
|
|
|
# Setup the replication and backlog parameters
|
|
test "PSYNC2 #3899 regression: setup" {
|
|
$R(1) slaveof $R_host(0) $R_port(0)
|
|
$R(2) slaveof $R_host(0) $R_port(0)
|
|
$R(0) set foo bar
|
|
wait_for_condition 50 1000 {
|
|
[status $R(1) master_link_status] == "up" &&
|
|
[status $R(2) master_link_status] == "up" &&
|
|
[$R(1) dbsize] == 1 &&
|
|
[$R(2) dbsize] == 1
|
|
} else {
|
|
fail "Replicas not replicating from master"
|
|
}
|
|
$R(0) config set repl-backlog-size 10mb
|
|
$R(1) config set repl-backlog-size 10mb
|
|
}
|
|
|
|
set cycle_start_time [clock milliseconds]
|
|
set bench_pid [exec src/redis-benchmark -s $R_unixsocket(0) -n 10000000 -r 1000 incr __rand_int__ > /dev/null &]
|
|
while 1 {
|
|
set elapsed [expr {[clock milliseconds]-$cycle_start_time}]
|
|
if {$elapsed > $duration*1000} break
|
|
if {rand() < .05} {
|
|
test "PSYNC2 #3899 regression: kill first replica" {
|
|
$R(1) client kill type master
|
|
}
|
|
}
|
|
if {rand() < .05} {
|
|
test "PSYNC2 #3899 regression: kill chained replica" {
|
|
$R(2) client kill type master
|
|
}
|
|
}
|
|
after 100
|
|
}
|
|
exec kill -9 $bench_pid
|
|
|
|
if {$debug_msg} {
|
|
for {set j 0} {$j < 100} {incr j} {
|
|
if {
|
|
[$R(0) debug digest] == [$R(1) debug digest] &&
|
|
[$R(1) debug digest] == [$R(2) debug digest]
|
|
} break
|
|
puts [$R(0) debug digest]
|
|
puts [$R(1) debug digest]
|
|
puts [$R(2) debug digest]
|
|
after 1000
|
|
}
|
|
}
|
|
|
|
test "PSYNC2 #3899 regression: verify consistency" {
|
|
wait_for_condition 50 1000 {
|
|
([$R(0) debug digest] eq [$R(1) debug digest]) &&
|
|
([$R(1) debug digest] eq [$R(2) debug digest])
|
|
} else {
|
|
fail "The three instances have different data sets"
|
|
}
|
|
}
|
|
}}}
|