mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-23 00:28:26 -05:00
8a86bca5ed
This commit revives the improves the ability to run the test suite against external servers, instead of launching and managing `redis-server` processes as part of the test fixture. This capability existed in the past, using the `--host` and `--port` options. However, it was quite limited and mostly useful when running a specific tests. Attempting to run larger chunks of the test suite experienced many issues: * Many tests depend on being able to start and control `redis-server` themselves, and there's no clear distinction between external server compatible and other tests. * Cluster mode is not supported (resulting with `CROSSSLOT` errors). This PR cleans up many things and makes it possible to run the entire test suite against an external server. It also provides more fine grained controls to handle cases where the external server supports a subset of the Redis commands, limited number of databases, cluster mode, etc. The tests directory now contains a `README.md` file that describes how this works. This commit also includes additional cleanups and fixes: * Tests can now be tagged. * Tag-based selection is now unified across `start_server`, `tags` and `test`. * More information is provided about skipped or ignored tests. * Repeated patterns in tests have been extracted to common procedures, both at a global level and on a per-test file basis. * Cleaned up some cases where test setup was based on a previous test executing (a major anti-pattern that repeats itself in many places). * Cleaned up some cases where test teardown was not part of a test (in the future we should have dedicated teardown code that executes even when tests fail). * Fixed some tests that were flaky running on external servers.
78 lines
2.6 KiB
Tcl
78 lines
2.6 KiB
Tcl
set system_name [string tolower [exec uname -s]]
|
|
set user_id [exec id -u]
|
|
|
|
if {$system_name eq {linux}} {
|
|
start_server {tags {"oom-score-adj external:skip"}} {
|
|
proc get_oom_score_adj {{pid ""}} {
|
|
if {$pid == ""} {
|
|
set pid [srv 0 pid]
|
|
}
|
|
set fd [open "/proc/$pid/oom_score_adj" "r"]
|
|
set val [gets $fd]
|
|
close $fd
|
|
|
|
return $val
|
|
}
|
|
|
|
test {CONFIG SET oom-score-adj works as expected} {
|
|
set base [get_oom_score_adj]
|
|
|
|
# Enable oom-score-adj, check defaults
|
|
r config set oom-score-adj-values "10 20 30"
|
|
r config set oom-score-adj yes
|
|
|
|
assert {[get_oom_score_adj] == [expr $base + 10]}
|
|
|
|
# Modify current class
|
|
r config set oom-score-adj-values "15 20 30"
|
|
assert {[get_oom_score_adj] == [expr $base + 15]}
|
|
|
|
# Check replica class
|
|
r replicaof localhost 1
|
|
assert {[get_oom_score_adj] == [expr $base + 20]}
|
|
r replicaof no one
|
|
assert {[get_oom_score_adj] == [expr $base + 15]}
|
|
|
|
# Check child process
|
|
r set key-a value-a
|
|
r config set rdb-key-save-delay 1000000
|
|
r bgsave
|
|
|
|
set child_pid [get_child_pid 0]
|
|
# Wait until background child process to setOOMScoreAdj success.
|
|
wait_for_condition 100 10 {
|
|
[get_oom_score_adj $child_pid] == [expr $base + 30]
|
|
} else {
|
|
fail "Set oom-score-adj of background child process is not ok"
|
|
}
|
|
}
|
|
|
|
# Failed oom-score-adj tests can only run unprivileged
|
|
if {$user_id != 0} {
|
|
test {CONFIG SET oom-score-adj handles configuration failures} {
|
|
# Bad config
|
|
r config set oom-score-adj no
|
|
r config set oom-score-adj-values "-1000 -1000 -1000"
|
|
|
|
# Make sure it fails
|
|
catch {r config set oom-score-adj yes} e
|
|
assert_match {*Failed to set*} $e
|
|
|
|
# Make sure it remains off
|
|
assert {[r config get oom-score-adj] == "oom-score-adj no"}
|
|
|
|
# Fix config
|
|
r config set oom-score-adj-values "0 100 100"
|
|
r config set oom-score-adj yes
|
|
|
|
# Make sure it fails
|
|
catch {r config set oom-score-adj-values "-1000 -1000 -1000"} e
|
|
assert_match {*Failed*} $e
|
|
|
|
# Make sure previous values remain
|
|
assert {[r config get oom-score-adj-values] == {oom-score-adj-values {0 100 100}}}
|
|
}
|
|
}
|
|
}
|
|
}
|