mirror of
https://codeberg.org/redict/redict.git
synced 2025-01-22 16:18:28 -05:00
8a86bca5ed
This commit revives the improves the ability to run the test suite against external servers, instead of launching and managing `redis-server` processes as part of the test fixture. This capability existed in the past, using the `--host` and `--port` options. However, it was quite limited and mostly useful when running a specific tests. Attempting to run larger chunks of the test suite experienced many issues: * Many tests depend on being able to start and control `redis-server` themselves, and there's no clear distinction between external server compatible and other tests. * Cluster mode is not supported (resulting with `CROSSSLOT` errors). This PR cleans up many things and makes it possible to run the entire test suite against an external server. It also provides more fine grained controls to handle cases where the external server supports a subset of the Redis commands, limited number of databases, cluster mode, etc. The tests directory now contains a `README.md` file that describes how this works. This commit also includes additional cleanups and fixes: * Tests can now be tagged. * Tag-based selection is now unified across `start_server`, `tags` and `test`. * More information is provided about skipped or ignored tests. * Repeated patterns in tests have been extracted to common procedures, both at a global level and on a per-test file basis. * Cleaned up some cases where test setup was based on a previous test executing (a major anti-pattern that repeats itself in many places). * Cleaned up some cases where test teardown was not part of a test (in the future we should have dedicated teardown code that executes even when tests fail). * Fixed some tests that were flaky running on external servers.
58 lines
1.8 KiB
Tcl
58 lines
1.8 KiB
Tcl
start_server {tags {"shutdown external:skip"}} {
|
|
test {Temp rdb will be deleted if we use bg_unlink when shutdown} {
|
|
for {set i 0} {$i < 20} {incr i} {
|
|
r set $i $i
|
|
}
|
|
# It will cost 2s(20 * 100ms) to dump rdb
|
|
r config set rdb-key-save-delay 100000
|
|
|
|
# Child is dumping rdb
|
|
r bgsave
|
|
after 100
|
|
set dir [lindex [r config get dir] 1]
|
|
set child_pid [get_child_pid 0]
|
|
set temp_rdb [file join [lindex [r config get dir] 1] temp-${child_pid}.rdb]
|
|
# Temp rdb must be existed
|
|
assert {[file exists $temp_rdb]}
|
|
|
|
catch {r shutdown nosave}
|
|
# Make sure the server was killed
|
|
catch {set rd [redis_deferring_client]} e
|
|
assert_match {*connection refused*} $e
|
|
|
|
# Temp rdb file must be deleted
|
|
assert {![file exists $temp_rdb]}
|
|
}
|
|
}
|
|
|
|
start_server {tags {"shutdown external:skip"}} {
|
|
test {Temp rdb will be deleted in signal handle} {
|
|
for {set i 0} {$i < 20} {incr i} {
|
|
r set $i $i
|
|
}
|
|
# It will cost 2s (20 * 100ms) to dump rdb
|
|
r config set rdb-key-save-delay 100000
|
|
|
|
set pid [s process_id]
|
|
set temp_rdb [file join [lindex [r config get dir] 1] temp-${pid}.rdb]
|
|
|
|
# trigger a shutdown which will save an rdb
|
|
exec kill -SIGINT $pid
|
|
# Wait for creation of temp rdb
|
|
wait_for_condition 50 10 {
|
|
[file exists $temp_rdb]
|
|
} else {
|
|
fail "Can't trigger rdb save on shutdown"
|
|
}
|
|
|
|
# Insist on immediate shutdown, temp rdb file must be deleted
|
|
exec kill -SIGINT $pid
|
|
# wait for the rdb file to be deleted
|
|
wait_for_condition 50 10 {
|
|
![file exists $temp_rdb]
|
|
} else {
|
|
fail "Can't trigger rdb save on shutdown"
|
|
}
|
|
}
|
|
}
|