antirez
1673a3f32c
Cluster: improve anti-affinity algo in redis-trib.rb.
...
See #3462 and related PRs.
We use a simple algorithm to calculate the level of affinity violation,
and then an optimizer that performs random swaps until things improve.
2018-01-18 11:44:19 +01:00
antirez
e1e0bbe04d
Remove useless comment from serverCron().
...
The behavior is well specified by the code itself.
2018-01-17 11:23:41 +01:00
Salvatore Sanfilippo
a18e4c964e
Merge pull request #4546 from hqin6/unstable
...
fixbug for #4545 dead loop aof rewrite
2018-01-17 11:21:55 +01:00
heqin
3d3faa0a19
fixbug for #4545 dead loop aof rewrite
2018-01-17 18:08:30 +08:00
Salvatore Sanfilippo
81401878de
Merge pull request #4609 from Qinch/unstable
...
fix assert problem in ZIP_DECODE_PREVLENSIZE macro
2018-01-17 10:45:11 +01:00
antirez
b23927b240
Hopefully more clear comment to explain the change in #4607 .
2018-01-16 15:52:13 +01:00
qinchao
1e0e168570
fix assert problem in ZIP_DECODE_PREVLENSIZE
...
, see issue: https://github.com/antirez/redis/issues/4587
2018-01-16 22:43:06 +08:00
Salvatore Sanfilippo
0cc43760d7
Merge pull request #4607 from oranagra/psync2_backlog
...
PSYNC2 fix - promoted slave should hold on to it's backlog
2018-01-16 15:32:58 +01:00
Oran Agra
689b64c3ad
PSYNC2 fix - promoted slave should hold on to it's backlog
...
after a slave is promoted (assuming it has no slaves
and it booted over an hour ago), it will lose it's replication
backlog at the next replication cron, rather than waiting for slaves
to connect to it.
so on a simple master/slave faiover, if the new slave doesn't connect
immediately, it may be too later and PSYNC2 will fail.
2018-01-16 10:10:42 +02:00
zhaozhao.zz
1b8eec3e53
aof: format code and comment
2018-01-15 13:01:03 +01:00
antirez
c45366be0a
Put more details in the comment introduced by #4601 .
2018-01-15 12:50:08 +01:00
Salvatore Sanfilippo
1ed5ac7ce5
Merge pull request #4601 from soloestoy/fix-memoryleak-for-lazy-server-del
...
lazyfree: fix memory leak for lazyfree-lazy-server-del
2018-01-15 12:43:55 +01:00
zhaozhao.zz
0517ab8397
lazyfree: fix memory leak for lazyfree-lazy-server-del
2018-01-15 00:45:37 +08:00
Salvatore Sanfilippo
aeeb747796
Merge pull request #4575 from soloestoy/bugfix-benchmark
...
redis-benchmark: bugfix - handle zero liveclients in right way
2018-01-12 17:43:01 +01:00
Salvatore Sanfilippo
72187fa8a5
Merge pull request #4581 from dvirsky/module_unlink
...
Added RM_UnlinkKey - a low level analog to UNLINK command
2018-01-12 17:41:09 +01:00
antirez
a5b6bc2bd7
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-01-12 17:16:38 +01:00
Salvatore Sanfilippo
71914387ba
Merge pull request #4586 from gnuhpc/fix-crashlog-typo
...
Fix a typo(maybe instruction?) in crash log
2018-01-12 17:16:12 +01:00
antirez
2f8476df91
Fix getKeysUsingCommandTable() in the case of nagative arity.
...
This fixes a crash with Redis Cluster when OBJECT is mis-used, because
getKeysUsingCommandTable() will call serverPanic() detecting we are
accessing an invalid argument in the case "OBJECT foo" is called.
This bug was introduced when OBJECT HELP was introduced, because the key
argument is set fixed at index 2 in the command table, however now
OBJECT may be called with an insufficient number of arguments to extract
the key.
The "Right Thing" would be to have a specific function to extract keys
from the OBJECT command, however this is kinda of an overkill, so I
preferred to make getKeysUsingCommandTable() more robust and just return
no keys when it's not possible to honor the command table, because new
commands are often added and also there are a number with an HELP
subcommand violating the normal form, and crashing for this trivial
reason or having many command-specific key extraction functions is not
great.
2018-01-12 11:26:29 +01:00
antirez
db7bd6fda9
Document new protocol options in #4568 into redis.conf.
2018-01-11 11:40:57 +01:00
antirez
13650446ac
proto-max-querybuf-len -> client-query-buffer-limit.
...
We already had client buffer limits exported as configuration options.
Stick with the naming scheme already used.
See #4568 .
2018-01-11 11:36:26 +01:00
antirez
8075572207
New config options about protocol prefixed with "proto".
...
Related to #4568 .
2018-01-11 11:27:41 +01:00
Salvatore Sanfilippo
c2fa4b8a60
Merge pull request #4568 from oranagra/restore_size_limit
...
fix RESTORE command size limits
2018-01-11 11:20:02 +01:00
huijing.whj
f0e09bf803
fix int overflow problem in freeMemoryIfNeeded
2018-01-10 23:47:02 +08:00
Salvatore Sanfilippo
e954742fbd
Merge pull request #3356 from yusaku/fix-module-firstkey
...
Fix the firstkey, lastkey, and keystep of moduleCommand
2018-01-09 18:58:31 +01:00
antirez
c17a0e134f
Test: MIGRATE AUTH test added.
...
Related to #2507 .
2018-01-09 18:49:19 +01:00
antirez
3ce1c28d47
Rewrite MIGRATE AUTH option.
...
See PR #2507 . This is a reimplementation of the fix that contained
different problems.
2018-01-09 18:48:26 +01:00
gnuhpc
36e71b88b5
Fix a typo(maybe instruction?) in crash log
2018-01-09 16:13:02 +08:00
Dvir Volk
e76dfc90a7
Added RM_UnlinkKey - a low level analog to UNLINK command
2018-01-07 16:41:43 +02:00
Salvatore Sanfilippo
e509fbb8d9
Merge pull request #4579 from gnuhpc/fix-memoryusage-list
...
Fix memory usage list bug
2018-01-05 11:53:11 +01:00
gnuhpc
5113a53df6
Fix memory usage list bug
2018-01-05 12:16:24 +08:00
zhaozhao.zz
c0f611f12a
redis-benchmark: bugfix - handle zero liveclients in right way
2018-01-03 12:47:25 +08:00
Oran Agra
b509a14c3e
Add config options for max-bulk-len and max-querybuf-len mainly to support RESTORE of large keys
2017-12-29 12:43:48 +02:00
Oran Agra
60a4f12f8b
fix processing of large bulks (above 2GB)
...
- protocol parsing (processMultibulkBuffer) was limitted to 32big positions in the buffer
readQueryFromClient potential overflow
- rioWriteBulkCount used int, although rioWriteBulkString gave it size_t
- several places in sds.c that used int for string length or index.
- bugfix in RM_SaveAuxField (return was 1 or -1 and not length)
- RM_SaveStringBuffer was limitted to 32bit length
2017-12-29 12:24:19 +02:00
antirez
0b561883b4
Hyperloglog: refresh hdr variable correctly.
...
This is a fix for the #3819 improvements. The o->ptr may change because
of hllSparseSet() calls, so 'hdr' must be correctly re-fetched.
2017-12-22 11:26:31 +01:00
antirez
27b81f3fbc
Hyperloglog: Support for PFMERGE sparse encoding as target.
...
This is a fix for #3819 .
2017-12-22 11:01:27 +01:00
antirez
cbe9d725a7
Hyperloglog: refactoring of sparse/dense add function.
...
The commit splits the add functions into a set() and add() set of
functions, so that it's possible to set registers in an independent way
just having the index and count.
Related to #3819 , otherwise a fix is not possible.
2017-12-22 11:00:22 +01:00
heqin
365e6c45ea
fixbug for #4545 dead loop aof rewrite
2017-12-18 17:59:03 +08:00
Itamar Haber
d49bfc4080
Uppercases subcommands in OBJECT HELP
2017-12-15 21:21:12 +02:00
Itamar Haber
7820377d00
Uppercases subcommands in MEMORY HELP
2017-12-15 21:19:41 +02:00
Salvatore Sanfilippo
238c9bd086
Merge pull request #4540 from hqin6/unstable
...
fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No suc…
2017-12-15 12:41:02 +01:00
heqin
ee724cac49
fixbug for #4538 Error opening /setting AOF rewrite IPC pipes: No such file or directory
2017-12-15 11:06:58 +08:00
Salvatore Sanfilippo
d745e8dfb3
Merge pull request #4536 from tporadowski/antirez_unstable-cli-history
...
Always enable command history in redis-cli run on a TTY
2017-12-14 22:14:45 +01:00
Salvatore Sanfilippo
398b2084af
Merge pull request #4528 from nashe/patch-oob-read-4527
...
Prevent off-by-one read in stringmatchlen()
2017-12-14 12:21:32 +01:00
antirez
12e65a424c
safe_write -> aofWrite. Function commented.
...
Related to #4498 .
2017-12-14 12:19:36 +01:00
Salvatore Sanfilippo
5182dcd645
Merge pull request #4498 from soloestoy/aof-safe-write
...
Aof safe write -- fix the short write
2017-12-14 12:15:46 +01:00
Tomasz Poradowski
77653ebe8a
always enable command history in redis-cli
...
- when redis-cli is running in a TTY - always enable command history
buffering, regardless if history file path can be successfully
determined
2017-12-13 23:49:41 +01:00
antirez
de276b6a43
Cluster: allow read-only EVAL/EVALSHA in slaves.
...
Fix #3665 .
2017-12-13 13:36:01 +01:00
nashe
f43eb5adcf
Prevent off-by-one read in stringmatchlen() ( fixes #4527 )
2017-12-12 01:25:03 +01:00
Itamar Haber
4317e2131f
Standardizes MEMORY HELP
subcommand
2017-12-10 17:54:56 +02:00
zhaozhao.zz
109ee497be
zset: change the span of zskiplistNode to unsigned long
2017-12-08 16:09:27 +08:00