antirez
666b3437e6
Disable protected mode in Sentinel mode.
...
Sentinel must be exposed, so protected mode is just an issue for users
in case Redis was started in Sentinel mode.
Related to #3279 and #3329 .
2018-10-31 12:37:48 +01:00
antirez
06a4acb7d3
When replica kills a pending RDB save during SYNC, log it.
...
This logs what happens in the context of the fix in PR #5367 .
2018-10-31 11:47:10 +01:00
Salvatore Sanfilippo
6204d8c139
Merge pull request #5367 from nUl1/fullresync-stopbgsave
...
Prevent RDB autosave from overwriting full resync results
2018-10-31 11:42:04 +01:00
David Carlier
e84d327fc1
Merge branch 'clang_build_fix_warnings' of https://github.com/devnexen/redis into clang_build_fix_warnings
2018-10-31 09:53:25 +00:00
David Carlier
cf2f5e19d9
tweak form feedback
2018-10-31 09:53:07 +00:00
David Carlier
9d6fbf0e00
allow flavors
2018-10-30 21:41:49 +00:00
David Carlier
a21d1522c7
allow flavors
2018-10-30 14:38:05 +00:00
David Carlier
6534b3e09e
Fix clang build.
...
Some math functions require c11 standard.
2018-10-30 13:23:43 +00:00
antirez
0c875c7751
asyncCloseClientOnOutputBufferLimitReached(): don't free fake clients.
...
Fake clients are used in special situations and are not linked to the
normal clients list, freeing them will always result in Redis crashing
in one way or the other.
It's not common to send replies to fake clients, but we have one usage
in the modules API. When a client is blocked, we associate to the
blocked client object (that is safe to manipulate in a thread), a fake
client that accumulates replies. So because of this bug there was
the problem described in issue #5443 .
The fix was verified to work with the provided example module. To write
a regression is very hard and unlikely to be triggered in the future.
2018-10-30 13:38:41 +01:00
Salvatore Sanfilippo
f1408b1729
Merge pull request #5489 from devnexen/unstable
...
Fix non Linux build.
2018-10-29 18:25:14 +01:00
David Carlier
ae3bfe583e
needs it for the global
2018-10-26 14:12:47 +00:00
David Carlier
0b73d0a8d2
Fix non Linux build.
...
timezone global is a linux-ism whereas it is a function under BSD.
Here a helper to get the timezone value in a more portable manner.
2018-10-26 14:02:09 +00:00
antirez
b8febe60b4
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 13:08:58 +02:00
antirez
f5494b1862
Add command fingerprint comment for XSETID.
2018-10-25 13:08:48 +02:00
Salvatore Sanfilippo
6dde56bf93
Merge pull request #5454 from soloestoy/multi-oom
...
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-25 13:00:19 +02:00
antirez
998001fbf2
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-25 11:50:15 +02:00
Salvatore Sanfilippo
12d5be1bf2
Merge pull request #5459 from itamarhaber/xpending_count_underflow
...
A fix to XPENDING's count underflow
2018-10-25 11:50:04 +02:00
antirez
6e11ef30e0
Fix XRANGE COUNT option for value of 0.
2018-10-25 11:36:24 +02:00
antirez
f06e8c331c
Fix typo in streamReplyWithRange() top comment.
2018-10-24 16:28:44 +02:00
Salvatore Sanfilippo
e8c108e938
Merge pull request #5469 from soloestoy/stat-key-miss-if-expired
...
if we read a expired key, misses++
2018-10-24 12:31:28 +02:00
Salvatore Sanfilippo
a2131f907a
Merge pull request #5453 from damz/pr/aof-buffer-evict
...
Overhead is the allocated size of the AOF buffer, not its length
2018-10-24 12:28:28 +02:00
antirez
8749fc3f67
Simplify part of the #5470 patch.
2018-10-24 12:26:27 +02:00
Salvatore Sanfilippo
3c89fb5ffd
Merge pull request #5470 from soloestoy/keys-no-trigger-expire
...
do not delete expired keys in KEYS command
2018-10-24 12:23:59 +02:00
antirez
54e8dd11ff
Use guide comments to make changes in #5462 more obvious.
2018-10-22 17:43:48 +02:00
antirez
0f18d8e0ed
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-22 17:41:43 +02:00
Salvatore Sanfilippo
3f6893a4e2
Merge pull request #5462 from youjiali1995/fix-migrate-expired-keys
...
migrate: fix mismatch of RESTORE reply when some keys have expired.
2018-10-22 17:40:37 +02:00
antirez
c33ef454f0
Remove useless complexity from MSET implementation.
2018-10-22 12:24:02 +02:00
Salvatore Sanfilippo
2f8912c36c
Merge pull request #5451 from hujiecs/unstable
...
several typos fixed, optimize MSETNX to avoid unnecessary loop
2018-10-22 12:17:08 +02:00
hujie
e610dbce14
fix typo in config.c
2018-10-21 10:37:36 +08:00
hujie
63e41ee192
fix typo
2018-10-20 12:18:56 +08:00
Thomas Orozco
f24ad5d831
cli: pass auth through REDISCLI_AUTH
...
This adds support for passing a password through a REDISCLI_AUTH
environment variable (which is safer than the CLI), which might often be
safer than passing it through a CLI argument.
Passing a password this way does not trigger the warning about passing a
password through CLI arguments, and CLI arguments take precedence over
it.
2018-10-19 19:15:14 +02:00
zhaozhao.zz
5ddd507624
if we read a expired key, misses++
2018-10-19 18:16:29 +08:00
zhaozhao.zz
7ab9cba59b
do not delete expired keys in KEYS command
2018-10-19 18:00:57 +08:00
antirez
f30b18f4de
Fix again stack generation on the Raspberry Pi.
...
The fix was removed by c8ca71d40
attempting to fix the stack generation
on ARM64, without testing if it would still work on ARM32.
Now it should work both sides.
2018-10-19 10:39:57 +02:00
youjiali1995
a6499ecac2
migrate: fix mismatch of RESTORE reply when some keys have expired.
2018-10-18 18:57:51 +08:00
Itamar Haber
edeaf85cab
Plugs a potential underflow
2018-10-17 19:33:11 +03:00
antirez
144832ee67
Streams: use bulk replies instead of status replies.
...
They play better with Lua scripting, otherwise Lua will see status
replies as "ok" = "string" which is very odd, and actually as @oranagra
reasoned in issue #5456 in the rest of the Redis code base there was no
such concern as saving a few bytes when the protocol is emitted.
2018-10-17 17:21:09 +02:00
Itamar Haber
acb3b55280
Corrects inline documentation of syntax
2018-10-17 16:13:55 +03:00
antirez
fdb575993f
Fix conditional in XGROUP.
2018-10-17 13:00:35 +02:00
antirez
ad78b50f62
Update help.h for redis-cli.
2018-10-17 12:57:21 +02:00
antirez
56871aeb60
Tests for XGROUP CREATE MKSTREAM.
2018-10-17 12:11:10 +02:00
antirez
492fd5c011
Fix XGROUP CREATE MKSTREAM handling of .
2018-10-17 12:10:52 +02:00
antirez
2e3d403349
Process MKSTREAM option of XGROUP CREATE at a later time.
...
This avoids issues with having to replicate a command that produced
errors.
2018-10-17 12:04:06 +02:00
antirez
ab11c5ebd1
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-10-17 11:36:03 +02:00
antirez
cb27dd1a68
XGROUP CREATE: MKSTREAM option for automatic stream creation.
2018-10-17 11:27:27 +02:00
zhaozhao.zz
e2de7e7524
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-17 16:40:45 +08:00
Salvatore Sanfilippo
3f7bc5a5d2
Merge pull request #5333 from soloestoy/stream-commands-flag
...
Scripting & Streams: some commands need right flags
2018-10-17 07:50:32 +02:00
Damien Tournoud
29e488cbb0
Overhead is the allocated size of the AOF buffer, not its length
2018-10-16 11:47:42 -07:00
Salvatore Sanfilippo
2f8f29aa0e
Merge pull request #5452 from soloestoy/xsetid-lastid
...
Streams: rewrite empty streams with certain lastid
2018-10-16 18:56:55 +02:00
zhaozhao.zz
c2e4c64db4
Streams: Tests modified XSTREAM -> XSETID
2018-10-16 23:56:26 +08:00