Chris Lamb
9cfcf37968
Clarify the "Creating Server TCP listening socket" error.
...
This really helps spot it in the logs, otherwise it does not look like a
warning/error. For example:
Creating Server TCP listening socket ::1:6379: bind: Cannot assign requested address
... is not nearly as clear as:
Could not create server TCP listening listening socket ::1:6379: bind: Cannot assign requested address
2018-11-23 17:57:01 +01:00
valentino
eae8d05826
fix short period of server.hz being uninitialized
...
server.hz was uninitialized between initServerConfig and initServer.
this can lead to someone (e.g. queued modules) doing createObject,
and accessing an uninitialized variable, that can potentially be 0,
and lead to a crash.
2018-11-05 12:01:26 +02:00
David Carlier
0b73d0a8d2
Fix non Linux build.
...
timezone global is a linux-ism whereas it is a function under BSD.
Here a helper to get the timezone value in a more portable manner.
2018-10-26 14:02:09 +00:00
zhaozhao.zz
e2de7e7524
MULTI: OOM err if cannot free enough memory in MULTI/EXEC context
2018-10-17 16:40:45 +08:00
Salvatore Sanfilippo
3f7bc5a5d2
Merge pull request #5333 from soloestoy/stream-commands-flag
...
Scripting & Streams: some commands need right flags
2018-10-17 07:50:32 +02:00
antirez
e3446fea9e
Streams: XSTREAM SETID -> XSETID.
...
Keep vanilla stream commands at toplevel, see #5426 .
2018-10-16 13:17:14 +02:00
Salvatore Sanfilippo
af09df08d7
Merge pull request #5426 from soloestoy/feature-xstream
...
Bugfix data inconsistency after aof rewrite, and add XSTREAM command.
2018-10-16 13:10:36 +02:00
antirez
c9d9ae7baa
Fix propagation of consumer groups last ID.
...
Issue #5433 .
2018-10-10 12:51:02 +02:00
zhaozhao.zz
ec511fa709
Streams: add a new command XTREAM
...
XSTREAM CREATE <key> <id or *> -- Create a new empty stream.
XSTREAM SETID <key> <id or $> -- Set the current stream ID.
2018-10-09 13:11:04 +08:00
antirez
73a78adf13
Fix printf type mismatch in genRedisInfoString().
2018-10-02 16:26:30 +02:00
Salvatore Sanfilippo
e19a06d2dd
Merge pull request #5242 from oranagra/script_mem
...
script cache memory in INFO and MEMORY includes both script code and overheads
2018-10-02 16:03:05 +02:00
Salvatore Sanfilippo
9ce638695c
Merge pull request #5398 from bmerry/fix-zrealloc-accounting
...
Fix incorrect memory usage accounting in zrealloc
2018-10-01 13:28:53 +02:00
Bruce Merry
8fd1031b10
Fix incorrect memory usage accounting in zrealloc
...
When HAVE_MALLOC_SIZE is false, each call to zrealloc causes used_memory
to increase by PREFIX_SIZE more than it should, due to mis-matched
accounting between the original zmalloc (which includes PREFIX size in
its increment) and zrealloc (which misses it from its decrement).
I've also supplied a command-line test to easily demonstrate the
problem. It's not wired into the test framework, because I don't know
TCL so I'm not sure how to automate it.
2018-09-30 11:49:03 +02:00
Oran Agra
f03aed3ca9
fix #5024 - commandstats for multi-exec were logged as EXEC.
...
this was broken a while back by ba9154d7e7bf959b002533384319a1e90545447b
the purpose of which was to fix commandstats for GEOADD
2018-09-30 12:43:11 +03:00
antirez
c202ba2b35
Module cluster flags: add hooks for NO_REDIRECTION flag.
2018-09-19 11:31:22 +02:00
antirez
744fe7f348
Module cluster flags: initial vars / defines added.
2018-09-19 11:20:52 +02:00
antirez
43385c4375
LOLWUT: wrap it into a proper command.
2018-09-12 11:34:10 +02:00
antirez
db146de086
Slave removal: server.c logs fixed.
2018-09-11 15:32:28 +02:00
antirez
ef2c7a5bbb
Slave removal: SLAVEOF -> REPLICAOF. SLAVEOF is now an alias.
2018-09-11 15:32:28 +02:00
Salvatore Sanfilippo
a62b8410ef
Merge pull request #5322 from youjiali1995/fix-sentinel-randomize
...
sentinel: fix randomized sentinelTimer.
2018-09-07 12:10:35 +02:00
zhaozhao.zz
8d24f8b46b
Scripting & Streams: some commands need right flags
...
xadd with id * generates random stream id
xadd & xtrim with approximate maxlen count may
trim stream randomly
xinfo may get random radix-tree-keys/nodes
xpending may get random idletime
xclaim: master and slave may have different
idletime in stream
2018-09-06 21:12:46 +08:00
antirez
7895835df6
Use commands (effects) replication by default in scripts.
...
See issue #5250 and issue #5292 for more info.
2018-09-05 19:33:56 +02:00
antirez
51b627d916
Don't perform eviction when re-entering the event loop.
...
Related to #5250 .
2018-09-05 13:10:07 +02:00
youjiali1995
a8322f44b3
sentinel: fix randomized sentinelTimer.
2018-09-05 10:32:18 +08:00
antirez
9ab91b8c6c
While the slave is busy, just accumulate master input.
...
Processing command from the master while the slave is in busy state is
not correct, however we cannot, also, just reply -BUSY to the
replication stream commands from the master. The correct solution is to
stop processing data from the master, but just accumulate the stream
into the buffers and resume the processing later.
Related to #5297 .
2018-08-31 16:45:02 +02:00
antirez
f5b29c6444
Allow scripts to timeout on slaves as well.
...
See reasoning in #5297 .
2018-08-31 16:45:01 +02:00
zhaozhao.zz
7d39c149c4
Supplement to PR #4835 , just take info/memory/command as random commands
2018-08-29 18:23:05 +08:00
Salvatore Sanfilippo
0e21efdb1c
Merge pull request #4835 from soloestoy/command-script-flag
...
some commands' flags should be set correctly, issue #4834
2018-08-29 12:13:50 +02:00
zhaozhao.zz
32844178ac
some commands' flags should be set correctly, issue #4834
2018-08-29 18:07:01 +08:00
antirez
067647a783
Introduce repl_slave_ignore_maxmemory flag internally.
...
Note: this breaks backward compatibility with Redis 4, since now slaves
by default are exact copies of masters and do not try to evict keys
independently.
2018-08-27 12:20:27 +02:00
antirez
abf52c7cf4
Better variable meaning in processCommand().
2018-08-27 12:17:34 +02:00
zhaozhao.zz
8a1219d93b
block: rewrite BRPOPLPUSH as RPOPLPUSH to propagate
2018-08-14 20:58:58 +08:00
Oran Agra
17c5f17686
Add log when server dies of SIGTERM during loading
...
this is very confusing to see the server disappears as if it got SIGKILL when it was not the case.
2018-08-13 17:43:29 +03:00
Oran Agra
f4b27ae222
script cache memory in INFO and MEMORY includes both script code and overheads
2018-08-13 17:36:54 +03:00
shenlongxing
fe56c67405
Fix stream command paras
2018-08-03 19:01:15 +08:00
antirez
db693be00d
Refactoring: replace low-level checks with writeCommandsDeniedByDiskError().
2018-07-31 13:16:43 +02:00
antirez
11dd3f4b03
Fix writeCommandsDeniedByDiskError() inverted return value.
2018-07-31 13:14:24 +02:00
antirez
0e49938b68
Better top comment for writeCommandsDeniedByDiskError().
2018-07-31 13:10:37 +02:00
antirez
5401fe7fb9
Introduce writeCommandsDeniedByDiskError().
2018-07-31 13:09:38 +02:00
Pavel Rochnyack
1e394b73b7
INFO CPU: higher precision of reported values
...
Closes : #5033
2018-07-30 18:06:22 +02:00
antirez
3c19ae941d
Add year in log.
...
User: "is there a reason why redis server logs are missing the year in
the "date time"?"
Me: "I guess I did not imagine it would be stable enough to run for
several years".
2018-07-30 17:42:30 +02:00
antirez
c426d85c4c
Control dynamic HZ via server configuration.
2018-07-30 13:37:30 +02:00
antirez
4e9c30a6ca
Merge branch 'dynamic-hz' into unstable
2018-07-30 13:31:23 +02:00
Salvatore Sanfilippo
445a2a2b1b
Merge pull request #4883 from itamarhaber/lua_scripts-in-info-memory
...
Adds memory information about the scripts' cache to INFO
2018-07-23 18:43:05 +02:00
antirez
b65ddfb16a
Dynamic HZ: adapt cron frequency to number of clients.
2018-07-23 14:21:04 +02:00
antirez
e6ea603ad3
Dynamic HZ: separate hz from the configured hz.
...
This way we can remember what the user configured HZ is, but change the
actual HZ dynamically if needed in the dynamic HZ feature
implementation.
2018-07-23 14:13:58 +02:00
antirez
4ff47a0b9b
Top comment clientsCron().
2018-07-20 09:46:18 +02:00
antirez
aba6855282
Clarify that clientsCronTrackExpansiveClients() indexes may jump ahead.
2018-07-20 09:36:48 +02:00
antirez
be88c0b16a
Rename INFO CLIENT max buffers field names for correctness.
...
They are actually delayed a few seconds, so let's call them "recent".
2018-07-19 17:38:20 +02:00
antirez
0cf3794e6e
Fix wrong array index variable in getExpansiveClientsInfo().
2018-07-19 17:34:15 +02:00