Oran Agra
98426e9886
On LUA script timeout, print the script SHA to the log
...
since the slowlog and other means that can help you detect the bad script
are only exposed after the script is done. it might be a good idea to at least
print the script name (sha) to the log when it timeouts.
2019-10-02 08:40:35 +03:00
antirez
40acb4412d
GEORADIUS reply: fix of the previous fix about #6417 .
2019-10-01 19:18:55 +02:00
Salvatore Sanfilippo
2e2fe98f9c
Merge pull request #6270 from oranagra/modules_info
...
Extend modules API to allow modules report to redis INFO
2019-10-01 18:02:33 +02:00
antirez
3281ebb495
Fix GEORADIUS replies broken after RESP3 introduction.
...
This commit fixes #6417 .
2019-10-01 10:38:56 +02:00
antirez
beebb3c013
Merge branch 'hashed-pass-opcode' into unstable
2019-10-01 10:33:04 +02:00
Oran Agra
1b4f888109
Use sdscatfmt instead of sdscatprintf in module info
...
sdscatfmt is faster
2019-09-30 21:13:13 +03:00
Oran Agra
d5c14c70b7
Merge remote-tracking branch 'antirez/unstable' into modules_info
2019-09-30 20:47:35 +03:00
antirez
a9628142fd
Clarify a comment about memory total_frag field.
2019-09-30 18:37:59 +02:00
antirez
09041b9359
ACLs: change hashed passwords opcode to also remove them.
...
Related to PR #6405
2019-09-30 18:28:45 +02:00
Madelyn Olson
ea7c3fe7fd
Allowed passing in of password hash and fixed config rewrite
2019-09-30 17:57:49 +02:00
Salvatore Sanfilippo
eb2114b9cd
Merge pull request #6411 from nikhilajayk/unstable
...
Added cluster host and protected mode variables to the create cluster script.
2019-09-30 17:46:09 +02:00
Salvatore Sanfilippo
2478b47b89
Merge pull request #6304 from dbenders/fix-issue-6141
...
Fix issue #6141 : cluster rebalance does not support binary key
2019-09-30 17:43:58 +02:00
antirez
6a2831c24a
Fix comments aesthetics.
2019-09-30 17:17:36 +02:00
antirez
23f5cb4233
Change a bit the style of #6385 .
2019-09-30 10:58:15 +02:00
Salvatore Sanfilippo
ad45d7e407
Merge pull request #6385 from filipecosta90/perf-reply-ss-error
...
Improve performance of RM_ReplyWithSimpleString and RM_ReplyWi…
2019-09-30 10:57:05 +02:00
antirez
916c4e5d86
moduleRDBLoadError(): io->ctx may be NULL.
...
The correct way to access the module about a given IO context is to
deference io->type->module, since io->ctx is only populated if the user
requests an explicit context from an IO object.
2019-09-27 18:42:38 +02:00
antirez
8b5848a4f5
Fix memory leak in moduleLoadFromQueue().
2019-09-27 18:33:21 +02:00
antirez
b394817754
Fix memory leak in RM_UnregisterCommandFilter().
2019-09-27 18:33:05 +02:00
antirez
0a07f8ffee
TerminateModuleForkChild(): fix function prototype.
2019-09-27 12:23:07 +02:00
antirez
721d3c9e0c
TerminateModuleForkChild(): move safety checks there.
...
We don't want that the API could be used directly in an unsafe way,
without checking if there is an active child. Now the safety checks are
moved directly in the function performing the operations.
2019-09-27 12:17:47 +02:00
antirez
de1f82aa33
Function renamed hasForkChild() -> hasActiveChildProcess().
2019-09-27 12:03:09 +02:00
antirez
82845f8d04
TerminateModuleForkChild(): use wait4 for safety.
...
In theory currently there is only one active child, but the API may
change or for bugs in the implementation we may have several (it was
like that for years because of a bug). Better to wait for a specific
pid and avoid consuing other pending children information.
2019-09-27 11:59:58 +02:00
antirez
beb1356b5b
Improve error message in BGSAVE.
2019-09-27 11:59:37 +02:00
antirez
ae3ef964c1
Modules fork: improve SIGUSR1 handling, fix include.
...
We can't expect SIGUSR1 to have any specific value range, so let's
define an exit code that we can handle in a special way.
This also fixes an #include <wait.h> that is not standard.
2019-09-27 11:39:45 +02:00
Salvatore Sanfilippo
b7c33af4a5
Merge pull request #6247 from oranagra/modules_fork
...
Module API for Forking
2019-09-27 11:24:45 +02:00
Salvatore Sanfilippo
6129758558
Merge branch 'unstable' into modules_fork
2019-09-27 11:24:06 +02:00
nikhilajayk
6578119a23
Added cluster host and protected mode variables
2019-09-26 21:51:49 +05:30
antirez
fddc4757c8
BGREWRITEAOF: improve the generic error message.
2019-09-26 16:14:21 +02:00
Oran Agra
83e87bac76
Fix lastbgsave_status, when new child signal handler get intended kill
...
And add a test for that.
2019-09-26 15:16:34 +03:00
antirez
b7b23bdfb8
INFO: more info about loaded modules.
...
Related to #6024 .
2019-09-26 12:18:55 +02:00
Salvatore Sanfilippo
c1ea6175c5
Merge pull request #6024 from itamarhaber/info_modules
...
Adds a "Modules" section to `INFO`
2019-09-26 11:58:52 +02:00
Salvatore Sanfilippo
959fb5cf68
Merge pull request #6235 from oranagra/module_rdb_load_errors
...
Allow modules to handle RDB loading errors.
2019-09-26 11:52:42 +02:00
Salvatore Sanfilippo
b0a90d8fa8
Merge pull request #4980 from yossigo/rm-assert
...
Add RedisModule_Assert() API call.
2019-09-26 11:39:29 +02:00
filipecosta90
af15b285fa
[fix] fixed the un-refactor bug.
2019-09-25 17:28:42 +01:00
Salvatore Sanfilippo
388bc55344
Merge pull request #6354 from jaredzhu/aarch64-devel
...
Add aarch64 uc_mcontext debug dump info
2019-09-25 18:14:24 +02:00
antirez
b3d6cb268a
Modify #6401 changes to fit 80 cols.
2019-09-25 18:08:11 +02:00
Salvatore Sanfilippo
f3aaf2b4d8
Merge pull request #6401 from valentinogeron/fix-discard-during-oom
...
DISCARD should not fail during OOM
2019-09-25 18:07:25 +02:00
Salvatore Sanfilippo
f6cf08e582
Merge pull request #6402 from mieko/unstable
...
Seed SipHash with 128-bit key
2019-09-25 18:03:39 +02:00
antirez
8a531cedb0
ACL: fix ##6408, default user state affecting all the connections.
2019-09-25 17:45:05 +02:00
Mike A. Owens
0a4d2bbd9c
Seed SipHash with 128-bit key
...
SipHash expects a 128-bit key, and we were indeed generating 128-bits,
but restricting them to hex characters 0-9a-f, effectively giving us
only 4 bits-per-byte of key material, and 64 bits overall.
Now, we skip the hex conversion and supply 128 bits of unfiltered
random data.
2019-09-23 19:24:09 -04:00
filipecosta90
733280d9cb
[fix] un-refactor the code. [perf] replyWithStatus now makes usage of addReplyProto
2019-09-23 23:45:31 +01:00
antirez
eda703ab28
redis-cli: support for ACL style user/pass AUTH.
2019-09-23 19:57:13 +02:00
antirez
b21dd082c3
redis-cli: CSV and RAW target for more RESP3 types.
2019-09-23 19:36:06 +02:00
antirez
cc108057ff
redis-cli: ability to start a session in RESP3 mode.
2019-09-23 17:55:05 +02:00
antirez
8ea185ea30
redis-cli: AUTH can now have 3 arguments as well.
2019-09-23 17:47:36 +02:00
antirez
bb7546c913
RESP3: varbatim handling for other redis-cli outputs.
2019-09-23 17:42:57 +02:00
antirez
5e399d5d33
hiredis udpated (RESP3 WIP).
2019-09-23 17:41:04 +02:00
antirez
264708427b
RESP3: implementation of verbatim output with TTY target.
2019-09-23 17:39:42 +02:00
valentino
7a73b7f168
DISCARD should not fail during OOM
...
discard command should not fail during OOM, otherwise client MULTI state
will not be cleared.
2019-09-22 09:22:53 +03:00
antirez
c3899720f6
hiredis updated to master version.
2019-09-20 20:08:38 +02:00