antirez
feb282883b
zzlIsInRange() now is capable of handling empty sorted sets that may end inside the data set when loading very old RDB files produced by early-stage versions of Redis.
2012-02-22 09:52:10 +01:00
Pieter Noordhuis
ca2344f991
Solaris has backtrace(3)
2012-02-21 10:20:28 -08:00
Pieter Noordhuis
57be47758e
Also force SIGSEGV without HAVE_BACKTRACE
2012-02-21 10:20:01 -08:00
antirez
7c96b467c1
Fixed undefined behavior in *INCR style functions overflow detection. Sorry clang!
2012-02-21 18:26:11 +01:00
antirez
fe7be46025
bzero -> memset
2012-02-21 10:06:04 +01:00
antirez
b66e5add82
The hiredis lib shipped with Redis was updated to latest version.
2012-02-19 20:26:50 +01:00
Pieter Noordhuis
cb598cdd59
Don't expire keys when loading an RDB after a SYNC
...
The cron is responsible for expiring keys. When keys are expired at
load time, it is possible that the snapshot of a master node gets
modified. This can in turn lead to inconsistencies in the data set.
A more concrete example of this behavior follows. A user reported a
slave that would show an monotonically increase input buffer length,
shortly after completing a SYNC. Also, `INFO` output showed a single
blocked client, which could only be the master link. Investigation
showed that indeed the `BRPOP` command was fed by the master. This
command can only end up in the stream of write operations when it did
NOT block, and effectively executed `RPOP`. However, when the key
involved in the `BRPOP` is expired BEFORE the command is executed, the
client executing it will block. The client in this case, is the master
link.
2012-02-16 17:21:13 +01:00
antirez
a400a9b2d7
Now HINCRBY can detect overflows too. Fix for issue #330 .
2012-02-16 16:09:08 +01:00
antirez
6e09ad1c15
Return ASAP from checkClientOutputBufferLimits() if c->reply_bytes is zero.
2012-02-16 12:20:56 +01:00
antirez
48a32944e6
Merge branch 'issue327' into unstable
2012-02-16 09:40:27 +01:00
antirez
3b0600c777
Add stdint.h in endianconv.h to fix issue #336 .
2012-02-15 12:21:04 +01:00
antirez
4a701b3801
redis-check-aof is now large files safe also on 32 bit systems.
2012-02-14 19:57:51 +01:00
antirez
120a36f22b
add -f flag to cp when installing, otherwise stopping the server is
...
needed when installing a new Redis version. Thanks to Scott Kevill.
Fixes issue #335 .
2012-02-14 16:15:24 +01:00
antirez
7a3e372025
endian.c/h -> endianconv.c/h to avoid issues with broken libraries search paths.
2012-02-14 16:11:46 +01:00
antirez
18aa2b87b6
Merge remote-tracking branch 'origin/unstable' into unstable
2012-02-14 16:02:04 +01:00
antirez
6136a16bd1
intset.c endianess fixes.
2012-02-14 15:35:50 +01:00
lsbardel
2f75bbab02
added lua struct c extension
2012-02-13 21:05:21 +00:00
antirez
66d1b021ec
ziplist.c endianess fixes, chapter 5.
2012-02-09 17:09:01 +01:00
antirez
cab1105c6e
ziplist.c endianess fixes, chapter 4.
2012-02-09 16:36:25 +01:00
antirez
3fa19b7dfc
ziplist.c endianess fixes, chapter 3.
2012-02-09 16:28:35 +01:00
antirez
8e0ef249a2
more ziplist.c endianess fixes
2012-02-08 23:20:39 +01:00
antirez
5653847714
ziplist.c fixes for bigendian
2012-02-08 22:59:35 +01:00
antirez
ac834d237a
A few small BSD related fixes.
2012-02-08 22:24:59 +01:00
antirez
b129c6df45
debugging messages removed from freeMemoryIfNeeded()
2012-02-08 00:10:20 +01:00
antirez
609baba8a2
Fixes to c->reply_bytes computation, and debug messages to closely study the behavior of memory pressure + slaves + maxmemory + blocked slaves.
2012-02-07 17:41:31 +01:00
antirez
442246dde2
Precision of getClientOutputBufferMemoryUsage() greatily improved, see issue #327 for more information.
2012-02-07 13:05:36 +01:00
antirez
8b7c3455b9
freeMemoryIfNeeded() minor refactoring
2012-02-06 16:56:42 +01:00
antirez
c1ef6ffe8a
Also remove size of AOF buffers from used memory when doing the math for freeMemoryIfNeeded()
2012-02-06 16:35:43 +01:00
antirez
7441fcdd56
Redis Manifesto moved from src to root dir
2012-02-05 09:37:08 +01:00
antirez
f6b32c14f4
This fixes issue #327 , is a very complex fix (unfortunately), details:
...
1) sendReplyToClient() now no longer stops transferring data to a single
client in the case we are out of memory (maxmemory-wise).
2) in processCommand() the idea of we being out of memory is no longer
the naive zmalloc_used_memory() > server.maxmemory. To say if we can
accept or not write queries is up to the return value of
freeMemoryIfNeeded(), that has full control about that.
3) freeMemoryIfNeeded() now does its math without considering output
buffers size. But at the same time it can't let the output buffers to
put us too much outside the max memory limit, so at the same time it
makes sure there is enough effort into delivering the output buffers to
the slaves, calling the write handler directly.
This three changes are the result of many tests, I found (partially
empirically) that is the best way to address the problem, but maybe
we'll find better solutions in the future.
2012-02-04 14:05:54 +01:00
antirez
355f859134
Use less memory when emitting the protocol, by using more shared objects for commonly emitted parts of the protocol.
2012-02-04 08:58:37 +01:00
antirez
ce8b772be7
Now Lua scripts dispatch Redis commands properly calling the call() function. In order to make this possible call() was improved with a new flags argument that controls how the Redis command is executed.
2012-02-02 16:30:52 +01:00
antirez
d876678b5e
Set a 3.5 GB maxmemory limit with noeviction policy if a 32 bit instance without user-provided memory limits is detected.
2012-02-02 10:26:20 +01:00
antirez
75eaac5c74
Added a server.arch_bits field instead of computing it at runtime for INFO.
2012-02-02 10:23:31 +01:00
antirez
b80b1c5914
Only incremnet stats for key miss/hit when the key is semantically accessed in read-only.
2012-02-01 21:51:20 +01:00
antirez
de79a2ee12
Make SORT BY <constant> STORE ... to always produce the same output by force sorting, so that we have deterministic replication of this command.
2012-02-01 17:05:45 +01:00
antirez
2c861050c1
SORT is now more deterministic: does not accept to compare by score items that have scores not representing a valid double. Also items with the same score are compared lexycographically. At the same time the scripting side introduced the ability to sort the output of SORT when sort uses the BY <constant> optimization, resulting in no specific ordering. Since in this case the user may use GET, and the result of GET can be null, converted into false as Lua data type, this commit also introduces the ability to sort Lua tables containining false, only if the first (faster) attempt at using just table.sort with a single argument fails.
2012-02-01 15:22:28 +01:00
antirez
548efd91e5
Order output of commands returning random arrays using table.sort when called from Lua, partially fixing issue #165 . The issue is yet not completely fixed since we can't add the REDIS_CMD_SORT_FOR_SCRIPT flag in SORT currently, both because it may contain NULLs and because it is not cool to re-sort everything at every call when instead this should be sorted only if BY <constant> is used.
2012-01-31 16:09:21 +01:00
antirez
8dd19d818f
Fixed redis-benchmark --help output typo
2012-01-31 11:43:32 +01:00
antirez
3c08fdae71
64 bit instances are no longer limited to have at max 2^32-1 elements in lists.
2012-01-31 10:35:52 +01:00
antirez
d1c4c94ebf
Merge remote-tracking branch 'origin/unstable' into unstable
2012-01-30 10:40:28 +01:00
Salvatore Sanfilippo
eb7d19ed69
Merge pull request #319 from fawek/lua-error-location
...
Lua reports line numbers off by one in error messages
2012-01-30 01:40:17 -08:00
antirez
89f6f6abcf
setKey(): call the higher level wrapper setModifiedKey() instead of touchWatchedKey() even if currently they are exactly the same.
2012-01-30 10:27:50 +01:00
Michal Kwiatkowski
a0bf8d0ad8
SORT with STORE removes key if result is empty. This fixes issue #227 .
2012-01-30 07:36:49 +01:00
Jakub Wieczorek
4d776dba3c
Lua reports line numbers off by one in error messages
2012-01-29 14:53:49 +01:00
Pieter Noordhuis
80586cb894
Test that zipmap from RDB is correctly converted
2012-01-25 13:28:11 -08:00
antirez
c715c9b8bf
Fixed typo in getClientLimitClassByName()
2012-01-25 18:07:56 +01:00
antirez
d329031fad
Fixed another possible bug in cluster.c found by clang --analyze.
2012-01-25 16:59:36 +01:00
antirez
9b810f1cde
Merge branch 'unstable' into limits
2012-01-25 16:46:53 +01:00
antirez
6710ff24d0
Fixed a non critical bug signaled by clang static analyzer thanks to Mukund Sivaraman for reporting it: there was a not initialized field populating the cluster message header, but it is always fixed at later time before sending the packet.
2012-01-25 16:46:35 +01:00
