antirez
e534e9aa83
In scanDatabaseForReadyLists() now we need to handle ZSETs as well.
...
Since the introduction of ZPOP makes this needed. Thanks to @oranagra
for reporting.
2018-06-12 17:28:40 +02:00
antirez
f70e88c1f6
RDB: store times consistently in little endian.
...
I'm not sure how this escaped the attention of Redis users for years,
but finally @oranagra reported this issue... Thanks to Oran.
2018-06-12 17:22:03 +02:00
antirez
4774d61691
Streams: improve type correctness in t_stream.c.
2018-06-12 14:12:53 +02:00
antirez
bcc42028c1
Fix XGROUP help missing space.
2018-06-12 13:20:46 +02:00
antirez
e916f4519c
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-06-12 13:14:01 +02:00
antirez
6bf65138de
Regression test for issue #5006 .
2018-06-12 13:13:35 +02:00
Salvatore Sanfilippo
bcecbebb74
Merge pull request #5012 from shenlongxing/fix-config
...
fix active-defrag-threshold value error
2018-06-12 13:05:19 +02:00
Shen Longxing
13957c9d07
fix active-defrag-threshold value error
...
The active-defrag-threshold-lower/active-defrag-threshold-upper min/max value in redis.conf should be consistent with 'config set' command.
2018-06-12 17:59:32 +08:00
antirez
7cc1312789
Streams: fix backward iteration when entry is not flagged SAMEFIELD.
...
See issue #5006 . The comment in the code was also wrong and
was rectified as well.
2018-06-12 10:22:49 +02:00
球状闪电
7659619824
Update geohash.c
...
fix geohasEncode bug when step > 31
2018-06-12 15:28:28 +08:00
Salvatore Sanfilippo
82661ba329
Merge pull request #5007 from leonchen83/patch-2
...
fix typo issue #5005
2018-06-12 09:28:26 +02:00
antirez
923e63e5ec
Streams: increment dirty counter for XGROUP SETID/DESTROY.
...
See issue #5005 comments.
2018-06-12 09:27:40 +02:00
Baoyi Chen
fac3e8aab5
fix typo
...
fix [#5005 ](https://github.com/antirez/redis/issues/5005 )
2018-06-12 08:52:18 +08:00
antirez
cec404f099
Use a less aggressive query buffer resize policy.
...
A user with many connections (10 thousand) on a single Redis server
reports in issue #4983 that sometimes Redis is idle becuase at the same
time many clients need to resize their query buffer according to the old
policy.
It looks like this was created by the fact that we allow the query
buffer to grow without problems to a size up to PROTO_MBULK_BIG_ARG
normally, but when the client is idle we immediately are more strict,
and a query buffer greater than 1024 bytes is already enough to trigger
the resize. So for instance if most of the clients stop at the same time
this issue should be easily triggered.
This behavior actually looks odd, and there should be only a clear limit
after we say, let's look at this query buffer to check if it's time to
resize it. This commit puts the limit at PROTO_MBULK_BIG_ARG, and the
check is performed both if compared to the peak usage the current usage
is too big, or if the client is idle.
Then when the check is performed, to waste just a few kbytes is
considered enough to proceed with the resize. This should fix the issue.
2018-06-11 17:12:28 +02:00
antirez
5bbb00fbb4
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-06-11 16:52:45 +02:00
antirez
34bd44187a
Fix client unblocking for XREADGROUP, issue #4978 .
...
We unblocked the client too early, when the group name object was no
longer valid in client->bpop, so propagating XCLAIM later in
streamPropagateXCLAIM() deferenced a field already set to NULL.
2018-06-11 16:51:06 +02:00
Salvatore Sanfilippo
ba2101738d
Merge pull request #5000 from shenlongxing/fix-config
...
fix integer case error
2018-06-11 16:34:26 +02:00
Salvatore Sanfilippo
b136502d0f
Merge pull request #4995 from shenlongxing/unstable
...
fix stream config typo
2018-06-11 16:33:38 +02:00
Salvatore Sanfilippo
5db262b623
Merge pull request #5002 from soloestoy/streams-read-or-write
...
Streams: lookupKey[Read->Write]OrReply in xdel and xtrim
2018-06-11 16:33:10 +02:00
Salvatore Sanfilippo
e2a9ea0405
Merge pull request #4901 from KFilipek/zmalloc_typo_fix
...
HW_PHYSMEM typo in preprocessor condition
2018-06-11 16:32:40 +02:00
Salvatore Sanfilippo
295db9ee0a
Merge pull request #5003 from soloestoy/streams-checkType
...
Streams: checkType for xread & xinfo
2018-06-11 16:32:00 +02:00
Salvatore Sanfilippo
163f32c22a
Merge pull request #5001 from michael-grunder/xgroup-check-type
...
Abort in XGROUP if the key is not a stream
2018-06-11 16:30:49 +02:00
antirez
00613bed06
Improved regression test for #4906 .
...
Removing the fix about 50% of the times the test will not be able to
pass cleanly. It's very hard to write a test that will always fail, or
actually, it is possible but then it's likely that it will consistently
pass if we change some random bit, so better to use randomization here.
2018-06-11 13:10:06 +02:00
antirez
27beaf2f22
Regression test for the dictScan() issue #4906 .
2018-06-11 12:51:26 +02:00
zhaozhao.zz
b8913ce721
Streams: checkType for xread & xinfo
2018-06-11 01:17:52 +08:00
zhaozhao.zz
cc81c6f1d3
Streams: lookupKey[Read->Write]OrReply in xdel and xtrim
2018-06-11 00:14:17 +08:00
michael-grunder
c04082cf13
Abort in XGROUP if the key is not a stream
2018-06-10 08:55:58 -07:00
shenlongxing
1210dd8a20
fix integer case error
2018-06-09 22:24:33 +08:00
Salvatore Sanfilippo
be899b824e
Merge pull request #4519 from soloestoy/zset-int-problem
...
Zset int problem
2018-06-08 12:45:11 +02:00
Salvatore Sanfilippo
5ebaadc96b
Merge pull request #4800 from soloestoy/dict-expand
...
adjust position of _dictNextPower in dictExpand
2018-06-08 12:32:18 +02:00
Salvatore Sanfilippo
9fa2e7020e
Merge pull request #4861 from soloestoy/rdb-dict-expand
...
RDB: expand dict if needed when rdb load object
2018-06-08 12:12:34 +02:00
antirez
269e80526f
Implement DEBUG htstats-key.
2018-06-08 11:17:20 +02:00
antirez
97e1f6812c
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-06-08 11:02:30 +02:00
antirez
2268d7e5dd
redis-cli inline help updated.
2018-06-07 18:53:00 +02:00
antirez
b2fc2eaecb
Add the stream group to the script generating the help.
2018-06-07 18:52:01 +02:00
Salvatore Sanfilippo
66c6218a3c
Merge pull request #4977 from michael-grunder/xpending-early-return
...
Return early in XPENDING if sent a nonexistent consumer group.
2018-06-07 18:49:09 +02:00
shenlongxing
018cf118d6
fix stream config typo
2018-06-07 23:13:36 +08:00
antirez
f847dd3ad8
Streams: better document the max node limits.
2018-06-07 14:37:56 +02:00
antirez
a7dbe37d53
Typo: entires -> entries in several places.
2018-06-07 14:36:56 +02:00
antirez
dfb3bf1b1e
Streams: make macro node limits configurable.
2018-06-07 14:36:13 +02:00
antirez
6d34ff3645
Streams: max node limits only checked if non zero.
2018-06-07 14:30:25 +02:00
antirez
19a438e2c0
Streams: use non static macro node limits.
...
Also add the concept of size/items limit, instead of just having as
limit the number of bytes.
2018-06-07 14:24:49 +02:00
shenlongxing
c85ae56edc
Fix write() errno error
2018-06-06 13:06:42 +02:00
antirez
b61416bdf4
Fix streamIteratorRemoveEntry() to update elements count.
...
Close #4989 .
2018-06-06 11:40:22 +02:00
antirez
0a698e499a
ZPOP: invert score-ele to match ZRANGE WITHSCORES order.
2018-06-05 17:06:25 +02:00
antirez
9e25f3e1de
Remove XINFO <key> special form.
...
As observed by Michael Grunder this usage while practical is
inconsistent because for instance it does not work against a key called
HELP. Removed.
2018-06-05 16:34:34 +02:00
antirez
2f123ea6a3
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-06-04 17:30:11 +02:00
antirez
36b392a0b2
XGROUP SETID implemented + consumer groups core fixes.
...
Now that we have SETID, the inetrnals of consumer groups should be able
to handle the case of the same message delivered multiple times just
as a side effect of calling XREADGROUP. Normally this should never
happen but if the admin manually "XGROUP SETID mykey mygroup 0",
messages will get re-delivered to clients waiting for the ">" special
ID. The consumer groups internals were not able to handle the case of a
message re-delivered in this circumstances that was already assigned to
another owner.
2018-06-04 17:28:03 +02:00
antirez
05a2996641
Rax library updated.
2018-06-04 17:26:16 +02:00
Salvatore Sanfilippo
b1783d3ab9
Merge pull request #4981 from yossigo/gcc7
...
Clean gcc 7.x warnings, redis-cli cluster fix.
2018-06-04 17:18:39 +02:00