antirez
7698316fda
Fix RM_Call() stale comment due to cut&paste.
2020-03-31 10:27:47 +02:00
antirez
19f5be231d
Modules: updated function doc after #7003 .
2020-03-23 11:17:50 +01:00
Salvatore Sanfilippo
7c5dc07016
Merge pull request #7003 from guybe7/rm_context_flags_handle_null
...
Allow RM_GetContextFlags to work with ctx==NULL
2020-03-23 11:15:42 +01:00
Guy Benoish
f16eaadd4f
Allow RM_GetContextFlags to work with ctx==NULL
2020-03-18 18:34:27 +05:30
Salvatore Sanfilippo
ebf1acd33c
Merge pull request #6918 from chendq8/fixModuleUnregisterUsedApi
...
Fix module unregister used api
2020-03-13 12:46:27 +01:00
antirez
c8ae90fef6
Modules: reformat RM_Scan() top comment a bit.
2020-02-28 18:09:46 +01:00
antirez
8a3e9a6d44
Modules: more details in RM_Scan API top comment.
2020-02-28 18:06:30 +01:00
Salvatore Sanfilippo
86cbddc475
Merge pull request #6838 from oranagra/rm_scan_dict_rehash
...
RM_Scan disable dict rehashing
2020-02-28 17:47:52 +01:00
Salvatore Sanfilippo
4ccb56d0e6
Merge pull request #6828 from guybe7/module_string_from_double
...
Add RM_CreateStringFromDouble
2020-02-28 11:06:02 +01:00
Salvatore Sanfilippo
f0d9a4e1a4
Merge pull request #6893 from oranagra/api_doc_aux_save
...
module api docs for aux_save and aux_load
2020-02-28 10:22:53 +01:00
Salvatore Sanfilippo
ca825701dc
Merge pull request #6876 from MeirShpilraien/changed_log_level_of_module_fork_api
...
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-27 10:26:55 +01:00
Salvatore Sanfilippo
37612118c8
Merge pull request #6919 from ashtul/Fix-ThreadSafeContext-functions-names
...
fix ThreadSafeContext lock/unlock function names
2020-02-27 10:01:48 +01:00
Guy Benoish
376a806bfb
Modules: Do not auto-unblock clients if not blocked on keys
2020-02-23 19:36:46 +05:30
Ariel
28bde89172
fix ThreadSafeContext lock/unlock function names
2020-02-22 23:49:23 +02:00
chendianqiang
9947956d7b
use correct list for moduleUnregisterUsedAPI
2020-02-22 15:03:01 +08:00
Oran Agra
6fff2cf9b6
module api docs for aux_save and aux_load
2020-02-16 15:43:19 +02:00
Salvatore Sanfilippo
c21c23bbba
Merge pull request #6863 from oranagra/module_commands_no_slowlog
...
add no-slowlog option to RM_CreateCommand
2020-02-13 17:02:19 +01:00
meir@redislabs.com
67dbc5f365
Changed log level for module fork api from 'notice' to 'verbos'.
2020-02-10 12:10:32 +02:00
Oran Agra
46216b0e83
add no-slowlog option to RM_CreateCommand
2020-02-06 15:06:33 +02:00
Oran Agra
28ef18a894
RM_Scan disable dict rehashing
...
The callback approach we took is very efficient, the module can do any
filtering of keys without building any list and cloning strings, it can
also read data from the key's value. but if the user tries to re-open
the key, or any other key, this can cause dict re-hashing (dictFind does
that), and that's very bad to do from inside dictScan.
this commit protects the dict from doing any rehashing during scan, but
also warns the user not to attempt any writes or command calls from
within the callback, for fear of unexpected side effects and crashes.
2020-02-06 11:48:12 +02:00
Salvatore Sanfilippo
5bfba06a3b
Merge pull request #6821 from guybe7/key_miss_notify
...
Exclude "keymiss" notification from NOTIFY_ALL
2020-02-06 10:43:05 +01:00
Salvatore Sanfilippo
2e1dd00c80
Merge pull request #6837 from oranagra/signal_modified_key_doc
...
update RM_SignalModifiedKey doc comment
2020-02-06 10:38:36 +01:00
Salvatore Sanfilippo
13741fb99d
Merge pull request #6846 from oranagra/module_client_flags
...
Fix client flags to be int64 in module.c
2020-02-06 10:32:35 +01:00
Oran Agra
85cc696f50
moduleRDBLoadError, add key name, and use panic rather than exit
...
using panic rather than exit means you get s stack trace of the code
path that experianced the error, and possibly other info.
2020-02-06 09:37:04 +02:00
Oran Agra
d454d5a4f5
Fix client flags to be int64 in module.c
...
currently there's no bug since the flags these functions handle are
always lower than 32bit, but still better fix the type to prevent future
bugs.
2020-02-06 09:33:20 +02:00
Oran Agra
3795aaf42a
update RM_SignalModifiedKey doc comment
2020-02-05 18:15:38 +02:00
Guy Benoish
1c7a2269d6
Add RM_CreateStringFromDouble
2020-02-04 19:28:09 +05:30
Oran Agra
138ed120dd
fix uninitialized info_cb var in module.c
2020-02-03 16:35:39 +02:00
Guy Benoish
2fda5f5c98
Exclude "keymiss" notification from NOTIFY_ALL
...
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)
Also updated redis.conf and module.c docs
2020-02-03 15:43:44 +05:30
Salvatore Sanfilippo
53ac8c7df2
Merge pull request #6812 from guybe7/str_convert_fix
...
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
Guy Benoish
2deb55512f
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
antirez
17ff3173d6
Add more info in the unblockClientFromModule() function.
2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo
bf53f9280a
Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
...
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
Guy Benoish
d7d13721d3
Modules: Fix blocked-client-related memory leak
...
If a blocked module client times-out (or disconnects, unblocked
by CLIENT command, etc.) we need to call moduleUnblockClient
in order to free memory allocated by the module sub-system
and blocked-client private data
Other changes:
Made blockedonkeys.tcl tests a bit more aggressive in order
to smoke-out potential memory leaks
2019-12-30 10:10:59 +05:30
Yossi Gottlieb
0c898bdb07
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2019-12-23 19:43:51 +02:00
Oran Agra
660645c742
modules don't signalModifiedKey in setKey() since that's done (optionally) in RM_CloseKey
2019-12-23 10:15:52 +02:00
antirez
324e22accf
Fix ip and missing mode in RM_GetClusterNodeInfo().
2019-12-20 12:29:02 +01:00
Salvatore Sanfilippo
d3a9dff6b9
Merge pull request #6615 from soloestoy/wrap-also-propagate-as-multi
...
Wrap also propagate as multi
2019-12-19 09:24:52 +01:00
antirez
c5bc1c14c0
Modules: rewrite top function doc of AvoidReplicaTraffic().
2019-12-18 17:11:03 +01:00
Salvatore Sanfilippo
ef0b45ece8
Merge pull request #6497 from oranagra/avoid_replica_traffic
...
Add config and module API for AvoidReplicaTraffic
2019-12-18 17:06:05 +01:00
antirez
5b9d3ac6c6
Avoid changing setKey() API after #6679 fix.
2019-12-18 11:58:02 +01:00
zhaozhao.zz
24044f3356
add a new SET option KEEPTTL that doesn't remove expire time
2019-12-18 15:20:36 +08:00
Salvatore Sanfilippo
b7c78b7651
Merge pull request #5916 from madolson/dev-unstable-acl-module-pr
...
Add module APIs for custom authentication
2019-12-17 09:58:26 +01:00
Madelyn Olson
576a08908b
Split error message so dependandent callers give a useful result
2019-12-16 23:34:37 -08:00
Madelyn Olson
44aa22c635
Added better exception handling around scripting and module
2019-12-16 23:33:53 -08:00
Madelyn Olson
f891b64a83
Tweaking the documentation
2019-12-17 07:28:55 +00:00
Madelyn Olson
034dcf185c
Add module APIs for custom authentication
2019-12-17 06:59:59 +00:00
antirez
aa3f13761f
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-12-16 11:18:20 +01:00
antirez
096592506e
Modules: allow to execute RM_Call() from the module init function.
2019-12-13 17:34:37 +01:00
Yossi Gottlieb
0283db5883
Improve RM_ModuleTypeReplaceValue() API.
...
With the previous API, a NULL return value was ambiguous and could
represent either an old value of NULL or an error condition. The new API
returns a status code and allows the old value to be returned
by-reference.
This commit also includes test coverage based on
tests/modules/datatype.c which did not exist at the time of the original
commit.
2019-12-12 18:50:11 +02:00