antirez
ffe003dcbe
memtest.c fixed to actually use v1 and v2 in memtest_fill_value().
2012-04-27 16:29:44 +02:00
antirez
841048f2c8
redis-cli commands description in help.h updated.
2012-04-27 15:57:27 +02:00
antirez
0ad10db220
Set LUA_MASKCOUNT hook more selectively. Fixes issue #480 .
...
An user reported a crash with Redis scripting (see issue #480 on
github), inspection of the kindly provided strack trace showed that
server.lua_caller was probably set to NULL. The stack trace also slowed
that the call to the hook was originating from a point where we just
used to set/get a few global variables in the Lua state.
What was happening is that we did not set the timeout hook selectively
only when the user script was called. Now we set it more selectively,
specifically only in the context of the lua_pcall() call, and make sure
to remove the hook when the call returns. Otherwise the hook can get
called in random contexts every time we do something with the Lua
state.
2012-04-27 11:41:25 +02:00
antirez
a3eb7ac87d
Re-introduce -g -rdynamic -ggdb when linking, fixing strack traces.
...
A previous commit removed -g -rdynamic -ggdb as LDFLAGS, not allowing
Redis to produce a stack trace wth symbol names on crash.
This commit fixes the issue.
2012-04-26 16:53:11 +02:00
antirez
11bd247d2b
Produce the stack trace in an async safe way.
2012-04-26 16:28:54 +02:00
antirez
3ada43e732
Don't use an alternative stack for SIGSEGV & co.
...
This commit reverts most of c575766202
2012-04-26 16:21:19 +02:00
David Tran
31788f50b7
Spelling: s/synchrnonization/synchronization
2012-04-25 12:21:56 -07:00
antirez
29c8cf0116
redis-check-dump now is RDB version 6 ready.
2012-04-24 19:05:27 +02:00
antirez
7dbc514de7
Spurious debugging printf removed.
2012-04-24 17:15:21 +02:00
antirez
a76b9063d0
Added two new encodings to ziplist.c
...
1) One integer "immediate" encoding that can encode from 0 to 12 in the
encoding byte itself.
2) One 8 bit signed integer encoding that can encode 8 bit signed small
integers in a single byte.
The idea is to exploit all the not used bits we have around in a
backward compatible way.
2012-04-24 17:04:00 +02:00
antirez
053d56a1fa
rdbLoad() should check REDIS_RDB_VERSION instead of hardcoded number.
2012-04-24 12:53:30 +02:00
antirez
f22cff43a6
ziplist.c: added comments about the new 24 bit encoding.
2012-04-24 12:52:36 +02:00
Grisha Trubetskoy
5a86ab4799
Add a 24bit integer to ziplists to save one byte for ints that can
...
fit in 24 bits (thanks to antirez for catching and solving the two's compliment
bug).
Increment REDIS_RDB_VERSION to 6
2012-04-24 12:02:19 +02:00
antirez
21661d7acc
Fixed a bug in propagation of PUBLISH via the cluster bus.
...
This bug was spotted by clang on FreeBSD.
2012-04-24 11:28:10 +02:00
antirez
e54fe9a79f
A few compiler warnings suppressed.
2012-04-24 11:11:55 +02:00
antirez
a66a496349
Fix and refactoring of code used to get registers on crash.
...
This fixes compilation on FreeBSD (and possibly other systems) by
not using ucontext_t at all if HAVE_BACKTRACE is not defined.
Also the ifdefs to get the registers are modified to explicitly test for the
operating system in the first level, and the arch in the second level
of nesting.
2012-04-24 11:11:35 +02:00
Salvatore Sanfilippo
d344228734
Merge pull request #421 from ErikDubbelboer/sds-const
...
Added consts keyword where possible
2012-04-23 02:34:19 -07:00
antirez
a3f990818d
Remove loadfile() access from the scripting engine.
2012-04-23 10:43:24 +02:00
antirez
eb6e7eb94d
Even inside #if 0 comments are comments.
2012-04-21 21:49:21 +02:00
antirez
92cc20ecfe
Merge remote-tracking branch 'origin/unstable' into unstable
2012-04-21 20:35:51 +02:00
antirez
d3701d2714
Limit memory used by big SLOWLOG entries.
...
Two limits are added:
1) Up to SLOWLOG_ENTRY_MAX_ARGV arguments are logged.
2) Up to SLOWLOG_ENTRY_MAX_STRING bytes per argument are logged.
3) slowlog-max-len is set to 128 by default (was 1024).
The number of remaining arguments / bytes is logged in the entry
so that the user can understand better the nature of the logged command.
2012-04-21 20:34:45 +02:00
Salvatore Sanfilippo
7d3ee4172f
Merge pull request #440 from ErikDubbelboer/spelling
...
Fixed some spelling errors in comments
2012-04-21 03:31:06 -07:00
antirez
e3923a3508
SHUTDOWN NOSAVE now can stop a non returning script. Issue #466 .
2012-04-19 23:35:15 +02:00
antirez
1e35ae7486
Currenly not used code in dict.c commented out.
2012-04-18 23:56:07 +02:00
antirez
5386f72d00
redis-cli --bigkeys output modified to be simpler to read..
2012-04-18 20:53:37 +02:00
antirez
f26761aa10
redis-cli --bigkeys
2012-04-18 20:33:02 +02:00
antirez
5ba79bda7f
Document mostly dead code in RPOPLPUSH implementation.
2012-04-18 17:38:02 +02:00
Salvatore Sanfilippo
d162f9eb64
Merge pull request #456 from pietern/unstable-mkopts
...
Persist Makefile flags (unstable)
2012-04-18 07:25:59 -07:00
antirez
acf41c96cb
Marginally cleaner lookupKeyByPattern() implementation.
...
just fieldobj itself as sentinel of the fact a field object is used or
not, instead of using the filed length, that may be confusing both for
people and for the compiler emitting a warning.
2012-04-18 11:37:14 +02:00
antirez
a5f8341245
Two small fixes to maxclients handling.
...
1) Don't accept maxclients set to < 0
2) Allow maxclients < 1024, it is useful for testing.
2012-04-18 11:31:24 +02:00
antirez
3c25c4a691
lookupKeyByPattern() used by SORT GET/BY rewritten. Fixes issue #460 .
...
lookupKeyByPattern() was implemented with a trick to speedup the lookup
process allocating two fake Redis obejcts on the stack. However now that
we propagate expires to the slave as DEL operations the lookup of the
key may result into a call to expireIfNeeded() having the stack
allocated object as argument, that may in turn use it to create the
protocol to send to the slave. But since this fake obejcts are
inherently read-only this is a problem.
As a side effect of this fix there are no longer size limits in the
pattern to be used with GET/BY option of SORT.
See https://github.com/antirez/redis/issues/460 for bug details.
2012-04-17 13:05:09 +02:00
Pieter Noordhuis
7e7b69fee1
Persist make settings and trigger rebuild if anything changes
2012-04-13 17:52:33 -07:00
Pieter Noordhuis
34c943b395
Don't set flags recursively
2012-04-13 17:52:33 -07:00
Pieter Noordhuis
620357fc8f
Remove unused LIBS variable
2012-04-13 17:52:33 -07:00
Pieter Noordhuis
caba585121
First set defaults, then do composition
2012-04-13 17:52:33 -07:00
Pieter Noordhuis
c04278ba3b
Question mark assignment is not needed
2012-04-13 17:52:33 -07:00
Pieter Noordhuis
166cf8a3b8
Ignore gcov/lcov artifacts
2012-04-13 17:52:33 -07:00
Pieter Noordhuis
0342dd7647
The lcov target shouldn't clean
...
This is not needed because every change in compiler/linker flags
triggers a cleanup.
2012-04-13 17:52:30 -07:00
Pieter Noordhuis
631539a5f2
Rename ADD_*FLAGS -> REDIS_*FLAGS, REDIS_*FLAGS -> FINAL_*FLAGS
...
This reflects that REDIS_*FLAGS will only be used for compilation of
Redis and not for its dependencies. Similarly, that FINAL_*FLAGS are
composed of other variables and holds the options that are finally
passed to the compiler and linker.
2012-04-13 17:34:31 -07:00
antirez
93a74949d7
Merge branch 'strict.lua' into unstable
2012-04-13 16:16:13 +02:00
antirez
c18405c909
A few var names fixed in Makefile.
...
I modified it for error in a previous commit doing search & replace.
2012-04-13 16:13:56 +02:00
antirez
6f659f34cf
EVAL errors are more clear now.
2012-04-13 15:12:16 +02:00
antirez
3a02140415
Use Lua tostring() before concatenation.
2012-04-13 14:54:49 +02:00
antirez
d86c4a7bf0
mt.declared is no longer needed.
...
Lua global protection can now be simpified becuase we no longer have the
global() function. It's useless to occupy memory with this table, it is
also not faster because the metamethods we use are only called when a
global object does not exist or we are trying to create it from a
script.
2012-04-13 13:36:08 +02:00
antirez
6663653f51
Stop access to global vars. Not configurable.
...
After considering the interaction between ability to delcare globals in
scripts using the 'global' function, and the complexities related to
hanlding replication and AOF in a sane way with globals AND ability to
turn protection On and Off, we reconsidered the design. The new design
makes clear that there is only one good way to write Redis scripts, that
is not using globals. In the rare cases state must be retained across
calls a Redis key can be used.
2012-04-13 13:26:59 +02:00
antirez
c9edd1b28a
Globals protection global() function modified for speed and correctness.
2012-04-13 12:13:02 +02:00
antirez
37b29ef2fa
Scripting: globals protection can now be switched on/off.
2012-04-13 11:23:45 +02:00
antirez
6e05f333a2
Print arch bits with redis-server -v
2012-04-12 11:50:18 +02:00
antirez
4c442e9d88
memtest.c: integer overflow fixed.
2012-04-12 11:49:52 +02:00
antirez
91e56965a3
Make gcov fixed.
2012-04-12 11:51:58 +02:00
antirez
9c83aec955
Makefile now introduces Redis-specific CFLAGS / LDFLAGS. Gcov target fixed. Added comments to describe how it works.
2012-04-12 11:09:38 +02:00
Salvatore Sanfilippo
0d83011a11
Merge pull request #449 from ErikDubbelboer/unstable
...
added explanation for the magic 511 backlog number
2012-04-11 09:25:44 -07:00
Erik Dubbelboer
815c06f2f7
added explanation for the magic 511 backlog number
2012-04-11 17:04:31 +02:00
antirez
ced068955d
Makefile.dep updated.
2012-04-11 12:12:30 +02:00
antirez
a470689d2e
make dep: redirect output to Makefile.dep.
2012-04-11 12:12:05 +02:00
antirez
c44ab51da1
Make inline functions rioRead/Write/Tell static. This fixes issue #447 .
2012-04-11 11:58:32 +02:00
antirez
d98b03b791
Macros ULONG_ONEZERO / ULONG_ZEROONE were inverted in #ifdef to test 32/64 bit arch.
2012-04-11 11:32:22 +02:00
Pieter Noordhuis
0a08d2b0e5
Clean up Makefiles
...
Remove unused variables. Instead of overriding non-standard variables
such as ARCH and PROF, use standard variables CFLAGS and LDFLAGS to
override Makefile settings. Move dependencies generated by `make dep` to
a separate file.
2012-04-11 11:24:17 +02:00
Pieter Noordhuis
3f7438ef9b
Everything x86 is little endian
2012-04-11 11:03:30 +02:00
antirez
f2f2ba1b3a
Comment typo fixed. Clusetr -> Cluster.
2012-04-11 10:57:02 +02:00
antirez
0b913c650d
Check write(2) return value to avoid warnings, because in this context failing write is not critical.
2012-04-10 16:48:28 +02:00
antirez
a3fb7fd4f6
Minor MIGRATE implementation simplification about ttl handling.
2012-04-10 16:46:29 +02:00
antirez
0882715710
Version 2.9.7.
2012-04-10 16:34:33 +02:00
antirez
84bcd3aa24
It is now possible to enable/disable RDB checksum computation from redis.conf or via CONFIG SET/GET. Also CONFIG SET support added for rdbcompression as well.
2012-04-10 15:47:10 +02:00
antirez
82e32055d8
RDB files now embed a crc64 checksum. Version of RDB bumped to 5.
2012-04-09 22:40:41 +02:00
antirez
8491f1d9fd
Fixed compilation of new rio.c changes (typos and so forth.)
2012-04-09 12:36:44 +02:00
antirez
46738646d4
dump/restore fixed to use the new crc64 API.
2012-04-09 12:33:57 +02:00
antirez
736b7c3f04
Add checksum computation to rio.c
2012-04-09 12:33:09 +02:00
antirez
88c1d9550d
crc64.c modified for incremental computation.
2012-04-09 12:20:47 +02:00
antirez
5a181d43cb
rio.c file somewhat documented so that the casual reader can understand what's going on without reading the code.
2012-04-09 11:11:00 +02:00
Erik Dubbelboer
e1d9857b12
Update src/rdb.c
2012-04-07 15:48:30 +03:00
Erik Dubbelboer
8d16e7a3c6
Update src/dict.c
2012-04-07 15:45:53 +03:00
Erik Dubbelboer
65fd32ab0a
Fixed some spelling errors in the comments
2012-04-07 14:40:29 +02:00
antirez
2cbdab903f
For coverage testing use exit() instead of _exit() when termiating saving children.
2012-04-07 12:11:23 +02:00
antirez
09f66a0be8
New client info field added to CLIENT LIST output: multi, containing the length of the current pipeline. Test modified accordingly.
2012-04-07 11:14:52 +02:00
antirez
4cb8bb2952
Never used function stringObjectEqualsMs() removed.
2012-04-07 02:10:48 +02:00
antirez
f02aa7bb79
Removed dead code: function rdbSaveTime() is no longer used since RDB now saves expires in milliseconds.
2012-04-07 02:03:29 +02:00
antirez
618a922957
New INFO field in persistence section: bgrewriteaof_scheduled.
2012-04-06 21:12:50 +02:00
antirez
321a724da5
version bumped to 2.9.6
2012-04-06 12:27:17 +02:00
jokea
3e1e1ac27d
implement aeWait using poll(2). Fixes issue #267 .
2012-04-06 11:47:17 +02:00
antirez
70381bbf82
expireGenericCommand(): better variable names and a top-comment that describes the function's behavior.
2012-04-05 15:52:08 +02:00
Premysl Hruby
c6bf4a0034
for (p)expireat use absolute time, without double recomputation
2012-04-05 15:46:21 +02:00
Premysl Hruby
d48d1309c6
fix mstime() ommited while comparing if key is already expired
2012-04-05 15:46:15 +02:00
Premysl Hruby
c35b4e845b
add support for generation of lcov coverage reports
2012-04-05 12:23:35 +02:00
Salvatore Sanfilippo
d84f776e87
Merge pull request #426 from anydot/fix-rm-vm-comments
...
remove mentions of VM in comments
2012-04-05 01:54:09 -07:00
Salvatore Sanfilippo
0d5f4ba7cd
Merge pull request #431 from anydot/f-signal
...
allocate alternate signal stack, change of sigaction flags for sigterm
2012-04-05 01:52:40 -07:00
Premysl Hruby
ebba7b3c92
future-proof version comparison
2012-04-05 10:41:28 +02:00
antirez
4b8c966140
Structure field controlling the INFO field master_link_down_since_seconds initialized correctly to avoid strange INFO output at startup when a slave has yet to connect to its master.
2012-04-04 18:32:22 +02:00
antirez
5ad1faa090
New "os" field in INFO output providing information about the operating system.
2012-04-04 15:38:13 +02:00
antirez
bb0fbc840d
SLAVEOF is not a write command.
2012-04-04 15:11:30 +02:00
antirez
9a322ab730
Print milliseconds of the current second in log lines timestamps. Sometimes precise timing is very important for debugging.
2012-04-04 15:11:17 +02:00
Premysl Hruby
c575766202
allocate alternate signal stack, change of sigaction flags for sigterm
2012-04-03 17:40:31 +02:00
antirez
1ad4d50805
redis-cli help.h updated. Script to generate it updated as well.
2012-04-03 15:30:33 +02:00
antirez
12e91892a0
Another fix for MIGRATE.
2012-04-03 15:10:42 +02:00
antirez
84e5684bca
Two fixed for MIGRATE: fix TTL propagation and fix transferring of data bigger than 64k.
2012-04-03 12:17:40 +02:00
antirez
e7957ca628
When the user-provided 'maxclients' value is too big for the max number of files we can open, at least try to search the max the OS is allowing (in steps of 256 filedes).
2012-04-03 11:53:45 +02:00
antirez
31f2ecf436
MIGRATE now let the client distinguish I/O errors and timeouts from other erros.
2012-04-02 16:38:24 +02:00
antirez
f8ea19e539
DUMP/RESTORE now use CRC64 instead of truncated SHA1.
2012-04-02 13:10:39 +02:00
antirez
9510d65dc8
CRC64 implementation added to Redis code base.
2012-04-02 12:31:44 +02:00
Premysl Hruby
8918de9202
remove mentions of VM in comments
2012-04-02 11:56:03 +02:00
antirez
70d848e1fa
RESTORE ability to set a TTL fixed, bug introduced with millisecond expires.
2012-04-02 11:14:47 +02:00
antirez
a149ce6875
Prettify source code of create/verify DUMP payload.
2012-04-02 10:52:39 +02:00
antirez
bd04465931
DUMP / RESTORE: store RDB version in little endian.
2012-04-02 10:46:24 +02:00
antirez
4de6c9a055
New DUMP format includes RDB version and truncated SHA1 checksum.
2012-04-01 12:51:40 +02:00
antirez
d0ace5a314
Write RDB magic using a REDIS_RDB_VERSION define that is defined inside rdb.h
2012-03-31 17:08:40 +02:00
antirez
609ea08445
redis-trib: fix the MIGRATE call that now has milliseconds timeout (were seconds before).
2012-03-31 11:28:37 +02:00
antirez
9157549fad
syncio.c calls in replication.c fixed for the new millisecond timeout API.
2012-03-31 11:23:30 +02:00
antirez
04d360fdcd
Better syncio.c with millisecond resolution.
2012-03-31 11:21:45 +02:00
Erik Dubbelboer
0a2ff52eae
Added consts keyword where possible
2012-03-30 21:19:51 +02:00
antirez
c2672a06cd
Purely aesthetic code change.
2012-03-30 10:39:34 +02:00
Joseph Jang
f892797e1b
Fixed a memory leak with replication
...
occurs when two or more dbs are replicated and at least one of them is >db10
2012-03-30 10:34:29 +02:00
antirez
0cdecca141
Protect globals access in Lua scripting.
2012-03-29 12:02:28 +02:00
antirez
4cba71e898
Fixed typo in comment: "te" -> "the".
2012-03-29 09:33:29 +02:00
antirez
179e54d2a9
Fix for slaves chains. Force resync of slaves (simply disconnecting them) when SLAVEOF turns a master into a slave.
2012-03-29 09:24:02 +02:00
Nathan Fritz
52ae8af807
added redis.sha1hex(string) as lua scripting function.
...
(The original implementation was modified by @antirez to conform Redis
coding standards.)
2012-03-28 20:37:40 +02:00
antirez
5471b8babd
Fixes for redisLogFromHandler().
2012-03-28 13:51:23 +02:00
antirez
a7d12cbaf1
Log from signal handlers is now safer.
2012-03-28 13:45:39 +02:00
antirez
1043c8064b
Merge branch 'watchdog' into unstable
2012-03-28 13:16:19 +02:00
Salvatore Sanfilippo
e4669c045d
Merge pull request #389 from huangz1990/patch-1
...
fix typo
2012-03-27 14:00:08 -07:00
Premysl Hruby
b57dbdbba3
remove disk-store related comments
2012-03-27 18:46:51 +02:00
Premysl Hruby
8af9fe841c
declare hashDictType as external too
2012-03-27 18:18:57 +02:00
Premysl Hruby
d194905449
use server.unixtime instead of time(NULL) where possible (cluster.c not checked though)
2012-03-27 17:39:58 +02:00
Premysl Hruby
024f213b12
fix time() instead of mstime() in expireIfNeeded
2012-03-27 17:31:21 +02:00
antirez
d174eed5d7
define zlibc_free() in a way that is not shadowed by jemalloc.
2012-03-27 16:54:53 +02:00
antirez
23c0cdd2ad
Produce the watchlog warning log in a way that is safer from a signal handler. Fix a memory leak in the backtrace generation function.
2012-03-27 15:24:33 +02:00
antirez
aa96122d96
Mask SIGALRM everything but in the main thread.
...
This is required to ensure that the signal will be delivered to the main
thread when the watchdog timer expires.
2012-03-27 13:48:57 +02:00
antirez
a354da9acd
Correctly set the SIGARLM timer for the software watchdog.
2012-03-27 12:11:37 +02:00
antirez
39bd025c29
Redis software watchdog.
2012-03-27 11:47:51 +02:00
antirez
a323870450
SIGSEGV handler refactored so that we can reuse stack trace and current client logging functionalities in other contexts.
2012-03-27 10:40:07 +02:00
antirez
ca09ad4d64
CONFIG RESETSTAT resets two more fields.
2012-03-25 11:43:19 +02:00
antirez
c1d01b3c57
New INFO field aof_delayed_fsync introduced.
...
This new field counts all the times Redis is configured with AOF enabled and
fsync policy 'everysec', but the previous fsync performed by the
background thread was not able to complete within two seconds, forcing
Redis to perform a write against the AOF file while the fsync is still
in progress (likely a blocking operation).
2012-03-25 11:27:35 +02:00
antirez
1b247d1333
Add used allocator in redis-server -v output.
2012-03-24 11:53:03 +01:00
antirez
58e34e6cb1
Fixed memory leak in hash loading.
2012-03-23 20:24:34 +01:00
antirez
bd376d13f8
Big endian fix. The bug was introduced because of a typo.
2012-03-23 12:42:20 +01:00
antirez
6f0e77ca19
Replicate HINCRBYFLOAT as HSET.
2012-03-23 10:22:58 +01:00
antirez
7b558b1d64
Code style hack.
2012-03-22 18:17:09 +01:00
antirez
1f6146df0c
Result of INCRBYFLOAT and HINCRBYFLOAT should never be in exponential form, and also should never contain trailing zeroes. This is not possible with vanilla printf() format specifiers, so we alter the output.
2012-03-22 18:17:05 +01:00
antirez
b22eab8faf
Correctly create shared.oomerr as an sds string.
2012-03-21 12:11:07 +01:00
antirez
7dcdd281f5
DEBUG should not be flagged as w otherwise we can not call DEBUG DIGEST and other commands against read only slaves.
2012-03-20 17:53:47 +01:00
antirez
f3fd419fc9
Support for read-only slaves. Semantical fixes.
...
This commit introduces support for read only slaves via redis.conf and CONFIG GET/SET commands. Also various semantical fixes are implemented here:
1) MULTI/EXEC with only read commands now work where the server is into a state where writes (or commands increasing memory usage) are not allowed. Before this patch everything inside a transaction would fail in this conditions.
2) Scripts just calling read-only commands will work against read only
slaves, when the server is out of memory, or when persistence is into an
error condition. Before the patch EVAL always failed in this condition.
2012-03-20 17:32:48 +01:00
antirez
0d44d50792
Suppress warnings compiling redis-cli with certain gcc versions.
2012-03-19 19:28:49 +01:00
antirez
bb0aadbe21
Read-only flag removed from PUBLISH command.
2012-03-19 19:16:41 +01:00
antirez
d4a515c56d
Memory addressing test implemented.
2012-03-19 14:02:34 +01:00
antirez
d033ccb0af
More memory tests implemented. Default number of iterations lowered to a more acceptable value of 50.
2012-03-18 18:03:27 +01:00
antirez
a5801142a4
Fixed typo.
2012-03-18 17:27:56 +01:00
antirez
1a197a3c1a
Number of iteration of --test-memory is now 300 (several minutes per gigabyte). Memtest86 and Memtester links are also displayed while running the test.
2012-03-18 17:25:00 +01:00
antirez
525be599a8
On crash suggest to give --test-memory a try.
2012-03-18 11:35:35 +01:00
antirez
fb068dc91d
Memory test function now less boring thanks to screen-wide progress bar.
2012-03-16 21:19:53 +01:00
antirez
54e0fa1c27
Hem... actual memtest.c file added.
2012-03-16 17:21:49 +01:00
antirez
c5166e3fc5
First implementation of --test-memory. Still a work in progress.
2012-03-16 17:17:39 +01:00
