8864 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Oran Agra	6d29c34da7	add SAVE subcommand to ACL HELP and top comment	2020-02-06 10:31:43 +02:00
Oran Agra	69e8ea7143	stopAppendOnly resets aof_rewrite_scheduled ... althouh in theory, users can do BGREWRITEAOF even if aof is disabled, i suppose it is more common that the scheduled flag is set by either startAppendOnly, of a failed initial AOFRW fork (AOF_WAIT_REWRITE)	2020-02-06 10:17:34 +02:00
Oran Agra	aac6a4cf13	move restartAOFAfterSYNC from replicaofCommand to replicationUnsetMaster ... replicationUnsetMaster can be called from other places, not just replicaofCOmmand, and all of these need to restart AOF	2020-02-06 10:14:32 +02:00
Oran Agra	86e302f5f3	freeClientAsync don't lock mutex if there's just one thread	2020-02-06 10:07:17 +02:00
Oran Agra	485d5d4a18	reduce repeated calls to use_diskless_load ... this function possibly iterates on the module list	2020-02-06 09:41:45 +02:00
Oran Agra	85cc696f50	moduleRDBLoadError, add key name, and use panic rather than exit ... using panic rather than exit means you get s stack trace of the code path that experianced the error, and possibly other info.	2020-02-06 09:37:04 +02:00
Oran Agra	d454d5a4f5	Fix client flags to be int64 in module.c ... currently there's no bug since the flags these functions handle are always lower than 32bit, but still better fix the type to prevent future bugs.	2020-02-06 09:33:20 +02:00
Oran Agra	a17bddf2a1	fix maxmemory config warning ... the warning condition was if usage > limit (saying it'll cause eviction or oom), but in fact the eviction and oom depends on used minus slave buffers. other than fixing the condition, i add info about the current usage and limit, which may be useful when looking at the log.	2020-02-06 09:23:22 +02:00
Oran Agra	7e1d5954e5	Memory leak when bind config is provided twice	2020-02-06 09:17:39 +02:00
Oran Agra	ac2c96f5b1	A few non-data commands that should be allowed while loading or stale ... SELECT, and HELLO are commands that may be executed by the client as soon as it connects, there's no reason to block them, preventing the client from doing the rest of his sequence (which might just be INFO or CONFIG, etc). MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing commands, which there's no reason to block.	2020-02-06 08:53:23 +02:00
Yossi Gottlieb	bb3d45a386	TLS: Update documentation.	2020-02-05 21:19:03 +02:00
Oran Agra	fe7e8dc955	Add handling of short read of module id in rdb	2020-02-05 19:47:09 +02:00
Salvatore Sanfilippo	edfe1b2f8b	Merge pull request #6839 from yossigo/fix/redis-conf-tls-clarifications ... TLS: Some redis.conf clarifications.	2020-02-05 17:33:21 +01:00
Yossi Gottlieb	1e02d599dc	TLS: Some redis.conf clarifications.	2020-02-05 18:30:12 +02:00
Oran Agra	3795aaf42a	update RM_SignalModifiedKey doc comment	2020-02-05 18:15:38 +02:00
Salvatore Sanfilippo	44ac202fbf	Merge pull request #6831 from oranagra/config_c_refactor_3 ... config.c verbose error replies for CONFIG SET, like config file parsing	2020-02-05 13:41:15 +01:00
Salvatore Sanfilippo	4abf0e1e10	Merge pull request #6829 from oranagra/memory_get_keys ... memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command	2020-02-05 13:33:18 +01:00
Oran Agra	ffdd0620d0	config.c verbose error replies for CONFIG SET, like config file parsing ... We noticed that the error replies for the generic mechanism for enums are very verbose for config file parsing, but not for config set command. instead of replicating this code, i did a small refactoring to share code between CONFIG SET and config file parsing. and also renamed the enum group functions to be consistent with the naming of other types.	2020-02-05 11:41:24 +02:00
Oran Agra	9ac6cb9ce4	memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command	2020-02-05 09:42:49 +02:00
antirez	90fae58b49	ACL LOG: make max log entries configurable.	2020-02-04 13:19:40 +01:00
antirez	64a73e9293	ACL LOG: test for AUTH reason.	2020-02-04 12:58:48 +01:00
antirez	0c1a4b5576	ACL LOG: log failed auth attempts.	2020-02-04 12:55:26 +01:00
lifubang	540b917a26	fix ssl flag check for redis-cli ... Signed-off-by: lifubang <lifubang@acmcoder.com>	2020-02-04 17:32:30 +08:00
Salvatore Sanfilippo	cfe39b7859	Merge pull request #6818 from leomurillo/zskiplistLevels ... Set ZSKIPLIST_MAXLEVEL to 32	2020-02-04 10:20:56 +01:00
Salvatore Sanfilippo	6ca1ad1e27	Merge pull request #6825 from trevor211/fixMemoryLeakAboutLuaScript ... Fix memory leak about lua script	2020-02-04 10:19:16 +01:00
WuYunlong	eb2196f5ce	Fix lua related memory leak.	2020-02-04 16:38:46 +08:00
WuYunlong	01eaf53bb3	Add tcl regression test in scripting.tcl to reproduce memory leak.	2020-02-04 16:34:11 +08:00
Salvatore Sanfilippo	2400f5782e	Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x ... TLS: Fix missing initialization in redis-cli.	2020-02-03 16:43:56 +01:00
Salvatore Sanfilippo	726abe4deb	Merge pull request #6824 from oranagra/fix_module_c_uninit_var ... fix uninitialized info_cb var in module.c	2020-02-03 15:46:13 +01:00
Oran Agra	138ed120dd	fix uninitialized info_cb var in module.c	2020-02-03 16:35:39 +02:00
Guy Benoish	2fda5f5c98	Exclude "keymiss" notification from NOTIFY_ALL ... Because "keymiss" is "special" compared to the rest of the notifications (Trying not to break existing apps using the 'A' format for notifications) Also updated redis.conf and module.c docs	2020-02-03 15:43:44 +05:30
Leo Murillo	560e1e6c4b	Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25	2020-02-02 02:48:00 -06:00
Salvatore Sanfilippo	53ac8c7df2	Merge pull request #6812 from guybe7/str_convert_fix ... ld2string should fail if string contains \0 in the middle	2020-01-30 17:51:04 +01:00
Guy Benoish	2deb55512f	ld2string should fail if string contains \0 in the middle ... This bug affected RM_StringToLongDouble and HINCRBYFLOAT. I added tests for both cases. Main changes: 1. Fixed string2ld to fail if string contains \0 in the middle 2. Use string2ld in getLongDoubleFromObject - No point of having duplicated code here The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble because the long double string was saved with length+1 (An innocent mistake, but it's actually a bug - The length passed to RM_SaveLongDouble should not include the last \0).	2020-01-30 18:15:17 +05:30
antirez	b189a21974	ACL LOG: implement a few basic tests.	2020-01-30 11:14:13 +01:00
antirez	396161765b	ACL LOG: also log ACL errors in the scripting/MULTI ctx.	2020-01-30 10:50:32 +01:00
Yossi Gottlieb	93edb3ff3a	TLS: Fix missing initialization in redis-cli.	2020-01-29 21:40:02 +02:00
antirez	30a466ba38	ACL LOG: implement LOG RESET.	2020-01-29 18:51:04 +01:00
antirez	6671032faf	ACL LOG: group similar entries in a given time delta.	2020-01-29 18:40:32 +01:00
antirez	17ff3173d6	Add more info in the unblockClientFromModule() function.	2020-01-29 12:47:50 +01:00
Salvatore Sanfilippo	bf53f9280a	Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak ... Modules: Fix blocked-client-related memory leak	2020-01-29 12:06:14 +01:00
antirez	61dffd8669	ACL LOG: actually emit entries.	2020-01-28 18:04:20 +01:00
antirez	e8d0057710	ACL LOG: implement ACL LOG subcommadn skeleton.	2020-01-28 17:30:50 +01:00
antirez	3e9e27e98f	ACL LOG: data structures and initial functions.	2020-01-27 18:37:52 +01:00
antirez	7ef2270ee7	Change error message for #6775.	2020-01-15 17:55:24 +01:00
Salvatore Sanfilippo	456bbc02c8	Merge pull request #6775 from SqREL/make-error-of-invalid-command-withing-context-explicit ... Make error when submitting command in incorrect context more explicit	2020-01-15 17:53:51 +01:00
antirez	2d7dc71b6f	Document I/O threads in redis.conf.	2020-01-13 19:10:42 +01:00
antirez	7d5fb5df3f	Setting N I/O threads should mean N-1 additional + 1 main thread.	2020-01-13 18:53:36 +01:00
antirez	28d146bed6	Simplify #6379 changes.	2020-01-13 13:25:37 +01:00
Salvatore Sanfilippo	9506c860f6	Merge pull request #6739 from trevor211/fixMemoryLeak ... Fix potential memory leak of rioWriteBulkStreamID().	2020-01-13 13:23:49 +01:00