zhaozhao.zz
43be967690
networking: optimize unlinkClient() in freeClient()
2017-11-30 18:11:05 +08:00
zhaozhao.zz
1b5f56d042
aof: cast sdslen to ssize_t
2017-11-30 10:27:12 +08:00
zhaozhao.zz
2d73cf2367
aof: fix the short write
2017-11-30 10:22:12 +08:00
Itamar Haber
0752a834f9
Check arity in SLOWLOG before accessing arg
2017-11-30 00:30:30 +02:00
antirez
2785d6caa0
Merge branch 'lfu-fixes' into unstable
2017-11-29 17:16:13 +01:00
Itamar Haber
51d42c88a6
Merge branch 'unstable' into help_subcommands
2017-11-28 21:28:40 +02:00
Itamar Haber
59d52f7fab
Standardizes the 'help' subcommand
...
This adds a new `addReplyHelp` helper that's used by commands
when returning a help text. The following commands have been
touched: DEBUG, OBJECT, COMMAND, PUBSUB, SCRIPT and SLOWLOG.
WIP
Fix entry command table entry for OBJECT for HELP option.
After #4472 the command may have just 2 arguments.
Improve OBJECT HELP descriptions.
See #4472 .
WIP 2
WIP 3
2017-11-28 21:15:45 +02:00
Salvatore Sanfilippo
565e139a56
Merge pull request #4200 from jeesyn/fix_typo
...
fix a typo
2017-11-28 18:44:11 +01:00
Salvatore Sanfilippo
b998e2035c
Merge pull request #4165 from zyegfryed/patch-1
...
Fix some typos
2017-11-28 18:43:45 +01:00
Salvatore Sanfilippo
923502a70b
Merge pull request #4166 from charpty/wip-redisclic-typo
...
redis-cli.c typo: helpe -> helper.
2017-11-28 18:41:51 +01:00
Salvatore Sanfilippo
26826329f5
Merge pull request #4167 from charpty/wip-redisclic-typo2
...
redis-cli.c typo: Requets -> Requests.
2017-11-28 18:41:28 +01:00
Salvatore Sanfilippo
3508b9c440
Merge pull request #4170 from TehWebby/patch-2
...
Fix typo
2017-11-28 18:40:43 +01:00
Salvatore Sanfilippo
4e55df4b5c
Merge pull request #4172 from TehWebby/patch-3
...
Fix typo
2017-11-28 18:40:02 +01:00
Salvatore Sanfilippo
ad171f5ce0
Merge pull request #4176 from KrauseFx/patch-1
...
Update link to https and use inline link
2017-11-28 18:39:43 +01:00
antirez
851e9fc48b
t_hash.c: clarify calling two times the same function.
2017-11-28 18:39:00 +01:00
antirez
aeee039a87
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2017-11-28 18:27:35 +01:00
antirez
c44732ac58
adlist: fix listJoin() in the case the second list is empty.
...
See #4192 , the original PR removed lines of code that are actually
needed, so thanks to @chunqiulfq for reporting the problem, but merging
solution from @jeesyn after checking, together with @artix75, that the
logic covers all the cases.
2017-11-28 18:25:14 +01:00
Salvatore Sanfilippo
c3806f5b72
Merge pull request #4215 from lamby/correct-faield-spelling
...
Correct spelling of "faield".
2017-11-28 18:08:32 +01:00
Salvatore Sanfilippo
a13106e001
Merge pull request #4374 from rouzier/patch-1
...
Fix file descriptor leak and error handling
2017-11-28 17:33:23 +01:00
Salvatore Sanfilippo
bf71b120f1
Merge pull request #4451 from devnexen/minor_build_fixes
...
Fix undefined behavior constant defined.
2017-11-28 17:23:48 +01:00
Itamar Haber
8c7f90e91e
Standardizes arity handling of DEBUG
2017-11-28 18:18:45 +02:00
antirez
06ca9d6839
LFU: Fix LFUDecrAndReturn() to just decrement.
...
Splitting the popularity in half actually just needs decrementing the
counter because the counter is logarithmic.
2017-11-28 12:18:30 +01:00
zhaozhao.zz
9f131c9a89
LFU: add hotkeys option to redis-cli
2017-11-27 18:39:29 +01:00
zhaozhao.zz
583c314725
LFU: do some changes about LFU to find hotkeys
...
Firstly, use access time to replace the decreas time of LFU.
For function LFUDecrAndReturn,
it should only try to get decremented counter,
not update LFU fields, we will update it in an explicit way.
And we will times halve the counter according to the times of
elapsed time than server.lfu_decay_time.
Everytime a key is accessed, we should update the LFU
including update access time, and increment the counter after
call function LFUDecrAndReturn.
If a key is overwritten, the LFU should be also updated.
Then we can use `OBJECT freq` command to get a key's frequence,
and LFUDecrAndReturn should be called in `OBJECT freq` command
in case of the key has not been accessed for a long time,
because we update the access time only when the key is read or
overwritten.
2017-11-27 18:39:22 +01:00
zhaozhao.zz
53cea97204
LFU: change lfu* parameters to int
2017-11-27 18:38:55 +01:00
zhaozhao.zz
dfc42ec447
LFU: fix the missing of config get and rewrite
2017-11-27 18:38:33 +01:00
antirez
75fa7879e6
Improve OBJECT HELP descriptions.
...
See #4472 .
2017-11-27 18:09:08 +01:00
antirez
b412c544fd
Fix entry command table entry for OBJECT for HELP option.
...
After #4472 the command may have just 2 arguments.
2017-11-27 13:16:07 +01:00
Salvatore Sanfilippo
29252391c4
Merge pull request #4472 from itamarhaber/object_patch
...
A minor fix and `help` subcommand for `OBJECT`
2017-11-27 12:41:02 +01:00
Itamar Haber
1c08220022
Adds -u <uri> option to redis-cli.
2017-11-27 11:34:11 +01:00
Itamar Haber
02d38f6b51
Adds OBJECT help
2017-11-24 19:59:05 +02:00
Itamar Haber
b28fb3d753
Prevents OBJECT freq
with noeviction
...
When maxmemory is set to noeviction, idletime is implicitly kept. This renders access frequency nonsensical.
2017-11-24 19:58:37 +02:00
antirez
dc2df135b3
Test: regression test for latency expire events logging bug.
...
Regression for #4452 .
2017-11-24 18:33:31 +01:00
Salvatore Sanfilippo
c508cb6793
Merge pull request #4452 from soloestoy/expire-latency
...
expire & latency: fix the missing latency records generated by expire
2017-11-24 18:21:35 +01:00
antirez
7229fa8d6d
Modules: fix memory leak in RM_IsModuleNameBusy().
2017-11-24 13:29:54 +01:00
antirez
4d063bb6ba
PSYNC2: reorganize comments related to recent fixes.
...
Related to PR #4412 and issue #4407 .
2017-11-24 11:08:29 +01:00
Salvatore Sanfilippo
9d86ae4597
Merge pull request #4412 from soloestoy/bugfix-psync2
...
PSYNC2: safe free backlog when reach the time limit and others
2017-11-24 10:56:18 +01:00
Salvatore Sanfilippo
f739c27229
Merge pull request #4344 from soloestoy/fix-module-name-conflict
...
Fix module name conflict
2017-11-24 09:37:06 +01:00
Salvatore Sanfilippo
58ac57f665
Merge pull request #4470 from oranagra/fix_string_to_double
...
fix string to double conversion, stopped parsing on \0 …
2017-11-24 08:59:23 +01:00
Oran Agra
adf2701cc9
fix string to double conversion, stopped parsing on \0 even if the string has more data.
...
getLongLongFromObject calls string2ll which has this line:
/* Return if not all bytes were used. */
so if you pass an sds with 3 characters "1\01" it will fail.
but getLongDoubleFromObject calls strtold, and considers it ok if eptr[0]==`\0`
i.e. if the end of the string found by strtold ends with null terminator
127.0.0.1:6379> set a 1
OK
127.0.0.1:6379> setrange a 2 2
(integer) 3
127.0.0.1:6379> get a
"1\x002"
127.0.0.1:6379> incrbyfloat a 2
"3"
127.0.0.1:6379> get a
"3"
2017-11-23 17:15:27 +02:00
antirez
de914ede93
Modules: fix for scripting replication of modules commands.
...
See issue #4466 / #4467 .
2017-11-23 15:14:17 +01:00
Salvatore Sanfilippo
ada206559d
Merge pull request #4467 from yossigo/fix-nested-multi
...
Nested MULTI/EXEC may replicate in different cases.
2017-11-23 13:38:43 +01:00
Yossi Gottlieb
2c70d28295
Nested MULTI/EXEC may replicate in different cases.
...
For example:
1. A module command called within a MULTI section.
2. A Lua script with replicate_commands() called within a MULTI section.
3. A module command called from a Lua script in the above context.
2017-11-22 22:02:51 +02:00
zhaozhao.zz
ea2e51c630
PSYNC2: persist cached_master's dbid inside the RDB
2017-11-22 12:11:26 +08:00
zhaozhao.zz
93037f7642
PSYNC2: make repl_stream_db never be -1
...
it means that after this change all the replication
info in RDB is valid, and it can distinguish us from
the older version.
2017-11-22 12:05:34 +08:00
zhaozhao.zz
7a808fd8a7
expire & latency: fix the missing latency records generated by expire
2017-11-21 23:35:30 +08:00
zhaozhao.zz
57bd8feb8d
rehash: handle one db until finished
2017-11-21 09:49:42 +01:00
David Carlier
62689ef0cf
Fix undefined behavior constant defined.
2017-11-19 16:23:42 +00:00
Salvatore Sanfilippo
cf9a3f7048
Merge pull request #2741 from kmiku7/unstable
...
fix boundary case for _dictNextPower
2017-11-08 17:06:09 +01:00
Salvatore Sanfilippo
30db805548
Merge pull request #4431 from itamarhaber/patch-10
...
Fixes an off-by-one in argument handling of `MEMORY USAGE`
2017-11-08 15:42:45 +01:00