antirez
f6b32c14f4
This fixes issue #327 , is a very complex fix (unfortunately), details:
...
1) sendReplyToClient() now no longer stops transferring data to a single
client in the case we are out of memory (maxmemory-wise).
2) in processCommand() the idea of we being out of memory is no longer
the naive zmalloc_used_memory() > server.maxmemory. To say if we can
accept or not write queries is up to the return value of
freeMemoryIfNeeded(), that has full control about that.
3) freeMemoryIfNeeded() now does its math without considering output
buffers size. But at the same time it can't let the output buffers to
put us too much outside the max memory limit, so at the same time it
makes sure there is enough effort into delivering the output buffers to
the slaves, calling the write handler directly.
This three changes are the result of many tests, I found (partially
empirically) that is the best way to address the problem, but maybe
we'll find better solutions in the future.
2012-02-04 14:05:54 +01:00
antirez
355f859134
Use less memory when emitting the protocol, by using more shared objects for commonly emitted parts of the protocol.
2012-02-04 08:58:37 +01:00
antirez
ce8b772be7
Now Lua scripts dispatch Redis commands properly calling the call() function. In order to make this possible call() was improved with a new flags argument that controls how the Redis command is executed.
2012-02-02 16:30:52 +01:00
antirez
d876678b5e
Set a 3.5 GB maxmemory limit with noeviction policy if a 32 bit instance without user-provided memory limits is detected.
2012-02-02 10:26:20 +01:00
antirez
75eaac5c74
Added a server.arch_bits field instead of computing it at runtime for INFO.
2012-02-02 10:23:31 +01:00
antirez
b80b1c5914
Only incremnet stats for key miss/hit when the key is semantically accessed in read-only.
2012-02-01 21:51:20 +01:00
antirez
c17947287a
Added tests checking ability of the scripting engine to reorder the output of commands with a random output regarding signle elements position in the multi bulk reply.
2012-02-01 17:49:03 +01:00
antirez
44d77bb217
A few SORT tests made more resistant to false negatives resulitng from poor randomization of Redis hash function with one byte inputs.
2012-02-01 17:37:48 +01:00
antirez
01f75bf352
New SORT tests checking the new more deterministic behavior of SORT sorting algorithm.
2012-02-01 17:17:52 +01:00
antirez
de79a2ee12
Make SORT BY <constant> STORE ... to always produce the same output by force sorting, so that we have deterministic replication of this command.
2012-02-01 17:05:45 +01:00
antirez
2c861050c1
SORT is now more deterministic: does not accept to compare by score items that have scores not representing a valid double. Also items with the same score are compared lexycographically. At the same time the scripting side introduced the ability to sort the output of SORT when sort uses the BY <constant> optimization, resulting in no specific ordering. Since in this case the user may use GET, and the result of GET can be null, converted into false as Lua data type, this commit also introduces the ability to sort Lua tables containining false, only if the first (faster) attempt at using just table.sort with a single argument fails.
2012-02-01 15:22:28 +01:00
antirez
548efd91e5
Order output of commands returning random arrays using table.sort when called from Lua, partially fixing issue #165 . The issue is yet not completely fixed since we can't add the REDIS_CMD_SORT_FOR_SCRIPT flag in SORT currently, both because it may contain NULLs and because it is not cool to re-sort everything at every call when instead this should be sorted only if BY <constant> is used.
2012-01-31 16:09:21 +01:00
antirez
8dd19d818f
Fixed redis-benchmark --help output typo
2012-01-31 11:43:32 +01:00
antirez
3c08fdae71
64 bit instances are no longer limited to have at max 2^32-1 elements in lists.
2012-01-31 10:35:52 +01:00
antirez
fc4ed4299b
minimal change to obuf-limits.tcl test to make sure there are no false positives with 32bit instances as well.
2012-01-30 21:08:10 +01:00
antirez
d1c4c94ebf
Merge remote-tracking branch 'origin/unstable' into unstable
2012-01-30 10:40:28 +01:00
Salvatore Sanfilippo
eb7d19ed69
Merge pull request #319 from fawek/lua-error-location
...
Lua reports line numbers off by one in error messages
2012-01-30 01:40:17 -08:00
antirez
89f6f6abcf
setKey(): call the higher level wrapper setModifiedKey() instead of touchWatchedKey() even if currently they are exactly the same.
2012-01-30 10:27:50 +01:00
Salvatore Sanfilippo
824ea0177f
Merge pull request #321 from mkwiatkowski/ticket227
...
SORT with STORE removes key if result is empty. This fixes issue #227 .
2012-01-30 01:25:34 -08:00
Michal Kwiatkowski
a0bf8d0ad8
SORT with STORE removes key if result is empty. This fixes issue #227 .
2012-01-30 07:36:49 +01:00
Jakub Wieczorek
4d776dba3c
Lua reports line numbers off by one in error messages
2012-01-29 14:53:49 +01:00
antirez
6c29410117
false positive in expire tests mitigated with a sleep, but other solutions exist if needed later.
2012-01-26 16:45:08 +01:00
antirez
7f7a13b27b
Less false positives for obuf-limits.tcl tests
2012-01-26 16:08:24 +01:00
Pieter Noordhuis
d3ea4c86a8
Update default configuration
2012-01-25 13:37:43 -08:00
Pieter Noordhuis
80586cb894
Test that zipmap from RDB is correctly converted
2012-01-25 13:28:11 -08:00
antirez
da9c4cc147
Added test for client output buffer limit (soft limit).
2012-01-25 18:34:56 +01:00
antirez
efc8f6c1a2
Added test for client output buffer limit (hard limit).
2012-01-25 18:11:04 +01:00
antirez
c715c9b8bf
Fixed typo in getClientLimitClassByName()
2012-01-25 18:07:56 +01:00
antirez
a30a8ae7ba
Merge branch 'unstable' into limits
2012-01-25 16:59:58 +01:00
antirez
4e97c2c71a
Fixed another possible bug in cluster.c found by clang --analyze.
2012-01-25 16:59:54 +01:00
antirez
d329031fad
Fixed another possible bug in cluster.c found by clang --analyze.
2012-01-25 16:59:36 +01:00
antirez
9b810f1cde
Merge branch 'unstable' into limits
2012-01-25 16:46:53 +01:00
antirez
6710ff24d0
Fixed a non critical bug signaled by clang static analyzer thanks to Mukund Sivaraman for reporting it: there was a not initialized field populating the cluster message header, but it is always fixed at later time before sending the packet.
2012-01-25 16:46:35 +01:00
antirez
c69ad1f24e
Merge branch 'unstable' into limits
2012-01-25 10:41:25 +01:00
antirez
ecc5702145
aeCreateEventLoop() cleanup on error unified in a single block (original
...
patch by Mukund Sivaraman, modified by me to make it simpler and to use
my coding style).
2012-01-25 10:37:32 +01:00
Mukund Sivaraman
caa63a3821
If aeApiCreate() fails, there's probably not much one can do, but in the name of consistency...
2012-01-25 10:27:37 +01:00
antirez
2f0f0d95c0
lenght -> length
2012-01-24 15:33:15 +01:00
antirez
3cbce4f45e
redis.conf typo fixed in the client-output-buffer-limit documentation
2012-01-24 14:46:23 +01:00
antirez
7957c67604
after all closing a client for output buffer limit overcoming is a WARNING level message.
2012-01-24 12:03:48 +01:00
antirez
c8a607f2b6
client-output-buffer-limit documented in redis.conf
2012-01-24 11:23:23 +01:00
antirez
7fe8d49a70
Client output buffer limits: configuration of parameters for the different classes of clients implemented.
2012-01-24 10:43:30 +01:00
antirez
06b3dced99
asyncCloseClientOnOutputBufferLimitReached() now ignores clients with REDIS_CLOSE_ASAP flag already set. Return value of the function changed from int to void since it is not used. Fixed logging of the client scheduled to be closed.
2012-01-24 09:32:39 +01:00
antirez
51669c5ac1
client buffer handling refactoring and optimization
2012-01-23 17:15:49 +01:00
antirez
3c0602ff41
CLIENT LIST test fixed (there is a new omem field in the output)
2012-01-23 16:19:49 +01:00
antirez
8c43e66346
actually call the function to async free clients in serverCron().
2012-01-23 16:17:22 +01:00
antirez
7eac2a75a4
Implementation of the internals that make possible to terminate clients overcoming configured output buffer (soft and hard) limits.
2012-01-23 16:12:37 +01:00
antirez
890da62eea
Merge branch 'unstable' into limits
2012-01-23 10:36:07 +01:00
antirez
b362c111da
fixed typo in hahs function seed default value. It is no longer used but fixed to retain the old constant as default anyway.
2012-01-22 01:40:23 +01:00
antirez
06c5523a88
typo in comment fixed
2012-01-21 23:34:06 +01:00
antirez
a48c8d873b
Fix for hash table collision attack. We simply randomize hash table initialization value at startup time.
2012-01-21 23:30:13 +01:00
