Salvatore Sanfilippo
85d1d1f870
Merge pull request #7089 from bytedance/set-thread-name
...
Threaded IO: set thread name for redis-server
2020-04-20 11:54:25 +02:00
antirez
2321939218
Sentinel: small refactoring of sentinelCollectTerminatedScripts().
...
Related to #7113 .
2020-04-20 11:52:34 +02:00
Salvatore Sanfilippo
f9d624c504
Merge pull request #7113 from OMG-By/unstable
...
fix(sentinel): sentinel.running_scripts not reset
2020-04-20 11:51:51 +02:00
zhenwei pi
5010da6ab0
Threaded IO: set thread name for redis-server
...
Set thread name for each thread of redis-server, this helps us to
monitor the utilization and optimise the performance.
And suggested-by Salvatore, implement this feature for multi
platforms. Currently support linux and bsd, ignore other OS.
An exmaple on Linux:
# top -d 5 -p `pidof redis-server ` -H
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
3682671 root 20 0 227744 8248 3836 R 99.2 0.0 0:19.53 redis-server
3682677 root 20 0 227744 8248 3836 S 26.4 0.0 0:04.15 io_thd_3
3682675 root 20 0 227744 8248 3836 S 23.6 0.0 0:03.98 io_thd_1
3682676 root 20 0 227744 8248 3836 S 23.6 0.0 0:03.97 io_thd_2
3682672 root 20 0 227744 8248 3836 S 0.2 0.0 0:00.02 bio_close_file
3682673 root 20 0 227744 8248 3836 S 0.2 0.0 0:00.02 bio_aof_fsync
3682674 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 bio_lazy_free
3682678 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682682 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682683 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682684 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682685 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
3682687 root 20 0 227744 8248 3836 S 0.0 0.0 0:00.00 jemalloc_bg_thd
Another exmaple on FreeBSD-12.1:
PID USERNAME PRI NICE SIZE RES STATE C TIME WCPU COMMAND
5212 root 100 0 48M 7280K CPU2 2 0:26 99.52% redis-server{redis-server}
5212 root 38 0 48M 7280K umtxn 4 0:06 26.94% redis-server{io_thd_3}
5212 root 36 0 48M 7280K umtxn 6 0:06 26.84% redis-server{io_thd_1}
5212 root 39 0 48M 7280K umtxn 1 0:06 25.30% redis-server{io_thd_2}
5212 root 20 0 48M 7280K uwait 3 0:00 0.00% redis-server{redis-server}
5212 root 21 0 48M 7280K uwait 2 0:00 0.00% redis-server{bio_close_file}
5212 root 21 0 48M 7280K uwait 3 0:00 0.00% redis-server{bio_aof_fsync}
5212 root 21 0 48M 7280K uwait 0 0:00 0.00% redis-server{bio_lazy_free}
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2020-04-18 11:17:21 +08:00
omg-by
9d27e00ddb
fix(sentinel): sentinel.running_scripts will always increase more times and not reset
...
when trigger a always fail scripts, sentinel.running_scripts will increase ten times, however it
only decrease one times onretry the maximum. and it will't reset, when it become
SENTINEL_SCRIPT_MAX_RUNNING, sentinel don't trigger scripts.
2020-04-18 00:49:16 +08:00
antirez
c479eace45
Fix XCLAIM propagation in AOF/replicas for blocking XREADGROUP.
...
See issue #7105 .
2020-04-17 12:38:15 +02:00
antirez
37b135a400
Update SDS to latest version.
2020-04-16 16:08:37 +02:00
antirez
c9388ecc73
RESP3: fix HELLO map len in Sentinel mode.
...
See #6160 .
2020-04-16 11:21:52 +02:00
hwware
12b9fd4f03
Fix not used marco in cluster.c
2020-04-15 22:00:36 -04:00
antirez
503a5a24fb
Don't allow empty spaces in ACL usernames.
...
Fixes issue #6418 .
2020-04-15 16:40:25 +02:00
antirez
3519a5a026
Don't allow empty spaces in ACL key patterns.
...
Fixes issue #6418 .
2020-04-15 16:12:07 +02:00
antirez
e8dd99fa53
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-04-15 16:01:56 +02:00
antirez
7f794a122f
Fix HELLO reply in Sentinel mode, see #6160 .
2020-04-15 15:59:52 +02:00
Salvatore Sanfilippo
dfd3ead90d
Merge pull request #7078 from karelrooted/fix/geo-hash-edge-case
...
FIX truncate max/min longitude,latitude related geo_point
2020-04-15 10:23:23 +02:00
Salvatore Sanfilippo
7428f51217
Merge pull request #7085 from guybe7/timeout_err_typo
...
Typo in getTimeoutFromObjectOrReply's error reply
2020-04-14 11:40:51 +02:00
antirez
552b36e657
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-04-14 11:23:57 +02:00
antirez
086c1db2d9
Fix zsetAdd() top comment spelling.
2020-04-14 11:23:44 +02:00
Salvatore Sanfilippo
33386bed66
Merge pull request #7095 from hwware/typofixacl
...
fix spelling in acl.c
2020-04-14 11:15:26 +02:00
antirez
5fece85491
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-04-14 10:52:45 +02:00
antirez
49ccd2a8e1
Fix function names in zslDeleteNode() top comment.
2020-04-14 10:52:40 +02:00
hwware
1323afed8b
fix spelling in acl.c
2020-04-14 00:16:29 -04:00
Guy Benoish
29760b2eb7
Typo in getTimeoutFromObjectOrReply's error reply
2020-04-11 15:05:01 +03:00
Salvatore Sanfilippo
767977c533
Merge pull request #7074 from hayleeliu/unstable
...
fix spelling mistake in bitops.c
2020-04-10 10:15:25 +02:00
antirez
839bbcb039
RESP3: change streams items from maps to arrays.
...
Streams items are similar to dictionaries, however they preserve both
the order, and allow for duplicated field names. So a map is not a
semantically sounding way to deal with this.
https://twitter.com/antirez/status/1248261087553880069
2020-04-10 10:12:26 +02:00
antirez
3072498665
Merge branch 'faster-rdb-loading' into unstable
2020-04-09 19:15:13 +02:00
antirez
6ad44b76b9
Use the special static refcount for stack objects.
2020-04-09 16:25:30 +02:00
antirez
d88f52ee7d
RDB: refactor some RDB loading code into dbAddRDBLoad().
2020-04-09 16:21:48 +02:00
antirez
399a6b2b47
incrRefCount(): abort on statically allocated object.
2020-04-09 16:20:41 +02:00
antirez
451872527c
More powerful DEBUG RELOAD.
...
Related to #3243 .
2020-04-09 12:10:10 +02:00
liumiuyong
3fbfa1885c
FIX: truncate max/min longitude,latitude related geo_point (ex: {180, 85.05112878} )
2020-04-09 17:48:29 +08:00
antirez
3d5b2d41b5
RDB: clarify a condition in rdbLoadRio().
2020-04-09 11:09:40 +02:00
antirez
30adc62232
RDB: load files faster avoiding useless free+realloc.
...
Reloading of the RDB generated by
DEBUG POPULATE 5000000
SAVE
is now 25% faster.
This commit also prepares the ability to have more flexibility when
loading stuff from the RDB, since we no longer use dbAdd() but can
control exactly how things are added in the database.
2020-04-09 10:24:46 +02:00
antirez
96a54866ab
Speedup: unblock clients on keys in O(1).
...
See #7071 .
2020-04-08 12:55:57 +02:00
hayleeliu
51b9de037d
fix spelling mistake in bitops.c
2020-04-08 18:20:32 +08:00
antirez
96688aa646
Fix ACL HELP table missing comma.
2020-04-08 10:56:47 +02:00
antirez
a6350f717d
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-04-07 14:10:43 +02:00
antirez
f69876280c
Speedup INFO by counting client memory incrementally.
...
Related to #5145 .
Design note: clients may change type when they turn into replicas or are
moved into the Pub/Sub category and so forth. Moreover the recomputation
of the bytes used is problematic for obvious reasons: it changes
continuously, so as a conservative way to avoid accumulating errors,
each client remembers the contribution it gave to the sum, and removes
it when it is freed or before updating it with the new memory usage.
2020-04-07 12:07:54 +02:00
Salvatore Sanfilippo
e93dcba46e
Merge pull request #7064 from mymilkbottles/unstable
...
Optimize lua log level judgment
2020-04-06 17:34:14 +02:00
Salvatore Sanfilippo
9a9109431b
Merge pull request #7065 from qetu3790/unstable
...
fix comments about RESIZE DB opcode in rdb.c
2020-04-06 17:32:44 +02:00
Salvatore Sanfilippo
094b47391d
Merge pull request #6243 from soloestoy/expand-lazy-free-server-del
...
lazyfree: add a new configuration lazyfree-lazy-user-del
2020-04-06 17:27:39 +02:00
qetu3790
2c42f6a8b8
fix comments about RESIZE DB opcode in rdb.c
...
fix comments about RESIZE DB opcode in rdb.c
2020-04-06 20:52:32 +08:00
antirez
121c51f4f3
Merge branch 'lcs' into unstable
2020-04-06 13:51:55 +02:00
antirez
ca8d6f1072
LCS: allow KEYS / STRINGS to be anywhere.
...
Initially they needed to be at the end so that we could extend to N
strings in the future, but after further consideration I no longer
believe it's worth it.
2020-04-06 13:48:31 +02:00
antirez
7261a5550f
LCS: get rid of STOREIDX option. Fix get keys helper.
2020-04-06 13:32:15 +02:00
mymilkbottles
25063f75d7
Judge the log level in advance
2020-04-06 19:27:06 +08:00
Salvatore Sanfilippo
af5c11874c
Merge pull request #6797 from patpatbear/issue_#6565_memory_borderline
...
Check OOM at script start to get stable lua OOM state.
2020-04-06 11:59:01 +02:00
Guy Benoish
a76a961cdd
Use __attribute__ only if __GNUC__ is defined
2020-04-03 14:49:40 +03:00
Salvatore Sanfilippo
f80b946bea
Merge pull request #6855 from guybe7/var_funcs_format_check
...
Modules: Perform printf-like format checks in variadic API
2020-04-03 13:46:27 +02:00
Guy Benoish
a8857320a5
Modules: Perform printf-like format checks in variadic API
2020-04-03 14:39:55 +03:00
Salvatore Sanfilippo
cbf212f981
Merge pull request #7030 from valentinogeron/xread-in-lua
...
XREAD and XREADGROUP should not be allowed from scripts when BLOCK op…
2020-04-03 11:14:13 +02:00