antirez
1043c8064b
Merge branch 'watchdog' into unstable
2012-03-28 13:16:19 +02:00
Salvatore Sanfilippo
e4669c045d
Merge pull request #389 from huangz1990/patch-1
...
fix typo
2012-03-27 14:00:08 -07:00
Premysl Hruby
b57dbdbba3
remove disk-store related comments
2012-03-27 18:46:51 +02:00
Premysl Hruby
8af9fe841c
declare hashDictType as external too
2012-03-27 18:18:57 +02:00
Premysl Hruby
d194905449
use server.unixtime instead of time(NULL) where possible (cluster.c not checked though)
2012-03-27 17:39:58 +02:00
Premysl Hruby
024f213b12
fix time() instead of mstime() in expireIfNeeded
2012-03-27 17:31:21 +02:00
antirez
d174eed5d7
define zlibc_free() in a way that is not shadowed by jemalloc.
2012-03-27 16:54:53 +02:00
antirez
23c0cdd2ad
Produce the watchlog warning log in a way that is safer from a signal handler. Fix a memory leak in the backtrace generation function.
2012-03-27 15:24:33 +02:00
antirez
aa96122d96
Mask SIGALRM everything but in the main thread.
...
This is required to ensure that the signal will be delivered to the main
thread when the watchdog timer expires.
2012-03-27 13:48:57 +02:00
antirez
a354da9acd
Correctly set the SIGARLM timer for the software watchdog.
2012-03-27 12:11:37 +02:00
antirez
39bd025c29
Redis software watchdog.
2012-03-27 11:47:51 +02:00
antirez
a323870450
SIGSEGV handler refactored so that we can reuse stack trace and current client logging functionalities in other contexts.
2012-03-27 10:40:07 +02:00
antirez
ca09ad4d64
CONFIG RESETSTAT resets two more fields.
2012-03-25 11:43:19 +02:00
antirez
c1d01b3c57
New INFO field aof_delayed_fsync introduced.
...
This new field counts all the times Redis is configured with AOF enabled and
fsync policy 'everysec', but the previous fsync performed by the
background thread was not able to complete within two seconds, forcing
Redis to perform a write against the AOF file while the fsync is still
in progress (likely a blocking operation).
2012-03-25 11:27:35 +02:00
antirez
1b247d1333
Add used allocator in redis-server -v output.
2012-03-24 11:53:03 +01:00
antirez
58e34e6cb1
Fixed memory leak in hash loading.
2012-03-23 20:24:34 +01:00
antirez
bd376d13f8
Big endian fix. The bug was introduced because of a typo.
2012-03-23 12:42:20 +01:00
antirez
6f0e77ca19
Replicate HINCRBYFLOAT as HSET.
2012-03-23 10:22:58 +01:00
antirez
7b558b1d64
Code style hack.
2012-03-22 18:17:09 +01:00
antirez
1f6146df0c
Result of INCRBYFLOAT and HINCRBYFLOAT should never be in exponential form, and also should never contain trailing zeroes. This is not possible with vanilla printf() format specifiers, so we alter the output.
2012-03-22 18:17:05 +01:00
antirez
b22eab8faf
Correctly create shared.oomerr as an sds string.
2012-03-21 12:11:07 +01:00
antirez
7dcdd281f5
DEBUG should not be flagged as w otherwise we can not call DEBUG DIGEST and other commands against read only slaves.
2012-03-20 17:53:47 +01:00
antirez
f3fd419fc9
Support for read-only slaves. Semantical fixes.
...
This commit introduces support for read only slaves via redis.conf and CONFIG GET/SET commands. Also various semantical fixes are implemented here:
1) MULTI/EXEC with only read commands now work where the server is into a state where writes (or commands increasing memory usage) are not allowed. Before this patch everything inside a transaction would fail in this conditions.
2) Scripts just calling read-only commands will work against read only
slaves, when the server is out of memory, or when persistence is into an
error condition. Before the patch EVAL always failed in this condition.
2012-03-20 17:32:48 +01:00
antirez
0d44d50792
Suppress warnings compiling redis-cli with certain gcc versions.
2012-03-19 19:28:49 +01:00
antirez
bb0aadbe21
Read-only flag removed from PUBLISH command.
2012-03-19 19:16:41 +01:00
antirez
d4a515c56d
Memory addressing test implemented.
2012-03-19 14:02:34 +01:00
antirez
d033ccb0af
More memory tests implemented. Default number of iterations lowered to a more acceptable value of 50.
2012-03-18 18:03:27 +01:00
antirez
a5801142a4
Fixed typo.
2012-03-18 17:27:56 +01:00
antirez
1a197a3c1a
Number of iteration of --test-memory is now 300 (several minutes per gigabyte). Memtest86 and Memtester links are also displayed while running the test.
2012-03-18 17:25:00 +01:00
antirez
525be599a8
On crash suggest to give --test-memory a try.
2012-03-18 11:35:35 +01:00
antirez
fb068dc91d
Memory test function now less boring thanks to screen-wide progress bar.
2012-03-16 21:19:53 +01:00
antirez
54e0fa1c27
Hem... actual memtest.c file added.
2012-03-16 17:21:49 +01:00
antirez
c5166e3fc5
First implementation of --test-memory. Still a work in progress.
2012-03-16 17:17:39 +01:00
antirez
c9d3dda29c
Fix for issue #391 .
...
Use a simple protocol between clientsCron() and helper functions to
understand if the client is still valind and clientsCron() should
continue processing or if the client was freed and we should continue
with the next one.
2012-03-15 20:55:14 +01:00
huangz1990
9448ddb0c6
fix typo
2012-03-15 14:27:14 +08:00
antirez
ae22bf1ef6
Reclaim space from the client querybuf if needed.
2012-03-14 15:32:30 +01:00
antirez
739803c064
sds.c: sdsAllocSize() function added.
2012-03-14 14:58:26 +01:00
antirez
9555f8f21b
sds.c new function sdsRemoveFreeSpace().
...
The new function is used in order to resize the string allocation so
that only the minimal allocation possible is used, removing all the free
space at the end of the string normally used to improve efficiency of
concatenation operations.
2012-03-14 10:13:23 +01:00
antirez
529bde82ec
Call all the helper functions needed by clientsCron() as clientsCronSomething() for clarity.
2012-03-14 09:56:22 +01:00
antirez
d19015be12
Process async client checks like client timeouts and BLPOP timeouts incrementally using a circular list.
2012-03-13 18:05:11 +01:00
antirez
bbaeda402c
Added a qbuf-free field to CLIENT LIST output.
2012-03-13 13:26:33 +01:00
antirez
e74dca73d9
Client creation time in redisClient structure. New age field in CLIENT LIST output.
2012-03-13 13:05:08 +01:00
antirez
573373802e
c->bufpos initialization moved for aesthetics.
2012-03-13 12:59:27 +01:00
antirez
c3e7441dad
RDB hashes loading, fixed another bug in the loading of HT-encoded hashes: when the hash entry is too big for ziplist, add the field, then convert. The code used to break before the new entry was inserted, resulting into missing fields in the loaded Hash object.
2012-03-13 11:00:18 +01:00
antirez
c3c856228d
RDB hashes loading fixed removing the assertion that failed every time an HT-encoded hash was loaded.
2012-03-13 09:49:11 +01:00
antirez
64b4c33c0b
Build dependencies updated.
2012-03-10 12:40:03 +01:00
antirez
f12d0224f3
RDB4 support in redis-check-dump.
2012-03-10 12:38:42 +01:00
antirez
c7d7d0a80f
RDB version is no 4, because small hashes are now encoded as ziplists, so older versions of Redis will not understand this format.
2012-03-10 12:35:31 +01:00
antirez
753bb3dcbd
More vertical space saved.
2012-03-10 11:19:17 +01:00
antirez
c0caa1cf54
Minor code aesthetic change to use Redis code base style rule of saving vertical space when possible.
2012-03-10 11:09:43 +01:00
antirez
d22248ae99
Removed handling of deprecated hash-max-zipmap-entries nad hash-map-zipmap-value. Pieter is too good with users ;). Better to have them switch to a saner configuration ASAP after the 2.6 upgrade.
2012-03-10 10:41:39 +01:00
antirez
addc032756
Added a top-function comment to rioWriteHashIteratorCursor() to better specify what the function does. Not immediately clear from the name.
2012-03-10 10:36:51 +01:00
antirez
8562798308
Merge conflicts resolved.
2012-03-09 22:07:45 +01:00
antirez
250e7f6908
Instantaneous ops/sec figure in INFO output.
2012-03-08 16:15:37 +01:00
antirez
0823e48fb9
Support for all the redis.conf fields in CONFIG GET. config.c refactored a bit.
2012-03-08 12:14:23 +01:00
antirez
91d664d6ce
run_id added to INFO output.
...
The Run ID is a field that identifies a single execution of the Redis
server. It can be useful for many purposes as it makes easy to detect if
the instance we are talking about is the same, or if it is a different
one or was rebooted. An application of run_id will be in the partial
synchronization of replication, where a slave may request a partial sync
from a given offset only if it is talking with the same master. Another
application is in failover and monitoring scripts.
2012-03-08 10:13:36 +01:00
antirez
44f508f1a8
clusterGetRandomName() generalized into getRandomHexChars() so that we can use it for the run_id field as well.
2012-03-08 10:08:44 +01:00
antirez
4d3bbf3590
By default Redis refuses writes with an error if the latest BGSAVE failed (and at least one save point is configured). However people having good monitoring systems may prefer a server that continues to work, since they are notified that there are problems by their monitoring systems. This commit implements the ability to turn the feature on or off via redis.conf and CONFIG SET.
2012-03-07 18:02:26 +01:00
antirez
c25e7eafef
Refuse writes if can't persist on disk.
...
Redis now refuses accepting write queries if RDB persistence is
configured, but RDB snapshots can't be generated for some reason.
The status of the latest background save operation is now exposed
in the INFO output as well. This fixes issue #90 .
2012-03-07 13:05:53 +01:00
antirez
e31b615e62
Better MONITOR output, now includes client ip:port or the lua string if the command was executed by the scripting engine.
2012-03-07 12:12:15 +01:00
antirez
7b845b6228
anetPeerToString() automatically populates ip/port with something that may be provided to the user as output in case of errors.
2012-03-07 11:30:30 +01:00
antirez
9494f1f15b
TIME command.
2012-03-07 10:38:01 +01:00
antirez
60893c6cc6
redis-cli: CSV output added, used for the --slave mode.
2012-02-29 17:43:06 +01:00
antirez
b8283ab218
Initial implementation of redis-cli --slave support.
2012-02-29 17:10:21 +01:00
antirez
a950a84303
Ping the slave using the standard protocol instead of the inline one.
2012-02-29 16:33:54 +01:00
antirez
c1db214eeb
Better implementation for BRPOP/BLPOP in the non blocking case.
2012-02-29 14:41:57 +01:00
antirez
cd8bdea31b
lpush arguments vector rewrite modified for more speed and to memory leak removal.
2012-02-29 13:38:30 +01:00
antirez
b67feecacd
Version bumped to 2.9.5
2012-02-29 00:54:52 +01:00
antirez
78d6a22dc3
Better system for additional commands replication.
...
The new code uses a more generic data structure to describe redis operations.
The new design allows for multiple alsoPropagate() calls within the scope of a
single command, that is useful in different contexts. For instance there
when there are multiple clients doing BRPOPLPUSH against the same list,
and a variadic LPUSH is performed against this list, the blocked clients
will both be served, and we should correctly replicate multiple LPUSH
commands after the replication of the current command.
2012-02-29 00:46:50 +01:00
antirez
eeb34eff52
Added a new API to replicate an additional command after the replication of the currently executed command, in order to propagte the LPUSH originating from RPOPLPUSH and indirectly by BRPOPLPUSH.
2012-02-28 18:03:08 +01:00
antirez
d8b1228bf6
propagate() prototype added to redis.h
2012-02-28 16:20:41 +01:00
antirez
edba65d090
Var renamed into pushGenericCommand() to better reflect what it means.
2012-02-28 16:17:55 +01:00
antirez
ad08d059d0
Added command propagation API.
2012-02-28 16:17:00 +01:00
Jakub Wieczorek
1d6628c088
Fix the build on Mac OS X, where features.h is non-existent
2012-02-26 15:13:05 +01:00
Premysl Hruby
80ff1fc6d0
use gcc sync builtins for memory counter when possible
2012-02-26 11:45:52 +01:00
Premysl Hruby
59132e4212
fix redis-benchmark memory leak
2012-02-26 10:01:27 +01:00
antirez
63505e0b59
Lua_cmsgpack added to Redis scripting.
2012-02-24 15:45:16 +01:00
antirez
f6da155bde
redis-benchmark: a few fixes to pipelining implementation.
2012-02-23 15:39:26 +01:00
antirez
b9474282f8
redis-benchmark: Initial support for pipelining.
2012-02-23 15:02:43 +01:00
antirez
62c394e219
unstable version called 2.9.4
2012-02-22 17:44:18 +01:00
antirez
a5bd08487f
Fix for issue #306 , thanks to tchajed (on github) for the pull request. The original patch was reworked a bit.
2012-02-22 16:07:06 +01:00
antirez
4eb3b3e970
Redis-cli should accept help command even if there is no connection to the server.
2012-02-22 15:16:11 +01:00
antirez
467d703ead
Merge remote-tracking branch 'origin/unstable' into unstable
2012-02-22 09:52:29 +01:00
antirez
feb282883b
zzlIsInRange() now is capable of handling empty sorted sets that may end inside the data set when loading very old RDB files produced by early-stage versions of Redis.
2012-02-22 09:52:10 +01:00
Pieter Noordhuis
ca2344f991
Solaris has backtrace(3)
2012-02-21 10:20:28 -08:00
Pieter Noordhuis
57be47758e
Also force SIGSEGV without HAVE_BACKTRACE
2012-02-21 10:20:01 -08:00
antirez
7c96b467c1
Fixed undefined behavior in *INCR style functions overflow detection. Sorry clang!
2012-02-21 18:26:11 +01:00
antirez
fe7be46025
bzero -> memset
2012-02-21 10:06:04 +01:00
antirez
b66e5add82
The hiredis lib shipped with Redis was updated to latest version.
2012-02-19 20:26:50 +01:00
Pieter Noordhuis
cb598cdd59
Don't expire keys when loading an RDB after a SYNC
...
The cron is responsible for expiring keys. When keys are expired at
load time, it is possible that the snapshot of a master node gets
modified. This can in turn lead to inconsistencies in the data set.
A more concrete example of this behavior follows. A user reported a
slave that would show an monotonically increase input buffer length,
shortly after completing a SYNC. Also, `INFO` output showed a single
blocked client, which could only be the master link. Investigation
showed that indeed the `BRPOP` command was fed by the master. This
command can only end up in the stream of write operations when it did
NOT block, and effectively executed `RPOP`. However, when the key
involved in the `BRPOP` is expired BEFORE the command is executed, the
client executing it will block. The client in this case, is the master
link.
2012-02-16 17:21:13 +01:00
antirez
a400a9b2d7
Now HINCRBY can detect overflows too. Fix for issue #330 .
2012-02-16 16:09:08 +01:00
antirez
6e09ad1c15
Return ASAP from checkClientOutputBufferLimits() if c->reply_bytes is zero.
2012-02-16 12:20:56 +01:00
antirez
48a32944e6
Merge branch 'issue327' into unstable
2012-02-16 09:40:27 +01:00
antirez
3b0600c777
Add stdint.h in endianconv.h to fix issue #336 .
2012-02-15 12:21:04 +01:00
antirez
4a701b3801
redis-check-aof is now large files safe also on 32 bit systems.
2012-02-14 19:57:51 +01:00
antirez
120a36f22b
add -f flag to cp when installing, otherwise stopping the server is
...
needed when installing a new Redis version. Thanks to Scott Kevill.
Fixes issue #335 .
2012-02-14 16:15:24 +01:00
antirez
7a3e372025
endian.c/h -> endianconv.c/h to avoid issues with broken libraries search paths.
2012-02-14 16:11:46 +01:00
antirez
18aa2b87b6
Merge remote-tracking branch 'origin/unstable' into unstable
2012-02-14 16:02:04 +01:00
antirez
6136a16bd1
intset.c endianess fixes.
2012-02-14 15:35:50 +01:00
lsbardel
2f75bbab02
added lua struct c extension
2012-02-13 21:05:21 +00:00