Simplify PR #6551 implementation.

This commit is contained in:
antirez 2019-11-19 11:56:02 +01:00
parent 065872e001
commit fe5aea38c3

View File

@ -465,12 +465,6 @@ struct redisCommand sentinelcmds[] = {
{"hello",helloCommand,-2,"no-script fast",0,NULL,0,0,0,0,0} {"hello",helloCommand,-2,"no-script fast",0,NULL,0,0,0,0,0}
}; };
/* List of client types that are killed when an instance becomes a slave */
const char* killedClientTypes[] = {
"normal",
"pubsub"
};
/* This function overwrites a few normal Redis config default with Sentinel /* This function overwrites a few normal Redis config default with Sentinel
* specific defaults. */ * specific defaults. */
void initSentinelConfig(void) { void initSentinelConfig(void) {
@ -3955,7 +3949,6 @@ char *sentinelGetLeader(sentinelRedisInstance *master, uint64_t epoch) {
int sentinelSendSlaveOf(sentinelRedisInstance *ri, char *host, int port) { int sentinelSendSlaveOf(sentinelRedisInstance *ri, char *host, int port) {
char portstr[32]; char portstr[32];
int retval; int retval;
unsigned int curType;
ll2string(portstr,sizeof(portstr),port); ll2string(portstr,sizeof(portstr),port);
@ -4000,11 +3993,11 @@ int sentinelSendSlaveOf(sentinelRedisInstance *ri, char *host, int port) {
* an issue because CLIENT is variadic command, so Redis will not * an issue because CLIENT is variadic command, so Redis will not
* recognized as a syntax error, and the transaction will not fail (but * recognized as a syntax error, and the transaction will not fail (but
* only the unsupported command will fail). */ * only the unsupported command will fail). */
for (curType = 0; curType < sizeof(killedClientTypes)/sizeof(killedClientTypes[0]); ++curType) { for (int type = 0; type < 2; type++) {
retval = redisAsyncCommand(ri->link->cc, retval = redisAsyncCommand(ri->link->cc,
sentinelDiscardReplyCallback, ri, "%s KILL TYPE %s", sentinelDiscardReplyCallback, ri, "%s KILL TYPE %s",
sentinelInstanceMapCommand(ri,"CLIENT"), sentinelInstanceMapCommand(ri,"CLIENT"),
killedClientTypes[curType]); type == 0 ? "normal" : "pubsub");
if (retval == C_ERR) return retval; if (retval == C_ERR) return retval;
ri->link->pending_commands++; ri->link->pending_commands++;
} }