caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-22 16:18:28 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid useless copying in LINDEX command for reply

Browse Source
This commit is contained in:
Viktor Söderqvist 2021-02-12 12:20:54 +01:00 committed by Oran Agra
parent fb3457d157
commit f521498b43
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/t_list.c
View File

@ -324,7 +324,6 @@ void lindexCommand(client *c) {
robj *o = lookupKeyReadOrReply(c,c->argv[1],shared.null[c->resp]); robj *o = lookupKeyReadOrReply(c,c->argv[1],shared.null[c->resp]);
if (o == NULL || checkType(c,o,OBJ_LIST)) return; if (o == NULL || checkType(c,o,OBJ_LIST)) return;
long index; long index;
robj *value = NULL;
if ((getLongFromObjectOrReply(c, c->argv[2], &index, NULL) != C_OK)) if ((getLongFromObjectOrReply(c, c->argv[2], &index, NULL) != C_OK))
return; return;
@ -333,12 +332,10 @@ void lindexCommand(client *c) {
quicklistEntry entry; quicklistEntry entry;
if (quicklistIndex(o->ptr, index, &entry)) { if (quicklistIndex(o->ptr, index, &entry)) {
if (entry.value) { if (entry.value) {
value = createStringObject((char*)entry.value,entry.sz); addReplyBulkCBuffer(c, entry.value, entry.sz);
} else { } else {
value = createStringObjectFromLongLong(entry.longval); addReplyBulkLongLong(c, entry.longval);
} }
addReplyBulk(c,value);
decrRefCount(value);
} else { } else {
addReplyNull(c); addReplyNull(c);
} }