caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-22 16:18:28 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added crash report on SIGABRT (#8004)

Browse Source 
The reason that we want to get a full crash report on SIGABRT
is that the jmalloc, when detecting a corruption, calls abort().
This will cause the Redis to exist silently without any report
and without any way to analyze what happened.
This commit is contained in:
Meir Shpilraien (Spielrein) 2020-11-03 14:59:21 +02:00 committed by GitHub
parent 9122379abc
commit f210e197f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/debug.c
View File

@ -839,6 +839,9 @@ void _serverAssert(const char *estr, const char *file, int line) {
#endif
printCrashReport();
}
// remove the signal handler so on abort() we will output the crash report.
removeSignalHandlers();
bugReportEnd(0, 0);
}
@ -923,6 +926,9 @@ void _serverPanic(const char *file, int line, const char *msg, ...) {
#endif
printCrashReport();
}
// remove the signal handler so on abort() we will output the crash report.
removeSignalHandlers();
bugReportEnd(0, 0);
}

1
src/redis-check-rdb.c
View File

@ -172,6 +172,7 @@ void rdbCheckSetupSignals(void) {
sigaction(SIGBUS, &act, NULL);
sigaction(SIGFPE, &act, NULL);
sigaction(SIGILL, &act, NULL);
sigaction(SIGABRT, &act, NULL);
}
/* Check the specified RDB file. Return 0 if the RDB looks sane, otherwise

2
src/server.c
View File

@ -5004,6 +5004,7 @@ void setupSignalHandlers(void) {
sigaction(SIGBUS, &act, NULL);
sigaction(SIGFPE, &act, NULL);
sigaction(SIGILL, &act, NULL);
sigaction(SIGABRT, &act, NULL);
}
return;
}
@ -5017,6 +5018,7 @@ void removeSignalHandlers(void) {
sigaction(SIGBUS, &act, NULL);
sigaction(SIGFPE, &act, NULL);
sigaction(SIGILL, &act, NULL);
sigaction(SIGABRT, &act, NULL);
}
/* This is the signal handler for children process. It is currently useful

11
tests/integration/logging.tcl
View File

@ -22,3 +22,14 @@ if {$system_name eq {linux} || $system_name eq {darwin}} {
}
}
}
set server_path [tmpdir server1.log]
start_server [list overrides [list dir $server_path]] {
test "Crash report generated on SIGABRT" {
set pid [s process_id]
exec kill -SIGABRT $pid
set pattern "*STACK TRACE*"
set result [exec tail -1000 < [srv 0 stdout]]
assert {[string match $pattern $result]}
}
}