From e257ab2bfeabfec5b4af562a5f0bbc28983ce26d Mon Sep 17 00:00:00 2001 From: antirez Date: Tue, 19 Nov 2013 10:13:04 +0100 Subject: [PATCH] Sentinel: sentinelFlushConfig() to CONFIG REWRITE + fsync. --- src/redis.h | 1 + src/sentinel.c | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/src/redis.h b/src/redis.h index 2361e03d6..bdc695228 100644 --- a/src/redis.h +++ b/src/redis.h @@ -1171,6 +1171,7 @@ void appendServerSaveParams(time_t seconds, int changes); void resetServerSaveParams(); struct rewriteConfigState; /* Forward declaration to export API. */ void rewriteConfigRewriteLine(struct rewriteConfigState *state, char *option, sds line, int force); +int rewriteConfig(char *path); /* db.c -- Keyspace access API */ int removeExpire(redisDb *db, robj *key); diff --git a/src/sentinel.c b/src/sentinel.c index 31005c9d1..bd951d8c0 100644 --- a/src/sentinel.c +++ b/src/sentinel.c @@ -36,6 +36,7 @@ #include #include #include +#include extern char **environ; @@ -1432,6 +1433,27 @@ void rewriteConfigSentinelOption(struct rewriteConfigState *state) { dictReleaseIterator(di); } +/* This function uses the config rewriting Redis engine in order to persist + * the state of the Sentinel in the current configuration file. + * + * Before returning the function calls fsync() against the generated + * configuration file to make sure changes are committed to disk. + * + * On failure the function logs a warning on the Redis log. */ +void sentinelFlushConfig(void) { + int fd; + + if (rewriteConfig(server.configfile) == -1) { + redisLog(REDIS_WARNING,"WARNING: Senitnel was not able to save the new configuration on disk!!!: %s", strerror(errno)); + return; + } + if ((fd = open(server.configfile,O_RDONLY)) != -1) { + fsync(fd); + close(fd); + } + return; +} + /* ====================== hiredis connection handling ======================= */ /* Completely disconnect an hiredis link from an instance. */