caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-22 08:08:53 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

xinfo-stream add minimum to seen-time, skip logreqres in fuzzer (#13056)

Browse Source 
Recently I saw in CI that reply-schemas-validator fails here:
```
Failed validating 'minimum' in schema[1]['properties']['groups']['items']['properties']['consumers']['items']['properties']['active-time']:
    {'description': 'Last time this consumer was active (successful '
                    'reading/claiming).',
     'minimum': 0,
     'type': 'integer'}

On instance['groups'][0]['consumers'][0]['active-time']:
    -1729380548878722639
```

The reason is that in fuzzer, we may restore corrupted active-time,
which will cause the reply schema CI to fail.

The fuzzer can cause corrupt the state in many places, which will
bugs that mess up the reply, so we decided to skip logreqres.

Also, seen-time is the same type as active-time, adding the minimum.

---------

Co-authored-by: Oran Agra <oran@redislabs.com>
This commit is contained in:
Binbin 2024-02-20 18:21:10 +08:00 committed by GitHub
parent 3c2ea1ea95
commit ca5cac998e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/commands/xinfo-stream.json
View File

@ -292,7 +292,8 @@
}, },
"seen-time": { "seen-time": {
"description": "timestamp of the last interaction attempt of the consumer", "description": "timestamp of the last interaction attempt of the consumer",
"type": "integer" "type": "integer",
"minimum": 0
}, },
"pel-count": { "pel-count": {
"description": "number of unacknowledged entries that belong to the consumer", "description": "number of unacknowledged entries that belong to the consumer",

4
tests/integration/corrupt-dump-fuzzer.tcl
View File

@ -1,6 +1,8 @@
# tests of corrupt listpack payload with valid CRC # tests of corrupt listpack payload with valid CRC
tags {"dump" "corruption" "external:skip"} { # The fuzzer can cause corrupt the state in many places, which could
# mess up the reply, so we decided to skip logreqres.
tags {"dump" "corruption" "external:skip" "logreqres:skip"} {
# catch sigterm so that in case one of the random command hangs the test, # catch sigterm so that in case one of the random command hangs the test,
# usually due to redis not putting a response in the output buffers, # usually due to redis not putting a response in the output buffers,