caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-23 00:28:26 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

faster INCR doing far less allocation in common cases

Browse Source
This commit is contained in:
antirez 2010-12-10 17:03:38 +01:00
parent dd48de748c
commit b215a496a4
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/t_string.c
View File

@ -144,8 +144,23 @@ void incrDecrCommand(redisClient *c, long long incr) {
o = lookupKeyWrite(c->db,c->argv[1]); o = lookupKeyWrite(c->db,c->argv[1]);
if (o != NULL && checkType(c,o,REDIS_STRING)) return; if (o != NULL && checkType(c,o,REDIS_STRING)) return;
if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return;
/* Fast path if the object is integer encoded and is not shared. */
if (o && o->refcount == 1 && o->encoding == REDIS_ENCODING_INT) {
long long newval = ((long)o->ptr) + incr;
if (newval >= LONG_MIN && newval <= LONG_MAX) {
o->ptr = (void*) (long) newval;
touchWatchedKey(c->db,c->argv[1]);
server.dirty++;
addReplyLongLong(c,newval);
return;
}
/* ... else take the usual safe path */
}
/* Otherwise we create a new object and replace the old one. */
if (getLongLongFromObjectOrReply(c,o,&value,NULL) != REDIS_OK) return;
value += incr; value += incr;
o = createStringObjectFromLongLong(value); o = createStringObjectFromLongLong(value);
dbReplace(c->db,c->argv[1],o); dbReplace(c->db,c->argv[1],o);