caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-22 16:18:28 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Optimize the performance of sdscatrepr in printable characters (#11725)

Browse Source 
sdscatrepr is not the hot path in redis, but it's still useful to have make it less wasteful.
This commit is contained in:
judeng 2023-01-22 15:16:17 +08:00 committed by GitHub
parent c95ff0f304
commit afd9e3ed3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/sds.c
View File

@ -997,6 +997,7 @@ void sdsfreesplitres(sds *tokens, int count) {
* After the call, the modified sds string is no longer valid and all the * After the call, the modified sds string is no longer valid and all the
* references must be substituted with the new pointer returned by the call. */ * references must be substituted with the new pointer returned by the call. */
sds sdscatrepr(sds s, const char *p, size_t len) { sds sdscatrepr(sds s, const char *p, size_t len) {
s = sdsMakeRoomFor(s, len + 2);
s = sdscatlen(s,"\"",1); s = sdscatlen(s,"\"",1);
while(len--) { while(len--) {
switch(*p) { switch(*p) {
@ -1011,7 +1012,7 @@ sds sdscatrepr(sds s, const char *p, size_t len) {
case '\b': s = sdscatlen(s,"\\b",2); break; case '\b': s = sdscatlen(s,"\\b",2); break;
default: default:
if (isprint(*p)) if (isprint(*p))
s = sdscatprintf(s,"%c",*p); s = sdscatlen(s, p, 1);
else else
s = sdscatprintf(s,"\\x%02x",(unsigned char)*p); s = sdscatprintf(s,"\\x%02x",(unsigned char)*p);
break; break;