From 9b4efe6cf4e165bac8031a26541ab04ff6d31402 Mon Sep 17 00:00:00 2001 From: ripcurld00d Date: Sun, 13 Apr 2014 21:09:54 +0300 Subject: [PATCH] redis-check-dump: use names instead of magic nums Use constants to avoid magic numbers in `types`, which is an array that stores the names of `REDIS` types. Closes #1681 --- src/redis-check-dump.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/redis-check-dump.c b/src/redis-check-dump.c index a4f103fdd..185cd243c 100644 --- a/src/redis-check-dump.c +++ b/src/redis-check-dump.c @@ -138,8 +138,10 @@ typedef struct { * at runtime to avoid strange compiler optimizations. */ static double R_Zero, R_PosInf, R_NegInf, R_Nan; +#define MAX_TYPES_NUM 256 +#define MAX_TYPE_NAME_LEN 16 /* store string types for output */ -static char types[256][16]; +static char types[MAX_TYPES_NUM][MAX_TYPE_NAME_LEN]; /* Return true if 't' is a valid object type. */ int checkType(unsigned char t) {