From 86c76cad74f9effb861dd1fc2f7d9f761b52077f Mon Sep 17 00:00:00 2001
From: hwware <wen.hui.ware@gmail.com>
Date: Sun, 29 Mar 2020 23:20:54 -0400
Subject: [PATCH] add check for not switching between optin optout mode
 directly

---
 src/networking.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/networking.c b/src/networking.c
index bad3e2c25..b6ab8eb5d 100644
--- a/src/networking.c
+++ b/src/networking.c
@@ -2314,7 +2314,7 @@ NULL
                 return;
             }
 
-            if ((options & CLIENT_TRACKING_OPTIN) && (options & CLIENT_TRACKING_OPTOUT))
+            if (options & CLIENT_TRACKING_OPTIN && options & CLIENT_TRACKING_OPTOUT)
             {
                 addReplyError(c,
                 "You can't specify both OPTIN mode and OPTOUT mode");
@@ -2322,6 +2322,17 @@ NULL
                 return;
             }
 
+            if ((options & CLIENT_TRACKING_OPTIN && c->flags & CLIENT_TRACKING_OPTOUT) ||
+                (options & CLIENT_TRACKING_OPTOUT && c->flags & CLIENT_TRACKING_OPTIN))
+            {
+                addReplyError(c,
+                "You can't switch OPTIN/OPTOUT mode before disabling "
+                "tracking for this client, and then re-enabling it with "
+                "a different mode.");
+                zfree(prefix);
+                return;
+            }
+
             enableTracking(c,redir,options,prefix,numprefix);
         } else if (!strcasecmp(c->argv[2]->ptr,"off")) {
             disableTracking(c);