caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-22 08:08:53 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add INCR type command against wrong argument test cases. (#12836)

Browse Source 
We have test cases for incr related commands with no key exist and
spaces in key and wrong type of key. However, we dont have test cases
covered for INCRBY INCRBYFLOAT DECRBY INCR DECR HINCRBY HINCRBYFLOAT
ZINCRBY with valid key and invalid value as argument, and float value to
incrby and decrby. So added test cases for the scenarios in incr.tcl.

Thank you!
This commit is contained in:
Wen Hui 2024-01-23 08:39:38 -05:00 committed by GitHub
parent 85c31e0cff
commit 685409139b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/unit/type/hash.tcl
View File

@ -492,6 +492,13 @@ start_server {tags {"hash"}} {
list [r hincrby htest foo 2]
} {2}
test {HINCRBY HINCRBYFLOAT against non-integer increment value} {
r del incrhash
r hset incrhash field 5
assert_error "*value is not an integer*" {r hincrby incrhash field v}
assert_error "*value is not a*" {r hincrbyfloat incrhash field v}
}
test {HINCRBY against non existing hash key} {
set rv {}
r hdel smallhash tmp

11
tests/unit/type/incr.tcl
View File

@ -183,6 +183,17 @@ start_server {tags {"incr"}} {
r get foo
} {0}
test {INCRBY INCRBYFLOAT DECRBY against unhappy path} {
r del mykeyincr
assert_error "*ERR wrong number of arguments*" {r incr mykeyincr v}
assert_error "*ERR wrong number of arguments*" {r decr mykeyincr v}
assert_error "*value is not an integer or out of range*" {r incrby mykeyincr v}
assert_error "*value is not an integer or out of range*" {r incrby mykeyincr 1.5}
assert_error "*value is not an integer or out of range*" {r decrby mykeyincr v}
assert_error "*value is not an integer or out of range*" {r decrby mykeyincr 1.5}
assert_error "*value is not a valid float*" {r incrbyfloat mykeyincr v}
}
foreach cmd {"incr" "decr" "incrby" "decrby"} {
test "$cmd operation should update encoding from raw to int" {
set res {}

6
tests/unit/type/zset.tcl
View File

@ -308,6 +308,12 @@ start_server {tags {"zset"}} {
assert_error "*NaN*" {r zincrby myzset -inf abc}
}
test "ZINCRBY against invalid incr value - $encoding" {
r del zincr
r zadd zincr 1 "one"
assert_error "*value is not a valid*" {r zincrby zincr v "one"}
}
test "ZADD - Variadic version base case - $encoding" {
r del myzset
list [r zadd myzset 10 a 20 b 30 c] [r zrange myzset 0 -1 withscores]