caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-23 08:38:27 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Net: clientsArePaused() should not touch blocked clients.

Browse Source 
When the list of unblocked clients were processed, btype was set to
blocking type none, but the client remained flagged with REDIS_BLOCKED.
When timeout is reached (or when the client disconnects), unblocking it
will trigger an assertion.

There is no need to process pending requests from blocked clients, so
now clientsArePaused() just avoid touching blocked clients.

Close #2467.
This commit is contained in:
antirez 2015-03-21 09:03:46 +01:00
parent a7010ae208
commit 5fe4a23131
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/networking.c
View File

@ -1689,7 +1689,7 @@ int clientsArePaused(void) {
while ((ln = listNext(&li)) != NULL) { while ((ln = listNext(&li)) != NULL) {
c = listNodeValue(ln); c = listNodeValue(ln);
if (c->flags & REDIS_SLAVE) continue; if (c->flags & (REDIS_SLAVE|REDIS_BLOCKED)) continue;
listAddNodeTail(server.unblocked_clients,c); listAddNodeTail(server.unblocked_clients,c);
} }
} }