From 58e9c261152819bfa5fe8d37ea943340c3575421 Mon Sep 17 00:00:00 2001 From: sundb Date: Thu, 24 Dec 2020 00:37:33 +0800 Subject: [PATCH] Fix redundancy incrRefCount in lmoveGenericCommand (#8218) --- src/t_list.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/t_list.c b/src/t_list.c index 106f960f6..1b4062c38 100644 --- a/src/t_list.c +++ b/src/t_list.c @@ -729,10 +729,6 @@ void lmoveGenericCommand(client *c, int wherefrom, int whereto) { if (checkType(c,dobj,OBJ_LIST)) return; value = listTypePop(sobj,wherefrom); serverAssert(value); /* assertion for valgrind (avoid NPD) */ - /* We saved touched key, and protect it, since lmoveHandlePush - * may change the client command argument vector (it does not - * currently). */ - incrRefCount(touchedkey); lmoveHandlePush(c,c->argv[2],dobj,value,whereto); /* listTypePop returns an object with its refcount incremented */ @@ -749,7 +745,6 @@ void lmoveGenericCommand(client *c, int wherefrom, int whereto) { touchedkey,c->db->id); } signalModifiedKey(c,c->db,touchedkey); - decrRefCount(touchedkey); server.dirty++; if (c->cmd->proc == blmoveCommand) { rewriteClientCommandVector(c,5,shared.lmove,