From 40abeb1f40fecbb772630a7e9d8d4bb82f7d11a1 Mon Sep 17 00:00:00 2001 From: antirez Date: Mon, 5 May 2014 17:07:09 +0200 Subject: [PATCH] Scripting: simpler reply buffer creation in luaRedisGenericCommand(). It if faster to just create the string with a single sdsnewlen() call. If c->bufpos is zero, the call will simply be like sdsemtpy(). --- src/scripting.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/scripting.c b/src/scripting.c index 9cce3165b..1202c5c2f 100644 --- a/src/scripting.c +++ b/src/scripting.c @@ -306,11 +306,8 @@ int luaRedisGenericCommand(lua_State *lua, int raise_error) { /* Convert the result of the Redis command into a suitable Lua type. * The first thing we need is to create a single string from the client * output buffers. */ - reply = sdsempty(); - if (c->bufpos) { - reply = sdscatlen(reply,c->buf,c->bufpos); - c->bufpos = 0; - } + reply = sdsnewlen(c->buf,c->bufpos); + c->bufpos = 0; while(listLength(c->reply)) { robj *o = listNodeValue(listFirst(c->reply));