caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-23 08:38:27 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed a refcount stuff leading to PUBSUB crashes

Browse Source
This commit is contained in:
antirez 2010-03-29 12:23:02 +02:00
parent de450ee9e5
commit 201037f562
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
redis.c
View File

@ -9301,6 +9301,8 @@ static int pubsubUnsubscribe(redisClient *c, robj *class, int notify) {
int retval = 0; int retval = 0;
/* Remove the class from the client -> classes hash table */ /* Remove the class from the client -> classes hash table */
incrRefCount(class); /* class may be just a pointer to the same object
we have in the hash tables. Protect it... */
if (dictDelete(c->pubsub_classes,class) == DICT_OK) { if (dictDelete(c->pubsub_classes,class) == DICT_OK) {
retval = 1; retval = 1;
/* Remove the client from the class -> clients list hash table */ /* Remove the client from the class -> clients list hash table */
@ -9318,6 +9320,7 @@ static int pubsubUnsubscribe(redisClient *c, robj *class, int notify) {
addReplyBulk(c,class); addReplyBulk(c,class);
addReplyLong(c,dictSize(c->pubsub_classes)); addReplyLong(c,dictSize(c->pubsub_classes));
} }
decrRefCount(class); /* it is finally safe to release it */
return retval; return retval;
} }