caleb-brown/redict
1
0
Fork 0
mirror of https://codeberg.org/redict/redict.git synced 2025-01-22 16:18:28 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

improve performance of keys command by using static objects (#12036)

Browse Source 
Improve performance by avoiding redundancy memory malloc/free
This commit is contained in:
judeng 2023-04-16 18:02:47 +08:00 committed by GitHub
parent d5d56d0d95
commit 1222b60873
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/db.c
View File

@ -774,17 +774,16 @@ void keysCommand(client *c) {
di = dictGetSafeIterator(c->db->dict); di = dictGetSafeIterator(c->db->dict);
allkeys = (pattern[0] == '*' && plen == 1); allkeys = (pattern[0] == '*' && plen == 1);
robj keyobj;
while((de = dictNext(di)) != NULL) { while((de = dictNext(di)) != NULL) {
sds key = dictGetKey(de); sds key = dictGetKey(de);
robj *keyobj;
if (allkeys || stringmatchlen(pattern,plen,key,sdslen(key),0)) { if (allkeys || stringmatchlen(pattern,plen,key,sdslen(key),0)) {
keyobj = createStringObject(key,sdslen(key)); initStaticStringObject(keyobj, key);
if (!keyIsExpired(c->db,keyobj)) { if (!keyIsExpired(c->db, &keyobj)) {
addReplyBulk(c,keyobj); addReplyBulkCBuffer(c, key, sdslen(key));
numkeys++; numkeys++;
} }
decrRefCount(keyobj);
} }
if (c->flags & CLIENT_CLOSE_ASAP) if (c->flags & CLIENT_CLOSE_ASAP)
break; break;