From 121ffc85f4ab8cb4a961551163ed53541834c2b1 Mon Sep 17 00:00:00 2001
From: antirez <antirez@gmail.com>
Date: Mon, 11 Jul 2011 12:56:00 +0200
Subject: [PATCH] better recap of failed tests.

---
 tests/support/test.tcl |  8 +++-----
 tests/test_helper.tcl  |  2 +-
 tests/unit/other.tcl   | 14 +++++++-------
 3 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/tests/support/test.tcl b/tests/support/test.tcl
index 0fca61822..4e68905a5 100644
--- a/tests/support/test.tcl
+++ b/tests/support/test.tcl
@@ -98,9 +98,7 @@ proc test {name code {okpattern undefined}} {
 
     incr ::num_tests
     set details {}
-    lappend details $::curfile
-    lappend details $::tags
-    lappend details $name
+    lappend details "$name in $::curfile"
 
     send_data_packet $::test_server_fd testing $name
 
@@ -111,7 +109,7 @@ proc test {name code {okpattern undefined}} {
             lappend ::tests_failed $details
 
             incr ::num_failed
-            send_data_packet $::test_server_fd err $name
+            send_data_packet $::test_server_fd err [join $details "\n"]
         } else {
             # Re-raise, let handler up the stack take care of this.
             error $error $::errorInfo
@@ -126,7 +124,7 @@ proc test {name code {okpattern undefined}} {
             lappend ::tests_failed $details
 
             incr ::num_failed
-            send_data_packet $::test_server_fd err $name
+            send_data_packet $::test_server_fd err [join $details "\n"]
         }
     }
 
diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl
index 6624ff285..86f88f3f8 100644
--- a/tests/test_helper.tcl
+++ b/tests/test_helper.tcl
@@ -277,7 +277,7 @@ proc the_end {} {
         puts "  $time seconds - $name"
     }
     if {[llength $::failed_tests]} {
-        puts "!!! WARNING: The following tests failed\n"
+        puts "\n[colorstr bold-red {!!! WARNING}] The following tests failed:\n"
         foreach failed $::failed_tests {
             puts "*** $failed"
         }
diff --git a/tests/unit/other.tcl b/tests/unit/other.tcl
index dff577159..8eebdc634 100644
--- a/tests/unit/other.tcl
+++ b/tests/unit/other.tcl
@@ -1,4 +1,11 @@
 start_server {tags {"other"}} {
+    if {$::force_failure} {
+        # This is used just for test suite development purposes.
+        test {Failing test} {
+            format err
+        } {ok}
+    }
+
     test {SAVE - make sure there are all the types as values} {
         # Wait for a background saving in progress to terminate
         waitForBgsave r
@@ -242,11 +249,4 @@ start_server {tags {"other"}} {
     test {Perform a final SAVE to leave a clean DB on disk} {
         r save
     } {OK}
-
-    if {$::force_failure} {
-        # This is used just for test suite development purposes.
-        test {Failing test} {
-            format err
-        } {ok}
-    }
 }