From 06f8a473fca79730e519c89571b1a7b227519d62 Mon Sep 17 00:00:00 2001 From: antirez Date: Fri, 6 Jan 2012 12:54:29 +0100 Subject: [PATCH] Regression tests for protocol desync bug related to Issue #141 --- tests/unit/protocol.tcl | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/tests/unit/protocol.tcl b/tests/unit/protocol.tcl index 516a834a8..3110d3d74 100644 --- a/tests/unit/protocol.tcl +++ b/tests/unit/protocol.tcl @@ -59,6 +59,37 @@ start_server {tags {"protocol"}} { reconnect assert_error "*wrong*arguments*ping*" {r ping x y z} } + + set c 0 + foreach seq [list "\x00" "*\x00" "$\x00"] { + incr c + test "Protocol desync regression test #$c" { + set s [socket [srv 0 host] [srv 0 port]] + puts -nonewline $s $seq + set payload [string repeat A 1024]"\n" + set test_start [clock seconds] + set test_time_limit 5 + while 1 { + if {[catch { + puts -nonewline $s payload + flush $s + incr payload_size [string length $payload] + }]} { + set retval [gets $s] + close $s + break + } else { + set elapsed [expr {[clock seconds]-$test_start}] + if {$elapsed > $test_time_limit} { + close $s + error "assertion:Redis did not closed connection after protocol desync" + } + } + } + set retval + } {*Protocol error*} + } + unset c } start_server {tags {"regression"}} {