2012-11-08 12:25:23 -05:00
|
|
|
/* SORT command and helper functions.
|
|
|
|
*
|
|
|
|
* Copyright (c) 2009-2012, Salvatore Sanfilippo <antirez at gmail dot com>
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions are met:
|
|
|
|
*
|
|
|
|
* * Redistributions of source code must retain the above copyright notice,
|
|
|
|
* this list of conditions and the following disclaimer.
|
|
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
|
|
* documentation and/or other materials provided with the distribution.
|
|
|
|
* * Neither the name of Redis nor the names of its contributors may be used
|
|
|
|
* to endorse or promote products derived from this software without
|
|
|
|
* specific prior written permission.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
2015-07-26 09:14:57 -04:00
|
|
|
#include "server.h"
|
2010-06-21 18:07:48 -04:00
|
|
|
#include "pqsort.h" /* Partial qsort for SORT+LIMIT */
|
2012-02-01 09:22:28 -05:00
|
|
|
#include <math.h> /* isnan() */
|
2010-06-21 18:07:48 -04:00
|
|
|
|
2012-10-03 05:41:08 -04:00
|
|
|
zskiplistNode* zslGetElementByRank(zskiplist *zsl, unsigned long rank);
|
|
|
|
|
2010-06-21 18:07:48 -04:00
|
|
|
redisSortOperation *createSortOperation(int type, robj *pattern) {
|
|
|
|
redisSortOperation *so = zmalloc(sizeof(*so));
|
|
|
|
so->type = type;
|
|
|
|
so->pattern = pattern;
|
|
|
|
return so;
|
|
|
|
}
|
|
|
|
|
2012-04-17 07:05:09 -04:00
|
|
|
/* Return the value associated to the key with a name obtained using
|
|
|
|
* the following rules:
|
|
|
|
*
|
2013-01-16 12:00:20 -05:00
|
|
|
* 1) The first occurrence of '*' in 'pattern' is substituted with 'subst'.
|
2012-04-17 07:05:09 -04:00
|
|
|
*
|
|
|
|
* 2) If 'pattern' matches the "->" string, everything on the left of
|
2013-12-05 10:35:32 -05:00
|
|
|
* the arrow is treated as the name of a hash field, and the part on the
|
|
|
|
* left as the key name containing a hash. The value of the specified
|
2012-04-17 07:05:09 -04:00
|
|
|
* field is returned.
|
|
|
|
*
|
|
|
|
* 3) If 'pattern' equals "#", the function simply returns 'subst' itself so
|
|
|
|
* that the SORT command can be used like: SORT key GET # to retrieve
|
|
|
|
* the Set/List elements directly.
|
|
|
|
*
|
2010-06-21 18:07:48 -04:00
|
|
|
* The returned object will always have its refcount increased by 1
|
|
|
|
* when it is non-NULL. */
|
2018-09-27 11:03:47 -04:00
|
|
|
robj *lookupKeyByPattern(redisDb *db, robj *pattern, robj *subst, int writeflag) {
|
2012-04-17 07:05:09 -04:00
|
|
|
char *p, *f, *k;
|
2010-06-21 18:07:48 -04:00
|
|
|
sds spat, ssub;
|
2012-04-18 05:37:14 -04:00
|
|
|
robj *keyobj, *fieldobj = NULL, *o;
|
2010-06-21 18:07:48 -04:00
|
|
|
int prefixlen, sublen, postfixlen, fieldlen;
|
|
|
|
|
|
|
|
/* If the pattern is "#" return the substitution object itself in order
|
|
|
|
* to implement the "SORT ... GET #" feature. */
|
|
|
|
spat = pattern->ptr;
|
|
|
|
if (spat[0] == '#' && spat[1] == '\0') {
|
|
|
|
incrRefCount(subst);
|
|
|
|
return subst;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* The substitution object may be specially encoded. If so we create
|
|
|
|
* a decoded object on the fly. Otherwise getDecodedObject will just
|
|
|
|
* increment the ref count, that we'll decrement later. */
|
|
|
|
subst = getDecodedObject(subst);
|
|
|
|
ssub = subst->ptr;
|
2012-04-17 07:05:09 -04:00
|
|
|
|
|
|
|
/* If we can't find '*' in the pattern we return NULL as to GET a
|
|
|
|
* fixed key does not make sense. */
|
2010-06-21 18:07:48 -04:00
|
|
|
p = strchr(spat,'*');
|
|
|
|
if (!p) {
|
|
|
|
decrRefCount(subst);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Find out if we're dealing with a hash dereference. */
|
2012-04-17 07:05:09 -04:00
|
|
|
if ((f = strstr(p+1, "->")) != NULL && *(f+2) != '\0') {
|
|
|
|
fieldlen = sdslen(spat)-(f-spat)-2;
|
|
|
|
fieldobj = createStringObject(f+2,fieldlen);
|
2010-06-21 18:07:48 -04:00
|
|
|
} else {
|
|
|
|
fieldlen = 0;
|
|
|
|
}
|
|
|
|
|
2012-04-17 07:05:09 -04:00
|
|
|
/* Perform the '*' substitution. */
|
2010-06-21 18:07:48 -04:00
|
|
|
prefixlen = p-spat;
|
|
|
|
sublen = sdslen(ssub);
|
2012-04-17 07:05:09 -04:00
|
|
|
postfixlen = sdslen(spat)-(prefixlen+1)-(fieldlen ? fieldlen+2 : 0);
|
|
|
|
keyobj = createStringObject(NULL,prefixlen+sublen+postfixlen);
|
|
|
|
k = keyobj->ptr;
|
|
|
|
memcpy(k,spat,prefixlen);
|
|
|
|
memcpy(k+prefixlen,ssub,sublen);
|
|
|
|
memcpy(k+prefixlen+sublen,p+1,postfixlen);
|
|
|
|
decrRefCount(subst); /* Incremented by decodeObject() */
|
2010-06-21 18:07:48 -04:00
|
|
|
|
|
|
|
/* Lookup substituted key */
|
2018-09-27 11:03:47 -04:00
|
|
|
if (!writeflag)
|
|
|
|
o = lookupKeyRead(db,keyobj);
|
|
|
|
else
|
|
|
|
o = lookupKeyWrite(db,keyobj);
|
2012-04-17 07:05:09 -04:00
|
|
|
if (o == NULL) goto noobj;
|
2010-06-21 18:07:48 -04:00
|
|
|
|
2012-04-18 05:37:14 -04:00
|
|
|
if (fieldobj) {
|
2015-07-26 09:28:00 -04:00
|
|
|
if (o->type != OBJ_HASH) goto noobj;
|
2010-06-21 18:07:48 -04:00
|
|
|
|
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 06:43:38 -04:00
|
|
|
/* Retrieve value from hash by the field name. The returned object
|
2015-09-23 03:33:23 -04:00
|
|
|
* is a new object with refcount already incremented. */
|
|
|
|
o = hashTypeGetValueObject(o, fieldobj->ptr);
|
2010-06-21 18:07:48 -04:00
|
|
|
} else {
|
2015-07-26 09:28:00 -04:00
|
|
|
if (o->type != OBJ_STRING) goto noobj;
|
2010-06-21 18:07:48 -04:00
|
|
|
|
|
|
|
/* Every object that this function returns needs to have its refcount
|
|
|
|
* increased. sortCommand decreases it again. */
|
|
|
|
incrRefCount(o);
|
|
|
|
}
|
2012-04-17 07:05:09 -04:00
|
|
|
decrRefCount(keyobj);
|
2012-04-18 05:37:14 -04:00
|
|
|
if (fieldobj) decrRefCount(fieldobj);
|
2010-06-21 18:07:48 -04:00
|
|
|
return o;
|
2012-04-17 07:05:09 -04:00
|
|
|
|
|
|
|
noobj:
|
|
|
|
decrRefCount(keyobj);
|
|
|
|
if (fieldlen) decrRefCount(fieldobj);
|
|
|
|
return NULL;
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* sortCompare() is used by qsort in sortCommand(). Given that qsort_r with
|
|
|
|
* the additional parameter is not standard but a BSD-specific we have to
|
|
|
|
* pass sorting parameters via the global 'server' structure */
|
|
|
|
int sortCompare(const void *s1, const void *s2) {
|
|
|
|
const redisSortObject *so1 = s1, *so2 = s2;
|
|
|
|
int cmp;
|
|
|
|
|
|
|
|
if (!server.sort_alpha) {
|
|
|
|
/* Numeric sorting. Here it's trivial as we precomputed scores */
|
|
|
|
if (so1->u.score > so2->u.score) {
|
|
|
|
cmp = 1;
|
|
|
|
} else if (so1->u.score < so2->u.score) {
|
|
|
|
cmp = -1;
|
|
|
|
} else {
|
2012-02-01 09:22:28 -05:00
|
|
|
/* Objects have the same score, but we don't want the comparison
|
2013-01-16 12:00:20 -05:00
|
|
|
* to be undefined, so we compare objects lexicographically.
|
2012-02-01 09:22:28 -05:00
|
|
|
* This way the result of SORT is deterministic. */
|
|
|
|
cmp = compareStringObjects(so1->obj,so2->obj);
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* Alphanumeric sorting */
|
|
|
|
if (server.sort_bypattern) {
|
|
|
|
if (!so1->u.cmpobj || !so2->u.cmpobj) {
|
|
|
|
/* At least one compare object is NULL */
|
|
|
|
if (so1->u.cmpobj == so2->u.cmpobj)
|
|
|
|
cmp = 0;
|
|
|
|
else if (so1->u.cmpobj == NULL)
|
|
|
|
cmp = -1;
|
|
|
|
else
|
|
|
|
cmp = 1;
|
|
|
|
} else {
|
2013-07-12 06:02:36 -04:00
|
|
|
/* We have both the objects, compare them. */
|
|
|
|
if (server.sort_store) {
|
|
|
|
cmp = compareStringObjects(so1->u.cmpobj,so2->u.cmpobj);
|
|
|
|
} else {
|
|
|
|
/* Here we can use strcoll() directly as we are sure that
|
|
|
|
* the objects are decoded string objects. */
|
|
|
|
cmp = strcoll(so1->u.cmpobj->ptr,so2->u.cmpobj->ptr);
|
|
|
|
}
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* Compare elements directly. */
|
2013-07-12 06:02:36 -04:00
|
|
|
if (server.sort_store) {
|
|
|
|
cmp = compareStringObjects(so1->obj,so2->obj);
|
|
|
|
} else {
|
|
|
|
cmp = collateStringObjects(so1->obj,so2->obj);
|
|
|
|
}
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return server.sort_desc ? -cmp : cmp;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* The SORT command is the most complex command in Redis. Warning: this code
|
|
|
|
* is optimized for speed and a bit less for readability */
|
2015-07-26 09:20:46 -04:00
|
|
|
void sortCommand(client *c) {
|
2010-06-21 18:07:48 -04:00
|
|
|
list *operations;
|
|
|
|
unsigned int outputlen = 0;
|
|
|
|
int desc = 0, alpha = 0;
|
2011-12-19 06:29:46 -05:00
|
|
|
long limit_start = 0, limit_count = -1, start, end;
|
2010-06-21 18:07:48 -04:00
|
|
|
int j, dontsort = 0, vectorlen;
|
|
|
|
int getop = 0; /* GET operation counter */
|
2018-07-01 01:24:50 -04:00
|
|
|
int int_conversion_error = 0;
|
2014-03-10 11:10:50 -04:00
|
|
|
int syntax_error = 0;
|
2010-06-21 18:07:48 -04:00
|
|
|
robj *sortval, *sortby = NULL, *storekey = NULL;
|
|
|
|
redisSortObject *vector; /* Resulting vector to sort */
|
|
|
|
|
|
|
|
/* Create a list of operations to perform for every sorted element.
|
2015-05-21 06:24:51 -04:00
|
|
|
* Operations can be GET */
|
2010-06-21 18:07:48 -04:00
|
|
|
operations = listCreate();
|
|
|
|
listSetFreeMethod(operations,zfree);
|
2012-10-03 05:41:08 -04:00
|
|
|
j = 2; /* options start at argv[2] */
|
2010-06-21 18:07:48 -04:00
|
|
|
|
|
|
|
/* The SORT command has an SQL-alike syntax, parse it */
|
|
|
|
while(j < c->argc) {
|
|
|
|
int leftargs = c->argc-j-1;
|
|
|
|
if (!strcasecmp(c->argv[j]->ptr,"asc")) {
|
|
|
|
desc = 0;
|
|
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"desc")) {
|
|
|
|
desc = 1;
|
|
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"alpha")) {
|
|
|
|
alpha = 1;
|
|
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"limit") && leftargs >= 2) {
|
2014-03-10 10:44:41 -04:00
|
|
|
if ((getLongFromObjectOrReply(c, c->argv[j+1], &limit_start, NULL)
|
2015-07-26 17:17:55 -04:00
|
|
|
!= C_OK) ||
|
2014-03-10 10:44:41 -04:00
|
|
|
(getLongFromObjectOrReply(c, c->argv[j+2], &limit_count, NULL)
|
2015-07-26 17:17:55 -04:00
|
|
|
!= C_OK))
|
2014-03-10 10:44:41 -04:00
|
|
|
{
|
2014-03-10 11:10:50 -04:00
|
|
|
syntax_error++;
|
|
|
|
break;
|
2014-03-10 10:44:41 -04:00
|
|
|
}
|
2010-06-21 18:07:48 -04:00
|
|
|
j+=2;
|
|
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"store") && leftargs >= 1) {
|
|
|
|
storekey = c->argv[j+1];
|
|
|
|
j++;
|
|
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"by") && leftargs >= 1) {
|
|
|
|
sortby = c->argv[j+1];
|
|
|
|
/* If the BY pattern does not contain '*', i.e. it is constant,
|
|
|
|
* we don't need to sort nor to lookup the weight keys. */
|
2014-03-10 11:28:18 -04:00
|
|
|
if (strchr(c->argv[j+1]->ptr,'*') == NULL) {
|
|
|
|
dontsort = 1;
|
|
|
|
} else {
|
|
|
|
/* If BY is specified with a real patter, we can't accept
|
|
|
|
* it in cluster mode. */
|
|
|
|
if (server.cluster_enabled) {
|
|
|
|
addReplyError(c,"BY option of SORT denied in Cluster mode.");
|
|
|
|
syntax_error++;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2010-06-21 18:07:48 -04:00
|
|
|
j++;
|
|
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"get") && leftargs >= 1) {
|
2014-03-10 11:10:50 -04:00
|
|
|
if (server.cluster_enabled) {
|
|
|
|
addReplyError(c,"GET option of SORT denied in Cluster mode.");
|
|
|
|
syntax_error++;
|
|
|
|
break;
|
|
|
|
}
|
2010-06-21 18:07:48 -04:00
|
|
|
listAddNodeTail(operations,createSortOperation(
|
2015-07-27 03:41:48 -04:00
|
|
|
SORT_OP_GET,c->argv[j+1]));
|
2010-06-21 18:07:48 -04:00
|
|
|
getop++;
|
|
|
|
j++;
|
|
|
|
} else {
|
2020-12-23 22:06:25 -05:00
|
|
|
addReplyErrorObject(c,shared.syntaxerr);
|
2014-03-10 11:10:50 -04:00
|
|
|
syntax_error++;
|
|
|
|
break;
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
j++;
|
|
|
|
}
|
|
|
|
|
2014-03-10 11:10:50 -04:00
|
|
|
/* Handle syntax errors set during options parsing. */
|
|
|
|
if (syntax_error) {
|
|
|
|
listRelease(operations);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-09-27 11:03:47 -04:00
|
|
|
/* Lookup the key to sort. It must be of the right types */
|
2021-01-04 03:28:47 -05:00
|
|
|
if (!storekey)
|
2018-09-27 11:03:47 -04:00
|
|
|
sortval = lookupKeyRead(c->db,c->argv[1]);
|
|
|
|
else
|
|
|
|
sortval = lookupKeyWrite(c->db,c->argv[1]);
|
|
|
|
if (sortval && sortval->type != OBJ_SET &&
|
|
|
|
sortval->type != OBJ_LIST &&
|
|
|
|
sortval->type != OBJ_ZSET)
|
|
|
|
{
|
|
|
|
listRelease(operations);
|
2020-12-23 22:06:25 -05:00
|
|
|
addReplyErrorObject(c,shared.wrongtypeerr);
|
2018-09-27 11:03:47 -04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Now we need to protect sortval incrementing its count, in the future
|
|
|
|
* SORT may have options able to overwrite/delete keys during the sorting
|
|
|
|
* and the sorted key itself may get destroyed */
|
|
|
|
if (sortval)
|
|
|
|
incrRefCount(sortval);
|
|
|
|
else
|
|
|
|
sortval = createQuicklistObject();
|
|
|
|
|
|
|
|
|
2014-10-23 11:52:35 -04:00
|
|
|
/* When sorting a set with no sort specified, we must sort the output
|
|
|
|
* so the result is consistent across scripting and replication.
|
Scripting: Force SORT BY constant determinism inside SORT itself.
SORT is able to return (faster than when ordering) unordered output if
the "BY" clause is used with a constant value. However we try to play
well with scripting requirements of determinism providing always sorted
outputs when SORT (and other similar commands) are called by Lua
scripts.
However we used the general mechanism in place in scripting in order to
reorder SORT output, that is, if the command has the "S" flag set, the
Lua scripting engine will take an additional step when converting a
multi bulk reply to Lua value, calling a Lua sorting function.
This is suboptimal as we can do it faster inside SORT itself.
This is also broken as issue #545 shows us: basically when SORT is used
with a constant BY, and additionally also GET is used, the Lua scripting
engine was trying to order the output as a flat array, while it was
actually a list of key-value pairs.
What we do know is to recognized if the caller of SORT is the Lua client
(since we can check this using the REDIS_LUA_CLIENT flag). If so, and if
a "don't sort" condition is triggered by the BY option with a constant
string, we force the lexicographical sorting.
This commit fixes this bug and improves the performance, and at the same
time simplifies the implementation. This does not mean I'm smart today,
it means I was stupid when I committed the original implementation ;)
2012-09-04 19:12:41 -04:00
|
|
|
*
|
2014-10-23 11:52:35 -04:00
|
|
|
* The other types (list, sorted set) will retain their native order
|
|
|
|
* even if no sort order is requested, so they remain stable across
|
|
|
|
* scripting and replication. */
|
2014-12-11 09:57:11 -05:00
|
|
|
if (dontsort &&
|
2015-07-26 09:28:00 -04:00
|
|
|
sortval->type == OBJ_SET &&
|
2015-07-27 03:41:48 -04:00
|
|
|
(storekey || c->flags & CLIENT_LUA))
|
2012-10-03 05:41:08 -04:00
|
|
|
{
|
|
|
|
/* Force ALPHA sorting */
|
2012-02-01 11:05:45 -05:00
|
|
|
dontsort = 0;
|
|
|
|
alpha = 1;
|
|
|
|
sortby = NULL;
|
|
|
|
}
|
|
|
|
|
2011-03-14 08:30:06 -04:00
|
|
|
/* Destructively convert encoded sorted sets for SORT. */
|
2015-07-26 09:28:00 -04:00
|
|
|
if (sortval->type == OBJ_ZSET)
|
|
|
|
zsetConvert(sortval, OBJ_ENCODING_SKIPLIST);
|
2011-03-14 08:30:06 -04:00
|
|
|
|
2021-06-10 08:39:33 -04:00
|
|
|
/* Obtain the length of the object to sort. */
|
2010-06-21 18:07:48 -04:00
|
|
|
switch(sortval->type) {
|
2015-07-26 09:28:00 -04:00
|
|
|
case OBJ_LIST: vectorlen = listTypeLength(sortval); break;
|
|
|
|
case OBJ_SET: vectorlen = setTypeSize(sortval); break;
|
|
|
|
case OBJ_ZSET: vectorlen = dictSize(((zset*)sortval->ptr)->dict); break;
|
2015-07-27 03:41:48 -04:00
|
|
|
default: vectorlen = 0; serverPanic("Bad SORT type"); /* Avoid GCC warning */
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
2012-10-03 05:41:08 -04:00
|
|
|
|
|
|
|
/* Perform LIMIT start,count sanity checking. */
|
|
|
|
start = (limit_start < 0) ? 0 : limit_start;
|
|
|
|
end = (limit_count < 0) ? vectorlen-1 : start+limit_count-1;
|
|
|
|
if (start >= vectorlen) {
|
|
|
|
start = vectorlen-1;
|
|
|
|
end = vectorlen-2;
|
|
|
|
}
|
|
|
|
if (end >= vectorlen) end = vectorlen-1;
|
|
|
|
|
2015-02-03 09:38:21 -05:00
|
|
|
/* Whenever possible, we load elements into the output array in a more
|
|
|
|
* direct way. This is possible if:
|
2012-10-03 05:41:08 -04:00
|
|
|
*
|
2015-02-03 09:38:21 -05:00
|
|
|
* 1) The object to sort is a sorted set or a list (internally sorted).
|
2012-10-03 05:41:08 -04:00
|
|
|
* 2) There is nothing to sort as dontsort is true (BY <constant string>).
|
|
|
|
*
|
2015-02-03 09:38:21 -05:00
|
|
|
* In this special case, if we have a LIMIT option that actually reduces
|
|
|
|
* the number of elements to fetch, we also optimize to just load the
|
|
|
|
* range we are interested in and allocating a vector that is big enough
|
|
|
|
* for the selected range length. */
|
2015-07-26 09:28:00 -04:00
|
|
|
if ((sortval->type == OBJ_ZSET || sortval->type == OBJ_LIST) &&
|
2012-10-03 05:41:08 -04:00
|
|
|
dontsort &&
|
|
|
|
(start != 0 || end != vectorlen-1))
|
|
|
|
{
|
|
|
|
vectorlen = end-start+1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Load the sorting vector with all the objects to sort */
|
2010-06-21 18:07:48 -04:00
|
|
|
vector = zmalloc(sizeof(redisSortObject)*vectorlen);
|
|
|
|
j = 0;
|
|
|
|
|
2015-07-26 09:28:00 -04:00
|
|
|
if (sortval->type == OBJ_LIST && dontsort) {
|
2015-02-01 22:29:20 -05:00
|
|
|
/* Special handling for a list, if 'dontsort' is true.
|
|
|
|
* This makes sure we return elements in the list original
|
|
|
|
* ordering, accordingly to DESC / ASC options.
|
|
|
|
*
|
|
|
|
* Note that in this case we also handle LIMIT here in a direct
|
|
|
|
* way, just getting the required range, as an optimization. */
|
|
|
|
if (end >= start) {
|
|
|
|
listTypeIterator *li;
|
|
|
|
listTypeEntry entry;
|
|
|
|
li = listTypeInitIterator(sortval,
|
2015-02-03 09:42:56 -05:00
|
|
|
desc ? (long)(listTypeLength(sortval) - start - 1) : start,
|
2015-07-27 03:41:48 -04:00
|
|
|
desc ? LIST_HEAD : LIST_TAIL);
|
2015-02-01 22:29:20 -05:00
|
|
|
|
|
|
|
while(j < vectorlen && listTypeNext(li,&entry)) {
|
|
|
|
vector[j].obj = listTypeGet(&entry);
|
|
|
|
vector[j].u.score = 0;
|
|
|
|
vector[j].u.cmpobj = NULL;
|
|
|
|
j++;
|
|
|
|
}
|
|
|
|
listTypeReleaseIterator(li);
|
2015-02-03 09:38:21 -05:00
|
|
|
/* Fix start/end: output code is not aware of this optimization. */
|
2015-02-01 22:29:20 -05:00
|
|
|
end -= start;
|
|
|
|
start = 0;
|
|
|
|
}
|
2015-07-26 09:28:00 -04:00
|
|
|
} else if (sortval->type == OBJ_LIST) {
|
2015-07-27 03:41:48 -04:00
|
|
|
listTypeIterator *li = listTypeInitIterator(sortval,0,LIST_TAIL);
|
2010-06-21 18:07:48 -04:00
|
|
|
listTypeEntry entry;
|
|
|
|
while(listTypeNext(li,&entry)) {
|
|
|
|
vector[j].obj = listTypeGet(&entry);
|
|
|
|
vector[j].u.score = 0;
|
|
|
|
vector[j].u.cmpobj = NULL;
|
|
|
|
j++;
|
|
|
|
}
|
|
|
|
listTypeReleaseIterator(li);
|
2015-07-26 09:28:00 -04:00
|
|
|
} else if (sortval->type == OBJ_SET) {
|
2010-08-21 05:25:13 -04:00
|
|
|
setTypeIterator *si = setTypeInitIterator(sortval);
|
2015-07-31 12:01:23 -04:00
|
|
|
sds sdsele;
|
|
|
|
while((sdsele = setTypeNextObject(si)) != NULL) {
|
|
|
|
vector[j].obj = createObject(OBJ_STRING,sdsele);
|
2010-08-21 05:15:31 -04:00
|
|
|
vector[j].u.score = 0;
|
|
|
|
vector[j].u.cmpobj = NULL;
|
|
|
|
j++;
|
|
|
|
}
|
|
|
|
setTypeReleaseIterator(si);
|
2015-07-26 09:28:00 -04:00
|
|
|
} else if (sortval->type == OBJ_ZSET && dontsort) {
|
2012-10-03 05:41:08 -04:00
|
|
|
/* Special handling for a sorted set, if 'dontsort' is true.
|
|
|
|
* This makes sure we return elements in the sorted set original
|
|
|
|
* ordering, accordingly to DESC / ASC options.
|
|
|
|
*
|
|
|
|
* Note that in this case we also handle LIMIT here in a direct
|
|
|
|
* way, just getting the required range, as an optimization. */
|
|
|
|
|
|
|
|
zset *zs = sortval->ptr;
|
|
|
|
zskiplist *zsl = zs->zsl;
|
|
|
|
zskiplistNode *ln;
|
2015-08-04 03:20:55 -04:00
|
|
|
sds sdsele;
|
2012-10-03 05:41:08 -04:00
|
|
|
int rangelen = vectorlen;
|
|
|
|
|
|
|
|
/* Check if starting point is trivial, before doing log(N) lookup. */
|
|
|
|
if (desc) {
|
|
|
|
long zsetlen = dictSize(((zset*)sortval->ptr)->dict);
|
|
|
|
|
|
|
|
ln = zsl->tail;
|
|
|
|
if (start > 0)
|
|
|
|
ln = zslGetElementByRank(zsl,zsetlen-start);
|
|
|
|
} else {
|
|
|
|
ln = zsl->header->level[0].forward;
|
|
|
|
if (start > 0)
|
|
|
|
ln = zslGetElementByRank(zsl,start+1);
|
|
|
|
}
|
|
|
|
|
|
|
|
while(rangelen--) {
|
2015-07-26 09:29:53 -04:00
|
|
|
serverAssertWithInfo(c,sortval,ln != NULL);
|
2015-08-04 03:20:55 -04:00
|
|
|
sdsele = ln->ele;
|
|
|
|
vector[j].obj = createStringObject(sdsele,sdslen(sdsele));
|
2012-10-03 05:41:08 -04:00
|
|
|
vector[j].u.score = 0;
|
|
|
|
vector[j].u.cmpobj = NULL;
|
|
|
|
j++;
|
|
|
|
ln = desc ? ln->backward : ln->level[0].forward;
|
|
|
|
}
|
2015-02-03 09:38:21 -05:00
|
|
|
/* Fix start/end: output code is not aware of this optimization. */
|
2012-10-03 05:41:08 -04:00
|
|
|
end -= start;
|
|
|
|
start = 0;
|
2015-07-26 09:28:00 -04:00
|
|
|
} else if (sortval->type == OBJ_ZSET) {
|
2010-08-21 05:15:31 -04:00
|
|
|
dict *set = ((zset*)sortval->ptr)->dict;
|
2010-06-21 18:07:48 -04:00
|
|
|
dictIterator *di;
|
|
|
|
dictEntry *setele;
|
2015-08-04 03:20:55 -04:00
|
|
|
sds sdsele;
|
2010-06-21 18:07:48 -04:00
|
|
|
di = dictGetIterator(set);
|
|
|
|
while((setele = dictNext(di)) != NULL) {
|
2015-08-04 03:20:55 -04:00
|
|
|
sdsele = dictGetKey(setele);
|
|
|
|
vector[j].obj = createStringObject(sdsele,sdslen(sdsele));
|
2010-06-21 18:07:48 -04:00
|
|
|
vector[j].u.score = 0;
|
|
|
|
vector[j].u.cmpobj = NULL;
|
|
|
|
j++;
|
|
|
|
}
|
|
|
|
dictReleaseIterator(di);
|
2010-08-21 05:15:31 -04:00
|
|
|
} else {
|
2015-07-27 03:41:48 -04:00
|
|
|
serverPanic("Unknown type");
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
2015-07-26 09:29:53 -04:00
|
|
|
serverAssertWithInfo(c,sortval,j == vectorlen);
|
2010-06-21 18:07:48 -04:00
|
|
|
|
|
|
|
/* Now it's time to load the right scores in the sorting vector */
|
2018-06-17 15:25:51 -04:00
|
|
|
if (!dontsort) {
|
2010-06-21 18:07:48 -04:00
|
|
|
for (j = 0; j < vectorlen; j++) {
|
|
|
|
robj *byval;
|
|
|
|
if (sortby) {
|
|
|
|
/* lookup value to sort by */
|
2018-09-27 11:03:47 -04:00
|
|
|
byval = lookupKeyByPattern(c->db,sortby,vector[j].obj,storekey!=NULL);
|
2010-06-21 18:07:48 -04:00
|
|
|
if (!byval) continue;
|
|
|
|
} else {
|
|
|
|
/* use object itself to sort by */
|
|
|
|
byval = vector[j].obj;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (alpha) {
|
|
|
|
if (sortby) vector[j].u.cmpobj = getDecodedObject(byval);
|
|
|
|
} else {
|
2012-06-05 15:50:10 -04:00
|
|
|
if (sdsEncodedObject(byval)) {
|
2012-02-01 09:22:28 -05:00
|
|
|
char *eptr;
|
|
|
|
|
|
|
|
vector[j].u.score = strtod(byval->ptr,&eptr);
|
|
|
|
if (eptr[0] != '\0' || errno == ERANGE ||
|
|
|
|
isnan(vector[j].u.score))
|
|
|
|
{
|
2018-07-01 01:24:50 -04:00
|
|
|
int_conversion_error = 1;
|
2012-02-01 09:22:28 -05:00
|
|
|
}
|
2015-07-26 09:28:00 -04:00
|
|
|
} else if (byval->encoding == OBJ_ENCODING_INT) {
|
2010-06-21 18:07:48 -04:00
|
|
|
/* Don't need to decode the object if it's
|
|
|
|
* integer-encoded (the only encoding supported) so
|
|
|
|
* far. We can just cast it */
|
|
|
|
vector[j].u.score = (long)byval->ptr;
|
|
|
|
} else {
|
2015-07-26 09:29:53 -04:00
|
|
|
serverAssertWithInfo(c,sortval,1 != 1);
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* when the object was retrieved using lookupKeyByPattern,
|
|
|
|
* its refcount needs to be decreased. */
|
|
|
|
if (sortby) {
|
|
|
|
decrRefCount(byval);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
server.sort_desc = desc;
|
|
|
|
server.sort_alpha = alpha;
|
|
|
|
server.sort_bypattern = sortby ? 1 : 0;
|
2013-07-12 06:02:36 -04:00
|
|
|
server.sort_store = storekey ? 1 : 0;
|
2010-06-21 18:07:48 -04:00
|
|
|
if (sortby && (start != 0 || end != vectorlen-1))
|
|
|
|
pqsort(vector,vectorlen,sizeof(redisSortObject),sortCompare, start,end);
|
|
|
|
else
|
|
|
|
qsort(vector,vectorlen,sizeof(redisSortObject),sortCompare);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Send command output to the output buffer, performing the specified
|
|
|
|
* GET/DEL/INCR/DECR operations if any. */
|
|
|
|
outputlen = getop ? getop*(end-start+1) : end-start+1;
|
2018-07-01 01:24:50 -04:00
|
|
|
if (int_conversion_error) {
|
2012-02-01 09:22:28 -05:00
|
|
|
addReplyError(c,"One or more scores can't be converted into double");
|
|
|
|
} else if (storekey == NULL) {
|
2010-06-21 18:07:48 -04:00
|
|
|
/* STORE option not specified, sent the sorting result to client */
|
2018-11-23 06:40:01 -05:00
|
|
|
addReplyArrayLen(c,outputlen);
|
2010-06-21 18:07:48 -04:00
|
|
|
for (j = start; j <= end; j++) {
|
|
|
|
listNode *ln;
|
|
|
|
listIter li;
|
|
|
|
|
|
|
|
if (!getop) addReplyBulk(c,vector[j].obj);
|
|
|
|
listRewind(operations,&li);
|
|
|
|
while((ln = listNext(&li))) {
|
|
|
|
redisSortOperation *sop = ln->value;
|
|
|
|
robj *val = lookupKeyByPattern(c->db,sop->pattern,
|
2018-09-27 11:03:47 -04:00
|
|
|
vector[j].obj,storekey!=NULL);
|
2010-06-21 18:07:48 -04:00
|
|
|
|
2015-07-27 03:41:48 -04:00
|
|
|
if (sop->type == SORT_OP_GET) {
|
2010-06-21 18:07:48 -04:00
|
|
|
if (!val) {
|
2018-11-30 03:41:54 -05:00
|
|
|
addReplyNull(c);
|
2010-06-21 18:07:48 -04:00
|
|
|
} else {
|
|
|
|
addReplyBulk(c,val);
|
|
|
|
decrRefCount(val);
|
|
|
|
}
|
|
|
|
} else {
|
2011-10-04 12:43:03 -04:00
|
|
|
/* Always fails */
|
2015-07-27 03:41:48 -04:00
|
|
|
serverAssertWithInfo(c,sortval,sop->type == SORT_OP_GET);
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
2014-11-13 14:11:47 -05:00
|
|
|
robj *sobj = createQuicklistObject();
|
2010-06-21 18:07:48 -04:00
|
|
|
|
|
|
|
/* STORE option specified, set the sorting result as a List object */
|
|
|
|
for (j = start; j <= end; j++) {
|
|
|
|
listNode *ln;
|
|
|
|
listIter li;
|
|
|
|
|
|
|
|
if (!getop) {
|
2015-07-27 03:41:48 -04:00
|
|
|
listTypePush(sobj,vector[j].obj,LIST_TAIL);
|
2010-06-21 18:07:48 -04:00
|
|
|
} else {
|
|
|
|
listRewind(operations,&li);
|
|
|
|
while((ln = listNext(&li))) {
|
|
|
|
redisSortOperation *sop = ln->value;
|
|
|
|
robj *val = lookupKeyByPattern(c->db,sop->pattern,
|
2018-09-27 11:03:47 -04:00
|
|
|
vector[j].obj,storekey!=NULL);
|
2010-06-21 18:07:48 -04:00
|
|
|
|
2015-07-27 03:41:48 -04:00
|
|
|
if (sop->type == SORT_OP_GET) {
|
2010-06-21 18:07:48 -04:00
|
|
|
if (!val) val = createStringObject("",0);
|
|
|
|
|
|
|
|
/* listTypePush does an incrRefCount, so we should take care
|
|
|
|
* care of the incremented refcount caused by either
|
|
|
|
* lookupKeyByPattern or createStringObject("",0) */
|
2015-07-27 03:41:48 -04:00
|
|
|
listTypePush(sobj,val,LIST_TAIL);
|
2010-06-21 18:07:48 -04:00
|
|
|
decrRefCount(val);
|
|
|
|
} else {
|
2011-10-04 12:43:03 -04:00
|
|
|
/* Always fails */
|
2015-07-27 03:41:48 -04:00
|
|
|
serverAssertWithInfo(c,sortval,sop->type == SORT_OP_GET);
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2012-01-30 01:36:49 -05:00
|
|
|
if (outputlen) {
|
2020-04-21 04:51:46 -04:00
|
|
|
setKey(c,c->db,storekey,sobj);
|
2015-07-27 03:41:48 -04:00
|
|
|
notifyKeyspaceEvent(NOTIFY_LIST,"sortstore",storekey,
|
2013-01-25 07:19:08 -05:00
|
|
|
c->db->id);
|
2012-01-30 01:36:49 -05:00
|
|
|
server.dirty += outputlen;
|
|
|
|
} else if (dbDelete(c->db,storekey)) {
|
2020-04-21 04:51:46 -04:00
|
|
|
signalModifiedKey(c,c->db,storekey);
|
2015-07-27 03:41:48 -04:00
|
|
|
notifyKeyspaceEvent(NOTIFY_GENERIC,"del",storekey,c->db->id);
|
2012-01-30 01:36:49 -05:00
|
|
|
server.dirty++;
|
|
|
|
}
|
2011-06-14 09:34:27 -04:00
|
|
|
decrRefCount(sobj);
|
2010-09-02 08:30:56 -04:00
|
|
|
addReplyLongLong(c,outputlen);
|
2010-06-21 18:07:48 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Cleanup */
|
2015-09-04 04:09:32 -04:00
|
|
|
for (j = 0; j < vectorlen; j++)
|
|
|
|
decrRefCount(vector[j].obj);
|
|
|
|
|
2010-06-21 18:07:48 -04:00
|
|
|
decrRefCount(sortval);
|
|
|
|
listRelease(operations);
|
|
|
|
for (j = 0; j < vectorlen; j++) {
|
|
|
|
if (alpha && vector[j].u.cmpobj)
|
|
|
|
decrRefCount(vector[j].u.cmpobj);
|
|
|
|
}
|
|
|
|
zfree(vector);
|
|
|
|
}
|