2012-05-19 04:33:20 -04:00
|
|
|
#include "redis.h"
|
|
|
|
|
|
|
|
/* -----------------------------------------------------------------------------
|
2012-05-19 10:16:25 -04:00
|
|
|
* Helpers and low level bit functions.
|
2012-05-19 04:33:20 -04:00
|
|
|
* -------------------------------------------------------------------------- */
|
|
|
|
|
|
|
|
/* This helper function used by GETBIT / SETBIT parses the bit offset arguemnt
|
|
|
|
* making sure an error is returned if it is negative or if it overflows
|
|
|
|
* Redis 512 MB limit for the string value. */
|
|
|
|
static int getBitOffsetFromArgument(redisClient *c, robj *o, size_t *offset) {
|
|
|
|
long long loffset;
|
|
|
|
char *err = "bit offset is not an integer or out of range";
|
|
|
|
|
|
|
|
if (getLongLongFromObjectOrReply(c,o,&loffset,err) != REDIS_OK)
|
|
|
|
return REDIS_ERR;
|
|
|
|
|
|
|
|
/* Limit offset to 512MB in bytes */
|
|
|
|
if ((loffset < 0) || ((unsigned long long)loffset >> 3) >= (512*1024*1024))
|
|
|
|
{
|
|
|
|
addReplyError(c,err);
|
|
|
|
return REDIS_ERR;
|
|
|
|
}
|
|
|
|
|
|
|
|
*offset = (size_t)loffset;
|
|
|
|
return REDIS_OK;
|
|
|
|
}
|
|
|
|
|
2012-05-19 10:16:25 -04:00
|
|
|
/* Count number of bits set in the binary array pointed by 's' and long
|
|
|
|
* 'count' bytes. The implementation of this function is required to
|
|
|
|
* work with a input string length up to 512 MB. */
|
|
|
|
long popcount(void *s, long count) {
|
|
|
|
long bits = 0;
|
2012-05-19 18:49:35 -04:00
|
|
|
unsigned char *p;
|
|
|
|
uint32_t *p4 = s;
|
2012-05-19 10:16:25 -04:00
|
|
|
static const unsigned char bitsinbyte[256] = {0,1,1,2,1,2,2,3,1,2,2,3,2,3,3,4,1,2,2,3,2,3,3,4,2,3,3,4,3,4,4,5,1,2,2,3,2,3,3,4,2,3,3,4,3,4,4,5,2,3,3,4,3,4,4,5,3,4,4,5,4,5,5,6,1,2,2,3,2,3,3,4,2,3,3,4,3,4,4,5,2,3,3,4,3,4,4,5,3,4,4,5,4,5,5,6,2,3,3,4,3,4,4,5,3,4,4,5,4,5,5,6,3,4,4,5,4,5,5,6,4,5,5,6,5,6,6,7,1,2,2,3,2,3,3,4,2,3,3,4,3,4,4,5,2,3,3,4,3,4,4,5,3,4,4,5,4,5,5,6,2,3,3,4,3,4,4,5,3,4,4,5,4,5,5,6,3,4,4,5,4,5,5,6,4,5,5,6,5,6,6,7,2,3,3,4,3,4,4,5,3,4,4,5,4,5,5,6,3,4,4,5,4,5,5,6,4,5,5,6,5,6,6,7,3,4,4,5,4,5,5,6,4,5,5,6,5,6,6,7,4,5,5,6,5,6,6,7,5,6,6,7,6,7,7,8};
|
|
|
|
|
2012-05-20 15:34:58 -04:00
|
|
|
/* Count bits 16 bytes at a time */
|
|
|
|
while(count>=16) {
|
|
|
|
uint32_t aux1, aux2, aux3, aux4;
|
|
|
|
|
|
|
|
aux1 = *p4++;
|
|
|
|
aux2 = *p4++;
|
|
|
|
aux3 = *p4++;
|
|
|
|
aux4 = *p4++;
|
|
|
|
count -= 16;
|
|
|
|
|
|
|
|
aux1 = aux1 - ((aux1 >> 1) & 0x55555555);
|
|
|
|
aux1 = (aux1 & 0x33333333) + ((aux1 >> 2) & 0x33333333);
|
|
|
|
aux2 = aux2 - ((aux2 >> 1) & 0x55555555);
|
|
|
|
aux2 = (aux2 & 0x33333333) + ((aux2 >> 2) & 0x33333333);
|
|
|
|
aux3 = aux3 - ((aux3 >> 1) & 0x55555555);
|
|
|
|
aux3 = (aux3 & 0x33333333) + ((aux3 >> 2) & 0x33333333);
|
|
|
|
aux4 = aux4 - ((aux4 >> 1) & 0x55555555);
|
|
|
|
aux4 = (aux4 & 0x33333333) + ((aux4 >> 2) & 0x33333333);
|
|
|
|
bits += ((((aux1 + (aux1 >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24) +
|
|
|
|
((((aux2 + (aux2 >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24) +
|
|
|
|
((((aux3 + (aux3 >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24) +
|
|
|
|
((((aux4 + (aux4 >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24);
|
2012-05-19 18:49:35 -04:00
|
|
|
}
|
|
|
|
/* Count the remaining bytes */
|
|
|
|
p = (unsigned char*)p4;
|
2012-05-19 10:16:25 -04:00
|
|
|
while(count--) bits += bitsinbyte[*p++];
|
|
|
|
return bits;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* Bits related string commands: GETBIT, SETBIT, BITCOUNT, BITOP.
|
|
|
|
* -------------------------------------------------------------------------- */
|
|
|
|
|
|
|
|
#define BITOP_AND 0
|
|
|
|
#define BITOP_OR 1
|
|
|
|
#define BITOP_XOR 2
|
|
|
|
#define BITOP_NOT 3
|
|
|
|
|
2012-05-19 04:33:20 -04:00
|
|
|
/* SETBIT key offset bitvalue */
|
|
|
|
void setbitCommand(redisClient *c) {
|
|
|
|
robj *o;
|
|
|
|
char *err = "bit is not an integer or out of range";
|
|
|
|
size_t bitoffset;
|
|
|
|
int byte, bit;
|
|
|
|
int byteval, bitval;
|
|
|
|
long on;
|
|
|
|
|
|
|
|
if (getBitOffsetFromArgument(c,c->argv[2],&bitoffset) != REDIS_OK)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (getLongFromObjectOrReply(c,c->argv[3],&on,err) != REDIS_OK)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* Bits can only be set or cleared... */
|
|
|
|
if (on & ~1) {
|
|
|
|
addReplyError(c,err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
o = lookupKeyWrite(c->db,c->argv[1]);
|
|
|
|
if (o == NULL) {
|
|
|
|
o = createObject(REDIS_STRING,sdsempty());
|
|
|
|
dbAdd(c->db,c->argv[1],o);
|
|
|
|
} else {
|
|
|
|
if (checkType(c,o,REDIS_STRING)) return;
|
|
|
|
|
|
|
|
/* Create a copy when the object is shared or encoded. */
|
|
|
|
if (o->refcount != 1 || o->encoding != REDIS_ENCODING_RAW) {
|
|
|
|
robj *decoded = getDecodedObject(o);
|
|
|
|
o = createStringObject(decoded->ptr, sdslen(decoded->ptr));
|
|
|
|
decrRefCount(decoded);
|
|
|
|
dbOverwrite(c->db,c->argv[1],o);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Grow sds value to the right length if necessary */
|
|
|
|
byte = bitoffset >> 3;
|
|
|
|
o->ptr = sdsgrowzero(o->ptr,byte+1);
|
|
|
|
|
|
|
|
/* Get current values */
|
|
|
|
byteval = ((char*)o->ptr)[byte];
|
|
|
|
bit = 7 - (bitoffset & 0x7);
|
|
|
|
bitval = byteval & (1 << bit);
|
|
|
|
|
|
|
|
/* Update byte with new bit value and return original value */
|
|
|
|
byteval &= ~(1 << bit);
|
|
|
|
byteval |= ((on & 0x1) << bit);
|
|
|
|
((char*)o->ptr)[byte] = byteval;
|
|
|
|
signalModifiedKey(c->db,c->argv[1]);
|
|
|
|
server.dirty++;
|
|
|
|
addReply(c, bitval ? shared.cone : shared.czero);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* GETBIT key offset */
|
|
|
|
void getbitCommand(redisClient *c) {
|
|
|
|
robj *o;
|
|
|
|
char llbuf[32];
|
|
|
|
size_t bitoffset;
|
|
|
|
size_t byte, bit;
|
|
|
|
size_t bitval = 0;
|
|
|
|
|
|
|
|
if (getBitOffsetFromArgument(c,c->argv[2],&bitoffset) != REDIS_OK)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if ((o = lookupKeyReadOrReply(c,c->argv[1],shared.czero)) == NULL ||
|
|
|
|
checkType(c,o,REDIS_STRING)) return;
|
|
|
|
|
|
|
|
byte = bitoffset >> 3;
|
|
|
|
bit = 7 - (bitoffset & 0x7);
|
|
|
|
if (o->encoding != REDIS_ENCODING_RAW) {
|
|
|
|
if (byte < (size_t)ll2string(llbuf,sizeof(llbuf),(long)o->ptr))
|
|
|
|
bitval = llbuf[byte] & (1 << bit);
|
|
|
|
} else {
|
|
|
|
if (byte < sdslen(o->ptr))
|
|
|
|
bitval = ((char*)o->ptr)[byte] & (1 << bit);
|
|
|
|
}
|
|
|
|
|
|
|
|
addReply(c, bitval ? shared.cone : shared.czero);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* BITOP op_name target_key src_key1 src_key2 src_key3 ... src_keyN */
|
|
|
|
void bitopCommand(redisClient *c) {
|
|
|
|
char *opname = c->argv[1]->ptr;
|
|
|
|
robj *o, *targetkey = c->argv[2];
|
|
|
|
long op, j, numkeys;
|
2012-05-22 11:40:20 -04:00
|
|
|
robj **objects; /* Array of soruce objects. */
|
2012-05-19 04:33:20 -04:00
|
|
|
unsigned char **src; /* Array of source strings pointers. */
|
|
|
|
long *len, maxlen = 0; /* Array of length of src strings, and max len. */
|
BITOP command 10x speed improvement.
This commit adds a fast-path to the BITOP that can be used for all the
bytes from 0 to the minimal length of the string, and if there are
at max 16 input keys.
Often the intersected bitmaps are roughly the same size, so this
optimization can provide a 10x speed boost to most real world usages
of the command.
Bytes are processed four full words at a time, in loops specialized
for the specific BITOP sub-command, without the need to check for
length issues with the inputs (since we run this algorithm only as far
as there is data from all the keys at the same time).
The remaining part of the string is intersected in the usual way using
the slow but generic algorith.
It is possible to do better than this with inputs that are not roughly
the same size, sorting the input keys by length, by initializing the
result string in a smarter way, and noticing that the final part of the
output string composed of only data from the longest string does not
need any proecessing since AND, OR and XOR against an empty string does
not alter the output (zero in the first case, and the original string in
the other two cases).
More implementations will be implemented later likely, but this should
be enough to release Redis 2.6-RC4 with bitops merged in.
Note: this commit also adds better testing for BITOP NOT command, that
is currently the faster and hard to optimize further since it just
flips the bits of a single input string.
2012-05-23 16:12:50 -04:00
|
|
|
long minlen = 0; /* Min len among the input keys. */
|
2012-05-19 04:33:20 -04:00
|
|
|
unsigned char *res = NULL; /* Resulting string. */
|
|
|
|
|
|
|
|
/* Parse the operation name. */
|
|
|
|
if ((opname[0] == 'a' || opname[0] == 'A') && !strcasecmp(opname,"and"))
|
|
|
|
op = BITOP_AND;
|
|
|
|
else if((opname[0] == 'o' || opname[0] == 'O') && !strcasecmp(opname,"or"))
|
|
|
|
op = BITOP_OR;
|
|
|
|
else if((opname[0] == 'x' || opname[0] == 'X') && !strcasecmp(opname,"xor"))
|
|
|
|
op = BITOP_XOR;
|
|
|
|
else if((opname[0] == 'n' || opname[0] == 'N') && !strcasecmp(opname,"not"))
|
|
|
|
op = BITOP_NOT;
|
|
|
|
else {
|
|
|
|
addReply(c,shared.syntaxerr);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Sanity check: NOT accepts only a single key argument. */
|
|
|
|
if (op == BITOP_NOT && c->argc != 4) {
|
|
|
|
addReplyError(c,"BITOP NOT must be called with a single source key.");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Lookup keys, and store pointers to the string objects into an array. */
|
|
|
|
numkeys = c->argc - 3;
|
|
|
|
src = zmalloc(sizeof(unsigned char*) * numkeys);
|
|
|
|
len = zmalloc(sizeof(long) * numkeys);
|
2012-05-22 11:40:20 -04:00
|
|
|
objects = zmalloc(sizeof(robj*) * numkeys);
|
2012-05-19 04:33:20 -04:00
|
|
|
for (j = 0; j < numkeys; j++) {
|
|
|
|
o = lookupKeyRead(c->db,c->argv[j+3]);
|
|
|
|
/* Handle non-existing keys as empty strings. */
|
|
|
|
if (o == NULL) {
|
2012-05-22 11:40:20 -04:00
|
|
|
objects[j] = NULL;
|
2012-05-19 04:33:20 -04:00
|
|
|
src[j] = NULL;
|
|
|
|
len[j] = 0;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
/* Return an error if one of the keys is not a string. */
|
|
|
|
if (checkType(c,o,REDIS_STRING)) {
|
2012-05-22 11:40:20 -04:00
|
|
|
for (j = j-1; j >= 0; j--) {
|
|
|
|
if (objects[j])
|
|
|
|
decrRefCount(objects[j]);
|
|
|
|
}
|
2012-05-19 04:33:20 -04:00
|
|
|
zfree(src);
|
|
|
|
zfree(len);
|
2012-05-22 11:40:20 -04:00
|
|
|
zfree(objects);
|
2012-05-19 04:33:20 -04:00
|
|
|
return;
|
|
|
|
}
|
2012-05-22 11:40:20 -04:00
|
|
|
objects[j] = getDecodedObject(o);
|
|
|
|
src[j] = objects[j]->ptr;
|
|
|
|
len[j] = sdslen(objects[j]->ptr);
|
2012-05-19 04:33:20 -04:00
|
|
|
if (len[j] > maxlen) maxlen = len[j];
|
BITOP command 10x speed improvement.
This commit adds a fast-path to the BITOP that can be used for all the
bytes from 0 to the minimal length of the string, and if there are
at max 16 input keys.
Often the intersected bitmaps are roughly the same size, so this
optimization can provide a 10x speed boost to most real world usages
of the command.
Bytes are processed four full words at a time, in loops specialized
for the specific BITOP sub-command, without the need to check for
length issues with the inputs (since we run this algorithm only as far
as there is data from all the keys at the same time).
The remaining part of the string is intersected in the usual way using
the slow but generic algorith.
It is possible to do better than this with inputs that are not roughly
the same size, sorting the input keys by length, by initializing the
result string in a smarter way, and noticing that the final part of the
output string composed of only data from the longest string does not
need any proecessing since AND, OR and XOR against an empty string does
not alter the output (zero in the first case, and the original string in
the other two cases).
More implementations will be implemented later likely, but this should
be enough to release Redis 2.6-RC4 with bitops merged in.
Note: this commit also adds better testing for BITOP NOT command, that
is currently the faster and hard to optimize further since it just
flips the bits of a single input string.
2012-05-23 16:12:50 -04:00
|
|
|
if (j == 0 || len[j] < minlen) minlen = len[j];
|
2012-05-19 04:33:20 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Compute the bit operation, if at least one string is not empty. */
|
|
|
|
if (maxlen) {
|
|
|
|
res = (unsigned char*) sdsnewlen(NULL,maxlen);
|
|
|
|
unsigned char output, byte;
|
|
|
|
long i;
|
|
|
|
|
BITOP command 10x speed improvement.
This commit adds a fast-path to the BITOP that can be used for all the
bytes from 0 to the minimal length of the string, and if there are
at max 16 input keys.
Often the intersected bitmaps are roughly the same size, so this
optimization can provide a 10x speed boost to most real world usages
of the command.
Bytes are processed four full words at a time, in loops specialized
for the specific BITOP sub-command, without the need to check for
length issues with the inputs (since we run this algorithm only as far
as there is data from all the keys at the same time).
The remaining part of the string is intersected in the usual way using
the slow but generic algorith.
It is possible to do better than this with inputs that are not roughly
the same size, sorting the input keys by length, by initializing the
result string in a smarter way, and noticing that the final part of the
output string composed of only data from the longest string does not
need any proecessing since AND, OR and XOR against an empty string does
not alter the output (zero in the first case, and the original string in
the other two cases).
More implementations will be implemented later likely, but this should
be enough to release Redis 2.6-RC4 with bitops merged in.
Note: this commit also adds better testing for BITOP NOT command, that
is currently the faster and hard to optimize further since it just
flips the bits of a single input string.
2012-05-23 16:12:50 -04:00
|
|
|
/* Fast path: as far as we have data for all the input bitmaps we
|
|
|
|
* can take a fast path that performs much better than the
|
|
|
|
* vanilla algorithm. */
|
|
|
|
j = 0;
|
|
|
|
if (minlen && numkeys <= 16) {
|
|
|
|
unsigned long *lp[16];
|
|
|
|
unsigned long *lres = (unsigned long*) res;
|
|
|
|
|
|
|
|
/* Note: sds pointer is always aligned to 8 byte boundary. */
|
|
|
|
memcpy(lp,src,sizeof(unsigned long*)*numkeys);
|
|
|
|
memcpy(res,src[0],minlen);
|
|
|
|
|
|
|
|
/* Different branches per different operations for speed (sorry). */
|
|
|
|
if (op == BITOP_AND) {
|
|
|
|
while(minlen >= sizeof(unsigned long)*4) {
|
|
|
|
for (i = 1; i < numkeys; i++) {
|
|
|
|
lres[0] &= lp[i][0];
|
|
|
|
lres[1] &= lp[i][1];
|
|
|
|
lres[2] &= lp[i][2];
|
|
|
|
lres[3] &= lp[i][3];
|
|
|
|
lp[i]+=4;
|
|
|
|
}
|
|
|
|
lres+=4;
|
|
|
|
j += sizeof(unsigned long)*4;
|
|
|
|
minlen -= sizeof(unsigned long)*4;
|
|
|
|
}
|
|
|
|
} else if (op == BITOP_OR) {
|
|
|
|
while(minlen >= sizeof(unsigned long)*4) {
|
|
|
|
for (i = 1; i < numkeys; i++) {
|
|
|
|
lres[0] |= lp[i][0];
|
|
|
|
lres[1] |= lp[i][1];
|
|
|
|
lres[2] |= lp[i][2];
|
|
|
|
lres[3] |= lp[i][3];
|
|
|
|
lp[i]+=4;
|
|
|
|
}
|
|
|
|
lres+=4;
|
|
|
|
j += sizeof(unsigned long)*4;
|
|
|
|
minlen -= sizeof(unsigned long)*4;
|
|
|
|
}
|
|
|
|
} else if (op == BITOP_XOR) {
|
|
|
|
while(minlen >= sizeof(unsigned long)*4) {
|
|
|
|
for (i = 1; i < numkeys; i++) {
|
|
|
|
lres[0] ^= lp[i][0];
|
|
|
|
lres[1] ^= lp[i][1];
|
|
|
|
lres[2] ^= lp[i][2];
|
|
|
|
lres[3] ^= lp[i][3];
|
|
|
|
lp[i]+=4;
|
|
|
|
}
|
|
|
|
lres+=4;
|
|
|
|
j += sizeof(unsigned long)*4;
|
|
|
|
minlen -= sizeof(unsigned long)*4;
|
|
|
|
}
|
|
|
|
} else if (op == BITOP_NOT) {
|
|
|
|
while(minlen >= sizeof(unsigned long)*4) {
|
|
|
|
lres[0] = ~lres[0];
|
|
|
|
lres[1] = ~lres[1];
|
|
|
|
lres[2] = ~lres[2];
|
|
|
|
lres[3] = ~lres[3];
|
|
|
|
lres+=4;
|
|
|
|
j += sizeof(unsigned long)*4;
|
|
|
|
minlen -= sizeof(unsigned long)*4;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* j is set to the next byte to process by the previous loop. */
|
|
|
|
for (; j < maxlen; j++) {
|
2012-05-19 04:33:20 -04:00
|
|
|
output = (len[0] <= j) ? 0 : src[0][j];
|
|
|
|
if (op == BITOP_NOT) output = ~output;
|
|
|
|
for (i = 1; i < numkeys; i++) {
|
|
|
|
byte = (len[i] <= j) ? 0 : src[i][j];
|
|
|
|
switch(op) {
|
|
|
|
case BITOP_AND: output &= byte; break;
|
|
|
|
case BITOP_OR: output |= byte; break;
|
|
|
|
case BITOP_XOR: output ^= byte; break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
res[j] = output;
|
|
|
|
}
|
|
|
|
}
|
2012-05-22 11:40:20 -04:00
|
|
|
for (j = 0; j < numkeys; j++) {
|
|
|
|
if (objects[j])
|
|
|
|
decrRefCount(objects[j]);
|
|
|
|
}
|
2012-05-19 04:33:20 -04:00
|
|
|
zfree(src);
|
|
|
|
zfree(len);
|
2012-05-22 11:40:20 -04:00
|
|
|
zfree(objects);
|
2012-05-19 04:33:20 -04:00
|
|
|
|
|
|
|
/* Store the computed value into the target key */
|
|
|
|
if (maxlen) {
|
|
|
|
o = createObject(REDIS_STRING,res);
|
|
|
|
setKey(c->db,targetkey,o);
|
|
|
|
decrRefCount(o);
|
|
|
|
} else if (dbDelete(c->db,targetkey)) {
|
|
|
|
signalModifiedKey(c->db,targetkey);
|
|
|
|
}
|
|
|
|
server.dirty++;
|
|
|
|
addReplyLongLong(c,maxlen); /* Return the output string length in bytes. */
|
|
|
|
}
|
|
|
|
|
|
|
|
/* BITCOUNT key [start end] */
|
|
|
|
void bitcountCommand(redisClient *c) {
|
|
|
|
robj *o;
|
|
|
|
long start, end;
|
|
|
|
unsigned char *p;
|
|
|
|
char llbuf[32];
|
|
|
|
size_t strlen;
|
|
|
|
|
|
|
|
/* Lookup, check for type, and return 0 for non existing keys. */
|
|
|
|
if ((o = lookupKeyReadOrReply(c,c->argv[1],shared.czero)) == NULL ||
|
|
|
|
checkType(c,o,REDIS_STRING)) return;
|
|
|
|
|
|
|
|
/* Set the 'p' pointer to the string, that can be just a stack allocated
|
|
|
|
* array if our string was integer encoded. */
|
|
|
|
if (o->encoding == REDIS_ENCODING_INT) {
|
|
|
|
p = (unsigned char*) llbuf;
|
|
|
|
strlen = ll2string(llbuf,sizeof(llbuf),(long)o->ptr);
|
|
|
|
} else {
|
|
|
|
p = (unsigned char*) o->ptr;
|
|
|
|
strlen = sdslen(o->ptr);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Parse start/end range if any. */
|
|
|
|
if (c->argc == 4) {
|
|
|
|
if (getLongFromObjectOrReply(c,c->argv[2],&start,NULL) != REDIS_OK)
|
|
|
|
return;
|
|
|
|
if (getLongFromObjectOrReply(c,c->argv[3],&end,NULL) != REDIS_OK)
|
|
|
|
return;
|
|
|
|
/* Convert negative indexes */
|
|
|
|
if (start < 0) start = strlen+start;
|
|
|
|
if (end < 0) end = strlen+end;
|
|
|
|
if (start < 0) start = 0;
|
|
|
|
if (end < 0) end = 0;
|
|
|
|
if ((unsigned)end >= strlen) end = strlen-1;
|
|
|
|
} else if (c->argc == 2) {
|
|
|
|
/* The whole string. */
|
|
|
|
start = 0;
|
|
|
|
end = strlen-1;
|
|
|
|
} else {
|
|
|
|
/* Syntax error. */
|
|
|
|
addReply(c,shared.syntaxerr);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Precondition: end >= 0 && end < strlen, so the only condition where
|
|
|
|
* zero can be returned is: start > end. */
|
|
|
|
if (start > end) {
|
|
|
|
addReply(c,shared.czero);
|
|
|
|
} else {
|
2012-05-19 10:16:25 -04:00
|
|
|
long bytes = end-start+1;
|
2012-05-19 04:33:20 -04:00
|
|
|
|
2012-05-19 10:16:25 -04:00
|
|
|
addReplyLongLong(c,popcount(p+start,bytes));
|
2012-05-19 04:33:20 -04:00
|
|
|
}
|
|
|
|
}
|