2010-06-22 00:07:48 +02:00
/*
2016-10-06 08:48:21 +02:00
* Copyright ( c ) 2009 - 2016 , Salvatore Sanfilippo < antirez at gmail dot com >
2010-06-22 00:07:48 +02:00
* All rights reserved .
*
* Redistribution and use in source and binary forms , with or without
* modification , are permitted provided that the following conditions are met :
*
* * Redistributions of source code must retain the above copyright notice ,
* this list of conditions and the following disclaimer .
* * Redistributions in binary form must reproduce the above copyright
* notice , this list of conditions and the following disclaimer in the
* documentation and / or other materials provided with the distribution .
* * Neither the name of Redis nor the names of its contributors may be used
* to endorse or promote products derived from this software without
* specific prior written permission .
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS " AS IS "
* AND ANY EXPRESS OR IMPLIED WARRANTIES , INCLUDING , BUT NOT LIMITED TO , THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED . IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT , INDIRECT , INCIDENTAL , SPECIAL , EXEMPLARY , OR
* CONSEQUENTIAL DAMAGES ( INCLUDING , BUT NOT LIMITED TO , PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES ; LOSS OF USE , DATA , OR PROFITS ; OR BUSINESS
* INTERRUPTION ) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY , WHETHER IN
* CONTRACT , STRICT LIABILITY , OR TORT ( INCLUDING NEGLIGENCE OR OTHERWISE )
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE , EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE .
*/
2015-07-26 15:14:57 +02:00
# include "server.h"
2020-08-28 01:54:10 -07:00
# include "monotonic.h"
2013-10-09 15:37:20 +02:00
# include "cluster.h"
2011-06-30 13:27:32 +02:00
# include "slowlog.h"
2011-09-13 16:10:26 +02:00
# include "bio.h"
2014-11-12 10:55:47 +01:00
# include "latency.h"
2017-05-09 11:57:09 +02:00
# include "atomicvar.h"
2010-06-22 00:07:48 +02:00
# include <time.h>
# include <signal.h>
# include <sys/wait.h>
# include <errno.h>
# include <assert.h>
# include <ctype.h>
# include <stdarg.h>
# include <arpa/inet.h>
# include <sys/stat.h>
# include <fcntl.h>
# include <sys/time.h>
# include <sys/resource.h>
# include <sys/uio.h>
2014-11-11 11:05:10 +01:00
# include <sys/un.h>
2010-06-22 00:07:48 +02:00
# include <limits.h>
# include <float.h>
# include <math.h>
2010-09-16 13:28:58 +02:00
# include <sys/resource.h>
2012-04-04 15:38:13 +02:00
# include <sys/utsname.h>
2013-07-12 12:06:05 +02:00
# include <locale.h>
2015-05-05 22:51:27 +09:00
# include <sys/socket.h>
2010-06-22 00:07:48 +02:00
/* Our shared "common" objects */
struct sharedObjectsStruct shared ;
2011-08-26 21:40:18 +03:00
/* Global vars that are actually used as constants. The following double
2010-06-22 00:07:48 +02:00
* values are used for double on - disk serialization , and are initialized
* at runtime to avoid strange compiler optimizations . */
double R_Zero , R_PosInf , R_NegInf , R_Nan ;
/*================================= Globals ================================= */
/* Global vars */
2017-05-09 11:57:09 +02:00
struct redisServer server ; /* Server global state */
2011-09-26 15:40:39 +02:00
2011-11-22 10:13:45 +01:00
/* Our command table.
*
* Every entry is composed of the following fields :
*
2019-01-23 11:21:02 +01:00
* name : A string representing the command name .
*
* function : Pointer to the C function implementing the command .
*
* arity : Number of arguments , it is possible to use - N to say > = N
*
* sflags : Command flags as string . See below for a table of flags .
*
* flags : Flags as bitmask . Computed by Redis using the ' sflags ' field .
*
* get_keys_proc : An optional function to get key arguments from a command .
2011-11-22 10:13:45 +01:00
* This is only used when the following three fields are not
* enough to specify what arguments are keys .
2019-01-23 11:21:02 +01:00
*
* first_key_index : First argument that is a key
*
* last_key_index : Last argument that is a key
*
* key_step : Step to get all the keys from first to last argument .
* For instance in MSET the step is two since arguments
* are key , val , key , val , . . .
*
* microseconds : Microseconds of total execution time for this command .
*
* calls : Total number of calls of this command .
*
* id : Command bit identifier for ACLs or other goals .
2011-11-22 10:13:45 +01:00
*
* The flags , microseconds and calls fields are computed by Redis and should
* always be set to zero .
*
2019-01-22 13:29:06 +01:00
* Command flags are expressed using space separated strings , that are turned
* into actual flags by the populateCommandTable ( ) function .
2011-09-26 15:40:39 +02:00
*
* This is the meaning of the flags :
*
2019-01-23 11:21:02 +01:00
* write : Write command ( may modify the key space ) .
*
* read - only : All the non special commands just reading from keys without
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* changing the content , or returning other information like
2019-01-23 11:21:02 +01:00
* the TIME command . Special commands such administrative commands
* or transaction related commands ( multi , exec , discard , . . . )
* are not flagged as read - only commands , since they affect the
* server or the connection in other ways .
*
* use - memory : May increase memory usage once called . Don ' t allow if out
* of memory .
*
* admin : Administrative command , like SAVE or SHUTDOWN .
*
* pub - sub : Pub / Sub related command .
*
* no - script : Command not allowed in scripts .
*
* random : Random command . Command is not deterministic , that is , the same
* command with the same arguments , with the same key space , may
* have different results . For instance SPOP and RANDOMKEY are
* two random commands .
*
* to - sort : Sort command output array if called from script , so that the
* output is deterministic . When this flag is used ( not always
* possible ) , then the " random " flag is not needed .
*
* ok - loading : Allow the command while loading the database .
*
* ok - stale : Allow the command while a slave has stale data but is not
* allowed to serve this data . Normally no command is accepted
* in this condition but just a few .
*
* no - monitor : Do not automatically propagate the command on MONITOR .
2019-10-24 11:20:15 +02:00
*
2019-07-19 10:22:40 -07:00
* no - slowlog : Do not automatically propagate the command to the slowlog .
2019-01-23 11:21:02 +01:00
*
* cluster - asking : Perform an implicit ASKING for this command , so the
* command will be accepted in cluster mode if the slot is marked
* as ' importing ' .
*
* fast : Fast command : O ( 1 ) or O ( log ( N ) ) command that should never
* delay its execution as long as the kernel scheduler is giving
* us time . Note that commands that may trigger a DEL as a side
* effect ( like SET ) are not fast commands .
2019-01-23 12:15:10 +01:00
*
* The following additional flags are only used in order to put commands
* in a specific ACL category . Commands can have multiple ACL categories .
*
* @ keyspace , @ read , @ write , @ set , @ sortedset , @ list , @ hash , @ string , @ bitmap ,
* @ hyperloglog , @ stream , @ admin , @ fast , @ slow , @ pubsub , @ blocking , @ dangerous ,
* @ connection , @ transaction , @ scripting , @ geo .
*
* Note that :
*
* 1 ) The read - only flag implies the @ read ACL category .
* 2 ) The write flag implies the @ write ACL category .
* 3 ) The fast flag implies the @ fast ACL category .
* 4 ) The admin flag implies the @ admin and @ dangerous ACL category .
* 5 ) The pub - sub flag implies the @ pubsub ACL category .
* 6 ) The lack of fast flag implies the @ slow ACL category .
* 7 ) The non obvious " keyspace " category includes the commands
* that interact with keys without having anything to do with
* specific data structures , such as : DEL , RENAME , MOVE , SELECT ,
* TYPE , EXPIRE * , PEXPIRE * , TTL , PTTL , . . .
2012-01-31 16:09:21 +01:00
*/
2019-01-22 13:29:06 +01:00
2011-01-24 10:56:06 +01:00
struct redisCommand redisCommandTable [ ] = {
2019-01-22 13:29:06 +01:00
{ " module " , moduleCommand , - 2 ,
" admin no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " get " , getCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
/* Note that we can't flag set as fast, since it may perform an
* implicit DEL of a large key . */
{ " set " , setCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " setnx " , setnxCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " setex " , setexCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " psetex " , psetexCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " append " , appendCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " strlen " , strlenCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2019-01-23 12:15:10 +01:00
{ " del " , delCommand , - 2 ,
" write @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " unlink " , unlinkCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " exists " , existsCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " setbit " , setbitCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @bitmap " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " getbit " , getbitCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @bitmap " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " bitfield " , bitfieldCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory @bitmap " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2020-03-04 20:51:45 +08:00
{ " bitfield_ro " , bitfieldroCommand , - 2 ,
" read-only fast @bitmap " ,
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " setrange " , setrangeCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " getrange " , getrangeCommand , 4 ,
2019-01-23 12:15:10 +01:00
" read-only @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " substr " , getrangeCommand , 4 ,
2019-01-23 12:15:10 +01:00
" read-only @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " incr " , incrCommand , 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " decr " , decrCommand , 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " mget " , mgetCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " rpush " , rpushCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " lpush " , lpushCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " rpushx " , rpushxCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " lpushx " , lpushxCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " linsert " , linsertCommand , 5 ,
2019-01-23 12:15:10 +01:00
" write use-memory @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " rpop " , rpopCommand , 2 ,
2019-01-23 12:15:10 +01:00
" write fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " lpop " , lpopCommand , 2 ,
2019-01-23 12:15:10 +01:00
" write fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " brpop " , brpopCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write no-script @list @blocking " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 2 , 1 , 0 , 0 , 0 } ,
{ " brpoplpush " , brpoplpushCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory no-script @list @blocking " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 2 , 1 , 0 , 0 , 0 } ,
{ " blpop " , blpopCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write no-script @list @blocking " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 2 , 1 , 0 , 0 , 0 } ,
{ " llen " , llenCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " lindex " , lindexCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " lset " , lsetCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " lrange " , lrangeCommand , 4 ,
2019-01-23 12:15:10 +01:00
" read-only @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " ltrim " , ltrimCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2020-06-10 12:40:24 +02:00
{ " lpos " , lposCommand , - 3 ,
" read-only @list " ,
2020-06-09 16:53:14 -04:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " lrem " , lremCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " rpoplpush " , rpoplpushCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @list " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 2 , 1 , 0 , 0 , 0 } ,
{ " sadd " , saddCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " srem " , sremCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write fast @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " smove " , smoveCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write fast @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 2 , 1 , 0 , 0 , 0 } ,
{ " sismember " , sismemberCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2020-08-11 04:55:06 -04:00
{ " smismember " , smismemberCommand , - 3 ,
" read-only fast @set " ,
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " scard " , scardCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " spop " , spopCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write random fast @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " srandmember " , srandmemberCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only random @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " sinter " , sinterCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " sinterstore " , sinterstoreCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " sunion " , sunionCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " sunionstore " , sunionstoreCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " sdiff " , sdiffCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " sdiffstore " , sdiffstoreCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " smembers " , sinterCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " sscan " , sscanCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" read-only random @set " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zadd " , zaddCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zincrby " , zincrbyCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrem " , zremCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zremrangebyscore " , zremrangebyscoreCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zremrangebyrank " , zremrangebyrankCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zremrangebylex " , zremrangebylexCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zunionstore " , zunionstoreCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @sortedset " ,
2020-09-11 16:59:15 +08:00
0 , zunionInterStoreGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " zinterstore " , zinterstoreCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @sortedset " ,
2020-09-11 16:59:15 +08:00
0 , zunionInterStoreGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " zunion " , zunionCommand , - 3 ,
" read-only @sortedset " ,
0 , zunionInterGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " zinter " , zinterCommand , - 3 ,
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , zunionInterGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " zrange " , zrangeCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrangebyscore " , zrangebyscoreCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrevrangebyscore " , zrevrangebyscoreCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrangebylex " , zrangebylexCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrevrangebylex " , zrevrangebylexCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zcount " , zcountCommand , 4 ,
2019-01-23 12:15:10 +01:00
" read-only fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zlexcount " , zlexcountCommand , 4 ,
2019-01-23 12:15:10 +01:00
" read-only fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrevrange " , zrevrangeCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zcard " , zcardCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zscore " , zscoreCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2020-08-04 10:49:33 -04:00
{ " zmscore " , zmscoreCommand , - 3 ,
" read-only fast @sortedset " ,
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " zrank " , zrankCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zrevrank " , zrevrankCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zscan " , zscanCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" read-only random @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zpopmin " , zpopminCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " zpopmax " , zpopmaxCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write fast @sortedset " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
2019-03-03 23:10:45 +02:00
{ " bzpopmin " , bzpopminCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write no-script fast @sortedset @blocking " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 2 , 1 , 0 , 0 , 0 } ,
2019-03-03 23:10:45 +02:00
{ " bzpopmax " , bzpopmaxCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write no-script fast @sortedset @blocking " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 2 , 1 , 0 , 0 , 0 } ,
{ " hset " , hsetCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hsetnx " , hsetnxCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hget " , hgetCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hmset " , hsetCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hmget " , hmgetCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hincrby " , hincrbyCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hincrbyfloat " , hincrbyfloatCommand , 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hdel " , hdelCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hlen " , hlenCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hstrlen " , hstrlenCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hkeys " , hkeysCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hvals " , hvalsCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hgetall " , hgetallCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only random @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hexists " , hexistsCommand , 3 ,
2019-01-23 12:15:10 +01:00
" read-only fast @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " hscan " , hscanCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" read-only random @hash " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " incrby " , incrbyCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " decrby " , decrbyCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " incrbyfloat " , incrbyfloatCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " getset " , getsetCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " mset " , msetCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 2 , 0 , 0 , 0 } ,
{ " msetnx " , msetnxCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory @string " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 2 , 0 , 0 , 0 } ,
{ " randomkey " , randomkeyCommand , 1 ,
2019-01-23 12:15:10 +01:00
" read-only random @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " select " , selectCommand , 2 ,
2020-02-06 08:53:23 +02:00
" ok-loading fast ok-stale @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " swapdb " , swapdbCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " move " , moveCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
/* Like for SET, we can't mark rename as a fast command because
* overwriting the target key may result in an implicit slow DEL . */
{ " rename " , renameCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 2 , 1 , 0 , 0 , 0 } ,
{ " renamenx " , renamenxCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 2 , 1 , 0 , 0 , 0 } ,
{ " expire " , expireCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " expireat " , expireatCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " pexpire " , pexpireCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " pexpireat " , pexpireatCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " keys " , keysCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only to-sort @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " scan " , scanCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only random @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " dbsize " , dbsizeCommand , 1 ,
2019-01-23 12:15:10 +01:00
" read-only fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " auth " , authCommand , - 2 ,
2019-02-26 01:23:11 +00:00
" no-auth no-script ok-loading ok-stale fast no-monitor no-slowlog @connection " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
/* We don't allow PING during loading since in Redis PING is used as
* failure detection , and a loading server is considered to be
* not available . */
{ " ping " , pingCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" ok-stale fast @connection " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " echo " , echoCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @connection " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " save " , saveCommand , 1 ,
" admin no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " bgsave " , bgsaveCommand , - 1 ,
" admin no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " bgrewriteaof " , bgrewriteaofCommand , 1 ,
" admin no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " shutdown " , shutdownCommand , - 1 ,
" admin no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " lastsave " , lastsaveCommand , 1 ,
2020-02-06 08:53:23 +02:00
" read-only random fast ok-loading ok-stale @admin @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " type " , typeCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " multi " , multiCommand , 1 ,
2020-02-25 16:51:35 +05:30
" no-script fast ok-loading ok-stale @transaction " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " exec " , execCommand , 1 ,
2020-02-25 16:51:35 +05:30
" no-script no-monitor no-slowlog ok-loading ok-stale @transaction " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " discard " , discardCommand , 1 ,
2020-02-25 16:51:35 +05:30
" no-script fast ok-loading ok-stale @transaction " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " sync " , syncCommand , 1 ,
" admin no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " psync " , syncCommand , 3 ,
" admin no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " replconf " , replconfCommand , - 1 ,
" admin no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " flushdb " , flushdbCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" write @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " flushall " , flushallCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" write @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " sort " , sortCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory @list @set @sortedset @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , sortGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " info " , infoCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" ok-loading ok-stale random @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " monitor " , monitorCommand , 1 ,
2020-02-06 08:53:23 +02:00
" admin no-script ok-loading ok-stale " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " ttl " , ttlCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast random @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " touch " , touchCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @keyspace " ,
2018-09-27 18:12:31 +03:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " pttl " , pttlCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast random @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " persist " , persistCommand , 2 ,
2019-01-23 12:15:10 +01:00
" write fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " slaveof " , replicaofCommand , 3 ,
" admin no-script ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " replicaof " , replicaofCommand , 3 ,
" admin no-script ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " role " , roleCommand , 1 ,
2019-01-23 12:15:10 +01:00
" ok-loading ok-stale no-script fast read-only @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " debug " , debugCommand , - 2 ,
2020-02-06 08:53:23 +02:00
" admin no-script ok-loading ok-stale " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " config " , configCommand , - 2 ,
" admin ok-loading ok-stale no-script " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " subscribe " , subscribeCommand , - 2 ,
" pub-sub no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " unsubscribe " , unsubscribeCommand , - 1 ,
" pub-sub no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " psubscribe " , psubscribeCommand , - 2 ,
" pub-sub no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " punsubscribe " , punsubscribeCommand , - 1 ,
" pub-sub no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " publish " , publishCommand , 3 ,
" pub-sub ok-loading ok-stale fast " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " pubsub " , pubsubCommand , - 2 ,
" pub-sub ok-loading ok-stale random " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " watch " , watchCommand , - 2 ,
2020-06-08 09:16:32 +03:00
" no-script fast ok-loading ok-stale @transaction " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " unwatch " , unwatchCommand , 1 ,
2020-06-08 09:16:32 +03:00
" no-script fast ok-loading ok-stale @transaction " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " cluster " , clusterCommand , - 2 ,
" admin ok-stale random " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " restore " , restoreCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " restore-asking " , restoreCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory cluster-asking @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " migrate " , migrateCommand , - 6 ,
2019-01-23 12:15:10 +01:00
" write random @keyspace @dangerous " ,
2019-01-22 13:29:06 +01:00
0 , migrateGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " asking " , askingCommand , 1 ,
2019-01-23 12:15:10 +01:00
" fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " readonly " , readonlyCommand , 1 ,
2019-01-23 12:15:10 +01:00
" fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " readwrite " , readwriteCommand , 1 ,
2019-01-23 12:15:10 +01:00
" fast @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " dump " , dumpCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only random @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " object " , objectCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only random @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 2 , 2 , 1 , 0 , 0 , 0 } ,
{ " memory " , memoryCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" random read-only " ,
2020-02-05 09:42:49 +02:00
0 , memoryGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
2019-01-22 13:29:06 +01:00
{ " client " , clientCommand , - 2 ,
2020-02-06 08:53:23 +02:00
" admin no-script random ok-loading ok-stale @connection " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " hello " , helloCommand , - 2 ,
2020-02-06 08:53:23 +02:00
" no-auth no-script fast no-monitor ok-loading ok-stale no-slowlog @connection " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
/* EVAL can modify the dataset, however it is not flagged as a write
* command since we do the check while running commands from Lua . */
{ " eval " , evalCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" no-script @scripting " ,
2019-01-22 13:29:06 +01:00
0 , evalGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " evalsha " , evalShaCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" no-script @scripting " ,
2019-01-22 13:29:06 +01:00
0 , evalGetKeys , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " slowlog " , slowlogCommand , - 2 ,
2020-02-06 08:53:23 +02:00
" admin random ok-loading ok-stale " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " script " , scriptCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" no-script @scripting " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " time " , timeCommand , 1 ,
2020-02-06 08:53:23 +02:00
" read-only random fast ok-loading ok-stale " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " bitop " , bitopCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write use-memory @bitmap " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 2 , - 1 , 1 , 0 , 0 , 0 } ,
{ " bitcount " , bitcountCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only @bitmap " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " bitpos " , bitposCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" read-only @bitmap " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " wait " , waitCommand , 3 ,
2019-01-23 12:15:10 +01:00
" no-script @keyspace " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
2018-09-27 18:12:31 +03:00
{ " command " , commandCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" ok-loading ok-stale random @connection " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " geoadd " , geoaddCommand , - 5 ,
2019-01-23 12:15:10 +01:00
" write use-memory @geo " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
/* GEORADIUS has store options that may write. */
{ " georadius " , georadiusCommand , - 6 ,
2019-01-23 12:15:10 +01:00
" write @geo " ,
2019-01-22 13:29:06 +01:00
0 , georadiusGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " georadius_ro " , georadiusroCommand , - 6 ,
2019-01-23 12:15:10 +01:00
" read-only @geo " ,
2019-01-22 13:29:06 +01:00
0 , georadiusGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " georadiusbymember " , georadiusbymemberCommand , - 5 ,
2019-01-23 12:15:10 +01:00
" write @geo " ,
2019-01-22 13:29:06 +01:00
0 , georadiusGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " georadiusbymember_ro " , georadiusbymemberroCommand , - 5 ,
2019-01-23 12:15:10 +01:00
" read-only @geo " ,
2019-01-22 13:29:06 +01:00
0 , georadiusGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " geohash " , geohashCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only @geo " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " geopos " , geoposCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only @geo " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " geodist " , geodistCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @geo " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " pfselftest " , pfselftestCommand , 1 ,
2019-01-23 12:15:10 +01:00
" admin @hyperloglog " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " pfadd " , pfaddCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @hyperloglog " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
/* Technically speaking PFCOUNT may change the key since it changes the
* final bytes in the HyperLogLog representation . However in this case
* we claim that the representation , even if accessible , is an internal
* affair , and the command is semantically read only . */
{ " pfcount " , pfcountCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only @hyperloglog " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " pfmerge " , pfmergeCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory @hyperloglog " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , - 1 , 1 , 0 , 0 , 0 } ,
{ " pfdebug " , pfdebugCommand , - 3 ,
" admin write " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " xadd " , xaddCommand , - 5 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast random @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xrange " , xrangeCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xrevrange " , xrevrangeCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" read-only @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xlen " , xlenCommand , 2 ,
2019-01-23 12:15:10 +01:00
" read-only fast @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xread " , xreadCommand , - 4 ,
2020-03-26 11:49:21 +02:00
" read-only @stream @blocking " ,
2019-01-22 13:29:06 +01:00
0 , xreadGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xreadgroup " , xreadCommand , - 7 ,
2020-03-26 11:49:21 +02:00
" write @stream @blocking " ,
2019-01-22 13:29:06 +01:00
0 , xreadGetKeys , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xgroup " , xgroupCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write use-memory @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 2 , 2 , 1 , 0 , 0 , 0 } ,
{ " xsetid " , xsetidCommand , 3 ,
2019-01-23 12:15:10 +01:00
" write use-memory fast @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xack " , xackCommand , - 4 ,
2019-01-23 12:15:10 +01:00
" write fast random @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xpending " , xpendingCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" read-only random @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xclaim " , xclaimCommand , - 6 ,
2019-01-23 12:15:10 +01:00
" write random fast @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xinfo " , xinfoCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" read-only random @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 2 , 2 , 1 , 0 , 0 , 0 } ,
{ " xdel " , xdelCommand , - 3 ,
2019-01-23 12:15:10 +01:00
" write fast @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " xtrim " , xtrimCommand , - 2 ,
2019-01-23 12:15:10 +01:00
" write random @stream " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 1 , 1 , 1 , 0 , 0 , 0 } ,
{ " post " , securityWarningCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" ok-loading ok-stale read-only " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " host: " , securityWarningCommand , - 1 ,
2019-01-23 12:15:10 +01:00
" ok-loading ok-stale read-only " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " latency " , latencyCommand , - 2 ,
" admin no-script ok-loading ok-stale " ,
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " lolwut " , lolwutCommand , - 1 ,
2019-01-23 11:14:39 +01:00
" read-only fast " ,
2019-01-22 13:29:06 +01:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
{ " acl " , aclCommand , - 2 ,
2019-10-29 15:10:07 -07:00
" admin no-script no-slowlog ok-loading ok-stale " ,
2020-04-01 16:10:18 +02:00
0 , NULL , 0 , 0 , 0 , 0 , 0 , 0 } ,
2020-04-24 16:49:27 +02:00
{ " stralgo " , stralgoCommand , - 2 ,
2020-04-27 13:35:17 +02:00
" read-only @string " ,
2020-04-01 16:10:18 +02:00
0 , lcsGetKeys , 0 , 0 , 0 , 0 , 0 , 0 }
2010-06-22 00:07:48 +02:00
} ;
/*============================ Utility functions ============================ */
2018-07-04 16:50:22 +02:00
/* We use a private localtime implementation which is fork-safe. The logging
* function of Redis may be called from other threads . */
void nolocks_localtime ( struct tm * tmp , time_t t , time_t tz , int dst ) ;
2011-02-09 10:10:35 +01:00
/* Low level logging. To use only for very big messages, otherwise
2015-07-26 15:17:43 +02:00
* serverLog ( ) is to prefer . */
void serverLogRaw ( int level , const char * msg ) {
2010-12-09 11:10:21 -05:00
const int syslogLevelMap [ ] = { LOG_DEBUG , LOG_INFO , LOG_NOTICE , LOG_WARNING } ;
const char * c = " .-*# " ;
2010-06-22 00:07:48 +02:00
FILE * fp ;
2010-07-22 23:31:40 +02:00
char buf [ 64 ] ;
2015-07-27 09:41:48 +02:00
int rawmode = ( level & LL_RAW ) ;
2013-05-15 10:12:29 +02:00
int log_to_stdout = server . logfile [ 0 ] = = ' \0 ' ;
2010-07-22 23:31:40 +02:00
2011-04-13 10:58:21 +02:00
level & = 0xff ; /* clear flags */
2010-07-22 23:31:40 +02:00
if ( level < server . verbosity ) return ;
2010-06-22 00:07:48 +02:00
2013-05-15 10:12:29 +02:00
fp = log_to_stdout ? stdout : fopen ( server . logfile , " a " ) ;
2010-06-22 00:07:48 +02:00
if ( ! fp ) return ;
2011-04-13 10:58:21 +02:00
if ( rawmode ) {
fprintf ( fp , " %s " , msg ) ;
} else {
2012-04-04 15:11:17 +02:00
int off ;
struct timeval tv ;
2014-05-22 18:48:37 +02:00
int role_char ;
pid_t pid = getpid ( ) ;
2012-04-04 15:11:17 +02:00
gettimeofday ( & tv , NULL ) ;
2018-07-04 16:50:22 +02:00
struct tm tm ;
nolocks_localtime ( & tm , tv . tv_sec , server . timezone , server . daylight_active ) ;
2018-07-30 17:42:30 +02:00
off = strftime ( buf , sizeof ( buf ) , " %d %b %Y %H:%M:%S. " , & tm ) ;
2012-04-04 15:11:17 +02:00
snprintf ( buf + off , sizeof ( buf ) - off , " %03d " , ( int ) tv . tv_usec / 1000 ) ;
2014-05-22 18:48:37 +02:00
if ( server . sentinel_mode ) {
role_char = ' X ' ; /* Sentinel. */
} else if ( pid ! = server . pid ) {
role_char = ' C ' ; /* RDB / AOF writing child. */
} else {
role_char = ( server . masterhost ? ' S ' : ' M ' ) ; /* Slave or Master. */
}
fprintf ( fp , " %d:%c %s %c %s \n " ,
( int ) getpid ( ) , role_char , buf , c [ level ] , msg ) ;
2011-04-13 10:58:21 +02:00
}
2010-12-09 11:10:21 -05:00
fflush ( fp ) ;
2013-05-15 10:12:29 +02:00
if ( ! log_to_stdout ) fclose ( fp ) ;
2010-12-09 11:10:21 -05:00
if ( server . syslog_enabled ) syslog ( syslogLevelMap [ level ] , " %s " , msg ) ;
2010-06-22 00:07:48 +02:00
}
2015-07-26 15:17:43 +02:00
/* Like serverLogRaw() but with printf-alike support. This is the function that
2011-02-09 10:10:35 +01:00
* is used across the code . The raw version is only used in order to dump
* the INFO output on crash . */
2015-07-26 15:17:43 +02:00
void serverLog ( int level , const char * fmt , . . . ) {
2011-02-09 10:10:35 +01:00
va_list ap ;
2015-07-27 09:41:48 +02:00
char msg [ LOG_MAX_LEN ] ;
2011-02-09 10:10:35 +01:00
2011-04-13 10:58:21 +02:00
if ( ( level & 0xff ) < server . verbosity ) return ;
2011-02-09 10:10:35 +01:00
va_start ( ap , fmt ) ;
vsnprintf ( msg , sizeof ( msg ) , fmt , ap ) ;
va_end ( ap ) ;
2015-07-26 15:17:43 +02:00
serverLogRaw ( level , msg ) ;
2011-02-09 10:10:35 +01:00
}
2012-03-28 13:45:39 +02:00
/* Log a fixed message without printf-alike capabilities, in a way that is
* safe to call from a signal handler .
*
* We actually use this only for signals that are not fatal from the point
* of view of Redis . Signals that are going to kill the server anyway and
2015-07-26 15:17:43 +02:00
* where we need printf - alike features are served by serverLog ( ) . */
void serverLogFromHandler ( int level , const char * msg ) {
2012-03-28 13:45:39 +02:00
int fd ;
2013-05-15 10:12:29 +02:00
int log_to_stdout = server . logfile [ 0 ] = = ' \0 ' ;
2012-03-28 13:45:39 +02:00
char buf [ 64 ] ;
2013-05-15 10:12:29 +02:00
if ( ( level & 0xff ) < server . verbosity | | ( log_to_stdout & & server . daemonize ) )
return ;
2014-06-26 18:48:40 +02:00
fd = log_to_stdout ? STDOUT_FILENO :
2013-05-15 10:12:29 +02:00
open ( server . logfile , O_APPEND | O_CREAT | O_WRONLY , 0644 ) ;
2012-03-28 13:45:39 +02:00
if ( fd = = - 1 ) return ;
ll2string ( buf , sizeof ( buf ) , getpid ( ) ) ;
2012-04-10 16:48:28 +02:00
if ( write ( fd , buf , strlen ( buf ) ) = = - 1 ) goto err ;
2014-05-22 19:24:35 +02:00
if ( write ( fd , " :signal-handler ( " , 17 ) = = - 1 ) goto err ;
2012-03-28 13:45:39 +02:00
ll2string ( buf , sizeof ( buf ) , time ( NULL ) ) ;
2012-04-10 16:48:28 +02:00
if ( write ( fd , buf , strlen ( buf ) ) = = - 1 ) goto err ;
if ( write ( fd , " ) " , 2 ) = = - 1 ) goto err ;
if ( write ( fd , msg , strlen ( msg ) ) = = - 1 ) goto err ;
if ( write ( fd , " \n " , 1 ) = = - 1 ) goto err ;
err :
2013-05-15 10:12:29 +02:00
if ( ! log_to_stdout ) close ( fd ) ;
2012-03-28 13:45:39 +02:00
}
2011-01-23 11:46:34 +01:00
/* Return the UNIX time in microseconds */
long long ustime ( void ) {
struct timeval tv ;
long long ust ;
gettimeofday ( & tv , NULL ) ;
ust = ( ( long long ) tv . tv_sec ) * 1000000 ;
ust + = tv . tv_usec ;
return ust ;
}
2011-11-09 00:03:03 +01:00
/* Return the UNIX time in milliseconds */
2015-07-28 10:14:33 +02:00
mstime_t mstime ( void ) {
2011-11-09 00:03:03 +01:00
return ustime ( ) / 1000 ;
}
2012-04-07 12:11:23 +02:00
/* After an RDB dump or AOF rewrite we exit from children using _exit() instead of
* exit ( ) , because the latter may interact with the same file objects used by
* the parent process . However if we are testing the coverage normal exit ( ) is
* used in order to obtain the right coverage information . */
void exitFromChild ( int retcode ) {
# ifdef COVERAGE_TEST
exit ( retcode ) ;
# else
_exit ( retcode ) ;
# endif
}
2010-06-22 00:07:48 +02:00
/*====================== Hash table type implementation ==================== */
2013-12-05 16:35:32 +01:00
/* This is a hash table type that uses the SDS dynamic strings library as
2014-08-14 11:22:52 -04:00
* keys and redis objects as values ( objects can hold SDS strings ,
2010-06-22 00:07:48 +02:00
* lists , sets ) . */
void dictVanillaFree ( void * privdata , void * val )
{
DICT_NOTUSED ( privdata ) ;
zfree ( val ) ;
}
void dictListDestructor ( void * privdata , void * val )
{
DICT_NOTUSED ( privdata ) ;
listRelease ( ( list * ) val ) ;
}
int dictSdsKeyCompare ( void * privdata , const void * key1 ,
const void * key2 )
{
int l1 , l2 ;
DICT_NOTUSED ( privdata ) ;
l1 = sdslen ( ( sds ) key1 ) ;
l2 = sdslen ( ( sds ) key2 ) ;
if ( l1 ! = l2 ) return 0 ;
return memcmp ( key1 , key2 , l1 ) = = 0 ;
}
2012-11-22 15:50:00 +01:00
/* A case insensitive version used for the command lookup table and other
* places where case insensitive non binary - safe comparison is needed . */
2010-11-03 11:23:59 +01:00
int dictSdsKeyCaseCompare ( void * privdata , const void * key1 ,
const void * key2 )
{
DICT_NOTUSED ( privdata ) ;
return strcasecmp ( key1 , key2 ) = = 0 ;
}
2015-07-28 11:03:01 +02:00
void dictObjectDestructor ( void * privdata , void * val )
2010-06-22 00:07:48 +02:00
{
DICT_NOTUSED ( privdata ) ;
2015-07-30 11:46:31 +02:00
if ( val = = NULL ) return ; /* Lazy freeing will set value to NULL. */
2010-06-22 00:07:48 +02:00
decrRefCount ( val ) ;
}
void dictSdsDestructor ( void * privdata , void * val )
{
DICT_NOTUSED ( privdata ) ;
sdsfree ( val ) ;
}
int dictObjKeyCompare ( void * privdata , const void * key1 ,
const void * key2 )
{
const robj * o1 = key1 , * o2 = key2 ;
return dictSdsKeyCompare ( privdata , o1 - > ptr , o2 - > ptr ) ;
}
2017-02-20 16:09:54 +01:00
uint64_t dictObjHash ( const void * key ) {
2010-06-22 00:07:48 +02:00
const robj * o = key ;
return dictGenHashFunction ( o - > ptr , sdslen ( ( sds ) o - > ptr ) ) ;
}
2017-02-20 16:09:54 +01:00
uint64_t dictSdsHash ( const void * key ) {
2010-06-22 00:07:48 +02:00
return dictGenHashFunction ( ( unsigned char * ) key , sdslen ( ( char * ) key ) ) ;
}
2017-02-20 16:09:54 +01:00
uint64_t dictSdsCaseHash ( const void * key ) {
2010-11-03 11:23:59 +01:00
return dictGenCaseHashFunction ( ( unsigned char * ) key , sdslen ( ( char * ) key ) ) ;
}
2010-06-22 00:07:48 +02:00
int dictEncObjKeyCompare ( void * privdata , const void * key1 ,
const void * key2 )
{
robj * o1 = ( robj * ) key1 , * o2 = ( robj * ) key2 ;
int cmp ;
2015-07-26 15:28:00 +02:00
if ( o1 - > encoding = = OBJ_ENCODING_INT & &
o2 - > encoding = = OBJ_ENCODING_INT )
2010-06-22 00:07:48 +02:00
return o1 - > ptr = = o2 - > ptr ;
2020-04-27 22:40:15 +02:00
/* Due to OBJ_STATIC_REFCOUNT, we avoid calling getDecodedObject() without
* good reasons , because it would incrRefCount ( ) the object , which
* is invalid . So we check to make sure dictFind ( ) works with static
* objects as well . */
2020-04-28 12:14:46 +03:00
if ( o1 - > refcount ! = OBJ_STATIC_REFCOUNT ) o1 = getDecodedObject ( o1 ) ;
if ( o2 - > refcount ! = OBJ_STATIC_REFCOUNT ) o2 = getDecodedObject ( o2 ) ;
2010-06-22 00:07:48 +02:00
cmp = dictSdsKeyCompare ( privdata , o1 - > ptr , o2 - > ptr ) ;
2020-04-28 12:14:46 +03:00
if ( o1 - > refcount ! = OBJ_STATIC_REFCOUNT ) decrRefCount ( o1 ) ;
if ( o2 - > refcount ! = OBJ_STATIC_REFCOUNT ) decrRefCount ( o2 ) ;
2010-06-22 00:07:48 +02:00
return cmp ;
}
2017-02-20 16:09:54 +01:00
uint64_t dictEncObjHash ( const void * key ) {
2010-06-22 00:07:48 +02:00
robj * o = ( robj * ) key ;
2012-06-05 21:50:10 +02:00
if ( sdsEncodedObject ( o ) ) {
2010-06-22 00:07:48 +02:00
return dictGenHashFunction ( o - > ptr , sdslen ( ( sds ) o - > ptr ) ) ;
} else {
2015-07-26 15:28:00 +02:00
if ( o - > encoding = = OBJ_ENCODING_INT ) {
2010-06-22 00:07:48 +02:00
char buf [ 32 ] ;
int len ;
len = ll2string ( buf , 32 , ( long ) o - > ptr ) ;
return dictGenHashFunction ( ( unsigned char * ) buf , len ) ;
} else {
2017-02-20 16:09:54 +01:00
uint64_t hash ;
2010-06-22 00:07:48 +02:00
o = getDecodedObject ( o ) ;
hash = dictGenHashFunction ( o - > ptr , sdslen ( ( sds ) o - > ptr ) ) ;
decrRefCount ( o ) ;
return hash ;
}
}
}
2015-07-31 18:01:23 +02:00
/* Generic hash table type where keys are Redis Objects, Values
* dummy pointers . */
dictType objectKeyPointerValueDictType = {
2010-06-22 00:07:48 +02:00
dictEncObjHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictEncObjKeyCompare , /* key compare */
2017-09-06 15:43:28 +02:00
dictObjectDestructor , /* key destructor */
2010-06-22 00:07:48 +02:00
NULL /* val destructor */
} ;
2017-09-06 15:43:28 +02:00
/* Like objectKeyPointerValueDictType(), but values can be destroyed, if
* not NULL , calling zfree ( ) . */
dictType objectKeyHeapPointerValueDictType = {
dictEncObjHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictEncObjKeyCompare , /* key compare */
dictObjectDestructor , /* key destructor */
dictVanillaFree /* val destructor */
} ;
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
/* Set dictionary type. Keys are SDS strings, values are not used. */
2015-07-31 18:01:23 +02:00
dictType setDictType = {
dictSdsHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCompare , /* key compare */
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
} ;
2010-06-22 00:07:48 +02:00
/* Sorted sets hash (note: a skiplist is used in addition to the hash table) */
dictType zsetDictType = {
2015-08-04 09:20:55 +02:00
dictSdsHash , /* hash function */
2010-06-22 00:07:48 +02:00
NULL , /* key dup */
NULL , /* val dup */
2015-08-04 09:20:55 +02:00
dictSdsKeyCompare , /* key compare */
NULL , /* Note: SDS string shared & freed by skiplist */
2010-08-03 20:49:53 +02:00
NULL /* val destructor */
2010-06-22 00:07:48 +02:00
} ;
/* Db->dict, keys are sds strings, vals are Redis objects. */
dictType dbDictType = {
dictSdsHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCompare , /* key compare */
dictSdsDestructor , /* key destructor */
2015-07-28 11:03:01 +02:00
dictObjectDestructor /* val destructor */
2010-06-22 00:07:48 +02:00
} ;
2012-11-22 15:50:00 +01:00
/* server.lua_scripts sha (as sds string) -> scripts (as robj) cache. */
dictType shaScriptObjectDictType = {
dictSdsCaseHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCaseCompare , /* key compare */
dictSdsDestructor , /* key destructor */
2015-09-10 17:26:48 +02:00
dictObjectDestructor /* val destructor */
2012-11-22 15:50:00 +01:00
} ;
2010-06-22 00:07:48 +02:00
/* Db->expires */
dictType keyptrDictType = {
2015-09-10 17:26:48 +02:00
dictSdsHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCompare , /* key compare */
NULL , /* key destructor */
NULL /* val destructor */
2010-06-22 00:07:48 +02:00
} ;
2010-11-03 11:23:59 +01:00
/* Command table. sds string -> command struct pointer. */
dictType commandTableDictType = {
2015-09-10 17:26:48 +02:00
dictSdsCaseHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCaseCompare , /* key compare */
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
2010-11-03 11:23:59 +01:00
} ;
2013-01-28 11:07:17 +01:00
/* Hash type hash table (note that small hashes are represented with ziplists) */
2010-06-22 00:07:48 +02:00
dictType hashDictType = {
2015-09-10 17:26:48 +02:00
dictSdsHash , /* hash function */
2010-06-22 00:07:48 +02:00
NULL , /* key dup */
NULL , /* val dup */
2015-09-23 09:33:23 +02:00
dictSdsKeyCompare , /* key compare */
2015-09-10 17:26:48 +02:00
dictSdsDestructor , /* key destructor */
dictSdsDestructor /* val destructor */
2010-06-22 00:07:48 +02:00
} ;
/* Keylist hash table type has unencoded redis objects as keys and
* lists as values . It ' s used for blocking operations ( BLPOP ) and to
* map swapped keys to a list of clients waiting for this keys to be loaded . */
dictType keylistDictType = {
dictObjHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictObjKeyCompare , /* key compare */
2015-09-10 17:26:48 +02:00
dictObjectDestructor , /* key destructor */
2010-06-22 00:07:48 +02:00
dictListDestructor /* val destructor */
} ;
2011-03-29 17:51:15 +02:00
/* Cluster nodes hash table, mapping nodes addresses 1.2.3.4:6379 to
* clusterNode structures . */
dictType clusterNodesDictType = {
dictSdsHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCompare , /* key compare */
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
} ;
2013-11-29 17:37:06 +01:00
/* Cluster re-addition blacklist. This maps node IDs to the time
* we can re - add this node . The goal is to avoid readding a removed
* node for some time . */
dictType clusterNodesBlackListDictType = {
dictSdsCaseHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCaseCompare , /* key compare */
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
} ;
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
/* Modules system dictionary type. Keys are module name,
* values are pointer to RedisModule struct . */
2016-03-06 13:44:24 +01:00
dictType modulesDictType = {
dictSdsCaseHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCaseCompare , /* key compare */
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
} ;
2012-11-12 00:45:10 +01:00
/* Migrate cache dict type. */
dictType migrateCacheDictType = {
dictSdsHash , /* hash function */
NULL , /* key dup */
NULL , /* val dup */
dictSdsKeyCompare , /* key compare */
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
} ;
2013-06-24 10:26:04 +02:00
/* Replication cached script dict (server.repl_scriptcache_dict).
* Keys are sds SHA1 strings , while values are not used at all in the current
* implementation . */
dictType replScriptCacheDictType = {
2013-06-24 18:57:31 +02:00
dictSdsCaseHash , /* hash function */
2013-06-24 10:26:04 +02:00
NULL , /* key dup */
NULL , /* val dup */
2013-06-24 18:57:31 +02:00
dictSdsKeyCaseCompare , /* key compare */
2013-06-24 10:26:04 +02:00
dictSdsDestructor , /* key destructor */
NULL /* val destructor */
} ;
2010-06-22 00:07:48 +02:00
int htNeedsResize ( dict * dict ) {
long long size , used ;
size = dictSlots ( dict ) ;
used = dictSize ( dict ) ;
2016-05-09 09:12:38 +03:00
return ( size > DICT_HT_INITIAL_SIZE & &
2015-07-27 09:41:48 +02:00
( used * 100 / size < HASHTABLE_MIN_FILL ) ) ;
2010-06-22 00:07:48 +02:00
}
2015-07-27 09:41:48 +02:00
/* If the percentage of used slots in the HT reaches HASHTABLE_MIN_FILL
2010-06-22 00:07:48 +02:00
* we resize the hash table to save memory */
2013-03-08 14:01:12 +01:00
void tryResizeHashTables ( int dbid ) {
if ( htNeedsResize ( server . db [ dbid ] . dict ) )
dictResize ( server . db [ dbid ] . dict ) ;
if ( htNeedsResize ( server . db [ dbid ] . expires ) )
dictResize ( server . db [ dbid ] . expires ) ;
2010-06-22 00:07:48 +02:00
}
/* Our hash table implementation performs rehashing incrementally while
* we write / read from the hash table . Still if the server is idle , the hash
* table will use two tables for a long time . So we try to use 1 millisecond
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* of CPU time at every call of this function to perform some rehashing .
2013-03-08 14:01:12 +01:00
*
* The function returns 1 if some rehashing was performed , otherwise 0
* is returned . */
int incrementallyRehash ( int dbid ) {
/* Keys dictionary */
if ( dictIsRehashing ( server . db [ dbid ] . dict ) ) {
dictRehashMilliseconds ( server . db [ dbid ] . dict , 1 ) ;
return 1 ; /* already used our millisecond for this loop... */
}
/* Expires */
if ( dictIsRehashing ( server . db [ dbid ] . expires ) ) {
dictRehashMilliseconds ( server . db [ dbid ] . expires , 1 ) ;
return 1 ; /* already used our millisecond for this loop... */
2010-06-22 00:07:48 +02:00
}
2013-03-08 14:01:12 +01:00
return 0 ;
2010-06-22 00:07:48 +02:00
}
/* This function is called once a background process of some kind terminates,
* as we want to avoid resizing the hash tables when there is a child in order
* to play well with copy - on - write ( otherwise when a resize happens lots of
* memory pages are copied ) . The goal of this function is to update the ability
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* for dict . c to resize the hash tables accordingly to the fact we have an
* active fork child running . */
2010-06-22 00:07:48 +02:00
void updateDictResizePolicy ( void ) {
2019-09-27 12:03:09 +02:00
if ( ! hasActiveChildProcess ( ) )
2010-06-22 00:07:48 +02:00
dictEnableResize ( ) ;
else
dictDisableResize ( ) ;
}
2020-08-12 15:23:55 +08:00
/* Return true if there are active children processes doing RDB saving,
2020-03-03 14:58:11 +01:00
* AOF rewriting , or some side process spawned by a loaded module . */
2019-09-27 12:03:09 +02:00
int hasActiveChildProcess ( ) {
2019-07-17 08:51:02 +03:00
return server . rdb_child_pid ! = - 1 | |
server . aof_child_pid ! = - 1 | |
server . module_child_pid ! = - 1 ;
}
2020-03-03 14:58:11 +01:00
/* Return true if this instance has persistence completely turned off:
* both RDB and AOF are disabled . */
int allPersistenceDisabled ( void ) {
return server . saveparamslen = = 0 & & server . aof_state = = AOF_OFF ;
}
2020-03-26 13:28:39 +01:00
/* ======================= Cron: called every 100 ms ======================== */
/* Add a sample to the operations per second array of samples. */
void trackInstantaneousMetric ( int metric , long long current_reading ) {
2020-08-09 03:11:14 +08:00
long long now = mstime ( ) ;
long long t = now - server . inst_metric [ metric ] . last_sample_time ;
2020-03-26 13:28:39 +01:00
long long ops = current_reading -
server . inst_metric [ metric ] . last_sample_count ;
long long ops_sec ;
ops_sec = t > 0 ? ( ops * 1000 / t ) : 0 ;
server . inst_metric [ metric ] . samples [ server . inst_metric [ metric ] . idx ] =
ops_sec ;
server . inst_metric [ metric ] . idx + + ;
server . inst_metric [ metric ] . idx % = STATS_METRIC_SAMPLES ;
2020-08-09 03:11:14 +08:00
server . inst_metric [ metric ] . last_sample_time = now ;
2020-03-26 13:28:39 +01:00
server . inst_metric [ metric ] . last_sample_count = current_reading ;
}
/* Return the mean of all the samples. */
long long getInstantaneousMetric ( int metric ) {
int j ;
long long sum = 0 ;
for ( j = 0 ; j < STATS_METRIC_SAMPLES ; j + + )
sum + = server . inst_metric [ metric ] . samples [ j ] ;
return sum / STATS_METRIC_SAMPLES ;
}
2012-03-14 15:32:30 +01:00
/* The client query buffer is an sds.c string that can end with a lot of
2012-03-15 20:51:35 +01:00
* free space not used , this function reclaims space if needed .
*
2013-01-17 01:00:20 +08:00
* The function always returns 0 as it never terminates the client . */
2015-07-26 15:20:46 +02:00
int clientsCronResizeQueryBuffer ( client * c ) {
2012-03-14 15:32:30 +01:00
size_t querybuf_size = sdsAllocSize ( c - > querybuf ) ;
time_t idletime = server . unixtime - c - > lastinteraction ;
/* There are two conditions to resize the query buffer:
* 1 ) Query buffer is > BIG_ARG and too big for latest peak .
2018-06-11 17:12:28 +02:00
* 2 ) Query buffer is > BIG_ARG and client is idle . */
if ( querybuf_size > PROTO_MBULK_BIG_ARG & &
( ( querybuf_size / ( c - > querybuf_peak + 1 ) ) > 2 | |
idletime > 2 ) )
2012-03-14 15:32:30 +01:00
{
2018-06-11 17:12:28 +02:00
/* Only resize the query buffer if it is actually wasting
* at least a few kbytes . */
if ( sdsavail ( c - > querybuf ) > 1024 * 4 ) {
2012-03-14 15:32:30 +01:00
c - > querybuf = sdsRemoveFreeSpace ( c - > querybuf ) ;
}
}
/* Reset the peak again to capture the peak memory usage in the next
* cycle . */
c - > querybuf_peak = 0 ;
2018-07-01 14:43:53 +08:00
2018-07-03 13:23:29 +02:00
/* Clients representing masters also use a "pending query buffer" that
* is the yet not applied part of the stream we are reading . Such buffer
* also needs resizing from time to time , otherwise after a very large
* transfer ( a huge value or a big MIGRATE operation ) it will keep using
* a lot of memory . */
2018-07-01 14:43:53 +08:00
if ( c - > flags & CLIENT_MASTER ) {
/* There are two conditions to resize the pending query buffer:
* 1 ) Pending Query buffer is > LIMIT_PENDING_QUERYBUF .
2018-07-03 13:23:29 +02:00
* 2 ) Used length is smaller than pending_querybuf_size / 2 */
2018-07-01 14:43:53 +08:00
size_t pending_querybuf_size = sdsAllocSize ( c - > pending_querybuf ) ;
if ( pending_querybuf_size > LIMIT_PENDING_QUERYBUF & &
2018-07-03 13:23:29 +02:00
sdslen ( c - > pending_querybuf ) < ( pending_querybuf_size / 2 ) )
{
2018-07-01 14:43:53 +08:00
c - > pending_querybuf = sdsRemoveFreeSpace ( c - > pending_querybuf ) ;
}
}
2012-03-15 20:51:35 +01:00
return 0 ;
2012-03-14 15:32:30 +01:00
}
2018-07-19 13:49:00 +02:00
/* This function is used in order to track clients using the biggest amount
* of memory in the latest few seconds . This way we can provide such information
* in the INFO output ( clients section ) , without having to do an O ( N ) scan for
* all the clients .
*
* This is how it works . We have an array of CLIENTS_PEAK_MEM_USAGE_SLOTS slots
* where we track , for each , the biggest client output and input buffers we
* saw in that slot . Every slot correspond to one of the latest seconds , since
* the array is indexed by doing UNIXTIME % CLIENTS_PEAK_MEM_USAGE_SLOTS .
*
* When we want to know what was recently the peak memory usage , we just scan
* such few slots searching for the maximum value . */
2018-07-19 13:54:15 +02:00
# define CLIENTS_PEAK_MEM_USAGE_SLOTS 8
2018-07-19 13:49:00 +02:00
size_t ClientsPeakMemInput [ CLIENTS_PEAK_MEM_USAGE_SLOTS ] ;
size_t ClientsPeakMemOutput [ CLIENTS_PEAK_MEM_USAGE_SLOTS ] ;
int clientsCronTrackExpansiveClients ( client * c ) {
size_t in_usage = sdsAllocSize ( c - > querybuf ) ;
size_t out_usage = getClientOutputBufferMemoryUsage ( c ) ;
2018-07-19 13:54:15 +02:00
int i = server . unixtime % CLIENTS_PEAK_MEM_USAGE_SLOTS ;
2018-07-19 13:59:13 +02:00
int zeroidx = ( i + 1 ) % CLIENTS_PEAK_MEM_USAGE_SLOTS ;
2018-07-19 13:54:15 +02:00
/* Always zero the next sample, so that when we switch to that second, we'll
* only register samples that are greater in that second without considering
2018-07-20 09:36:44 +02:00
* the history of such slot .
*
* Note : our index may jump to any random position if serverCron ( ) is not
* called for some reason with the normal frequency , for instance because
* some slow command is called taking multiple seconds to execute . In that
* case our array may end containing data which is potentially older
* than CLIENTS_PEAK_MEM_USAGE_SLOTS seconds : however this is not a problem
* since here we want just to track if " recently " there were very expansive
* clients from the POV of memory usage . */
2018-07-19 13:59:13 +02:00
ClientsPeakMemInput [ zeroidx ] = 0 ;
ClientsPeakMemOutput [ zeroidx ] = 0 ;
2018-07-19 13:54:15 +02:00
/* Track the biggest values observed so far in this slot. */
if ( in_usage > ClientsPeakMemInput [ i ] ) ClientsPeakMemInput [ i ] = in_usage ;
if ( out_usage > ClientsPeakMemOutput [ i ] ) ClientsPeakMemOutput [ i ] = out_usage ;
2018-07-19 13:49:00 +02:00
return 0 ; /* This function never terminates the client. */
}
2020-04-07 12:07:09 +02:00
/* Iterating all the clients in getMemoryOverheadData() is too slow and
* in turn would make the INFO command too slow . So we perform this
* computation incrementally and track the ( not instantaneous but updated
* to the second ) total memory used by clients using clinetsCron ( ) in
* a more incremental way ( depending on server . hz ) . */
int clientsCronTrackClientsMemUsage ( client * c ) {
size_t mem = 0 ;
int type = getClientType ( c ) ;
mem + = getClientOutputBufferMemoryUsage ( c ) ;
mem + = sdsAllocSize ( c - > querybuf ) ;
mem + = sizeof ( client ) ;
/* Now that we have the memory used by the client, remove the old
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* value from the old category , and add it back . */
2020-04-07 12:07:09 +02:00
server . stat_clients_type_memory [ c - > client_cron_last_memory_type ] - =
c - > client_cron_last_memory_usage ;
server . stat_clients_type_memory [ type ] + = mem ;
/* Remember what we added and where, to remove it next time. */
c - > client_cron_last_memory_usage = mem ;
c - > client_cron_last_memory_type = type ;
return 0 ;
}
2018-07-19 13:58:04 +02:00
/* Return the max samples in the memory usage of clients tracked by
* the function clientsCronTrackExpansiveClients ( ) . */
void getExpansiveClientsInfo ( size_t * in_usage , size_t * out_usage ) {
size_t i = 0 , o = 0 ;
for ( int j = 0 ; j < CLIENTS_PEAK_MEM_USAGE_SLOTS ; j + + ) {
if ( ClientsPeakMemInput [ j ] > i ) i = ClientsPeakMemInput [ j ] ;
2018-07-19 17:34:15 +02:00
if ( ClientsPeakMemOutput [ j ] > o ) o = ClientsPeakMemOutput [ j ] ;
2018-07-19 13:58:04 +02:00
}
* in_usage = i ;
* out_usage = o ;
}
2018-07-20 09:46:18 +02:00
/* This function is called by serverCron() and is used in order to perform
* operations on clients that are important to perform constantly . For instance
* we use this function in order to disconnect clients after a timeout , including
* clients blocked in some blocking command with a non - zero timeout .
*
* The function makes some effort to process all the clients every second , even
* if this cannot be strictly guaranteed , since serverCron ( ) may be called with
* an actual frequency lower than server . hz in case of latency events like slow
* commands .
*
* It is very important for this function , and the functions it calls , to be
* very fast : sometimes Redis has tens of hundreds of connected clients , and the
* default server . hz value is 10 , so sometimes here we need to process thousands
* of clients per second , turning this function into a source of latency .
*/
Client timeout handling improved.
The previos attempt to process each client at least once every ten
seconds was not a good idea, because:
1. Usually because of the past min iterations set to 50, you get much
better processing period most of the times.
2. However when there are many clients and a normal setting for
server.hz, the edge case is triggered, and waiting 10 seconds for a
BLPOP that asked for 1 second is not ok.
3. Moreover, because of the high min-itereations limit of 50, when HZ
was set to an high value, the actual behavior was to process a lot of
clients per second.
Also the function checking for timeouts called gettimeofday() at each
iteration which can be costly.
The new implementation will try to process each client once per second,
gets the current time as argument, and does not attempt to process more
than 5 clients per iteration if not needed.
So now:
1. The CPU usage of an idle Redis process is the same or better.
2. The CPU usage of a busy Redis process is the same or better.
3. However a non trivial amount of work may be performed per iteration
when there are many many clients. In this particular case the user may
want to raise the "HZ" value if needed.
Btw with 4000 clients it was still not possible to noticy any actual
latency created by processing 400 clients per second, since the work
performed for each client is pretty small.
2015-07-16 10:54:12 +02:00
# define CLIENTS_CRON_MIN_ITERATIONS 5
2012-03-13 18:05:11 +01:00
void clientsCron ( void ) {
2018-07-20 09:46:18 +02:00
/* Try to process at least numclients/server.hz of clients
* per call . Since normally ( if there are no big latency events ) this
* function is called server . hz times per second , in the average case we
* process all the clients in 1 second . */
2012-03-14 15:32:30 +01:00
int numclients = listLength ( server . clients ) ;
Client timeout handling improved.
The previos attempt to process each client at least once every ten
seconds was not a good idea, because:
1. Usually because of the past min iterations set to 50, you get much
better processing period most of the times.
2. However when there are many clients and a normal setting for
server.hz, the edge case is triggered, and waiting 10 seconds for a
BLPOP that asked for 1 second is not ok.
3. Moreover, because of the high min-itereations limit of 50, when HZ
was set to an high value, the actual behavior was to process a lot of
clients per second.
Also the function checking for timeouts called gettimeofday() at each
iteration which can be costly.
The new implementation will try to process each client once per second,
gets the current time as argument, and does not attempt to process more
than 5 clients per iteration if not needed.
So now:
1. The CPU usage of an idle Redis process is the same or better.
2. The CPU usage of a busy Redis process is the same or better.
3. However a non trivial amount of work may be performed per iteration
when there are many many clients. In this particular case the user may
want to raise the "HZ" value if needed.
Btw with 4000 clients it was still not possible to noticy any actual
latency created by processing 400 clients per second, since the work
performed for each client is pretty small.
2015-07-16 10:54:12 +02:00
int iterations = numclients / server . hz ;
mstime_t now = mstime ( ) ;
/* Process at least a few clients while we are at it, even if we need
* to process less than CLIENTS_CRON_MIN_ITERATIONS to meet our contract
* of processing each client once per second . */
if ( iterations < CLIENTS_CRON_MIN_ITERATIONS )
iterations = ( numclients < CLIENTS_CRON_MIN_ITERATIONS ) ?
numclients : CLIENTS_CRON_MIN_ITERATIONS ;
2012-03-13 18:05:11 +01:00
while ( listLength ( server . clients ) & & iterations - - ) {
2015-07-26 15:20:46 +02:00
client * c ;
2012-03-13 18:05:11 +01:00
listNode * head ;
/* Rotate the list, take the current head, process.
* This way if the client must be removed from the list it ' s the
* first element and we don ' t incur into O ( N ) computation . */
2020-04-08 12:55:57 +02:00
listRotateTailToHead ( server . clients ) ;
2012-03-13 18:05:11 +01:00
head = listFirst ( server . clients ) ;
c = listNodeValue ( head ) ;
2012-03-15 20:51:35 +01:00
/* The following functions do different service checks on the client.
* The protocol is that they return non - zero if the client was
* terminated . */
Client timeout handling improved.
The previos attempt to process each client at least once every ten
seconds was not a good idea, because:
1. Usually because of the past min iterations set to 50, you get much
better processing period most of the times.
2. However when there are many clients and a normal setting for
server.hz, the edge case is triggered, and waiting 10 seconds for a
BLPOP that asked for 1 second is not ok.
3. Moreover, because of the high min-itereations limit of 50, when HZ
was set to an high value, the actual behavior was to process a lot of
clients per second.
Also the function checking for timeouts called gettimeofday() at each
iteration which can be costly.
The new implementation will try to process each client once per second,
gets the current time as argument, and does not attempt to process more
than 5 clients per iteration if not needed.
So now:
1. The CPU usage of an idle Redis process is the same or better.
2. The CPU usage of a busy Redis process is the same or better.
3. However a non trivial amount of work may be performed per iteration
when there are many many clients. In this particular case the user may
want to raise the "HZ" value if needed.
Btw with 4000 clients it was still not possible to noticy any actual
latency created by processing 400 clients per second, since the work
performed for each client is pretty small.
2015-07-16 10:54:12 +02:00
if ( clientsCronHandleTimeout ( c , now ) ) continue ;
2012-03-15 20:51:35 +01:00
if ( clientsCronResizeQueryBuffer ( c ) ) continue ;
2018-07-19 13:49:00 +02:00
if ( clientsCronTrackExpansiveClients ( c ) ) continue ;
2020-04-07 12:07:09 +02:00
if ( clientsCronTrackClientsMemUsage ( c ) ) continue ;
2012-03-13 18:05:11 +01:00
}
}
2013-03-08 11:54:33 +01:00
/* This function handles 'background' operations we are required to do
* incrementally in Redis databases , such as active key expiring , resizing ,
* rehashing . */
void databasesCron ( void ) {
2013-03-08 14:01:12 +01:00
/* Expire keys by random sampling. Not required for slaves
* as master will synthesize DELs for us . */
2019-05-06 11:46:07 +08:00
if ( server . active_expire_enabled ) {
Fix master replica inconsistency for upgrading scenario.
Before this commit, when upgrading a replica, expired keys will not
be loaded, thus causing replica having less keys in db. To this point,
master and replica's keys is logically consistent. However, before
the keys in master and replica are physically consistent, that is,
they have the same dbsize, if master got a problem and the replica
got promoted and becomes new master of that partition, and master
updates a key which does not exist on master, but physically exists
on the old master(new replica), the old master would refuse to update
the key, thus causing master and replica data inconsistent.
How could this happen?
That's all because of the wrong judgement of roles while starting up
the server. We can not use server.masterhost to judge if the server
is master or replica, since it fails in cluster mode.
When we start the server, we load rdb and do want to load expired keys,
and do not want to have the ability to active expire keys, if it is
a replica.
2020-03-18 16:20:10 +08:00
if ( iAmMaster ( ) ) {
2019-05-06 11:46:07 +08:00
activeExpireCycle ( ACTIVE_EXPIRE_CYCLE_SLOW ) ;
} else {
expireSlaveKeys ( ) ;
}
Replication: fix the infamous key leakage of writable slaves + EXPIRE.
BACKGROUND AND USE CASEj
Redis slaves are normally write only, however the supprot a "writable"
mode which is very handy when scaling reads on slaves, that actually
need write operations in order to access data. For instance imagine
having slaves replicating certain Sets keys from the master. When
accessing the data on the slave, we want to peform intersections between
such Sets values. However we don't want to intersect each time: to cache
the intersection for some time often is a good idea.
To do so, it is possible to setup a slave as a writable slave, and
perform the intersection on the slave side, perhaps setting a TTL on the
resulting key so that it will expire after some time.
THE BUG
Problem: in order to have a consistent replication, expiring of keys in
Redis replication is up to the master, that synthesize DEL operations to
send in the replication stream. However slaves logically expire keys
by hiding them from read attempts from clients so that if the master did
not promptly sent a DEL, the client still see logically expired keys
as non existing.
Because slaves don't actively expire keys by actually evicting them but
just masking from the POV of read operations, if a key is created in a
writable slave, and an expire is set, the key will be leaked forever:
1. No DEL will be received from the master, which does not know about
such a key at all.
2. No eviction will be performed by the slave, since it needs to disable
eviction because it's up to masters, otherwise consistency of data is
lost.
THE FIX
In order to fix the problem, the slave should be able to tag keys that
were created in the slave side and have an expire set in some way.
My solution involved using an unique additional dictionary created by
the writable slave only if needed. The dictionary is obviously keyed by
the key name that we need to track: all the keys that are set with an
expire directly by a client writing to the slave are tracked.
The value in the dictionary is a bitmap of all the DBs where such a key
name need to be tracked, so that we can use a single dictionary to track
keys in all the DBs used by the slave (actually this limits the solution
to the first 64 DBs, but the default with Redis is to use 16 DBs).
This solution allows to pay both a small complexity and CPU penalty,
which is zero when the feature is not used, actually. The slave-side
eviction is encapsulated in code which is not coupled with the rest of
the Redis core, if not for the hook to track the keys.
TODO
I'm doing the first smoke tests to see if the feature works as expected:
so far so good. Unit tests should be added before merging into the
4.0 branch.
2016-12-13 10:20:06 +01:00
}
2013-03-08 11:54:33 +01:00
2016-12-30 03:37:52 +02:00
/* Defrag keys gradually. */
Adjustments for active defrag defaults and tuning
Reduce default minimum effort, so that when fragmentation is just detected,
the impact on the latency will be minor.
Reduce the default maximum effort, mainly to prevent a case were a sudden
massive deletions, won't trigger an aggressive defrag that will cause latency.
When activedefrag is disabled mid-run, reset the 'running' info field, and
clear the scan cursor, so that when it'll be re-enabled, a new fresh scan will
start.
Clearing the 'running' variable is important since lowering the defragger
tunables mid-scan won't help, the defragger only considers new threshold when
a new scan starts, and during a scan it can only become more aggressive,
(when more severe fragmentation is detected), it'll never go less aggressive.
So by temporarily disabling activedefrag, one can lower th the tunables.
Removing the experimantal warning.
2019-11-10 09:38:50 +02:00
activeDefragCycle ( ) ;
2016-12-30 03:37:52 +02:00
2013-03-08 14:01:12 +01:00
/* Perform hash tables rehashing if needed, but only if there are no
* other processes saving the DB on disk . Otherwise rehashing is bad
* as will cause a lot of copy - on - write of memory pages . */
2019-09-27 12:03:09 +02:00
if ( ! hasActiveChildProcess ( ) ) {
2013-03-08 14:01:12 +01:00
/* We use global counters so if we stop the computation at a given
* DB we ' ll be able to start from the successive in the next
* cron loop iteration . */
2013-03-08 17:41:20 +01:00
static unsigned int resize_db = 0 ;
static unsigned int rehash_db = 0 ;
2015-07-27 09:41:48 +02:00
int dbs_per_call = CRON_DBS_PER_CALL ;
2014-08-13 11:44:38 +02:00
int j ;
2013-03-08 14:01:12 +01:00
2013-03-11 10:51:03 +01:00
/* Don't test more DBs than we have. */
if ( dbs_per_call > server . dbnum ) dbs_per_call = server . dbnum ;
2013-03-08 14:01:12 +01:00
/* Resize */
2013-03-11 10:51:03 +01:00
for ( j = 0 ; j < dbs_per_call ; j + + ) {
2013-03-08 14:01:12 +01:00
tryResizeHashTables ( resize_db % server . dbnum ) ;
resize_db + + ;
}
/* Rehash */
if ( server . activerehashing ) {
2013-03-11 10:51:03 +01:00
for ( j = 0 ; j < dbs_per_call ; j + + ) {
2017-11-18 01:21:39 +08:00
int work_done = incrementallyRehash ( rehash_db ) ;
2013-03-08 14:01:12 +01:00
if ( work_done ) {
/* If the function did some work, stop here, we'll do
* more at the next cron loop . */
break ;
2017-11-18 01:21:39 +08:00
} else {
/* If this db didn't need rehash, we'll try the next one. */
rehash_db + + ;
rehash_db % = server . dbnum ;
2013-03-08 14:01:12 +01:00
}
}
}
2013-03-08 11:54:33 +01:00
}
}
2014-02-13 15:09:41 +01:00
/* We take a cached value of the unix time in the global state because with
* virtual memory and aging there is to store the current time in objects at
* every object access , and accuracy is not needed . To access a global var is
2019-11-05 10:14:34 +01:00
* a lot faster than calling time ( NULL ) .
*
* This function should be fast because it is called at every command execution
* in call ( ) , so it is possible to decide if to update the daylight saving
* info or not using the ' update_daylight_info ' argument . Normally we update
* such info only when calling this function from serverCron ( ) but not when
* calling it from call ( ) . */
void updateCachedTime ( int update_daylight_info ) {
server . ustime = ustime ( ) ;
server . mstime = server . ustime / 1000 ;
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
time_t unixtime = server . mstime / 1000 ;
atomicSet ( server . unixtime , unixtime ) ;
2018-07-04 16:44:57 +02:00
2019-03-30 11:26:58 +01:00
/* To get information about daylight saving time, we need to call
* localtime_r and cache the result . However calling localtime_r in this
* context is safe since we will never fork ( ) while here , in the main
* thread . The logging function will call a thread safe version of
* localtime that has no locks . */
2019-11-05 10:14:34 +01:00
if ( update_daylight_info ) {
struct tm tm ;
time_t ut = server . unixtime ;
localtime_r ( & ut , & tm ) ;
server . daylight_active = tm . tm_isdst ;
}
2014-02-13 15:09:41 +01:00
}
2019-08-11 16:07:53 +03:00
void checkChildrenDone ( void ) {
int statloc ;
pid_t pid ;
if ( ( pid = wait3 ( & statloc , WNOHANG , NULL ) ) ! = 0 ) {
int exitcode = WEXITSTATUS ( statloc ) ;
int bysignal = 0 ;
if ( WIFSIGNALED ( statloc ) ) bysignal = WTERMSIG ( statloc ) ;
2019-10-16 17:08:07 +03:00
/* sigKillChildHandler catches the signal and calls exit(), but we
* must make sure not to flag lastbgsave_status , etc incorrectly .
* We could directly terminate the child process via SIGUSR1
* without handling it , but in this case Valgrind will log an
* annoying error . */
if ( exitcode = = SERVER_CHILD_NOERROR_RETVAL ) {
bysignal = SIGUSR1 ;
exitcode = 1 ;
}
2019-08-11 16:07:53 +03:00
if ( pid = = - 1 ) {
serverLog ( LL_WARNING , " wait3() returned an error: %s. "
2019-10-16 17:08:07 +03:00
" rdb_child_pid = %d, aof_child_pid = %d, module_child_pid = %d " ,
2019-08-11 16:07:53 +03:00
strerror ( errno ) ,
( int ) server . rdb_child_pid ,
2019-10-16 17:08:07 +03:00
( int ) server . aof_child_pid ,
( int ) server . module_child_pid ) ;
2019-08-11 16:07:53 +03:00
} else if ( pid = = server . rdb_child_pid ) {
backgroundSaveDoneHandler ( exitcode , bysignal ) ;
if ( ! bysignal & & exitcode = = 0 ) receiveChildInfo ( ) ;
} else if ( pid = = server . aof_child_pid ) {
backgroundRewriteDoneHandler ( exitcode , bysignal ) ;
if ( ! bysignal & & exitcode = = 0 ) receiveChildInfo ( ) ;
2019-10-16 17:08:07 +03:00
} else if ( pid = = server . module_child_pid ) {
ModuleForkDoneHandler ( exitcode , bysignal ) ;
if ( ! bysignal & & exitcode = = 0 ) receiveChildInfo ( ) ;
2019-08-11 16:07:53 +03:00
} else {
if ( ! ldbRemoveChild ( pid ) ) {
serverLog ( LL_WARNING ,
" Warning, detected child with unmatched pid: %ld " ,
( long ) pid ) ;
}
}
updateDictResizePolicy ( ) ;
closeChildInfoPipe ( ) ;
Accelerate diskless master connections, and general re-connections (#6271)
Diskless master has some inherent latencies.
1) fork starts with delay from cron rather than immediately
2) replica is put online only after an ACK. but the ACK
was sent only once a second.
3) but even if it would arrive immediately, it will not
register in case cron didn't yet detect that the fork is done.
Besides that, when a replica disconnects, it doesn't immediately
attempts to re-connect, it waits for replication cron (one per second).
in case it was already online, it may be important to try to re-connect
as soon as possible, so that the backlog at the master doesn't vanish.
In case it disconnected during rdb transfer, one can argue that it's
not very important to re-connect immediately, but this is needed for the
"diskless loading short read" test to be able to run 100 iterations in 5
seconds, rather than 3 (waiting for replication cron re-connection)
changes in this commit:
1) sync command starts a fork immediately if no sync_delay is configured
2) replica sends REPLCONF ACK when done reading the rdb (rather than on 1s cron)
3) when a replica unexpectedly disconnets, it immediately tries to
re-connect rather than waiting 1s
4) when when a child exits, if there is another replica waiting, we spawn a new
one right away, instead of waiting for 1s replicationCron.
5) added a call to connectWithMaster from replicationSetMaster. which is called
from the REPLICAOF command but also in 3 places in cluster.c, in all of
these the connection attempt will now be immediate instead of delayed by 1
second.
side note:
we can add a call to rdbPipeReadHandler in replconfCommand when getting
a REPLCONF ACK from the replica to solve a race where the replica got
the entire rdb and EOF marker before we detected that the pipe was
closed.
in the test i did see this race happens in one about of some 300 runs,
but i concluded that this race is unlikely in real life (where the
replica is on another host and we're more likely to first detect the
pipe was closed.
the test runs 100 iterations in 3 seconds, so in some cases it'll take 4
seconds instead (waiting for another REPLCONF ACK).
Removing unneeded startBgsaveForReplication from updateSlavesWaitingForBgsave
Now that CheckChildrenDone is calling the new replicationStartPendingFork
(extracted from serverCron) there's actually no need to call
startBgsaveForReplication from updateSlavesWaitingForBgsave anymore,
since as soon as updateSlavesWaitingForBgsave returns, CheckChildrenDone is
calling replicationStartPendingFork that handles that anyway.
The code in updateSlavesWaitingForBgsave had a bug in which it ignored
repl-diskless-sync-delay, but removing that code shows that this bug was
hiding another bug, which is that the max_idle should have used >= and
not >, this one second delay has a big impact on my new test.
2020-08-06 16:53:06 +03:00
/* start any pending forks immediately. */
replicationStartPendingFork ( ) ;
2019-08-11 16:07:53 +03:00
}
}
2020-08-27 11:09:32 +03:00
/* Called from serverCron and loadingCron to update cached memory metrics. */
void cronUpdateMemoryStats ( ) {
/* Record the max memory used since the server was started. */
if ( zmalloc_used_memory ( ) > server . stat_peak_memory )
server . stat_peak_memory = zmalloc_used_memory ( ) ;
run_with_period ( 100 ) {
/* Sample the RSS and other metrics here since this is a relatively slow call.
* We must sample the zmalloc_used at the same time we take the rss , otherwise
* the frag ratio calculate may be off ( ratio of two samples at different times ) */
server . cron_malloc_stats . process_rss = zmalloc_get_rss ( ) ;
server . cron_malloc_stats . zmalloc_used = zmalloc_used_memory ( ) ;
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
/* Sampling the allocator info can be slow too.
* The fragmentation ratio it ' ll show is potentially more accurate
2020-08-27 11:09:32 +03:00
* it excludes other RSS pages such as : shared libraries , LUA and other non - zmalloc
* allocations , and allocator reserved pages that can be pursed ( all not actual frag ) */
zmalloc_get_allocator_info ( & server . cron_malloc_stats . allocator_allocated ,
& server . cron_malloc_stats . allocator_active ,
& server . cron_malloc_stats . allocator_resident ) ;
/* in case the allocator isn't providing these stats, fake them so that
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* fragmentation info still shows some ( inaccurate metrics ) */
2020-08-27 11:09:32 +03:00
if ( ! server . cron_malloc_stats . allocator_resident ) {
/* LUA memory isn't part of zmalloc_used, but it is part of the process RSS,
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* so we must deduct it in order to be able to calculate correct
2020-08-27 11:09:32 +03:00
* " allocator fragmentation " ratio */
size_t lua_memory = lua_gc ( server . lua , LUA_GCCOUNT , 0 ) * 1024LL ;
server . cron_malloc_stats . allocator_resident = server . cron_malloc_stats . process_rss - lua_memory ;
}
if ( ! server . cron_malloc_stats . allocator_active )
server . cron_malloc_stats . allocator_active = server . cron_malloc_stats . allocator_resident ;
if ( ! server . cron_malloc_stats . allocator_allocated )
server . cron_malloc_stats . allocator_allocated = server . cron_malloc_stats . zmalloc_used ;
}
}
2012-12-14 17:10:40 +01:00
/* This is our timer interrupt, called server.hz times per second.
2012-05-13 16:40:29 +02:00
* Here is where we do a number of things that need to be done asynchronously .
* For instance :
*
* - Active expired keys collection ( it is also performed in a lazy way on
* lookup ) .
2013-01-17 01:00:20 +08:00
* - Software watchdog .
2012-05-13 16:40:29 +02:00
* - Update some statistic .
* - Incremental rehashing of the DBs hash tables .
* - Triggering BGSAVE / AOF rewrite , and handling of terminated children .
2013-01-17 01:00:20 +08:00
* - Clients timeout of different kinds .
2012-05-13 16:40:29 +02:00
* - Replication reconnection .
* - Many more . . .
*
2012-12-14 17:10:40 +01:00
* Everything directly called here will be called server . hz times per second ,
2012-05-13 16:40:29 +02:00
* so in order to throttle execution of things we want to do less frequently
* a macro is used : run_with_period ( milliseconds ) { . . . . }
*/
2010-06-22 00:07:48 +02:00
int serverCron ( struct aeEventLoop * eventLoop , long long id , void * clientData ) {
2012-07-23 12:54:52 +02:00
int j ;
2015-07-27 09:41:48 +02:00
UNUSED ( eventLoop ) ;
UNUSED ( id ) ;
UNUSED ( clientData ) ;
2010-06-22 00:07:48 +02:00
2012-03-27 11:47:51 +02:00
/* Software watchdog: deliver the SIGALRM that will reach the signal
* handler if we don ' t return here fast enough . */
if ( server . watchdog_period ) watchdogScheduleSignal ( server . watchdog_period ) ;
2014-02-13 15:09:41 +01:00
/* Update the time cache. */
2019-11-05 10:14:34 +01:00
updateCachedTime ( 1 ) ;
2011-09-13 12:21:54 +02:00
2018-07-30 13:37:30 +02:00
server . hz = server . config_hz ;
2018-07-23 14:21:04 +02:00
/* Adapt the server.hz value to the number of configured clients. If we have
* many clients , we want to call serverCron ( ) with an higher frequency . */
2018-07-30 13:37:30 +02:00
if ( server . dynamic_hz ) {
while ( listLength ( server . clients ) / server . hz >
MAX_CLIENTS_PER_CLOCK_TICK )
{
server . hz * = 2 ;
if ( server . hz > CONFIG_MAX_HZ ) {
server . hz = CONFIG_MAX_HZ ;
break ;
}
2018-07-23 14:21:04 +02:00
}
}
2014-12-03 12:06:54 +01:00
run_with_period ( 100 ) {
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
long long stat_net_input_bytes , stat_net_output_bytes ;
atomicGet ( server . stat_net_input_bytes , stat_net_input_bytes ) ;
atomicGet ( server . stat_net_output_bytes , stat_net_output_bytes ) ;
2015-07-27 09:41:48 +02:00
trackInstantaneousMetric ( STATS_METRIC_COMMAND , server . stat_numcommands ) ;
trackInstantaneousMetric ( STATS_METRIC_NET_INPUT ,
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
stat_net_input_bytes ) ;
2015-07-27 09:41:48 +02:00
trackInstantaneousMetric ( STATS_METRIC_NET_OUTPUT ,
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
stat_net_output_bytes ) ;
2014-12-03 12:06:54 +01:00
}
2012-03-08 16:15:37 +01:00
2015-07-27 09:41:48 +02:00
/* We have just LRU_BITS bits per object for LRU information.
2014-03-20 11:47:12 +01:00
* So we use an ( eventually wrapping ) LRU clock .
2010-06-22 00:07:48 +02:00
*
2014-03-20 11:47:12 +01:00
* Note that even if the counter wraps it ' s not a big problem ,
* everything will still work but some object will appear younger
* to Redis . However for this to happen a given object should never be
* touched for all the time needed to the counter to wrap , which is
* not likely .
2010-10-14 21:22:21 +02:00
*
* Note that you can change the resolution altering the
2015-07-27 09:41:48 +02:00
* LRU_CLOCK_RESOLUTION define . */
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
unsigned int lruclock = getLRUClock ( ) ;
atomicSet ( server . lruclock , lruclock ) ;
2010-06-22 00:07:48 +02:00
2020-08-27 11:09:32 +03:00
cronUpdateMemoryStats ( ) ;
2014-03-24 12:00:20 +01:00
2010-06-22 00:07:48 +02:00
/* We received a SIGTERM, shutting down here in a safe way, as it is
* not ok doing so inside the signal handler . */
if ( server . shutdown_asap ) {
2015-07-28 11:10:42 +02:00
if ( prepareForShutdown ( SHUTDOWN_NOFLAGS ) = = C_OK ) exit ( 0 ) ;
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " SIGTERM received but errors trying to shut down the server, check the logs for more information " ) ;
2013-01-19 13:19:41 +01:00
server . shutdown_asap = 0 ;
2010-06-22 00:07:48 +02:00
}
/* Show some info about non-empty databases */
2012-05-13 16:40:29 +02:00
run_with_period ( 5000 ) {
for ( j = 0 ; j < server . dbnum ; j + + ) {
long long size , used , vkeys ;
size = dictSlots ( server . db [ j ] . dict ) ;
used = dictSize ( server . db [ j ] . dict ) ;
vkeys = dictSize ( server . db [ j ] . expires ) ;
if ( used | | vkeys ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_VERBOSE , " DB %d: %lld keys (%lld volatile) in %lld slots HT. " , j , used , vkeys , size ) ;
2012-05-13 16:40:29 +02:00
/* dictPrintStats(server.dict); */
}
2010-06-22 00:07:48 +02:00
}
}
/* Show information about connected clients */
2012-07-23 12:54:52 +02:00
if ( ! server . sentinel_mode ) {
run_with_period ( 5000 ) {
2019-12-11 10:17:23 +01:00
serverLog ( LL_DEBUG ,
2018-09-11 10:39:24 +02:00
" %lu clients connected (%lu replicas), %zu bytes in use " ,
2012-07-23 12:54:52 +02:00
listLength ( server . clients ) - listLength ( server . slaves ) ,
listLength ( server . slaves ) ,
zmalloc_used_memory ( ) ) ;
}
2010-06-22 00:07:48 +02:00
}
2012-03-13 18:05:11 +01:00
/* We need to do a few operations on clients asynchronously. */
clientsCron ( ) ;
2010-06-22 00:07:48 +02:00
2013-03-08 13:59:50 +01:00
/* Handle background operations on Redis databases. */
databasesCron ( ) ;
2011-06-10 12:39:23 +02:00
/* Start a scheduled AOF rewrite if this was requested by the user while
* a BGSAVE was in progress . */
2019-09-27 12:03:09 +02:00
if ( ! hasActiveChildProcess ( ) & &
2011-12-21 11:58:42 +01:00
server . aof_rewrite_scheduled )
2011-06-10 12:39:23 +02:00
{
rewriteAppendOnlyFileBackground ( ) ;
}
2011-01-07 23:41:00 +01:00
/* Check if a background saving or AOF rewrite in progress terminated. */
2019-09-27 12:03:09 +02:00
if ( hasActiveChildProcess ( ) | | ldbPendingChildren ( ) )
2015-11-14 22:13:32 +01:00
{
2019-08-11 16:07:53 +03:00
checkChildrenDone ( ) ;
2011-06-25 12:22:03 +02:00
} else {
2011-06-10 12:39:23 +02:00
/* If there is not a background saving/rewrite in progress check if
2018-01-17 11:23:37 +01:00
* we have to save / rewrite now . */
2018-07-04 20:04:06 +08:00
for ( j = 0 ; j < server . saveparamslen ; j + + ) {
2010-06-22 00:07:48 +02:00
struct saveparam * sp = server . saveparams + j ;
2013-04-02 14:05:50 +02:00
/* Save if we reached the given amount of changes,
* the given amount of seconds , and if the latest bgsave was
* successful or if , in case of an error , at least
2015-07-27 09:41:48 +02:00
* CONFIG_BGSAVE_RETRY_DELAY seconds already elapsed . */
2010-06-22 00:07:48 +02:00
if ( server . dirty > = sp - > changes & &
2013-04-02 14:05:50 +02:00
server . unixtime - server . lastsave > sp - > seconds & &
( server . unixtime - server . lastbgsave_try >
2015-07-27 09:41:48 +02:00
CONFIG_BGSAVE_RETRY_DELAY | |
2015-07-26 23:17:55 +02:00
server . lastbgsave_status = = C_OK ) )
2013-04-02 14:05:50 +02:00
{
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " %d changes in %d seconds. Saving... " ,
2013-02-27 12:27:15 +01:00
sp - > changes , ( int ) sp - > seconds ) ;
2017-09-19 23:03:39 +02:00
rdbSaveInfo rsi , * rsiptr ;
rsiptr = rdbPopulateSaveInfo ( & rsi ) ;
rdbSaveBackground ( server . rdb_filename , rsiptr ) ;
2010-06-22 00:07:48 +02:00
break ;
}
2018-07-04 20:04:06 +08:00
}
/* Trigger an AOF rewrite if needed. */
if ( server . aof_state = = AOF_ON & &
2019-09-27 12:03:09 +02:00
! hasActiveChildProcess ( ) & &
2018-07-04 20:04:06 +08:00
server . aof_rewrite_perc & &
server . aof_current_size > server . aof_rewrite_min_size )
{
2011-12-21 11:58:42 +01:00
long long base = server . aof_rewrite_base_size ?
2018-07-04 20:04:06 +08:00
server . aof_rewrite_base_size : 1 ;
2011-12-21 11:58:42 +01:00
long long growth = ( server . aof_current_size * 100 / base ) - 100 ;
if ( growth > = server . aof_rewrite_perc ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " Starting automatic rewriting of AOF on %lld%% growth " , growth ) ;
2011-06-10 12:39:23 +02:00
rewriteAppendOnlyFileBackground ( ) ;
}
2018-07-04 20:04:06 +08:00
}
2010-06-22 00:07:48 +02:00
}
2011-09-16 12:35:12 +02:00
2014-02-12 16:27:59 +01:00
/* AOF postponed flush: Try at every cron cycle if the slow fsync
* completed . */
if ( server . aof_flush_postponed_start ) flushAppendOnlyFile ( 0 ) ;
/* AOF write errors: in this case we have a buffer to flush as well and
* clear the AOF error in case of success to make the DB writable again ,
* however to try every second is enough in case of ' hz ' is set to
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* a higher frequency . */
2014-02-12 16:27:59 +01:00
run_with_period ( 1000 ) {
2015-07-26 23:17:55 +02:00
if ( server . aof_last_write_status = = C_ERR )
2014-02-12 16:27:59 +01:00
flushAppendOnlyFile ( 0 ) ;
2014-02-12 12:47:10 +01:00
}
2011-09-16 12:35:12 +02:00
2014-02-04 15:52:09 +01:00
/* Clear the paused clients flag if needed. */
2016-08-03 10:56:26 +02:00
clientsArePaused ( ) ; /* Don't check return value, just use the side effect.*/
2014-02-04 15:52:09 +01:00
2016-07-21 18:34:53 +02:00
/* Replication cron function -- used to reconnect to master,
* detect transfer failures , start background RDB transfers and so forth . */
2012-05-13 16:40:29 +02:00
run_with_period ( 1000 ) replicationCron ( ) ;
2010-11-04 17:29:53 +01:00
2012-11-12 00:45:10 +01:00
/* Run the Redis Cluster cron. */
2013-10-09 16:18:33 +02:00
run_with_period ( 100 ) {
2012-05-13 16:40:29 +02:00
if ( server . cluster_enabled ) clusterCron ( ) ;
}
2011-03-29 17:51:15 +02:00
2012-11-12 00:45:10 +01:00
/* Run the Sentinel timer if we are in sentinel mode. */
2018-09-05 10:32:18 +08:00
if ( server . sentinel_mode ) sentinelTimer ( ) ;
2012-07-23 12:54:52 +02:00
2012-11-12 00:45:10 +01:00
/* Cleanup expired MIGRATE cached sockets. */
run_with_period ( 1000 ) {
migrateCloseTimedoutSockets ( ) ;
}
2019-03-25 17:05:06 +00:00
/* Stop the I/O threads if we don't have enough pending work. */
stopThreadedIOIfNeeded ( ) ;
2020-05-14 10:41:28 +02:00
/* Resize tracking keys table if needed. This is also done at every
* command execution , but we want to be sure that if the last command
* executed changes the value via CONFIG SET , the server will perform
* the operation even if completely idle . */
if ( server . tracking_clients ) trackingLimitUsedSlots ( ) ;
2016-07-21 18:34:53 +02:00
/* Start a scheduled BGSAVE if the corresponding flag is set. This is
* useful when we are forced to postpone a BGSAVE because an AOF
* rewrite is in progress .
*
* Note : this code must be after the replicationCron ( ) call above so
* make sure when refactoring this file to keep this order . This is useful
* because we want to give priority to RDB savings for replication . */
2019-09-27 12:03:09 +02:00
if ( ! hasActiveChildProcess ( ) & &
2016-07-21 18:34:53 +02:00
server . rdb_bgsave_scheduled & &
( server . unixtime - server . lastbgsave_try > CONFIG_BGSAVE_RETRY_DELAY | |
server . lastbgsave_status = = C_OK ) )
{
2017-09-19 23:03:39 +02:00
rdbSaveInfo rsi , * rsiptr ;
rsiptr = rdbPopulateSaveInfo ( & rsi ) ;
if ( rdbSaveBackground ( server . rdb_filename , rsiptr ) = = C_OK )
2016-07-21 18:34:53 +02:00
server . rdb_bgsave_scheduled = 0 ;
}
2019-10-29 17:59:09 +02:00
/* Fire the cron loop modules event. */
RedisModuleCronLoopV1 ei = { REDISMODULE_CRON_LOOP_VERSION , server . hz } ;
moduleFireServerEvent ( REDISMODULE_EVENT_CRON_LOOP ,
0 ,
& ei ) ;
2011-01-20 13:18:23 +01:00
server . cronloops + + ;
2012-12-14 17:10:40 +01:00
return 1000 / server . hz ;
2010-06-22 00:07:48 +02:00
}
2020-09-03 08:47:29 +03:00
void blockingOperationStarts ( ) {
updateCachedTime ( 0 ) ;
server . blocked_last_cron = server . mstime ;
}
void blockingOperationEnds ( ) {
server . blocked_last_cron = 0 ;
}
/* This function fill in the role of serverCron during RDB or AOF loading, and
* also during blocked scripts .
2020-08-27 11:09:32 +03:00
* It attempts to do its duties at a similar rate as the configured server . hz ,
* and updates cronloops variable so that similarly to serverCron , the
* run_with_period can be used . */
2020-09-03 08:47:29 +03:00
void whileBlockedCron ( ) {
/* Here we may want to perform some cron jobs (normally done server.hz times
* per second ) . */
/* Since this function depends on a call to blockingOperationStarts, let's
* make sure it was done . */
serverAssert ( server . blocked_last_cron ) ;
/* In case we where called too soon, leave right away. This way one time
* jobs after the loop below don ' t need an if . and we don ' t bother to start
* latency monitor if this function is called too often . */
if ( server . blocked_last_cron > = server . mstime )
return ;
mstime_t latency ;
latencyStartMonitor ( latency ) ;
/* In some cases we may be called with big intervals, so we may need to do
* extra work here . This is because some of the functions in serverCron rely
* on the fact that it is performed every 10 ms or so . For instance , if
* activeDefragCycle needs to utilize 25 % cpu , it will utilize 2.5 ms , so we
* need to call it multiple times . */
long hz_ms = 1000 / server . hz ;
while ( server . blocked_last_cron < server . mstime ) {
/* Defrag keys gradually. */
activeDefragCycle ( ) ;
server . blocked_last_cron + = hz_ms ;
2020-08-27 11:09:32 +03:00
/* Increment cronloop so that run_with_period works. */
server . cronloops + + ;
}
2020-09-03 08:47:29 +03:00
/* Other cron jobs do not need to be done in a loop. No need to check
* server . blocked_last_cron since we have an early exit at the top . */
/* Update memory stats during loading (excluding blocked scripts) */
if ( server . loading ) cronUpdateMemoryStats ( ) ;
latencyEndMonitor ( latency ) ;
latencyAddSampleIfNeeded ( " while-blocked-cron " , latency ) ;
2020-08-27 11:09:32 +03:00
}
2020-05-10 19:13:47 +03:00
extern int ProcessingEventsWhileBlocked ;
2010-06-22 00:07:48 +02:00
/* This function gets called every time Redis is entering the
* main loop of the event driven library , that is , before to sleep
2020-05-10 19:13:47 +03:00
* for ready file descriptors .
2020-05-12 13:07:44 +02:00
*
2020-05-10 19:13:47 +03:00
* Note : This function is ( currently ) called from two functions :
* 1. aeMain - The main server loop
* 2. processEventsWhileBlocked - Process clients during RDB / AOF load
2020-05-12 13:07:44 +02:00
*
2020-05-10 19:13:47 +03:00
* If it was called from processEventsWhileBlocked we don ' t want
* to perform all actions ( For example , we don ' t want to expire
* keys ) , but we do need to perform some actions .
2020-05-12 13:07:44 +02:00
*
2020-05-10 19:13:47 +03:00
* The most important is freeClientsInAsyncFreeQueue but we also
* call some other low - risk functions . */
2010-06-22 00:07:48 +02:00
void beforeSleep ( struct aeEventLoop * eventLoop ) {
2015-07-27 09:41:48 +02:00
UNUSED ( eventLoop ) ;
2010-06-22 00:07:48 +02:00
2020-05-12 13:07:44 +02:00
/* Just call a subset of vital functions in case we are re-entering
2020-05-14 10:02:57 +02:00
* the event loop from processEventsWhileBlocked ( ) . Note that in this
* case we keep track of the number of events we are processing , since
* processEventsWhileBlocked ( ) wants to stop ASAP if there are no longer
* events to handle . */
2020-05-12 13:07:44 +02:00
if ( ProcessingEventsWhileBlocked ) {
2020-05-14 10:02:57 +02:00
uint64_t processed = 0 ;
processed + = handleClientsWithPendingReadsUsingThreads ( ) ;
processed + = tlsProcessPendingData ( ) ;
processed + = handleClientsWithPendingWrites ( ) ;
processed + = freeClientsInAsyncFreeQueue ( ) ;
server . events_processed_while_blocked + = processed ;
2020-05-12 13:07:44 +02:00
return ;
2020-05-10 19:13:47 +03:00
}
2020-03-26 13:28:39 +01:00
/* Handle precise timeouts of blocked clients. */
2020-03-27 16:34:45 +01:00
handleBlockedClientsTimeout ( ) ;
2020-03-26 13:28:39 +01:00
2020-03-16 11:20:48 +08:00
/* We should handle pending reads clients ASAP after event loop. */
handleClientsWithPendingReadsUsingThreads ( ) ;
2019-08-19 12:18:25 +03:00
/* Handle TLS pending data. (must be done before flushAppendOnlyFile) */
tlsProcessPendingData ( ) ;
2020-03-26 13:28:39 +01:00
2019-08-19 12:18:25 +03:00
/* If tls still has pending unread data don't sleep at all. */
2019-10-15 17:21:33 +03:00
aeSetDontWait ( server . el , tlsHasPendingData ( ) ) ;
2019-08-19 12:18:25 +03:00
2015-03-20 09:46:10 +01:00
/* Call the Redis Cluster before sleep function. Note that this function
2015-03-21 09:19:02 +01:00
* may change the state of Redis Cluster ( from ok to fail or vice versa ) ,
2015-03-20 09:46:10 +01:00
* so it ' s a good idea to call it before serving the unblocked clients
* later in this function . */
if ( server . cluster_enabled ) clusterBeforeSleep ( ) ;
2013-08-27 09:31:43 +02:00
/* Run a fast expire cycle (the called function will return
* ASAP if a fast cycle is not needed ) . */
if ( server . active_expire_enabled & & server . masterhost = = NULL )
activeExpireCycle ( ACTIVE_EXPIRE_CYCLE_FAST ) ;
2013-08-05 12:05:22 +02:00
2019-11-26 10:43:57 +08:00
/* Unblock all the clients blocked for synchronous replication
* in WAIT . */
if ( listLength ( server . clients_waiting_acks ) )
processClientsWaitingReplicas ( ) ;
/* Check if there are clients unblocked by modules that implement
* blocking commands . */
if ( moduleCount ( ) ) moduleHandleBlockedClients ( ) ;
/* Try to process pending commands for clients that were just unblocked. */
if ( listLength ( server . unblocked_clients ) )
processUnblockedClients ( ) ;
2013-12-04 15:52:20 +01:00
/* Send all the slaves an ACK request if at least one client blocked
2020-04-29 11:16:30 +02:00
* during the previous event loop iteration . Note that we do this after
* processUnblockedClients ( ) , so if there are multiple pipelined WAITs
* and the just unblocked WAIT gets blocked again , we don ' t have to wait
* a server cron cycle in absence of other event loop events . See # 6623. */
2013-12-04 15:52:20 +01:00
if ( server . get_ack_from_slaves ) {
robj * argv [ 3 ] ;
argv [ 0 ] = createStringObject ( " REPLCONF " , 8 ) ;
argv [ 1 ] = createStringObject ( " GETACK " , 6 ) ;
argv [ 2 ] = createStringObject ( " * " , 1 ) ; /* Not used argument. */
replicationFeedSlaves ( server . slaves , server . slaveseldb , argv , 3 ) ;
decrRefCount ( argv [ 0 ] ) ;
decrRefCount ( argv [ 1 ] ) ;
decrRefCount ( argv [ 2 ] ) ;
server . get_ack_from_slaves = 0 ;
}
2020-02-12 19:22:04 +01:00
/* Send the invalidation messages to clients participating to the
* client side caching protocol in broadcasting ( BCAST ) mode . */
trackingBroadcastInvalidationMessages ( ) ;
2010-06-22 00:07:48 +02:00
/* Write the AOF buffer on disk */
2011-09-16 12:35:12 +02:00
flushAppendOnlyFile ( 0 ) ;
2015-09-28 18:25:57 +02:00
/* Handle writes with pending output buffers. */
2017-10-24 08:35:05 +02:00
handleClientsWithPendingWritesUsingThreads ( ) ;
/* Close clients that need to be closed asynchronous */
freeClientsInAsyncFreeQueue ( ) ;
2017-05-03 11:26:21 +02:00
/* Before we are going to sleep, let the threads access the dataset by
* releasing the GIL . Redis main thread will not touch anything at this
* time . */
if ( moduleCount ( ) ) moduleReleaseGIL ( ) ;
}
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
/* This function is called immediately after the event loop multiplexing
2017-05-03 11:26:21 +02:00
* API returned , and the control is going to soon return to Redis by invoking
* the different events callbacks . */
void afterSleep ( struct aeEventLoop * eventLoop ) {
UNUSED ( eventLoop ) ;
2020-05-10 19:13:47 +03:00
if ( ! ProcessingEventsWhileBlocked ) {
if ( moduleCount ( ) ) moduleAcquireGIL ( ) ;
}
2010-06-22 00:07:48 +02:00
}
/* =========================== Server initialization ======================== */
void createSharedObjects ( void ) {
int j ;
2015-07-26 15:28:00 +02:00
shared . crlf = createObject ( OBJ_STRING , sdsnew ( " \r \n " ) ) ;
shared . ok = createObject ( OBJ_STRING , sdsnew ( " +OK \r \n " ) ) ;
shared . err = createObject ( OBJ_STRING , sdsnew ( " -ERR \r \n " ) ) ;
shared . emptybulk = createObject ( OBJ_STRING , sdsnew ( " $0 \r \n \r \n " ) ) ;
shared . czero = createObject ( OBJ_STRING , sdsnew ( " :0 \r \n " ) ) ;
shared . cone = createObject ( OBJ_STRING , sdsnew ( " :1 \r \n " ) ) ;
2018-11-26 18:55:05 +01:00
shared . emptyarray = createObject ( OBJ_STRING , sdsnew ( " *0 \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . pong = createObject ( OBJ_STRING , sdsnew ( " +PONG \r \n " ) ) ;
shared . queued = createObject ( OBJ_STRING , sdsnew ( " +QUEUED \r \n " ) ) ;
shared . emptyscan = createObject ( OBJ_STRING , sdsnew ( " *2 \r \n $1 \r \n 0 \r \n *0 \r \n " ) ) ;
shared . wrongtypeerr = createObject ( OBJ_STRING , sdsnew (
2012-11-06 20:25:34 +01:00
" -WRONGTYPE Operation against a key holding the wrong kind of value \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . nokeyerr = createObject ( OBJ_STRING , sdsnew (
2010-06-22 00:07:48 +02:00
" -ERR no such key \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . syntaxerr = createObject ( OBJ_STRING , sdsnew (
2010-06-22 00:07:48 +02:00
" -ERR syntax error \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . sameobjecterr = createObject ( OBJ_STRING , sdsnew (
2010-06-22 00:07:48 +02:00
" -ERR source and destination objects are the same \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . outofrangeerr = createObject ( OBJ_STRING , sdsnew (
2010-06-22 00:07:48 +02:00
" -ERR index out of range \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . noscripterr = createObject ( OBJ_STRING , sdsnew (
2011-05-13 22:02:38 +02:00
" -NOSCRIPT No matching script. Please use EVAL. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . loadingerr = createObject ( OBJ_STRING , sdsnew (
2010-11-08 11:52:03 +01:00
" -LOADING Redis is loading the dataset in memory \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . slowscripterr = createObject ( OBJ_STRING , sdsnew (
2011-11-18 14:10:48 +01:00
" -BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . masterdownerr = createObject ( OBJ_STRING , sdsnew (
2018-09-11 10:39:24 +02:00
" -MASTERDOWN Link with MASTER is down and replica-serve-stale-data is set to 'no'. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . bgsaveerr = createObject ( OBJ_STRING , sdsnew (
2017-05-19 12:03:30 +02:00
" -MISCONF Redis is configured to save RDB snapshots, but it is currently not able to persist on disk. Commands that may modify the data set are disabled, because this instance is configured to report errors during writes if RDB snapshotting fails (stop-writes-on-bgsave-error option). Please check the Redis logs for details about the RDB error. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . roslaveerr = createObject ( OBJ_STRING , sdsnew (
2018-09-11 10:39:24 +02:00
" -READONLY You can't write against a read only replica. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . noautherr = createObject ( OBJ_STRING , sdsnew (
2013-02-12 16:25:41 +01:00
" -NOAUTH Authentication required. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . oomerr = createObject ( OBJ_STRING , sdsnew (
2012-03-21 12:11:07 +01:00
" -OOM command not allowed when used memory > 'maxmemory'. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . execaborterr = createObject ( OBJ_STRING , sdsnew (
2012-11-15 20:11:05 +01:00
" -EXECABORT Transaction discarded because of previous errors. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . noreplicaserr = createObject ( OBJ_STRING , sdsnew (
2018-09-11 10:39:24 +02:00
" -NOREPLICAS Not enough good replicas to write. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . busykeyerr = createObject ( OBJ_STRING , sdsnew (
2014-05-12 10:01:59 +02:00
" -BUSYKEY Target key name already exists. \r \n " ) ) ;
2015-07-26 15:28:00 +02:00
shared . space = createObject ( OBJ_STRING , sdsnew ( " " ) ) ;
shared . colon = createObject ( OBJ_STRING , sdsnew ( " : " ) ) ;
shared . plus = createObject ( OBJ_STRING , sdsnew ( " + " ) ) ;
2012-03-30 02:06:53 +09:00
2018-11-30 09:41:54 +01:00
/* The shared NULL depends on the protocol version. */
shared . null [ 0 ] = NULL ;
shared . null [ 1 ] = NULL ;
2018-11-30 16:32:06 +01:00
shared . null [ 2 ] = createObject ( OBJ_STRING , sdsnew ( " $-1 \r \n " ) ) ;
2018-11-30 09:41:54 +01:00
shared . null [ 3 ] = createObject ( OBJ_STRING , sdsnew ( " _ \r \n " ) ) ;
2018-11-30 16:32:06 +01:00
shared . nullarray [ 0 ] = NULL ;
shared . nullarray [ 1 ] = NULL ;
shared . nullarray [ 2 ] = createObject ( OBJ_STRING , sdsnew ( " *-1 \r \n " ) ) ;
shared . nullarray [ 3 ] = createObject ( OBJ_STRING , sdsnew ( " _ \r \n " ) ) ;
2019-09-02 12:50:47 +02:00
shared . emptymap [ 0 ] = NULL ;
shared . emptymap [ 1 ] = NULL ;
shared . emptymap [ 2 ] = createObject ( OBJ_STRING , sdsnew ( " *0 \r \n " ) ) ;
shared . emptymap [ 3 ] = createObject ( OBJ_STRING , sdsnew ( " %0 \r \n " ) ) ;
shared . emptyset [ 0 ] = NULL ;
shared . emptyset [ 1 ] = NULL ;
shared . emptyset [ 2 ] = createObject ( OBJ_STRING , sdsnew ( " *0 \r \n " ) ) ;
shared . emptyset [ 3 ] = createObject ( OBJ_STRING , sdsnew ( " ~0 \r \n " ) ) ;
2015-07-27 09:41:48 +02:00
for ( j = 0 ; j < PROTO_SHARED_SELECT_CMDS ; j + + ) {
2012-11-03 12:15:29 +01:00
char dictid_str [ 64 ] ;
int dictid_len ;
dictid_len = ll2string ( dictid_str , sizeof ( dictid_str ) , j ) ;
2015-07-26 15:28:00 +02:00
shared . select [ j ] = createObject ( OBJ_STRING ,
2012-11-03 12:15:29 +01:00
sdscatprintf ( sdsempty ( ) ,
" *2 \r \n $6 \r \n SELECT \r \n $%d \r \n %s \r \n " ,
dictid_len , dictid_str ) ) ;
2012-03-30 02:06:53 +09:00
}
2010-06-22 00:07:48 +02:00
shared . messagebulk = createStringObject ( " $7 \r \n message \r \n " , 13 ) ;
shared . pmessagebulk = createStringObject ( " $8 \r \n pmessage \r \n " , 14 ) ;
shared . subscribebulk = createStringObject ( " $9 \r \n subscribe \r \n " , 15 ) ;
shared . unsubscribebulk = createStringObject ( " $11 \r \n unsubscribe \r \n " , 18 ) ;
shared . psubscribebulk = createStringObject ( " $10 \r \n psubscribe \r \n " , 17 ) ;
shared . punsubscribebulk = createStringObject ( " $12 \r \n punsubscribe \r \n " , 19 ) ;
2012-02-04 08:58:37 +01:00
shared . del = createStringObject ( " DEL " , 3 ) ;
2015-10-02 15:27:57 +02:00
shared . unlink = createStringObject ( " UNLINK " , 6 ) ;
2012-02-29 14:41:57 +01:00
shared . rpop = createStringObject ( " RPOP " , 4 ) ;
shared . lpop = createStringObject ( " LPOP " , 4 ) ;
A reimplementation of blocking operation internals.
Redis provides support for blocking operations such as BLPOP or BRPOP.
This operations are identical to normal LPOP and RPOP operations as long
as there are elements in the target list, but if the list is empty they
block waiting for new data to arrive to the list.
All the clients blocked waiting for th same list are served in a FIFO
way, so the first that blocked is the first to be served when there is
more data pushed by another client into the list.
The previous implementation of blocking operations was conceived to
serve clients in the context of push operations. For for instance:
1) There is a client "A" blocked on list "foo".
2) The client "B" performs `LPUSH foo somevalue`.
3) The client "A" is served in the context of the "B" LPUSH,
synchronously.
Processing things in a synchronous way was useful as if "A" pushes a
value that is served by "B", from the point of view of the database is a
NOP (no operation) thing, that is, nothing is replicated, nothing is
written in the AOF file, and so forth.
However later we implemented two things:
1) Variadic LPUSH that could add multiple values to a list in the
context of a single call.
2) BRPOPLPUSH that was a version of BRPOP that also provided a "PUSH"
side effect when receiving data.
This forced us to make the synchronous implementation more complex. If
client "B" is waiting for data, and "A" pushes three elemnents in a
single call, we needed to propagate an LPUSH with a missing argument
in the AOF and replication link. We also needed to make sure to
replicate the LPUSH side of BRPOPLPUSH, but only if in turn did not
happened to serve another blocking client into another list ;)
This were complex but with a few of mutually recursive functions
everything worked as expected... until one day we introduced scripting
in Redis.
Scripting + synchronous blocking operations = Issue #614.
Basically you can't "rewrite" a script to have just a partial effect on
the replicas and AOF file if the script happened to serve a few blocked
clients.
The solution to all this problems, implemented by this commit, is to
change the way we serve blocked clients. Instead of serving the blocked
clients synchronously, in the context of the command performing the PUSH
operation, it is now an asynchronous and iterative process:
1) If a key that has clients blocked waiting for data is the subject of
a list push operation, We simply mark keys as "ready" and put it into a
queue.
2) Every command pushing stuff on lists, as a variadic LPUSH, a script,
or whatever it is, is replicated verbatim without any rewriting.
3) Every time a Redis command, a MULTI/EXEC block, or a script,
completed its execution, we run the list of keys ready to serve blocked
clients (as more data arrived), and process this list serving the
blocked clients.
4) As a result of "3" maybe more keys are ready again for other clients
(as a result of BRPOPLPUSH we may have push operations), so we iterate
back to step "3" if it's needed.
The new code has a much simpler semantics, and a simpler to understand
implementation, with the disadvantage of not being able to "optmize out"
a PUSH+BPOP as a No OP.
This commit will be tested with care before the final merge, more tests
will be added likely.
2012-09-04 10:37:49 +02:00
shared . lpush = createStringObject ( " LPUSH " , 5 ) ;
2018-08-14 20:58:58 +08:00
shared . rpoplpush = createStringObject ( " RPOPLPUSH " , 9 ) ;
2018-05-11 17:31:46 +02:00
shared . zpopmin = createStringObject ( " ZPOPMIN " , 7 ) ;
shared . zpopmax = createStringObject ( " ZPOPMAX " , 7 ) ;
2019-11-22 15:32:43 +08:00
shared . multi = createStringObject ( " MULTI " , 5 ) ;
shared . exec = createStringObject ( " EXEC " , 4 ) ;
2015-07-27 09:41:48 +02:00
for ( j = 0 ; j < OBJ_SHARED_INTEGERS ; j + + ) {
2015-07-30 11:46:31 +02:00
shared . integers [ j ] =
makeObjectShared ( createObject ( OBJ_STRING , ( void * ) ( long ) j ) ) ;
2015-07-26 15:28:00 +02:00
shared . integers [ j ] - > encoding = OBJ_ENCODING_INT ;
2010-06-22 00:07:48 +02:00
}
2015-07-27 09:41:48 +02:00
for ( j = 0 ; j < OBJ_SHARED_BULKHDR_LEN ; j + + ) {
2015-07-26 15:28:00 +02:00
shared . mbulkhdr [ j ] = createObject ( OBJ_STRING ,
2012-02-04 08:58:37 +01:00
sdscatprintf ( sdsempty ( ) , " *%d \r \n " , j ) ) ;
2015-07-26 15:28:00 +02:00
shared . bulkhdr [ j ] = createObject ( OBJ_STRING ,
2012-02-04 08:58:37 +01:00
sdscatprintf ( sdsempty ( ) , " $%d \r \n " , j ) ) ;
}
2012-02-04 08:11:31 +01:00
/* The following two shared objects, minstring and maxstrings, are not
* actually used for their value but as a special object meaning
* respectively the minimum possible string and the maximum possible
* string in string comparisons for the ZRANGEBYLEX command . */
2015-08-04 09:20:55 +02:00
shared . minstring = sdsnew ( " minstring " ) ;
shared . maxstring = sdsnew ( " maxstring " ) ;
2010-06-22 00:07:48 +02:00
}
2014-03-16 08:51:54 +09:00
void initServerConfig ( void ) {
2013-05-13 18:34:18 +02:00
int j ;
2019-11-05 10:14:34 +01:00
updateCachedTime ( 1 ) ;
2015-07-27 09:41:48 +02:00
getRandomHexChars ( server . runid , CONFIG_RUN_ID_SIZE ) ;
PSYNC2: different improvements to Redis replication.
The gist of the changes is that now, partial resynchronizations between
slaves and masters (without the need of a full resync with RDB transfer
and so forth), work in a number of cases when it was impossible
in the past. For instance:
1. When a slave is promoted to mastrer, the slaves of the old master can
partially resynchronize with the new master.
2. Chained slalves (slaves of slaves) can be moved to replicate to other
slaves or the master itsef, without requiring a full resync.
3. The master itself, after being turned into a slave, is able to
partially resynchronize with the new master, when it joins replication
again.
In order to obtain this, the following main changes were operated:
* Slaves also take a replication backlog, not just masters.
* Same stream replication for all the slaves and sub slaves. The
replication stream is identical from the top level master to its slaves
and is also the same from the slaves to their sub-slaves and so forth.
This means that if a slave is later promoted to master, it has the
same replication backlong, and can partially resynchronize with its
slaves (that were previously slaves of the old master).
* A given replication history is no longer identified by the `runid` of
a Redis node. There is instead a `replication ID` which changes every
time the instance has a new history no longer coherent with the past
one. So, for example, slaves publish the same replication history of
their master, however when they are turned into masters, they publish
a new replication ID, but still remember the old ID, so that they are
able to partially resynchronize with slaves of the old master (up to a
given offset).
* The replication protocol was slightly modified so that a new extended
+CONTINUE reply from the master is able to inform the slave of a
replication ID change.
* REPLCONF CAPA is used in order to notify masters that a slave is able
to understand the new +CONTINUE reply.
* The RDB file was extended with an auxiliary field that is able to
select a given DB after loading in the slave, so that the slave can
continue receiving the replication stream from the point it was
disconnected without requiring the master to insert "SELECT" statements.
This is useful in order to guarantee the "same stream" property, because
the slave must be able to accumulate an identical backlog.
* Slave pings to sub-slaves are now sent in a special form, when the
top-level master is disconnected, in order to don't interfer with the
replication stream. We just use out of band "\n" bytes as in other parts
of the Redis protocol.
An old design document is available here:
https://gist.github.com/antirez/ae068f95c0d084891305
However the implementation is not identical to the description because
during the work to implement it, different changes were needed in order
to make things working well.
2016-11-09 11:31:06 +01:00
server . runid [ CONFIG_RUN_ID_SIZE ] = ' \0 ' ;
changeReplicationId ( ) ;
2016-11-23 16:12:20 +01:00
clearReplicationId2 ( ) ;
2019-12-16 11:24:19 +01:00
server . hz = CONFIG_DEFAULT_HZ ; /* Initialize it ASAP, even if it may get
updated later after loading the config .
This value may be used before the server
is initialized . */
2018-10-26 14:02:09 +00:00
server . timezone = getTimeZone ( ) ; /* Initialized by tzset(). */
2013-05-09 16:57:59 +02:00
server . configfile = NULL ;
2015-10-13 10:58:08 +02:00
server . executable = NULL ;
2012-02-02 10:02:40 +01:00
server . arch_bits = ( sizeof ( long ) = = 8 ) ? 64 : 32 ;
2013-07-04 18:50:15 +02:00
server . bindaddr_count = 0 ;
2015-07-26 15:14:57 +02:00
server . unixsocketperm = CONFIG_DEFAULT_UNIX_SOCKET_PERM ;
2013-07-05 11:47:20 +02:00
server . ipfd_count = 0 ;
2019-09-12 10:56:54 +03:00
server . tlsfd_count = 0 ;
2010-08-03 13:33:12 +02:00
server . sofd = - 1 ;
2013-03-27 17:55:02 +01:00
server . active_expire_enabled = 1 ;
2015-07-27 09:41:48 +02:00
server . client_max_querybuf_len = PROTO_MAX_QUERYBUF_LEN ;
2010-06-22 00:07:48 +02:00
server . saveparams = NULL ;
2010-11-08 11:52:03 +01:00
server . loading = 0 ;
2015-07-26 15:14:57 +02:00
server . logfile = zstrdup ( CONFIG_DEFAULT_LOGFILE ) ;
2015-07-27 09:41:48 +02:00
server . aof_state = AOF_OFF ;
2011-12-21 11:58:42 +01:00
server . aof_rewrite_base_size = 0 ;
server . aof_rewrite_scheduled = 0 ;
2019-08-19 12:18:25 +03:00
server . aof_flush_sleep = 0 ;
2011-12-21 12:17:02 +01:00
server . aof_last_fsync = time ( NULL ) ;
2012-05-25 12:11:30 +02:00
server . aof_rewrite_time_last = - 1 ;
server . aof_rewrite_time_start = - 1 ;
2015-07-26 23:17:55 +02:00
server . aof_lastbgrewrite_status = C_OK ;
2012-03-25 11:27:35 +02:00
server . aof_delayed_fsync = 0 ;
2011-12-21 12:17:02 +01:00
server . aof_fd = - 1 ;
server . aof_selected_db = - 1 ; /* Make sure the first time will not match */
2011-09-16 12:35:12 +02:00
server . aof_flush_postponed_start = 0 ;
2014-08-25 17:07:37 -04:00
server . pidfile = NULL ;
2016-12-30 03:37:52 +02:00
server . active_defrag_running = 0 ;
2013-01-23 16:23:33 +01:00
server . notify_keyspace_events = 0 ;
2017-09-09 11:10:59 +02:00
server . blocked_clients = 0 ;
memset ( server . blocked_clients_by_type , 0 ,
sizeof ( server . blocked_clients_by_type ) ) ;
2010-06-22 00:07:48 +02:00
server . shutdown_asap = 0 ;
2015-07-26 15:14:57 +02:00
server . cluster_configfile = zstrdup ( CONFIG_DEFAULT_CLUSTER_CONFIG_FILE ) ;
2018-09-19 11:31:22 +02:00
server . cluster_module_flags = CLUSTER_MODULE_FLAG_NONE ;
2012-11-12 00:45:10 +01:00
server . migrate_cached_sockets = dictCreate ( & migrateCacheDictType , NULL ) ;
2014-06-16 14:22:55 +02:00
server . next_client_id = 1 ; /* Client IDs, start from 1 .*/
2012-12-12 15:59:22 +02:00
server . loading_process_events_interval_bytes = ( 1024 * 1024 * 2 ) ;
2010-06-22 00:07:48 +02:00
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
unsigned int lruclock = getLRUClock ( ) ;
atomicSet ( server . lruclock , lruclock ) ;
2010-06-22 00:07:48 +02:00
resetServerSaveParams ( ) ;
appendServerSaveParams ( 60 * 60 , 1 ) ; /* save after 1 hour and 1 change */
appendServerSaveParams ( 300 , 100 ) ; /* save after 5 minutes and 100 changes */
appendServerSaveParams ( 60 , 10000 ) ; /* save after 1 minute and 10000 changes */
2015-10-02 15:27:57 +02:00
2010-06-22 00:07:48 +02:00
/* Replication related */
server . masterauth = NULL ;
server . masterhost = NULL ;
server . masterport = 6379 ;
server . master = NULL ;
2013-01-30 18:33:16 +01:00
server . cached_master = NULL ;
PSYNC2: different improvements to Redis replication.
The gist of the changes is that now, partial resynchronizations between
slaves and masters (without the need of a full resync with RDB transfer
and so forth), work in a number of cases when it was impossible
in the past. For instance:
1. When a slave is promoted to mastrer, the slaves of the old master can
partially resynchronize with the new master.
2. Chained slalves (slaves of slaves) can be moved to replicate to other
slaves or the master itsef, without requiring a full resync.
3. The master itself, after being turned into a slave, is able to
partially resynchronize with the new master, when it joins replication
again.
In order to obtain this, the following main changes were operated:
* Slaves also take a replication backlog, not just masters.
* Same stream replication for all the slaves and sub slaves. The
replication stream is identical from the top level master to its slaves
and is also the same from the slaves to their sub-slaves and so forth.
This means that if a slave is later promoted to master, it has the
same replication backlong, and can partially resynchronize with its
slaves (that were previously slaves of the old master).
* A given replication history is no longer identified by the `runid` of
a Redis node. There is instead a `replication ID` which changes every
time the instance has a new history no longer coherent with the past
one. So, for example, slaves publish the same replication history of
their master, however when they are turned into masters, they publish
a new replication ID, but still remember the old ID, so that they are
able to partially resynchronize with slaves of the old master (up to a
given offset).
* The replication protocol was slightly modified so that a new extended
+CONTINUE reply from the master is able to inform the slave of a
replication ID change.
* REPLCONF CAPA is used in order to notify masters that a slave is able
to understand the new +CONTINUE reply.
* The RDB file was extended with an auxiliary field that is able to
select a given DB after loading in the slave, so that the slave can
continue receiving the replication stream from the point it was
disconnected without requiring the master to insert "SELECT" statements.
This is useful in order to guarantee the "same stream" property, because
the slave must be able to accumulate an identical backlog.
* Slave pings to sub-slaves are now sent in a special form, when the
top-level master is disconnected, in order to don't interfer with the
replication stream. We just use out of band "\n" bytes as in other parts
of the Redis protocol.
An old design document is available here:
https://gist.github.com/antirez/ae068f95c0d084891305
However the implementation is not identical to the description because
during the work to implement it, different changes were needed in order
to make things working well.
2016-11-09 11:31:06 +01:00
server . master_initial_offset = - 1 ;
2015-07-27 09:41:48 +02:00
server . repl_state = REPL_STATE_NONE ;
2019-07-01 15:22:29 +03:00
server . repl_transfer_tmpfile = NULL ;
server . repl_transfer_fd = - 1 ;
2019-09-12 10:56:54 +03:00
server . repl_transfer_s = NULL ;
2015-07-27 09:41:48 +02:00
server . repl_syncio_timeout = CONFIG_REPL_SYNCIO_TIMEOUT ;
2013-03-13 12:51:10 +01:00
server . repl_down_since = 0 ; /* Never connected, repl is down since EVER. */
2013-01-30 18:33:16 +01:00
server . master_repl_offset = 0 ;
/* Replication partial resync backlog */
server . repl_backlog = NULL ;
server . repl_backlog_histlen = 0 ;
server . repl_backlog_idx = 0 ;
server . repl_backlog_off = 0 ;
server . repl_no_slaves_since = time ( NULL ) ;
2010-06-22 00:07:48 +02:00
2012-01-23 16:12:37 +01:00
/* Client output buffer limits */
2015-07-28 16:58:04 +02:00
for ( j = 0 ; j < CLIENT_TYPE_OBUF_COUNT ; j + + )
2013-05-13 18:34:18 +02:00
server . client_obuf_limits [ j ] = clientBufferLimitsDefaults [ j ] ;
2012-01-23 16:12:37 +01:00
2020-08-12 17:58:56 +03:00
/* Linux OOM Score config */
for ( j = 0 ; j < CONFIG_OOM_COUNT ; j + + )
server . oom_score_adj_values [ j ] = configOOMScoreAdjValuesDefaults [ j ] ;
2010-06-22 00:07:48 +02:00
/* Double constants initialization */
R_Zero = 0.0 ;
R_PosInf = 1.0 / R_Zero ;
R_NegInf = - 1.0 / R_Zero ;
R_Nan = R_Zero / R_Zero ;
2010-11-03 12:14:36 +01:00
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
/* Command table -- we initialize it here as it is part of the
2010-11-03 12:14:36 +01:00
* initial configuration , since command names may be changed via
* redis . conf using the rename - command directive . */
server . commands = dictCreate ( & commandTableDictType , NULL ) ;
2013-03-06 16:28:26 +01:00
server . orig_commands = dictCreate ( & commandTableDictType , NULL ) ;
2010-11-03 12:14:36 +01:00
populateCommandTable ( ) ;
server . delCommand = lookupCommandByCString ( " del " ) ;
server . multiCommand = lookupCommandByCString ( " multi " ) ;
2012-02-28 18:03:08 +01:00
server . lpushCommand = lookupCommandByCString ( " lpush " ) ;
A reimplementation of blocking operation internals.
Redis provides support for blocking operations such as BLPOP or BRPOP.
This operations are identical to normal LPOP and RPOP operations as long
as there are elements in the target list, but if the list is empty they
block waiting for new data to arrive to the list.
All the clients blocked waiting for th same list are served in a FIFO
way, so the first that blocked is the first to be served when there is
more data pushed by another client into the list.
The previous implementation of blocking operations was conceived to
serve clients in the context of push operations. For for instance:
1) There is a client "A" blocked on list "foo".
2) The client "B" performs `LPUSH foo somevalue`.
3) The client "A" is served in the context of the "B" LPUSH,
synchronously.
Processing things in a synchronous way was useful as if "A" pushes a
value that is served by "B", from the point of view of the database is a
NOP (no operation) thing, that is, nothing is replicated, nothing is
written in the AOF file, and so forth.
However later we implemented two things:
1) Variadic LPUSH that could add multiple values to a list in the
context of a single call.
2) BRPOPLPUSH that was a version of BRPOP that also provided a "PUSH"
side effect when receiving data.
This forced us to make the synchronous implementation more complex. If
client "B" is waiting for data, and "A" pushes three elemnents in a
single call, we needed to propagate an LPUSH with a missing argument
in the AOF and replication link. We also needed to make sure to
replicate the LPUSH side of BRPOPLPUSH, but only if in turn did not
happened to serve another blocking client into another list ;)
This were complex but with a few of mutually recursive functions
everything worked as expected... until one day we introduced scripting
in Redis.
Scripting + synchronous blocking operations = Issue #614.
Basically you can't "rewrite" a script to have just a partial effect on
the replicas and AOF file if the script happened to serve a few blocked
clients.
The solution to all this problems, implemented by this commit, is to
change the way we serve blocked clients. Instead of serving the blocked
clients synchronously, in the context of the command performing the PUSH
operation, it is now an asynchronous and iterative process:
1) If a key that has clients blocked waiting for data is the subject of
a list push operation, We simply mark keys as "ready" and put it into a
queue.
2) Every command pushing stuff on lists, as a variadic LPUSH, a script,
or whatever it is, is replicated verbatim without any rewriting.
3) Every time a Redis command, a MULTI/EXEC block, or a script,
completed its execution, we run the list of keys ready to serve blocked
clients (as more data arrived), and process this list serving the
blocked clients.
4) As a result of "3" maybe more keys are ready again for other clients
(as a result of BRPOPLPUSH we may have push operations), so we iterate
back to step "3" if it's needed.
The new code has a much simpler semantics, and a simpler to understand
implementation, with the disadvantage of not being able to "optmize out"
a PUSH+BPOP as a No OP.
This commit will be tested with care before the final merge, more tests
will be added likely.
2012-09-04 10:37:49 +02:00
server . lpopCommand = lookupCommandByCString ( " lpop " ) ;
server . rpopCommand = lookupCommandByCString ( " rpop " ) ;
2018-05-11 17:31:46 +02:00
server . zpopminCommand = lookupCommandByCString ( " zpopmin " ) ;
server . zpopmaxCommand = lookupCommandByCString ( " zpopmax " ) ;
2015-02-09 22:49:27 +01:00
server . sremCommand = lookupCommandByCString ( " srem " ) ;
2015-10-29 12:39:07 +01:00
server . execCommand = lookupCommandByCString ( " exec " ) ;
2017-06-16 17:51:38 +08:00
server . expireCommand = lookupCommandByCString ( " expire " ) ;
server . pexpireCommand = lookupCommandByCString ( " pexpire " ) ;
2018-03-19 14:16:13 +01:00
server . xclaimCommand = lookupCommandByCString ( " xclaim " ) ;
2018-10-10 12:51:02 +02:00
server . xgroupCommand = lookupCommandByCString ( " xgroup " ) ;
2019-11-22 16:38:49 +08:00
server . rpoplpushCommand = lookupCommandByCString ( " rpoplpush " ) ;
2014-06-26 18:48:40 +02:00
2012-03-27 11:47:51 +02:00
/* Debugging */
server . watchdog_period = 0 ;
2018-09-05 19:33:56 +02:00
/* By default we want scripts to be always replicated by effects
* ( single commands executed by the script ) , and not by sending the
* script to the slave / AOF . This is the new way starting from
* Redis 5. However it is possible to revert it via redis . conf . */
server . lua_always_replicate_commands = 1 ;
2019-11-26 16:52:28 +02:00
initConfigValues ( ) ;
2010-06-22 00:07:48 +02:00
}
2015-10-13 10:58:08 +02:00
extern char * * environ ;
/* Restart the server, executing the same executable that started this
* instance , with the same arguments and configuration file .
*
2015-10-13 11:08:24 +02:00
* The function is designed to directly call execve ( ) so that the new
* server instance will retain the PID of the previous one .
*
2015-10-13 10:58:08 +02:00
* The list of flags , that may be bitwise ORed together , alter the
* behavior of this function :
*
* RESTART_SERVER_NONE No flags .
* RESTART_SERVER_GRACEFULLY Do a proper shutdown before restarting .
* RESTART_SERVER_CONFIG_REWRITE Rewrite the config file before restarting .
*
* On success the function does not return , because the process turns into
* a different process . On error C_ERR is returned . */
int restartServer ( int flags , mstime_t delay ) {
int j ;
/* Check if we still have accesses to the executable that started this
* server instance . */
2017-11-30 18:08:21 +01:00
if ( access ( server . executable , X_OK ) = = - 1 ) {
serverLog ( LL_WARNING , " Can't restart: this process has no "
" permissions to execute %s " , server . executable ) ;
return C_ERR ;
}
2015-10-13 10:58:08 +02:00
/* Config rewriting. */
if ( flags & RESTART_SERVER_CONFIG_REWRITE & &
server . configfile & &
2020-09-09 15:43:11 +03:00
rewriteConfig ( server . configfile , 0 ) = = - 1 )
2017-11-30 18:08:21 +01:00
{
serverLog ( LL_WARNING , " Can't restart: configuration rewrite process "
" failed " ) ;
return C_ERR ;
}
2015-10-13 10:58:08 +02:00
/* Perform a proper shutdown. */
if ( flags & RESTART_SERVER_GRACEFULLY & &
2017-11-30 18:08:21 +01:00
prepareForShutdown ( SHUTDOWN_NOFLAGS ) ! = C_OK )
{
serverLog ( LL_WARNING , " Can't restart: error preparing for shutdown " ) ;
return C_ERR ;
}
2015-10-13 10:58:08 +02:00
/* Close all file descriptors, with the exception of stdin, stdout, strerr
* which are useful if we restart a Redis server which is not daemonized . */
2017-07-05 15:40:25 +02:00
for ( j = 3 ; j < ( int ) server . maxclients + 1024 ; j + + ) {
/* Test the descriptor validity before closing it, otherwise
* Valgrind issues a warning on close ( ) . */
if ( fcntl ( j , F_GETFD ) ! = - 1 ) close ( j ) ;
}
2015-10-13 10:58:08 +02:00
/* Execute the server with the original command line. */
if ( delay ) usleep ( delay * 1000 ) ;
2017-11-30 18:30:06 +01:00
zfree ( server . exec_argv [ 0 ] ) ;
server . exec_argv [ 0 ] = zstrdup ( server . executable ) ;
2015-10-13 10:58:08 +02:00
execve ( server . executable , server . exec_argv , environ ) ;
/* If an error occurred here, there is nothing we can do, but exit. */
_exit ( 1 ) ;
return C_ERR ; /* Never reached. */
}
2020-08-12 17:58:56 +03:00
static void readOOMScoreAdj ( void ) {
# ifdef HAVE_PROC_OOM_SCORE_ADJ
char buf [ 64 ] ;
int fd = open ( " /proc/self/oom_score_adj " , O_RDONLY ) ;
if ( fd < 0 ) return ;
if ( read ( fd , buf , sizeof ( buf ) ) > 0 )
server . oom_score_adj_base = atoi ( buf ) ;
close ( fd ) ;
# endif
}
/* This function will configure the current process's oom_score_adj according
* to user specified configuration . This is currently implemented on Linux
* only .
*
* A process_class value of - 1 implies OOM_CONFIG_MASTER or OOM_CONFIG_REPLICA ,
* depending on current role .
*/
int setOOMScoreAdj ( int process_class ) {
if ( ! server . oom_score_adj ) return C_OK ;
if ( process_class = = - 1 )
process_class = ( server . masterhost ? CONFIG_OOM_REPLICA : CONFIG_OOM_MASTER ) ;
serverAssert ( process_class > = 0 & & process_class < CONFIG_OOM_COUNT ) ;
# ifdef HAVE_PROC_OOM_SCORE_ADJ
2020-08-21 16:37:49 -04:00
int fd ;
int val ;
char buf [ 64 ] ;
2020-08-12 17:58:56 +03:00
val = server . oom_score_adj_base + server . oom_score_adj_values [ process_class ] ;
if ( val > 1000 ) val = 1000 ;
if ( val < - 1000 ) val = - 1000 ;
snprintf ( buf , sizeof ( buf ) - 1 , " %d \n " , val ) ;
fd = open ( " /proc/self/oom_score_adj " , O_WRONLY ) ;
if ( fd < 0 | | write ( fd , buf , strlen ( buf ) ) < 0 ) {
serverLog ( LOG_WARNING , " Unable to write oom_score_adj: %s " , strerror ( errno ) ) ;
if ( fd ! = - 1 ) close ( fd ) ;
return C_ERR ;
}
close ( fd ) ;
return C_OK ;
# else
/* Unsupported */
return C_ERR ;
# endif
}
2011-12-15 11:42:40 +01:00
/* This function will try to raise the max number of open files accordingly to
2014-03-22 19:15:04 -04:00
* the configured max number of clients . It also reserves a number of file
2015-07-27 09:41:48 +02:00
* descriptors ( CONFIG_MIN_RESERVED_FDS ) for extra operations of
2014-03-22 19:15:04 -04:00
* persistence , listening sockets , log files and so forth .
2011-12-15 11:42:40 +01:00
*
* If it will not be possible to set the limit accordingly to the configured
* max number of clients , the function will do the reverse setting
* server . maxclients to the value that we can actually handle . */
void adjustOpenFilesLimit ( void ) {
2015-07-27 09:41:48 +02:00
rlim_t maxfiles = server . maxclients + CONFIG_MIN_RESERVED_FDS ;
2011-12-15 11:42:40 +01:00
struct rlimit limit ;
if ( getrlimit ( RLIMIT_NOFILE , & limit ) = = - 1 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Unable to obtain the current NOFILE limit (%s), assuming 1024 and setting the max clients configuration accordingly. " ,
2011-12-15 11:42:40 +01:00
strerror ( errno ) ) ;
2015-07-27 09:41:48 +02:00
server . maxclients = 1024 - CONFIG_MIN_RESERVED_FDS ;
2011-12-15 11:42:40 +01:00
} else {
rlim_t oldlimit = limit . rlim_cur ;
/* Set the max number of files if the current limit is not enough
* for our needs . */
if ( oldlimit < maxfiles ) {
2014-12-19 10:04:15 +01:00
rlim_t bestlimit ;
2014-03-25 09:01:46 +01:00
int setrlimit_error = 0 ;
/* Try to set the file limit to match 'maxfiles' or at least
* to the higher value supported less than maxfiles . */
2014-12-19 10:04:15 +01:00
bestlimit = maxfiles ;
while ( bestlimit > oldlimit ) {
2014-08-13 11:44:38 +02:00
rlim_t decr_step = 16 ;
2014-03-25 09:01:46 +01:00
2014-12-19 10:04:15 +01:00
limit . rlim_cur = bestlimit ;
limit . rlim_max = bestlimit ;
2012-04-03 11:53:45 +02:00
if ( setrlimit ( RLIMIT_NOFILE , & limit ) ! = - 1 ) break ;
2014-03-25 09:01:46 +01:00
setrlimit_error = errno ;
2014-12-19 10:04:15 +01:00
/* We failed to set file limit to 'bestlimit'. Try with a
2014-03-25 09:01:46 +01:00
* smaller limit decrementing by a few FDs per iteration . */
2014-12-19 10:04:15 +01:00
if ( bestlimit < decr_step ) break ;
bestlimit - = decr_step ;
2012-04-03 11:53:45 +02:00
}
2014-03-25 09:01:46 +01:00
/* Assume that the limit we get initially is still valid if
* our last try was even lower . */
2014-12-19 10:04:15 +01:00
if ( bestlimit < oldlimit ) bestlimit = oldlimit ;
2014-03-25 09:01:46 +01:00
2014-12-19 10:04:15 +01:00
if ( bestlimit < maxfiles ) {
2016-11-10 16:59:52 +02:00
unsigned int old_maxclients = server . maxclients ;
2016-12-19 08:53:25 +01:00
server . maxclients = bestlimit - CONFIG_MIN_RESERVED_FDS ;
/* maxclients is unsigned so may overflow: in order
* to check if maxclients is now logically less than 1
* we test indirectly via bestlimit . */
2016-11-10 16:59:52 +02:00
if ( bestlimit < = CONFIG_MIN_RESERVED_FDS ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Your current 'ulimit -n' "
2015-07-28 11:19:20 +02:00
" of %llu is not enough for the server to start. "
2014-03-22 19:23:01 -04:00
" Please increase your open file limit to at least "
2014-04-07 08:57:05 +02:00
" %llu. Exiting. " ,
( unsigned long long ) oldlimit ,
( unsigned long long ) maxfiles ) ;
2014-03-22 19:23:01 -04:00
exit ( 1 ) ;
}
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " You requested maxclients of %d "
2014-03-22 19:23:01 -04:00
" requiring at least %llu max file descriptors. " ,
2014-04-07 08:57:05 +02:00
old_maxclients ,
( unsigned long long ) maxfiles ) ;
2015-07-28 11:19:20 +02:00
serverLog ( LL_WARNING , " Server can't set maximum open files "
2014-03-22 19:23:01 -04:00
" to %llu because of OS error: %s. " ,
2014-04-07 08:57:05 +02:00
( unsigned long long ) maxfiles , strerror ( setrlimit_error ) ) ;
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Current maximum open files is %llu. "
2014-03-22 19:23:01 -04:00
" maxclients has been reduced to %d to compensate for "
" low ulimit. "
" If you need higher maxclients increase 'ulimit -n'. " ,
2014-12-19 10:04:15 +01:00
( unsigned long long ) bestlimit , server . maxclients ) ;
2011-12-15 11:42:40 +01:00
} else {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " Increased maximum number of open files "
2014-03-22 19:23:01 -04:00
" to %llu (it was originally set to %llu). " ,
2014-04-07 08:57:05 +02:00
( unsigned long long ) maxfiles ,
( unsigned long long ) oldlimit ) ;
2011-12-15 11:42:40 +01:00
}
}
}
}
2014-12-04 10:54:31 +01:00
/* Check that server.tcp_backlog can be actually enforced in Linux according
* to the value of / proc / sys / net / core / somaxconn , or warn about it . */
void checkTcpBacklogSettings ( void ) {
# ifdef HAVE_PROC_SOMAXCONN
FILE * fp = fopen ( " /proc/sys/net/core/somaxconn " , " r " ) ;
char buf [ 1024 ] ;
if ( ! fp ) return ;
if ( fgets ( buf , sizeof ( buf ) , fp ) ! = NULL ) {
int somaxconn = atoi ( buf ) ;
if ( somaxconn > 0 & & somaxconn < server . tcp_backlog ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " WARNING: The TCP backlog setting of %d cannot be enforced because /proc/sys/net/core/somaxconn is set to the lower value of %d. " , server . tcp_backlog , somaxconn ) ;
2014-12-04 10:54:31 +01:00
}
}
fclose ( fp ) ;
# endif
}
2013-08-22 14:01:16 +02:00
/* Initialize a set of file descriptors to listen to the specified 'port'
* binding the addresses specified in the Redis server configuration .
*
* The listening file descriptors are stored in the integer array ' fds '
* and their number is set in ' * count ' .
*
* The addresses to bind are specified in the global server . bindaddr array
* and their number is server . bindaddr_count . If the server configuration
* contains no specific addresses to bind , this function will try to
* bind * ( all addresses ) for both the IPv4 and IPv6 protocols .
*
2015-07-26 23:17:55 +02:00
* On success the function returns C_OK .
2013-08-22 14:01:16 +02:00
*
2015-07-26 23:17:55 +02:00
* On error the function returns C_ERR . For the function to be on
2013-08-22 14:01:16 +02:00
* error , at least one of the server . bindaddr addresses was
* impossible to bind , or no bind addresses were specified in the server
* configuration but the function is not able to bind * for at least
* one of the IPv4 or IPv6 protocols . */
int listenToPort ( int port , int * fds , int * count ) {
int j ;
/* Force binding of 0.0.0.0 if no bind address is specified, always
* entering the loop if j = = 0. */
if ( server . bindaddr_count = = 0 ) server . bindaddr [ 0 ] = NULL ;
for ( j = 0 ; j < server . bindaddr_count | | j = = 0 ; j + + ) {
if ( server . bindaddr [ j ] = = NULL ) {
2016-08-21 20:39:15 +03:00
int unsupported = 0 ;
2013-08-22 14:01:16 +02:00
/* Bind * for both IPv6 and IPv4, we enter here only if
* server . bindaddr_count = = 0. */
2014-01-31 14:55:43 +01:00
fds [ * count ] = anetTcp6Server ( server . neterr , port , NULL ,
server . tcp_backlog ) ;
2014-04-24 17:33:57 +02:00
if ( fds [ * count ] ! = ANET_ERR ) {
anetNonBlock ( NULL , fds [ * count ] ) ;
( * count ) + + ;
2016-09-09 14:59:48 +02:00
} else if ( errno = = EAFNOSUPPORT ) {
2016-08-21 20:39:15 +03:00
unsupported + + ;
2016-11-30 15:26:59 +01:00
serverLog ( LL_WARNING , " Not listening to IPv6: unsupported " ) ;
2016-09-09 14:59:48 +02:00
}
2016-05-05 10:02:42 +02:00
2016-09-09 14:59:48 +02:00
if ( * count = = 1 | | unsupported ) {
/* Bind the IPv4 address as well. */
fds [ * count ] = anetTcpServer ( server . neterr , port , NULL ,
server . tcp_backlog ) ;
if ( fds [ * count ] ! = ANET_ERR ) {
anetNonBlock ( NULL , fds [ * count ] ) ;
( * count ) + + ;
} else if ( errno = = EAFNOSUPPORT ) {
unsupported + + ;
2016-11-30 15:26:59 +01:00
serverLog ( LL_WARNING , " Not listening to IPv4: unsupported " ) ;
2016-09-09 14:59:48 +02:00
}
}
2016-05-05 10:02:42 +02:00
/* Exit the loop if we were able to bind * on IPv4 and IPv6,
2013-08-22 14:01:16 +02:00
* otherwise fds [ * count ] will be ANET_ERR and we ' ll print an
* error and return to the caller with an error . */
2016-08-21 20:39:15 +03:00
if ( * count + unsupported = = 2 ) break ;
2013-08-22 14:01:16 +02:00
} else if ( strchr ( server . bindaddr [ j ] , ' : ' ) ) {
/* Bind IPv6 address. */
2014-01-31 14:55:43 +01:00
fds [ * count ] = anetTcp6Server ( server . neterr , port , server . bindaddr [ j ] ,
server . tcp_backlog ) ;
2013-08-22 14:01:16 +02:00
} else {
/* Bind IPv4 address. */
2014-01-31 14:55:43 +01:00
fds [ * count ] = anetTcpServer ( server . neterr , port , server . bindaddr [ j ] ,
server . tcp_backlog ) ;
2013-08-22 14:01:16 +02:00
}
if ( fds [ * count ] = = ANET_ERR ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2018-11-23 17:57:01 +01:00
" Could not create server TCP listening socket %s:%d: %s " ,
2013-08-22 14:01:16 +02:00
server . bindaddr [ j ] ? server . bindaddr [ j ] : " * " ,
2014-02-19 17:26:33 -05:00
port , server . neterr ) ;
2018-11-23 17:43:01 +01:00
if ( errno = = ENOPROTOOPT | | errno = = EPROTONOSUPPORT | |
errno = = ESOCKTNOSUPPORT | | errno = = EPFNOSUPPORT | |
errno = = EAFNOSUPPORT | | errno = = EADDRNOTAVAIL )
continue ;
2015-07-26 23:17:55 +02:00
return C_ERR ;
2013-08-22 14:01:16 +02:00
}
2014-04-24 17:33:57 +02:00
anetNonBlock ( NULL , fds [ * count ] ) ;
2013-08-22 14:01:16 +02:00
( * count ) + + ;
}
2015-07-26 23:17:55 +02:00
return C_OK ;
2013-08-22 14:01:16 +02:00
}
2014-03-19 12:55:49 +01:00
/* Resets the stats that we expose via INFO or other means that we want
* to reset via CONFIG RESETSTAT . The function is also used in order to
* initialize these fields in initServer ( ) at server startup . */
void resetServerStats ( void ) {
2014-12-03 12:06:54 +01:00
int j ;
2014-03-19 12:55:49 +01:00
server . stat_numcommands = 0 ;
server . stat_numconnections = 0 ;
server . stat_expiredkeys = 0 ;
Track number of logically expired keys still in memory.
This commit adds two new fields in the INFO output, stats section:
expired_stale_perc:0.34
expired_time_cap_reached_count:58
The first field is an estimate of the number of keys that are yet in
memory but are already logically expired. They reason why those keys are
yet not reclaimed is because the active expire cycle can't spend more
time on the process of reclaiming the keys, and at the same time nobody
is accessing such keys. However as the active expire cycle runs, while
it will eventually have to return to the caller, because of time limit
or because there are less than 25% of keys logically expired in each
given database, it collects the stats in order to populate this INFO
field.
Note that expired_stale_perc is a running average, where the current
sample accounts for 5% and the history for 95%, so you'll see it
changing smoothly over time.
The other field, expired_time_cap_reached_count, counts the number
of times the expire cycle had to stop, even if still it was finding a
sizeable number of keys yet to expire, because of the time limit.
This allows people handling operations to understand if the Redis
server, during mass-expiration events, is able to collect keys fast
enough usually. It is normal for this field to increment during mass
expires, but normally it should very rarely increment. When instead it
constantly increments, it means that the current workloads is using
a very important percentage of CPU time to expire keys.
This feature was created thanks to the hints of Rashmi Ramesh and
Bart Robinson from Twitter. In private email exchanges, they noted how
it was important to improve the observability of this parameter in the
Redis server. Actually in big deployments, the amount of keys that are
yet to expire in each server, even if they are logically expired, may
account for a very big amount of wasted memory.
2018-02-19 11:12:49 +01:00
server . stat_expired_stale_perc = 0 ;
server . stat_expired_time_cap_reached_count = 0 ;
2019-11-14 18:27:37 +01:00
server . stat_expire_cycle_time_used = 0 ;
2014-03-19 12:55:49 +01:00
server . stat_evictedkeys = 0 ;
server . stat_keyspace_misses = 0 ;
server . stat_keyspace_hits = 0 ;
2016-12-30 03:37:52 +02:00
server . stat_active_defrag_hits = 0 ;
server . stat_active_defrag_misses = 0 ;
server . stat_active_defrag_key_hits = 0 ;
server . stat_active_defrag_key_misses = 0 ;
2018-02-18 17:15:22 +02:00
server . stat_active_defrag_scanned = 0 ;
2014-03-19 12:55:49 +01:00
server . stat_fork_time = 0 ;
2014-07-08 17:05:56 +02:00
server . stat_fork_rate = 0 ;
2014-03-19 12:55:49 +01:00
server . stat_rejected_conn = 0 ;
server . stat_sync_full = 0 ;
server . stat_sync_partial_ok = 0 ;
server . stat_sync_partial_err = 0 ;
2020-07-29 01:46:44 -04:00
server . stat_io_reads_processed = 0 ;
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
atomicSet ( server . stat_total_reads_processed , 0 ) ;
2020-07-29 01:46:44 -04:00
server . stat_io_writes_processed = 0 ;
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
atomicSet ( server . stat_total_writes_processed , 0 ) ;
2015-07-27 09:41:48 +02:00
for ( j = 0 ; j < STATS_METRIC_COUNT ; j + + ) {
2014-12-03 12:06:54 +01:00
server . inst_metric [ j ] . idx = 0 ;
server . inst_metric [ j ] . last_sample_time = mstime ( ) ;
server . inst_metric [ j ] . last_sample_count = 0 ;
memset ( server . inst_metric [ j ] . samples , 0 ,
sizeof ( server . inst_metric [ j ] . samples ) ) ;
}
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
atomicSet ( server . stat_net_input_bytes , 0 ) ;
atomicSet ( server . stat_net_output_bytes , 0 ) ;
2020-03-29 13:08:21 +03:00
server . stat_unexpected_error_replies = 0 ;
2015-07-15 16:11:40 +02:00
server . aof_delayed_fsync = 0 ;
2020-09-03 08:47:29 +03:00
server . blocked_last_cron = 0 ;
2014-03-19 12:55:49 +01:00
}
2020-09-18 16:08:52 +08:00
/* Make the thread killable at any time, so that kill threads functions
* can work reliably ( default cancelability type is PTHREAD_CANCEL_DEFERRED ) .
* Needed for pthread_cancel used by the fast memory test used by the crash report . */
void makeThreadKillable ( void ) {
pthread_setcancelstate ( PTHREAD_CANCEL_ENABLE , NULL ) ;
pthread_setcanceltype ( PTHREAD_CANCEL_ASYNCHRONOUS , NULL ) ;
}
2014-03-16 08:51:54 +09:00
void initServer ( void ) {
2010-06-22 00:07:48 +02:00
int j ;
signal ( SIGHUP , SIG_IGN ) ;
signal ( SIGPIPE , SIG_IGN ) ;
2011-03-06 17:49:22 +01:00
setupSignalHandlers ( ) ;
2020-09-18 16:08:52 +08:00
makeThreadKillable ( ) ;
2010-06-22 00:07:48 +02:00
2010-12-09 11:10:21 -05:00
if ( server . syslog_enabled ) {
openlog ( server . syslog_ident , LOG_PID | LOG_NDELAY | LOG_NOWAIT ,
server . syslog_facility ) ;
}
2019-11-28 11:24:57 +02:00
/* Initialization after setting defaults from the config system. */
server . aof_state = server . aof_enabled ? AOF_ON : AOF_OFF ;
2018-07-23 14:13:58 +02:00
server . hz = server . config_hz ;
2014-05-22 18:48:37 +02:00
server . pid = getpid ( ) ;
2020-09-20 13:43:28 +03:00
server . in_fork_child = CHILD_TYPE_NONE ;
2020-09-15 13:06:47 +08:00
server . main_thread_id = pthread_self ( ) ;
2012-01-12 16:02:57 +01:00
server . current_client = NULL ;
2019-11-19 11:28:04 +01:00
server . fixed_time_expire = 0 ;
2010-06-22 00:07:48 +02:00
server . clients = listCreate ( ) ;
2018-06-27 13:26:01 +02:00
server . clients_index = raxNew ( ) ;
2012-01-23 16:12:37 +01:00
server . clients_to_close = listCreate ( ) ;
2010-06-22 00:07:48 +02:00
server . slaves = listCreate ( ) ;
server . monitors = listCreate ( ) ;
2015-09-28 18:25:57 +02:00
server . clients_pending_write = listCreate ( ) ;
2019-03-30 11:26:58 +01:00
server . clients_pending_read = listCreate ( ) ;
2020-03-26 13:28:39 +01:00
server . clients_timeout_table = raxNew ( ) ;
2012-11-02 16:31:28 +01:00
server . slaveseldb = - 1 ; /* Force to emit the first SELECT command. */
2010-12-06 16:39:39 +01:00
server . unblocked_clients = listCreate ( ) ;
A reimplementation of blocking operation internals.
Redis provides support for blocking operations such as BLPOP or BRPOP.
This operations are identical to normal LPOP and RPOP operations as long
as there are elements in the target list, but if the list is empty they
block waiting for new data to arrive to the list.
All the clients blocked waiting for th same list are served in a FIFO
way, so the first that blocked is the first to be served when there is
more data pushed by another client into the list.
The previous implementation of blocking operations was conceived to
serve clients in the context of push operations. For for instance:
1) There is a client "A" blocked on list "foo".
2) The client "B" performs `LPUSH foo somevalue`.
3) The client "A" is served in the context of the "B" LPUSH,
synchronously.
Processing things in a synchronous way was useful as if "A" pushes a
value that is served by "B", from the point of view of the database is a
NOP (no operation) thing, that is, nothing is replicated, nothing is
written in the AOF file, and so forth.
However later we implemented two things:
1) Variadic LPUSH that could add multiple values to a list in the
context of a single call.
2) BRPOPLPUSH that was a version of BRPOP that also provided a "PUSH"
side effect when receiving data.
This forced us to make the synchronous implementation more complex. If
client "B" is waiting for data, and "A" pushes three elemnents in a
single call, we needed to propagate an LPUSH with a missing argument
in the AOF and replication link. We also needed to make sure to
replicate the LPUSH side of BRPOPLPUSH, but only if in turn did not
happened to serve another blocking client into another list ;)
This were complex but with a few of mutually recursive functions
everything worked as expected... until one day we introduced scripting
in Redis.
Scripting + synchronous blocking operations = Issue #614.
Basically you can't "rewrite" a script to have just a partial effect on
the replicas and AOF file if the script happened to serve a few blocked
clients.
The solution to all this problems, implemented by this commit, is to
change the way we serve blocked clients. Instead of serving the blocked
clients synchronously, in the context of the command performing the PUSH
operation, it is now an asynchronous and iterative process:
1) If a key that has clients blocked waiting for data is the subject of
a list push operation, We simply mark keys as "ready" and put it into a
queue.
2) Every command pushing stuff on lists, as a variadic LPUSH, a script,
or whatever it is, is replicated verbatim without any rewriting.
3) Every time a Redis command, a MULTI/EXEC block, or a script,
completed its execution, we run the list of keys ready to serve blocked
clients (as more data arrived), and process this list serving the
blocked clients.
4) As a result of "3" maybe more keys are ready again for other clients
(as a result of BRPOPLPUSH we may have push operations), so we iterate
back to step "3" if it's needed.
The new code has a much simpler semantics, and a simpler to understand
implementation, with the disadvantage of not being able to "optmize out"
a PUSH+BPOP as a No OP.
This commit will be tested with care before the final merge, more tests
will be added likely.
2012-09-04 10:37:49 +02:00
server . ready_keys = listCreate ( ) ;
2013-12-04 15:52:20 +01:00
server . clients_waiting_acks = listCreate ( ) ;
server . get_ack_from_slaves = 0 ;
2014-02-04 15:52:09 +01:00
server . clients_paused = 0 ;
2020-05-14 10:02:57 +02:00
server . events_processed_while_blocked = 0 ;
2014-12-17 17:11:20 +01:00
server . system_memory_size = zmalloc_get_memory_size ( ) ;
2010-12-29 19:39:42 +01:00
2020-07-27 12:52:13 +03:00
if ( ( server . tls_port | | server . tls_replication | | server . tls_cluster )
& & tlsConfigure ( & server . tls_ctx_config ) = = C_ERR ) {
2019-09-12 10:56:54 +03:00
serverLog ( LL_WARNING , " Failed to configure TLS. Check logs for more info. " ) ;
exit ( 1 ) ;
}
2010-06-22 00:07:48 +02:00
createSharedObjects ( ) ;
2011-12-15 11:42:40 +01:00
adjustOpenFilesLimit ( ) ;
2020-08-28 01:54:10 -07:00
const char * clk_msg = monotonicInit ( ) ;
serverLog ( LL_NOTICE , " monotonic clock: %s " , clk_msg ) ;
2015-07-27 09:41:48 +02:00
server . el = aeCreateEventLoop ( server . maxclients + CONFIG_FDSET_INCR ) ;
2017-04-21 16:27:38 +02:00
if ( server . el = = NULL ) {
serverLog ( LL_WARNING ,
" Failed creating the event loop. Error message: '%s' " ,
strerror ( errno ) ) ;
exit ( 1 ) ;
}
2010-06-22 00:07:48 +02:00
server . db = zmalloc ( sizeof ( redisDb ) * server . dbnum ) ;
2011-02-07 12:52:01 +01:00
2013-08-22 14:01:16 +02:00
/* Open the TCP listening socket for the user commands. */
2013-12-23 11:31:35 +01:00
if ( server . port ! = 0 & &
2015-07-26 23:17:55 +02:00
listenToPort ( server . port , server . ipfd , & server . ipfd_count ) = = C_ERR )
2013-08-22 14:01:16 +02:00
exit ( 1 ) ;
2019-09-12 10:56:54 +03:00
if ( server . tls_port ! = 0 & &
listenToPort ( server . tls_port , server . tlsfd , & server . tlsfd_count ) = = C_ERR )
exit ( 1 ) ;
2013-07-05 11:47:20 +02:00
/* Open the listening Unix domain socket. */
2010-10-13 17:17:56 +02:00
if ( server . unixsocket ! = NULL ) {
unlink ( server . unixsocket ) ; /* don't care if this fails */
2014-01-31 14:55:43 +01:00
server . sofd = anetUnixServer ( server . neterr , server . unixsocket ,
server . unixsocketperm , server . tcp_backlog ) ;
2010-08-03 13:33:12 +02:00
if ( server . sofd = = ANET_ERR ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Opening Unix socket: %s " , server . neterr ) ;
2010-08-03 13:33:12 +02:00
exit ( 1 ) ;
}
2014-04-24 17:33:57 +02:00
anetNonBlock ( NULL , server . sofd ) ;
2010-08-01 22:55:24 +02:00
}
2013-07-05 11:47:20 +02:00
/* Abort if there are no listening sockets at all. */
2019-09-12 10:56:54 +03:00
if ( server . ipfd_count = = 0 & & server . tlsfd_count = = 0 & & server . sofd < 0 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Configured to not listen anywhere, exiting. " ) ;
2010-06-22 00:07:48 +02:00
exit ( 1 ) ;
}
2013-07-05 11:47:20 +02:00
/* Create the Redis databases, and initialize other internal state. */
2010-06-22 00:07:48 +02:00
for ( j = 0 ; j < server . dbnum ; j + + ) {
server . db [ j ] . dict = dictCreate ( & dbDictType , NULL ) ;
server . db [ j ] . expires = dictCreate ( & keyptrDictType , NULL ) ;
2019-11-14 18:27:37 +01:00
server . db [ j ] . expires_cursor = 0 ;
2010-06-22 00:07:48 +02:00
server . db [ j ] . blocking_keys = dictCreate ( & keylistDictType , NULL ) ;
2015-07-31 18:01:23 +02:00
server . db [ j ] . ready_keys = dictCreate ( & objectKeyPointerValueDictType , NULL ) ;
2010-06-22 00:07:48 +02:00
server . db [ j ] . watched_keys = dictCreate ( & keylistDictType , NULL ) ;
server . db [ j ] . id = j ;
2013-08-06 15:00:43 +02:00
server . db [ j ] . avg_ttl = 0 ;
2018-02-18 17:15:22 +02:00
server . db [ j ] . defrag_later = listCreate ( ) ;
Adjustments for active defrag defaults and tuning
Reduce default minimum effort, so that when fragmentation is just detected,
the impact on the latency will be minor.
Reduce the default maximum effort, mainly to prevent a case were a sudden
massive deletions, won't trigger an aggressive defrag that will cause latency.
When activedefrag is disabled mid-run, reset the 'running' info field, and
clear the scan cursor, so that when it'll be re-enabled, a new fresh scan will
start.
Clearing the 'running' variable is important since lowering the defragger
tunables mid-scan won't help, the defragger only considers new threshold when
a new scan starts, and during a scan it can only become more aggressive,
(when more severe fragmentation is detected), it'll never go less aggressive.
So by temporarily disabling activedefrag, one can lower th the tunables.
Removing the experimantal warning.
2019-11-10 09:38:50 +02:00
listSetFreeMethod ( server . db [ j ] . defrag_later , ( void ( * ) ( void * ) ) sdsfree ) ;
2010-06-22 00:07:48 +02:00
}
2016-07-13 10:45:37 +02:00
evictionPoolAlloc ( ) ; /* Initialize the LRU keys pool. */
2010-06-22 00:07:48 +02:00
server . pubsub_channels = dictCreate ( & keylistDictType , NULL ) ;
server . pubsub_patterns = listCreate ( ) ;
2018-03-01 11:46:56 +08:00
server . pubsub_patterns_dict = dictCreate ( & keylistDictType , NULL ) ;
2010-06-22 00:07:48 +02:00
listSetFreeMethod ( server . pubsub_patterns , freePubsubPattern ) ;
listSetMatchMethod ( server . pubsub_patterns , listMatchPubsubPattern ) ;
server . cronloops = 0 ;
2011-12-21 12:22:13 +01:00
server . rdb_child_pid = - 1 ;
2011-12-21 12:17:02 +01:00
server . aof_child_pid = - 1 ;
2019-07-17 08:51:02 +03:00
server . module_child_pid = - 1 ;
2015-07-27 09:41:48 +02:00
server . rdb_child_type = RDB_CHILD_TYPE_NONE ;
2019-08-11 16:07:53 +03:00
server . rdb_pipe_conns = NULL ;
server . rdb_pipe_numconns = 0 ;
server . rdb_pipe_numconns_writing = 0 ;
server . rdb_pipe_buff = NULL ;
server . rdb_pipe_bufflen = 0 ;
2016-07-21 18:34:53 +02:00
server . rdb_bgsave_scheduled = 0 ;
2016-09-19 13:45:20 +02:00
server . child_info_pipe [ 0 ] = - 1 ;
server . child_info_pipe [ 1 ] = - 1 ;
server . child_info_data . magic = 0 ;
Allow an AOF rewrite buffer > 2GB (Fix for issue #504).
During the AOF rewrite process, the parent process needs to accumulate
the new writes in an in-memory buffer: when the child will terminate the
AOF rewriting process this buffer (that ist the difference between the
dataset when the rewrite was started, and the current dataset) is
flushed to the new AOF file.
We used to implement this buffer using an sds.c string, but sds.c has a
2GB limit. Sometimes the dataset can be big enough, the amount of writes
so high, and the rewrite process slow enough that we overflow the 2GB
limit, causing a crash, documented on github by issue #504.
In order to prevent this from happening, this commit introduces a new
system to accumulate writes, implemented by a linked list of blocks of
10 MB each, so that we also avoid paying the reallocation cost.
Note that theoretically modern operating systems may implement realloc()
simply as a remaping of the old pages, thus with very good performances,
see for instance the mremap() syscall on Linux. However this is not
always true, and jemalloc by default avoids doing this because there are
issues with the current implementation of mremap().
For this reason we are using a linked list of blocks instead of a single
block that gets reallocated again and again.
The changes in this commit lacks testing, that will be performed before
merging into the unstable branch. This fix will not enter 2.4 because it
is too invasive. However 2.4 will log a warning when the AOF rewrite
buffer is near to the 2GB limit.
2012-05-22 13:03:41 +02:00
aofRewriteBufferReset ( ) ;
2011-12-21 12:17:02 +01:00
server . aof_buf = sdsempty ( ) ;
2013-04-02 14:05:50 +02:00
server . lastsave = time ( NULL ) ; /* At startup we consider the DB saved. */
server . lastbgsave_try = 0 ; /* At startup we never tried to BGSAVE. */
2012-05-25 12:11:30 +02:00
server . rdb_save_time_last = - 1 ;
server . rdb_save_time_start = - 1 ;
2010-06-22 00:07:48 +02:00
server . dirty = 0 ;
2014-03-19 12:55:49 +01:00
resetServerStats ( ) ;
/* A few stats we don't want to reset: server startup time, and peak mem. */
2010-06-22 00:07:48 +02:00
server . stat_starttime = time ( NULL ) ;
2011-04-21 10:49:52 +02:00
server . stat_peak_memory = 0 ;
2016-09-19 13:45:20 +02:00
server . stat_rdb_cow_bytes = 0 ;
server . stat_aof_cow_bytes = 0 ;
2019-07-17 08:51:02 +03:00
server . stat_module_cow_bytes = 0 ;
2020-04-07 12:07:09 +02:00
for ( int j = 0 ; j < CLIENT_TYPE_COUNT ; j + + )
server . stat_clients_type_memory [ j ] = 0 ;
2018-02-18 17:36:21 +02:00
server . cron_malloc_stats . zmalloc_used = 0 ;
server . cron_malloc_stats . process_rss = 0 ;
server . cron_malloc_stats . allocator_allocated = 0 ;
server . cron_malloc_stats . allocator_active = 0 ;
server . cron_malloc_stats . allocator_resident = 0 ;
2015-07-26 23:17:55 +02:00
server . lastbgsave_status = C_OK ;
server . aof_last_write_status = C_OK ;
2014-02-12 12:47:10 +01:00
server . aof_last_write_errno = 0 ;
2013-05-29 11:36:44 +02:00
server . repl_good_slaves_count = 0 ;
2013-07-05 11:47:20 +02:00
2016-06-08 16:07:32 +02:00
/* Create the timer callback, this is our way to process many background
* operations incrementally , like clients timeout , eviction of unaccessed
* expired keys and so forth . */
2015-09-25 10:06:28 +02:00
if ( aeCreateTimeEvent ( server . el , 1 , serverCron , NULL , NULL ) = = AE_ERR ) {
2015-07-30 11:46:31 +02:00
serverPanic ( " Can't create event loop timers. " ) ;
2013-02-27 18:00:47 +08:00
exit ( 1 ) ;
}
2013-07-05 11:47:20 +02:00
/* Create an event handler for accepting new connections in TCP and Unix
* domain sockets . */
for ( j = 0 ; j < server . ipfd_count ; j + + ) {
if ( aeCreateFileEvent ( server . el , server . ipfd [ j ] , AE_READABLE ,
acceptTcpHandler , NULL ) = = AE_ERR )
{
2015-07-27 09:41:48 +02:00
serverPanic (
2013-07-05 11:47:20 +02:00
" Unrecoverable error creating server.ipfd file event. " ) ;
}
}
2019-09-12 10:56:54 +03:00
for ( j = 0 ; j < server . tlsfd_count ; j + + ) {
if ( aeCreateFileEvent ( server . el , server . tlsfd [ j ] , AE_READABLE ,
acceptTLSHandler , NULL ) = = AE_ERR )
{
serverPanic (
" Unrecoverable error creating server.tlsfd file event. " ) ;
}
}
2010-08-03 13:33:12 +02:00
if ( server . sofd > 0 & & aeCreateFileEvent ( server . el , server . sofd , AE_READABLE ,
2015-07-27 09:41:48 +02:00
acceptUnixHandler , NULL ) = = AE_ERR ) serverPanic ( " Unrecoverable error creating server.sofd file event. " ) ;
2010-06-22 00:07:48 +02:00
2017-04-10 09:33:21 +02:00
/* Register a readable event for the pipe used to awake the event loop
* when a blocked client in a module needs attention . */
if ( aeCreateFileEvent ( server . el , server . module_blocked_pipe [ 0 ] , AE_READABLE ,
moduleBlockedClientPipeReadable , NULL ) = = AE_ERR ) {
serverPanic (
" Error registering the readable event for the module "
" blocked clients subsystem. " ) ;
}
2020-05-10 19:13:47 +03:00
/* Register before and after sleep handlers (note this needs to be done
* before loading persistence since it is used by processEventsWhileBlocked . */
aeSetBeforeSleepProc ( server . el , beforeSleep ) ;
aeSetAfterSleepProc ( server . el , afterSleep ) ;
2013-07-05 11:47:20 +02:00
/* Open the AOF file if needed. */
2015-07-27 09:41:48 +02:00
if ( server . aof_state = = AOF_ON ) {
2011-12-21 12:17:02 +01:00
server . aof_fd = open ( server . aof_filename ,
2011-12-21 10:31:34 +01:00
O_WRONLY | O_APPEND | O_CREAT , 0644 ) ;
2011-12-21 12:17:02 +01:00
if ( server . aof_fd = = - 1 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Can't open the append-only file: %s " ,
2010-06-22 00:07:48 +02:00
strerror ( errno ) ) ;
exit ( 1 ) ;
}
}
2012-02-02 10:17:16 +01:00
/* 32 bit instances are limited to 4GB of address space, so if there is
* no explicit limit in the user provided configuration we set a limit
2012-10-22 10:43:39 +02:00
* at 3 GB using maxmemory with ' noeviction ' policy ' . This avoids
* useless crashes of the Redis instance for out of memory . */
2012-02-02 10:17:16 +01:00
if ( server . arch_bits = = 32 & & server . maxmemory = = 0 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Warning: 32 bit instance detected but no memory limit set. Setting 3 GB maxmemory limit with 'noeviction' policy now. " ) ;
2012-10-22 10:43:39 +02:00
server . maxmemory = 3072LL * ( 1024 * 1024 ) ; /* 3 GB */
2015-07-27 09:41:48 +02:00
server . maxmemory_policy = MAXMEMORY_NO_EVICTION ;
2012-02-02 10:17:16 +01:00
}
2011-03-29 17:51:15 +02:00
if ( server . cluster_enabled ) clusterInit ( ) ;
2013-06-24 19:27:49 +02:00
replicationScriptCacheInit ( ) ;
2015-11-05 11:10:46 +01:00
scriptingInit ( 1 ) ;
2011-06-30 13:27:32 +02:00
slowlogInit ( ) ;
2014-07-01 11:30:15 +02:00
latencyMonitorInit ( ) ;
2019-09-09 14:35:06 +03:00
}
/* Some steps in server initialization need to be done last (after modules
* are loaded ) .
* Specifically , creation of threads due to a race bug in ld . so , in which
* Thread Local Storage initialization collides with dlopen call .
* see : https : //sourceware.org/bugzilla/show_bug.cgi?id=19329 */
void InitServerLast ( ) {
2011-09-13 16:10:26 +02:00
bioInit ( ) ;
2017-10-24 08:35:05 +02:00
initThreadedIO ( ) ;
2019-05-30 12:51:32 +03:00
set_jemalloc_bg_thread ( server . jemalloc_bg_thread ) ;
2016-09-13 17:39:22 +02:00
server . initial_memory_usage = zmalloc_used_memory ( ) ;
2010-06-22 00:07:48 +02:00
}
2019-01-22 17:46:49 +01:00
/* Parse the flags string description 'strflags' and set them to the
* command ' c ' . If the flags are all valid C_OK is returned , otherwise
* C_ERR is returned ( yet the recognized flags are set in the command ) . */
int populateCommandTableParseFlags ( struct redisCommand * c , char * strflags ) {
int argc ;
sds * argv ;
/* Split the line into arguments for processing. */
argv = sdssplitargs ( strflags , & argc ) ;
if ( argv = = NULL ) return C_ERR ;
for ( int j = 0 ; j < argc ; j + + ) {
char * flag = argv [ j ] ;
2019-01-23 16:59:09 +01:00
if ( ! strcasecmp ( flag , " write " ) ) {
c - > flags | = CMD_WRITE | CMD_CATEGORY_WRITE ;
} else if ( ! strcasecmp ( flag , " read-only " ) ) {
c - > flags | = CMD_READONLY | CMD_CATEGORY_READ ;
} else if ( ! strcasecmp ( flag , " use-memory " ) ) {
c - > flags | = CMD_DENYOOM ;
} else if ( ! strcasecmp ( flag , " admin " ) ) {
c - > flags | = CMD_ADMIN | CMD_CATEGORY_ADMIN | CMD_CATEGORY_DANGEROUS ;
} else if ( ! strcasecmp ( flag , " pub-sub " ) ) {
c - > flags | = CMD_PUBSUB | CMD_CATEGORY_PUBSUB ;
} else if ( ! strcasecmp ( flag , " no-script " ) ) {
c - > flags | = CMD_NOSCRIPT ;
} else if ( ! strcasecmp ( flag , " random " ) ) {
c - > flags | = CMD_RANDOM ;
} else if ( ! strcasecmp ( flag , " to-sort " ) ) {
c - > flags | = CMD_SORT_FOR_SCRIPT ;
} else if ( ! strcasecmp ( flag , " ok-loading " ) ) {
c - > flags | = CMD_LOADING ;
} else if ( ! strcasecmp ( flag , " ok-stale " ) ) {
c - > flags | = CMD_STALE ;
} else if ( ! strcasecmp ( flag , " no-monitor " ) ) {
c - > flags | = CMD_SKIP_MONITOR ;
2019-07-19 10:22:40 -07:00
} else if ( ! strcasecmp ( flag , " no-slowlog " ) ) {
c - > flags | = CMD_SKIP_SLOWLOG ;
2019-01-23 16:59:09 +01:00
} else if ( ! strcasecmp ( flag , " cluster-asking " ) ) {
c - > flags | = CMD_ASKING ;
} else if ( ! strcasecmp ( flag , " fast " ) ) {
c - > flags | = CMD_FAST | CMD_CATEGORY_FAST ;
2019-02-26 01:23:11 +00:00
} else if ( ! strcasecmp ( flag , " no-auth " ) ) {
c - > flags | = CMD_NO_AUTH ;
2019-01-23 16:59:09 +01:00
} else {
/* Parse ACL categories here if the flag name starts with @. */
uint64_t catflag ;
if ( flag [ 0 ] = = ' @ ' & &
( catflag = ACLGetCommandCategoryFlagByName ( flag + 1 ) ) ! = 0 )
{
c - > flags | = catflag ;
} else {
sdsfreesplitres ( argv , argc ) ;
return C_ERR ;
}
2019-01-22 17:46:49 +01:00
}
}
2019-02-12 17:06:26 +01:00
/* If it's not @fast is @slow in this binary world. */
if ( ! ( c - > flags & CMD_CATEGORY_FAST ) ) c - > flags | = CMD_CATEGORY_SLOW ;
2019-01-22 17:46:49 +01:00
sdsfreesplitres ( argv , argc ) ;
return C_OK ;
}
2010-11-03 11:23:59 +01:00
/* Populates the Redis Command Table starting from the hard coded list
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* we have on top of server . c file . */
2010-11-03 11:23:59 +01:00
void populateCommandTable ( void ) {
int j ;
2011-01-24 10:56:06 +01:00
int numcommands = sizeof ( redisCommandTable ) / sizeof ( struct redisCommand ) ;
2010-11-03 11:23:59 +01:00
for ( j = 0 ; j < numcommands ; j + + ) {
2011-01-24 10:56:06 +01:00
struct redisCommand * c = redisCommandTable + j ;
2013-03-06 16:28:26 +01:00
int retval1 , retval2 ;
2010-06-22 00:07:48 +02:00
2019-01-09 17:23:23 +01:00
/* Translate the command string flags description into an actual
* set of flags . */
2019-01-22 17:46:49 +01:00
if ( populateCommandTableParseFlags ( c , c - > sflags ) = = C_ERR )
serverPanic ( " Unsupported command flag " ) ;
2011-09-26 15:40:39 +02:00
2019-01-09 21:31:29 +01:00
c - > id = ACLGetCommandID ( c - > name ) ; /* Assign the ID used for ACL. */
2013-03-06 16:28:26 +01:00
retval1 = dictAdd ( server . commands , sdsnew ( c - > name ) , c ) ;
/* Populate an additional dictionary that will be unaffected
* by rename - command statements in redis . conf . */
retval2 = dictAdd ( server . orig_commands , sdsnew ( c - > name ) , c ) ;
2015-07-26 15:29:53 +02:00
serverAssert ( retval1 = = DICT_OK & & retval2 = = DICT_OK ) ;
2010-11-03 11:23:59 +01:00
}
2010-06-22 00:07:48 +02:00
}
2011-01-24 10:56:06 +01:00
void resetCommandTableStats ( void ) {
2017-04-13 17:03:46 +03:00
struct redisCommand * c ;
dictEntry * de ;
dictIterator * di ;
2011-01-24 10:56:06 +01:00
2017-04-13 17:03:46 +03:00
di = dictGetSafeIterator ( server . commands ) ;
while ( ( de = dictNext ( di ) ) ! = NULL ) {
c = ( struct redisCommand * ) dictGetVal ( de ) ;
2011-01-24 10:56:06 +01:00
c - > microseconds = 0 ;
c - > calls = 0 ;
}
2017-04-13 17:03:46 +03:00
dictReleaseIterator ( di ) ;
2011-01-24 10:56:06 +01:00
}
2012-02-29 00:46:50 +01:00
/* ========================== Redis OP Array API ============================ */
void redisOpArrayInit ( redisOpArray * oa ) {
oa - > ops = NULL ;
oa - > numops = 0 ;
}
int redisOpArrayAppend ( redisOpArray * oa , struct redisCommand * cmd , int dbid ,
robj * * argv , int argc , int target )
{
redisOp * op ;
oa - > ops = zrealloc ( oa - > ops , sizeof ( redisOp ) * ( oa - > numops + 1 ) ) ;
op = oa - > ops + oa - > numops ;
op - > cmd = cmd ;
op - > dbid = dbid ;
op - > argv = argv ;
op - > argc = argc ;
op - > target = target ;
oa - > numops + + ;
return oa - > numops ;
}
void redisOpArrayFree ( redisOpArray * oa ) {
while ( oa - > numops ) {
int j ;
redisOp * op ;
oa - > numops - - ;
op = oa - > ops + oa - > numops ;
for ( j = 0 ; j < op - > argc ; j + + )
decrRefCount ( op - > argv [ j ] ) ;
zfree ( op - > argv ) ;
}
zfree ( oa - > ops ) ;
}
2010-06-22 00:07:48 +02:00
/* ====================== Commands lookup and execution ===================== */
2010-11-03 11:23:59 +01:00
struct redisCommand * lookupCommand ( sds name ) {
return dictFetchValue ( server . commands , name ) ;
}
struct redisCommand * lookupCommandByCString ( char * s ) {
struct redisCommand * cmd ;
sds name = sdsnew ( s ) ;
cmd = dictFetchValue ( server . commands , name ) ;
sdsfree ( name ) ;
return cmd ;
2010-06-22 00:07:48 +02:00
}
2013-03-06 16:28:26 +01:00
/* Lookup the command in the current table, if not found also check in
* the original table containing the original command names unaffected by
* redis . conf rename - command statement .
*
* This is used by functions rewriting the argument vector such as
* rewriteClientCommandVector ( ) in order to set client - > cmd pointer
* correctly even if the command was renamed . */
struct redisCommand * lookupCommandOrOriginal ( sds name ) {
struct redisCommand * cmd = dictFetchValue ( server . commands , name ) ;
if ( ! cmd ) cmd = dictFetchValue ( server . orig_commands , name ) ;
return cmd ;
}
2012-02-28 16:17:00 +01:00
/* Propagate the specified command (in the context of the specified database id)
2012-10-16 17:35:50 +02:00
* to AOF and Slaves .
2012-02-28 16:17:00 +01:00
*
* flags are an xor between :
2015-07-27 09:41:48 +02:00
* + PROPAGATE_NONE ( no propagation of command at all )
* + PROPAGATE_AOF ( propagate into the AOF file if is enabled )
* + PROPAGATE_REPL ( propagate into the replication link )
2015-02-09 22:49:27 +01:00
*
2020-04-17 12:38:12 +02:00
* This should not be used inside commands implementation since it will not
* wrap the resulting commands in MULTI / EXEC . Use instead alsoPropagate ( ) ,
* preventCommandPropagation ( ) , forceCommandPropagation ( ) .
*
* However for functions that need to ( also ) propagate out of the context of a
* command execution , for example when serving a blocked client , you
* want to use propagate ( ) .
2012-02-28 16:17:00 +01:00
*/
void propagate ( struct redisCommand * cmd , int dbid , robj * * argv , int argc ,
int flags )
{
2015-07-27 09:41:48 +02:00
if ( server . aof_state ! = AOF_OFF & & flags & PROPAGATE_AOF )
2012-02-28 16:17:00 +01:00
feedAppendOnlyFile ( cmd , dbid , argv , argc ) ;
2015-07-27 09:41:48 +02:00
if ( flags & PROPAGATE_REPL )
2012-02-28 16:17:00 +01:00
replicationFeedSlaves ( server . slaves , dbid , argv , argc ) ;
}
2012-02-29 00:46:50 +01:00
/* Used inside commands to schedule the propagation of additional commands
2015-02-09 23:44:42 +01:00
* after the current command is propagated to AOF / Replication .
*
* ' cmd ' must be a pointer to the Redis command to replicate , dbid is the
* database ID the command should be propagated into .
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* Arguments of the command to propagate are passed as an array of redis
2015-02-09 23:44:42 +01:00
* objects pointers of len ' argc ' , using the ' argv ' vector .
*
* The function does not take a reference to the passed ' argv ' vector ,
* so it is up to the caller to release the passed argv ( but it is usually
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* stack allocated ) . The function automatically increments ref count of
2015-02-09 23:44:42 +01:00
* passed objects , so the caller does not need to . */
2012-02-28 18:03:08 +01:00
void alsoPropagate ( struct redisCommand * cmd , int dbid , robj * * argv , int argc ,
int target )
{
2015-02-09 23:57:52 +01:00
robj * * argvcopy ;
2015-02-09 23:44:42 +01:00
int j ;
2015-02-09 23:57:52 +01:00
if ( server . loading ) return ; /* No propagation during loading. */
argvcopy = zmalloc ( sizeof ( robj * ) * argc ) ;
2015-02-09 23:44:42 +01:00
for ( j = 0 ; j < argc ; j + + ) {
argvcopy [ j ] = argv [ j ] ;
incrRefCount ( argv [ j ] ) ;
}
redisOpArrayAppend ( & server . also_propagate , cmd , dbid , argvcopy , argc , target ) ;
2012-02-28 18:03:08 +01:00
}
2013-06-21 12:07:53 +02:00
/* It is possible to call the function forceCommandPropagation() inside a
2014-04-13 18:44:58 -03:00
* Redis command implementation in order to to force the propagation of a
2013-06-21 12:07:53 +02:00
* specific command execution into AOF / Replication . */
2015-07-26 15:20:46 +02:00
void forceCommandPropagation ( client * c , int flags ) {
2015-07-27 09:41:48 +02:00
if ( flags & PROPAGATE_REPL ) c - > flags | = CLIENT_FORCE_REPL ;
if ( flags & PROPAGATE_AOF ) c - > flags | = CLIENT_FORCE_AOF ;
2013-06-21 12:07:53 +02:00
}
2015-02-09 22:49:27 +01:00
/* Avoid that the executed command is propagated at all. This way we
* are free to just propagate what we want using the alsoPropagate ( )
* API . */
2015-07-26 15:20:46 +02:00
void preventCommandPropagation ( client * c ) {
2015-07-27 09:41:48 +02:00
c - > flags | = CLIENT_PREVENT_PROP ;
2015-02-09 22:49:27 +01:00
}
2015-10-29 11:05:27 +01:00
/* AOF specific version of preventCommandPropagation(). */
void preventCommandAOF ( client * c ) {
c - > flags | = CLIENT_PREVENT_AOF_PROP ;
}
/* Replication specific version of preventCommandPropagation(). */
void preventCommandReplication ( client * c ) {
c - > flags | = CLIENT_PREVENT_REPL_PROP ;
}
2015-11-10 13:31:25 +01:00
/* Call() is the core of Redis execution of a command.
*
* The following flags can be passed :
* CMD_CALL_NONE No flags .
* CMD_CALL_SLOWLOG Check command speed and log in the slow log if needed .
* CMD_CALL_STATS Populate command stats .
* CMD_CALL_PROPAGATE_AOF Append command to AOF if it modified the dataset
* or if the client flags are forcing propagation .
2018-03-16 09:59:17 +01:00
* CMD_CALL_PROPAGATE_REPL Send command to slaves if it modified the dataset
2015-11-10 13:31:25 +01:00
* or if the client flags are forcing propagation .
* CMD_CALL_PROPAGATE Alias for PROPAGATE_AOF | PROPAGATE_REPL .
* CMD_CALL_FULL Alias for SLOWLOG | STATS | PROPAGATE .
*
* The exact propagation behavior depends on the client flags .
* Specifically :
*
* 1. If the client flags CLIENT_FORCE_AOF or CLIENT_FORCE_REPL are set
* and assuming the corresponding CMD_CALL_PROPAGATE_AOF / REPL is set
* in the call flags , then the command is propagated even if the
* dataset was not affected by the command .
* 2. If the client flags CLIENT_PREVENT_REPL_PROP or CLIENT_PREVENT_AOF_PROP
* are set , the propagation into AOF or to slaves is not performed even
* if the command modified the dataset .
*
* Note that regardless of the client flags , if CMD_CALL_PROPAGATE_AOF
* or CMD_CALL_PROPAGATE_REPL are not set , then respectively AOF or
* slaves propagation will never occur .
*
* Client flags are modified by the implementation of a given command
* using the following API :
*
* forceCommandPropagation ( client * c , int flags ) ;
* preventCommandPropagation ( client * c ) ;
* preventCommandAOF ( client * c ) ;
* preventCommandReplication ( client * c ) ;
*
*/
2015-07-26 15:20:46 +02:00
void call ( client * c , int flags ) {
2019-11-05 10:14:34 +01:00
long long dirty ;
ustime_t start , duration ;
2013-06-21 12:07:53 +02:00
int client_old_flags = c - > flags ;
2018-09-30 11:37:19 +03:00
struct redisCommand * real_cmd = c - > cmd ;
2010-06-22 00:07:48 +02:00
2019-11-19 11:28:04 +01:00
server . fixed_time_expire + + ;
2019-11-06 09:57:29 +01:00
2020-05-05 15:50:00 +02:00
/* Send the command to clients in MONITOR mode if applicable.
* Administrative commands are considered too dangerous to be shown . */
2012-10-16 17:35:50 +02:00
if ( listLength ( server . monitors ) & &
! server . loading & &
2015-07-27 09:41:48 +02:00
! ( c - > cmd - > flags & ( CMD_SKIP_MONITOR | CMD_ADMIN ) ) )
2012-10-16 17:35:50 +02:00
{
2012-03-07 12:12:15 +01:00
replicationFeedMonitors ( c , server . monitors , c - > db - > id , c - > argv , c - > argc ) ;
2012-10-16 17:35:50 +02:00
}
2012-02-28 16:17:00 +01:00
2015-10-29 10:44:30 +01:00
/* Initialization: clear the flags that must be set by the command on
* demand , and initialize the array for additional commands propagation . */
c - > flags & = ~ ( CLIENT_FORCE_AOF | CLIENT_FORCE_REPL | CLIENT_PREVENT_PROP ) ;
2016-03-06 13:44:24 +01:00
redisOpArray prev_also_propagate = server . also_propagate ;
2012-02-29 00:46:50 +01:00
redisOpArrayInit ( & server . also_propagate ) ;
2015-10-29 10:44:30 +01:00
/* Call the command. */
2010-06-22 00:07:48 +02:00
dirty = server . dirty ;
2019-11-05 10:14:34 +01:00
updateCachedTime ( 0 ) ;
start = server . ustime ;
2011-07-08 12:59:30 +02:00
c - > cmd - > proc ( c ) ;
2011-06-30 13:27:32 +02:00
duration = ustime ( ) - start ;
2014-02-07 18:29:20 +01:00
dirty = server . dirty - dirty ;
2014-09-16 10:12:50 +02:00
if ( dirty < 0 ) dirty = 0 ;
2012-02-02 16:30:52 +01:00
Don't write replies if close the client ASAP (#7202)
Before this commit, we would have continued to add replies to the reply buffer even if client
output buffer limit is reached, so the used memory would keep increasing over the configured limit.
What's more, we shouldn’t write any reply to the client if it is set 'CLIENT_CLOSE_ASAP' flag
because that doesn't conform to its definition and we will close all clients flagged with
'CLIENT_CLOSE_ASAP' in ‘beforeSleep’.
Because of code execution order, before this, we may firstly write to part of the replies to
the socket before disconnecting it, but in fact, we may can’t send the full replies to clients
since OS socket buffer is limited. But this unexpected behavior makes some commands work well,
for instance ACL DELUSER, if the client deletes the current user, we need to send reply to client
and close the connection, but before, we close the client firstly and write the reply to reply
buffer. secondly, we shouldn't do this despite the fact it works well in most cases.
We add a flag 'CLIENT_CLOSE_AFTER_COMMAND' to mark clients, this flag means we will close the
client after executing commands and send all entire replies, so that we can write replies to
reply buffer during executing commands, send replies to clients, and close them later.
We also fix some implicit problems. If client output buffer limit is enforced in 'multi/exec',
all commands will be executed completely in redis and clients will not read any reply instead of
partial replies. Even more, if the client executes 'ACL deluser' the using user in 'multi/exec',
it will not read the replies after 'ACL deluser' just like before executing 'client kill' itself
in 'multi/exec'.
We added some tests for output buffer limit breach during multi-exec and using a pipeline of
many small commands rather than one with big response.
Co-authored-by: Oran Agra <oran@redislabs.com>
2020-09-24 21:01:41 +08:00
/* After executing command, we will close the client after writing entire
* reply if it is set ' CLIENT_CLOSE_AFTER_COMMAND ' flag . */
if ( c - > flags & CLIENT_CLOSE_AFTER_COMMAND ) {
c - > flags & = ~ CLIENT_CLOSE_AFTER_COMMAND ;
c - > flags | = CLIENT_CLOSE_AFTER_REPLY ;
}
2012-02-02 16:30:52 +01:00
/* When EVAL is called loading the AOF we don't want commands called
* from Lua to go into the slowlog or to populate statistics . */
2015-07-27 09:41:48 +02:00
if ( server . loading & & c - > flags & CLIENT_LUA )
flags & = ~ ( CMD_CALL_SLOWLOG | CMD_CALL_STATS ) ;
2012-02-02 16:30:52 +01:00
2013-06-21 12:07:53 +02:00
/* If the caller is Lua, we want to force the EVAL caller to propagate
* the script if the command flag or client flag are forcing the
* propagation . */
2015-07-27 09:41:48 +02:00
if ( c - > flags & CLIENT_LUA & & server . lua_caller ) {
if ( c - > flags & CLIENT_FORCE_REPL )
server . lua_caller - > flags | = CLIENT_FORCE_REPL ;
if ( c - > flags & CLIENT_FORCE_AOF )
server . lua_caller - > flags | = CLIENT_FORCE_AOF ;
2013-06-21 12:07:53 +02:00
}
2012-02-28 16:17:00 +01:00
/* Log the command into the Slow log if needed, and populate the
* per - command statistics that we show in INFO commandstats . */
2019-07-31 19:04:29 +02:00
if ( flags & CMD_CALL_SLOWLOG & & ! ( c - > cmd - > flags & CMD_SKIP_SLOWLOG ) ) {
2015-07-27 09:41:48 +02:00
char * latency_event = ( c - > cmd - > flags & CMD_FAST ) ?
2014-07-01 11:43:38 +02:00
" fast-command " : " command " ;
2014-07-01 16:09:02 +02:00
latencyAddSampleIfNeeded ( latency_event , duration / 1000 ) ;
2017-06-15 12:57:54 +02:00
slowlogPushEntryIfNeeded ( c , c - > argv , c - > argc , duration ) ;
2014-07-01 11:43:38 +02:00
}
2019-07-03 12:42:16 +02:00
2015-07-27 09:41:48 +02:00
if ( flags & CMD_CALL_STATS ) {
2018-09-30 11:37:19 +03:00
/* use the real command that was executed (cmd and lastamc) may be
* different , in case of MULTI - EXEC or re - written commands such as
* EXPIRE , GEOADD , etc . */
real_cmd - > microseconds + = duration ;
real_cmd - > calls + + ;
2012-02-02 16:30:52 +01:00
}
2012-02-28 16:17:00 +01:00
/* Propagate the command into the AOF and replication link */
2015-10-29 15:57:41 +01:00
if ( flags & CMD_CALL_PROPAGATE & &
( c - > flags & CLIENT_PREVENT_PROP ) ! = CLIENT_PREVENT_PROP )
{
int propagate_flags = PROPAGATE_NONE ;
2012-02-28 16:17:00 +01:00
2015-10-29 11:05:27 +01:00
/* Check if the command operated changes in the data set. If so
* set for replication / AOF propagation . */
2015-10-29 15:57:41 +01:00
if ( dirty ) propagate_flags | = ( PROPAGATE_AOF | PROPAGATE_REPL ) ;
2015-10-29 11:05:27 +01:00
2015-11-10 13:31:25 +01:00
/* If the client forced AOF / replication of the command, set
2015-10-29 11:05:27 +01:00
* the flags regardless of the command effects on the data set . */
2015-10-30 09:41:04 +01:00
if ( c - > flags & CLIENT_FORCE_REPL ) propagate_flags | = PROPAGATE_REPL ;
if ( c - > flags & CLIENT_FORCE_AOF ) propagate_flags | = PROPAGATE_AOF ;
2015-10-29 11:05:27 +01:00
2015-10-29 15:57:41 +01:00
/* However prevent AOF / replication propagation if the command
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* implementation called preventCommandPropagation ( ) or similar ,
2015-10-29 15:57:41 +01:00
* or if we don ' t have the call ( ) flags to do so . */
if ( c - > flags & CLIENT_PREVENT_REPL_PROP | |
! ( flags & CMD_CALL_PROPAGATE_REPL ) )
propagate_flags & = ~ PROPAGATE_REPL ;
if ( c - > flags & CLIENT_PREVENT_AOF_PROP | |
! ( flags & CMD_CALL_PROPAGATE_AOF ) )
propagate_flags & = ~ PROPAGATE_AOF ;
2015-10-29 11:05:27 +01:00
/* Call propagate() only if at least one of AOF / replication
2017-11-23 13:05:00 +01:00
* propagation is needed . Note that modules commands handle replication
* in an explicit way , so we never replicate them automatically . */
if ( propagate_flags ! = PROPAGATE_NONE & & ! ( c - > cmd - > flags & CMD_MODULE ) )
2015-10-29 15:57:41 +01:00
propagate ( c - > cmd , c - > db - > id , c - > argv , c - > argc , propagate_flags ) ;
2012-02-02 16:30:52 +01:00
}
2013-01-10 11:19:40 +01:00
2015-10-29 10:44:30 +01:00
/* Restore the old replication flags, since call() can be executed
2013-06-21 12:07:53 +02:00
* recursively . */
2015-07-27 09:41:48 +02:00
c - > flags & = ~ ( CLIENT_FORCE_AOF | CLIENT_FORCE_REPL | CLIENT_PREVENT_PROP ) ;
2015-02-09 22:49:27 +01:00
c - > flags | = client_old_flags &
2015-07-27 09:41:48 +02:00
( CLIENT_FORCE_AOF | CLIENT_FORCE_REPL | CLIENT_PREVENT_PROP ) ;
2013-06-21 12:07:53 +02:00
2013-01-10 11:19:40 +01:00
/* Handle the alsoPropagate() API to handle commands that want to propagate
2015-02-09 22:49:27 +01:00
* multiple separated commands . Note that alsoPropagate ( ) is not affected
2015-07-27 09:41:48 +02:00
* by CLIENT_PREVENT_PROP flag . */
2012-02-29 00:46:50 +01:00
if ( server . also_propagate . numops ) {
2012-02-28 18:03:08 +01:00
int j ;
2012-02-29 00:46:50 +01:00
redisOp * rop ;
2012-02-28 18:03:08 +01:00
2015-07-27 09:41:48 +02:00
if ( flags & CMD_CALL_PROPAGATE ) {
2019-11-22 15:32:43 +08:00
int multi_emitted = 0 ;
/* Wrap the commands in server.also_propagate array,
2020-03-29 13:08:21 +03:00
* but don ' t wrap it if we are already in MULTI context ,
2020-03-31 11:00:45 +02:00
* in case the nested MULTI / EXEC .
2019-11-22 15:32:43 +08:00
*
* And if the array contains only one command , no need to
* wrap it , since the single command is atomic . */
2020-03-31 11:00:45 +02:00
if ( server . also_propagate . numops > 1 & &
! ( c - > cmd - > flags & CMD_MODULE ) & &
! ( c - > flags & CLIENT_MULTI ) & &
! ( flags & CMD_CALL_NOWRAP ) )
{
2019-11-22 15:32:43 +08:00
execCommandPropagateMulti ( c ) ;
multi_emitted = 1 ;
}
2015-02-09 23:57:52 +01:00
for ( j = 0 ; j < server . also_propagate . numops ; j + + ) {
rop = & server . also_propagate . ops [ j ] ;
2015-10-29 15:57:41 +01:00
int target = rop - > target ;
/* Whatever the command wish is, we honor the call() flags. */
if ( ! ( flags & CMD_CALL_PROPAGATE_AOF ) ) target & = ~ PROPAGATE_AOF ;
if ( ! ( flags & CMD_CALL_PROPAGATE_REPL ) ) target & = ~ PROPAGATE_REPL ;
if ( target )
propagate ( rop - > cmd , rop - > dbid , rop - > argv , rop - > argc , target ) ;
2015-02-09 23:57:52 +01:00
}
2019-11-22 15:32:43 +08:00
if ( multi_emitted ) {
execCommandPropagateExec ( c ) ;
}
2012-02-29 00:46:50 +01:00
}
redisOpArrayFree ( & server . also_propagate ) ;
2012-02-28 18:03:08 +01:00
}
2016-03-06 13:44:24 +01:00
server . also_propagate = prev_also_propagate ;
2019-07-03 12:42:16 +02:00
/* If the client has keys tracking enabled for client side caching,
* make sure to remember the keys it fetched via this command . */
if ( c - > cmd - > flags & CMD_READONLY ) {
client * caller = ( c - > flags & CLIENT_LUA & & server . lua_caller ) ?
server . lua_caller : c ;
2020-02-10 17:18:11 +01:00
if ( caller - > flags & CLIENT_TRACKING & &
! ( caller - > flags & CLIENT_TRACKING_BCAST ) )
{
2019-07-03 12:42:16 +02:00
trackingRememberKeys ( caller ) ;
2020-02-10 17:18:11 +01:00
}
2019-07-03 12:42:16 +02:00
}
2019-11-19 11:28:04 +01:00
server . fixed_time_expire - - ;
2010-06-22 00:07:48 +02:00
server . stat_numcommands + + ;
}
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
/* Used when a command that is ready for execution needs to be rejected, due to
* varios pre - execution checks . it returns the appropriate error to the client .
* If there ' s a transaction is flags it as dirty , and if the command is EXEC ,
2020-08-27 12:54:01 +03:00
* it aborts the transaction .
* Note : ' reply ' is expected to end with \ r \ n */
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
void rejectCommand ( client * c , robj * reply ) {
flagTransaction ( c ) ;
if ( c - > cmd & & c - > cmd - > proc = = execCommand ) {
execCommandAbort ( c , reply - > ptr ) ;
} else {
/* using addReplyError* rather than addReply so that the error can be logged. */
2020-08-27 12:54:01 +03:00
addReplyErrorObject ( c , reply ) ;
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
}
}
void rejectCommandFormat ( client * c , const char * fmt , . . . ) {
flagTransaction ( c ) ;
va_list ap ;
va_start ( ap , fmt ) ;
sds s = sdscatvprintf ( sdsempty ( ) , fmt , ap ) ;
va_end ( ap ) ;
2020-08-27 12:54:01 +03:00
/* Make sure there are no newlines in the string, otherwise invalid protocol
* is emitted ( The args come from the user , they may contain any character ) . */
sdsmapchars ( s , " \r \n " , " " , 2 ) ;
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
if ( c - > cmd & & c - > cmd - > proc = = execCommand ) {
execCommandAbort ( c , s ) ;
} else {
2020-08-27 12:54:01 +03:00
addReplyErrorSds ( c , s ) ;
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
}
sdsfree ( s ) ;
}
2020-07-21 14:41:44 +08:00
/* Returns 1 for commands that may have key names in their arguments, but have
* no pre - determined key positions . */
2020-07-20 20:33:06 +08:00
static int cmdHasMovableKeys ( struct redisCommand * cmd ) {
return ( cmd - > getkeys_proc & & ! ( cmd - > flags & CMD_MODULE ) ) | |
cmd - > flags & CMD_MODULE_GETKEYS ;
}
2010-06-22 00:07:48 +02:00
/* If this function gets called we already read a whole
2012-11-01 18:14:55 +08:00
* command , arguments are in the client argv / argc fields .
2010-06-22 00:07:48 +02:00
* processCommand ( ) execute the command or prepare the
* server for a bulk read from the client .
*
2015-12-17 09:22:16 +01:00
* If C_OK is returned the client is still alive and valid and
2013-01-17 01:00:20 +08:00
* other operations can be performed by the caller . Otherwise
2015-12-17 09:22:16 +01:00
* if C_ERR is returned the client was destroyed ( i . e . after QUIT ) . */
2015-07-26 15:20:46 +02:00
int processCommand ( client * c ) {
2018-02-23 16:19:37 +02:00
moduleCallCommandFilters ( c ) ;
2010-10-13 11:25:40 +02:00
/* The QUIT command is handled separately. Normal command procs will
* go through checking for replication and QUIT will cause trouble
* when FORCE_REPLICATION is enabled and would be implemented in
* a regular command proc . */
2010-06-22 00:07:48 +02:00
if ( ! strcasecmp ( c - > argv [ 0 ] - > ptr , " quit " ) ) {
2010-10-13 11:25:40 +02:00
addReply ( c , shared . ok ) ;
2015-07-27 09:41:48 +02:00
c - > flags | = CLIENT_CLOSE_AFTER_REPLY ;
2015-07-26 23:17:55 +02:00
return C_ERR ;
2010-06-22 00:07:48 +02:00
}
/* Now lookup the command and check ASAP about trivial error conditions
2011-07-08 12:59:30 +02:00
* such as wrong arity , bad command name and so forth . */
2011-11-24 14:56:34 +01:00
c - > cmd = c - > lastcmd = lookupCommand ( c - > argv [ 0 ] - > ptr ) ;
2011-07-08 12:59:30 +02:00
if ( ! c - > cmd ) {
fix rare replication stream corruption with disk-based replication
The slave sends \n keepalive messages to the master while parsing the rdb,
and later sends REPLCONF ACK once a second. rarely, the master recives both
a linefeed char and a REPLCONF in the same read, \n*3\r\n$8\r\nREPLCONF\r\n...
and it tries to trim two chars (\r\n) from the query buffer,
trimming the '*' from *3\r\n$8\r\nREPLCONF\r\n...
then the master tries to process a command starting with '3' and replies to
the slave a bunch of -ERR and one +OK.
although the slave silently ignores these (prints a log message), this corrupts
the replication offset at the slave since the slave increases the replication
offset, and the master did not.
other than the fix in processInlineBuffer, i did several other improvments
while hunting this very rare bug.
- when redis replies with "unknown command" it includes a portion of the
arguments, not just the command name. so it would be easier to understand
what was recived, in my case, on the slave side, it was -ERR, but
the "arguments" were the interesting part (containing info on the error).
- about a year ago i added code in addReplyErrorLength to print the error to
the log in case of a reply to master (since this string isn't actually
trasmitted to the master), now changed that block to print a similar log
message to indicate an error being sent from the master to the slave.
note that the slave is marked as CLIENT_SLAVE only after PSYNC was received,
so this will not cause any harm for REPLCONF, and will only indicate problems
that are gonna corrupt the replication stream anyway.
- two places were c->reply was emptied, and i wanted to reset sentlen
this is a precaution (i did not actually see such a problem), since a
non-zero sentlen will cause corruption to be transmitted on the socket.
2018-07-14 16:49:15 +03:00
sds args = sdsempty ( ) ;
int i ;
for ( i = 1 ; i < c - > argc & & sdslen ( args ) < 128 ; i + + )
args = sdscatprintf ( args , " `%.*s`, " , 128 - ( int ) sdslen ( args ) , ( char * ) c - > argv [ i ] - > ptr ) ;
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommandFormat ( c , " unknown command `%s`, with args beginning with: %s " ,
fix rare replication stream corruption with disk-based replication
The slave sends \n keepalive messages to the master while parsing the rdb,
and later sends REPLCONF ACK once a second. rarely, the master recives both
a linefeed char and a REPLCONF in the same read, \n*3\r\n$8\r\nREPLCONF\r\n...
and it tries to trim two chars (\r\n) from the query buffer,
trimming the '*' from *3\r\n$8\r\nREPLCONF\r\n...
then the master tries to process a command starting with '3' and replies to
the slave a bunch of -ERR and one +OK.
although the slave silently ignores these (prints a log message), this corrupts
the replication offset at the slave since the slave increases the replication
offset, and the master did not.
other than the fix in processInlineBuffer, i did several other improvments
while hunting this very rare bug.
- when redis replies with "unknown command" it includes a portion of the
arguments, not just the command name. so it would be easier to understand
what was recived, in my case, on the slave side, it was -ERR, but
the "arguments" were the interesting part (containing info on the error).
- about a year ago i added code in addReplyErrorLength to print the error to
the log in case of a reply to master (since this string isn't actually
trasmitted to the master), now changed that block to print a similar log
message to indicate an error being sent from the master to the slave.
note that the slave is marked as CLIENT_SLAVE only after PSYNC was received,
so this will not cause any harm for REPLCONF, and will only indicate problems
that are gonna corrupt the replication stream anyway.
- two places were c->reply was emptied, and i wanted to reset sentlen
this is a precaution (i did not actually see such a problem), since a
non-zero sentlen will cause corruption to be transmitted on the socket.
2018-07-14 16:49:15 +03:00
( char * ) c - > argv [ 0 ] - > ptr , args ) ;
sdsfree ( args ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2011-07-08 12:59:30 +02:00
} else if ( ( c - > cmd - > arity > 0 & & c - > cmd - > arity ! = c - > argc ) | |
( c - > argc < - c - > cmd - > arity ) ) {
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommandFormat ( c , " wrong number of arguments for '%s' command " ,
2011-07-08 12:59:30 +02:00
c - > cmd - > name ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2010-06-22 00:07:48 +02:00
}
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
int is_write_command = ( c - > cmd - > flags & CMD_WRITE ) | |
( c - > cmd - > proc = = execCommand & & ( c - > mstate . cmd_flags & CMD_WRITE ) ) ;
int is_denyoom_command = ( c - > cmd - > flags & CMD_DENYOOM ) | |
( c - > cmd - > proc = = execCommand & & ( c - > mstate . cmd_flags & CMD_DENYOOM ) ) ;
int is_denystale_command = ! ( c - > cmd - > flags & CMD_STALE ) | |
( c - > cmd - > proc = = execCommand & & ( c - > mstate . cmd_inv_flags & CMD_STALE ) ) ;
int is_denyloading_command = ! ( c - > cmd - > flags & CMD_LOADING ) | |
( c - > cmd - > proc = = execCommand & & ( c - > mstate . cmd_inv_flags & CMD_LOADING ) ) ;
2019-02-11 16:47:02 +01:00
/* Check if the user is authenticated. This check is skipped in case
* the default user is flagged as " nopass " and is active . */
2019-09-25 17:45:05 +02:00
int auth_required = ( ! ( DefaultUser - > flags & USER_FLAG_NOPASS ) | |
2020-03-20 12:45:48 +01:00
( DefaultUser - > flags & USER_FLAG_DISABLED ) ) & &
2019-02-11 16:47:02 +01:00
! c - > authenticated ;
2019-09-25 17:45:05 +02:00
if ( auth_required ) {
2019-02-26 01:23:11 +00:00
/* AUTH and HELLO and no auth modules are valid even in
* non - authenticated state . */
if ( ! ( c - > cmd - > flags & CMD_NO_AUTH ) ) {
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . noautherr ) ;
2019-02-11 16:47:02 +01:00
return C_OK ;
}
2010-06-22 00:07:48 +02:00
}
2019-01-15 18:28:43 +01:00
/* Check if the user can run this command according to the current
* ACLs . */
2020-01-28 18:04:20 +01:00
int acl_keypos ;
int acl_retval = ACLCheckCommandPerm ( c , & acl_keypos ) ;
2019-01-16 18:31:05 +01:00
if ( acl_retval ! = ACL_OK ) {
2020-02-04 12:55:26 +01:00
addACLLogEntry ( c , acl_retval , acl_keypos , NULL ) ;
2019-01-16 18:31:05 +01:00
if ( acl_retval = = ACL_DENIED_CMD )
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommandFormat ( c ,
2019-01-16 18:31:05 +01:00
" -NOPERM this user has no permissions to run "
2019-06-07 13:20:22 -07:00
" the '%s' command or its subcommand " , c - > cmd - > name ) ;
2019-01-16 18:31:05 +01:00
else
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommandFormat ( c ,
2019-01-16 18:31:05 +01:00
" -NOPERM this user has no permissions to access "
" one of the keys used as arguments " ) ;
2019-01-15 18:28:43 +01:00
return C_OK ;
}
2013-03-05 13:02:44 +01:00
/* If cluster is enabled perform the cluster redirection here.
* However we don ' t perform the redirection if :
* 1 ) The sender of this command is our master .
* 2 ) The command has no key arguments . */
2011-03-29 17:51:15 +02:00
if ( server . cluster_enabled & &
2015-07-27 09:41:48 +02:00
! ( c - > flags & CLIENT_MASTER ) & &
! ( c - > flags & CLIENT_LUA & &
server . lua_caller - > flags & CLIENT_MASTER ) & &
2020-07-20 20:33:06 +08:00
! ( ! cmdHasMovableKeys ( c - > cmd ) & & c - > cmd - > firstkey = = 0 & &
2016-03-11 15:22:36 -05:00
c - > cmd - > proc ! = execCommand ) )
2013-03-05 13:02:44 +01:00
{
2011-03-29 17:51:15 +02:00
int hashslot ;
2016-05-05 11:33:43 +02:00
int error_code ;
clusterNode * n = getNodeByQuery ( c , c - > cmd , c - > argv , c - > argc ,
& hashslot , & error_code ) ;
if ( n = = NULL | | n ! = server . cluster - > myself ) {
if ( c - > cmd - > proc = = execCommand ) {
discardTransaction ( c ) ;
} else {
flagTransaction ( c ) ;
2011-03-29 17:51:15 +02:00
}
2016-05-05 11:33:43 +02:00
clusterRedirectClient ( c , n , hashslot , error_code ) ;
return C_OK ;
2011-03-29 17:51:15 +02:00
}
}
2010-10-11 13:05:09 +02:00
/* Handle the maxmemory directive.
2018-09-05 13:10:05 +02:00
*
* Note that we do not want to reclaim memory if we are here re - entering
* the event loop since there is a busy Lua script running in timeout
2018-12-07 17:06:55 +01:00
* condition , to avoid mixing the propagation of scripts with the
* propagation of DELs due to eviction . */
2018-09-05 13:10:05 +02:00
if ( server . maxmemory & & ! server . lua_timedout ) {
2020-09-15 23:16:01 -07:00
int out_of_memory = ( performEvictions ( ) = = EVICT_FAIL ) ;
/* performEvictions may flush slave output buffers. This may result
* in a slave , that may be the active client , to be freed . */
2015-12-17 09:39:43 +01:00
if ( server . current_client = = NULL ) return C_ERR ;
2020-08-27 09:19:24 +03:00
int reject_cmd_on_oom = is_denyoom_command ;
/* If client is in MULTI/EXEC context, queuing may consume an unlimited
* amount of memory , so we want to stop that .
* However , we never want to reject DISCARD , or even EXEC ( unless it
* contains denied commands , in which case is_denyoom_command is already
* set . */
if ( c - > flags & CLIENT_MULTI & &
c - > cmd - > proc ! = execCommand & &
c - > cmd - > proc ! = discardCommand ) {
reject_cmd_on_oom = 1 ;
}
if ( out_of_memory & & reject_cmd_on_oom ) {
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . oomerr ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2012-02-04 14:05:54 +01:00
}
2020-01-20 21:17:02 +08:00
/* Save out_of_memory result at script start, otherwise if we check OOM
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
* until first write within script , memory used by lua stack and
2020-01-20 21:17:02 +08:00
* arguments might interfere . */
if ( c - > cmd - > proc = = evalCommand | | c - > cmd - > proc = = evalShaCommand ) {
server . lua_oom = out_of_memory ;
}
2010-06-22 00:07:48 +02:00
}
2019-07-22 18:59:53 +02:00
/* Make sure to use a reasonable amount of memory for client side
* caching metadata . */
if ( server . tracking_clients ) trackingLimitUsedSlots ( ) ;
2013-11-28 16:25:49 +01:00
/* Don't accept write commands if there are problems persisting on disk
* and if this is a master instance . */
2018-07-31 13:16:43 +02:00
int deny_write_type = writeCommandsDeniedByDiskError ( ) ;
if ( deny_write_type ! = DISK_ERROR_TYPE_NONE & &
2014-01-28 10:10:56 +01:00
server . masterhost = = NULL & &
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
( is_write_command | | c - > cmd - > proc = = pingCommand ) )
2012-03-07 13:05:46 +01:00
{
2018-07-31 13:16:43 +02:00
if ( deny_write_type = = DISK_ERROR_TYPE_RDB )
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . bgsaveerr ) ;
2014-02-12 12:47:10 +01:00
else
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommandFormat ( c ,
2020-08-27 12:54:01 +03:00
" -MISCONF Errors writing to the AOF file: %s " ,
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
strerror ( server . aof_last_write_errno ) ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2012-03-07 13:05:46 +01:00
}
2013-05-29 11:36:44 +02:00
/* Don't accept write commands if there are not enough good slaves and
2013-11-28 16:25:49 +01:00
* user configured the min - slaves - to - write option . */
2014-06-05 10:48:05 +02:00
if ( server . masterhost = = NULL & &
server . repl_min_slaves_to_write & &
2013-05-29 11:45:40 +02:00
server . repl_min_slaves_max_lag & &
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
is_write_command & &
2013-05-29 11:36:44 +02:00
server . repl_good_slaves_count < server . repl_min_slaves_to_write )
{
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . noreplicaserr ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2013-05-29 11:36:44 +02:00
}
2012-07-22 17:13:49 +02:00
/* Don't accept write commands if this is a read only slave. But
2012-03-20 17:32:48 +01:00
* accept write commands if this is our master . */
if ( server . masterhost & & server . repl_slave_ro & &
2015-07-27 09:41:48 +02:00
! ( c - > flags & CLIENT_MASTER ) & &
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
is_write_command )
2012-03-20 17:32:48 +01:00
{
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . roslaveerr ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2012-03-20 17:32:48 +01:00
}
2018-12-19 17:56:50 +01:00
/* Only allow a subset of commands in the context of Pub/Sub if the
* connection is in RESP2 mode . With RESP3 there are no limits . */
if ( ( c - > flags & CLIENT_PUBSUB & & c - > resp = = 2 ) & &
2014-07-16 17:34:07 +02:00
c - > cmd - > proc ! = pingCommand & &
2011-07-08 12:59:30 +02:00
c - > cmd - > proc ! = subscribeCommand & &
c - > cmd - > proc ! = unsubscribeCommand & &
c - > cmd - > proc ! = psubscribeCommand & &
c - > cmd - > proc ! = punsubscribeCommand ) {
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommandFormat ( c ,
2020-01-15 17:55:24 +01:00
" Can't execute '%s': only (P)SUBSCRIBE / "
" (P)UNSUBSCRIBE / PING / QUIT are allowed in this context " ,
2020-01-10 23:34:15 +02:00
c - > cmd - > name ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2010-06-22 00:07:48 +02:00
}
2017-12-05 14:41:16 +08:00
/* Only allow commands with flag "t", such as INFO, SLAVEOF and so on,
* when slave - serve - stale - data is no and we are a slave with a broken
* link with master . */
2015-07-27 09:41:48 +02:00
if ( server . masterhost & & server . repl_state ! = REPL_STATE_CONNECTED & &
2010-11-04 19:59:21 +01:00
server . repl_serve_stale_data = = 0 & &
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
is_denystale_command )
2010-11-04 19:59:21 +01:00
{
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . masterdownerr ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2010-11-04 19:59:21 +01:00
}
2012-07-22 17:13:49 +02:00
/* Loading DB? Return an error if the command has not the
2015-07-27 09:41:48 +02:00
* CMD_LOADING flag . */
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
if ( server . loading & & is_denyloading_command ) {
rejectCommand ( c , shared . loadingerr ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2010-11-08 11:52:03 +01:00
}
2020-03-25 12:46:59 +01:00
/* Lua script too slow? Only allow a limited number of commands.
* Note that we need to allow the transactions commands , otherwise clients
* sending a transaction with pipelining without error checking , may have
* the MULTI plus a few initial commands refused , then the timeout
* condition resolves , and the bottom - half of the transaction gets
* executed , see Github PR # 7022. */
2011-11-18 14:10:48 +01:00
if ( server . lua_timedout & &
2012-10-11 18:34:05 +02:00
c - > cmd - > proc ! = authCommand & &
2018-12-21 17:11:52 +01:00
c - > cmd - > proc ! = helloCommand & &
2013-05-28 15:23:42 +02:00
c - > cmd - > proc ! = replconfCommand & &
2020-03-25 12:46:59 +01:00
c - > cmd - > proc ! = multiCommand & &
c - > cmd - > proc ! = discardCommand & &
2020-06-08 09:16:32 +03:00
c - > cmd - > proc ! = watchCommand & &
c - > cmd - > proc ! = unwatchCommand & &
2012-04-19 23:35:15 +02:00
! ( c - > cmd - > proc = = shutdownCommand & &
2011-11-18 14:10:48 +01:00
c - > argc = = 2 & &
tolower ( ( ( char * ) c - > argv [ 1 ] - > ptr ) [ 0 ] ) = = ' n ' ) & &
! ( c - > cmd - > proc = = scriptCommand & &
c - > argc = = 2 & &
tolower ( ( ( char * ) c - > argv [ 1 ] - > ptr ) [ 0 ] ) = = ' k ' ) )
{
EXEC always fails with EXECABORT and multi-state is cleared
In order to support the use of multi-exec in pipeline, it is important that
MULTI and EXEC are never rejected and it is easy for the client to know if the
connection is still in multi state.
It was easy to make sure MULTI and DISCARD never fail (done by previous
commits) since these only change the client state and don't do any actual
change in the server, but EXEC is a different story.
Since in the past, it was possible for clients to handle some EXEC errors and
retry the EXEC, we now can't affort to return any error on EXEC other than
EXECABORT, which now carries with it the real reason for the abort too.
Other fixes in this commit:
- Some checks that where performed at the time of queuing need to be re-
validated when EXEC runs, for instance if the transaction contains writes
commands, it needs to be aborted. there was one check that was already done
in execCommand (-READONLY), but other checks where missing: -OOM, -MISCONF,
-NOREPLICAS, -MASTERDOWN
- When a command is rejected by processCommand it was rejected with addReply,
which was not recognized as an error in case the bad command came from the
master. this will enable to count or MONITOR these errors in the future.
- make it easier for tests to create additional (non deferred) clients.
- add tests for the fixes of this commit.
2020-06-11 21:09:35 +03:00
rejectCommand ( c , shared . slowscripterr ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2011-10-27 14:49:10 +02:00
}
2010-06-22 00:07:48 +02:00
/* Exec the command */
2015-07-27 09:41:48 +02:00
if ( c - > flags & CLIENT_MULTI & &
2011-07-08 12:59:30 +02:00
c - > cmd - > proc ! = execCommand & & c - > cmd - > proc ! = discardCommand & &
c - > cmd - > proc ! = multiCommand & & c - > cmd - > proc ! = watchCommand )
2010-06-22 00:07:48 +02:00
{
2011-07-08 12:59:30 +02:00
queueMultiCommand ( c ) ;
2010-06-22 00:07:48 +02:00
addReply ( c , shared . queued ) ;
} else {
2015-07-27 09:41:48 +02:00
call ( c , CMD_CALL_FULL ) ;
2013-12-04 15:52:20 +01:00
c - > woff = server . master_repl_offset ;
A reimplementation of blocking operation internals.
Redis provides support for blocking operations such as BLPOP or BRPOP.
This operations are identical to normal LPOP and RPOP operations as long
as there are elements in the target list, but if the list is empty they
block waiting for new data to arrive to the list.
All the clients blocked waiting for th same list are served in a FIFO
way, so the first that blocked is the first to be served when there is
more data pushed by another client into the list.
The previous implementation of blocking operations was conceived to
serve clients in the context of push operations. For for instance:
1) There is a client "A" blocked on list "foo".
2) The client "B" performs `LPUSH foo somevalue`.
3) The client "A" is served in the context of the "B" LPUSH,
synchronously.
Processing things in a synchronous way was useful as if "A" pushes a
value that is served by "B", from the point of view of the database is a
NOP (no operation) thing, that is, nothing is replicated, nothing is
written in the AOF file, and so forth.
However later we implemented two things:
1) Variadic LPUSH that could add multiple values to a list in the
context of a single call.
2) BRPOPLPUSH that was a version of BRPOP that also provided a "PUSH"
side effect when receiving data.
This forced us to make the synchronous implementation more complex. If
client "B" is waiting for data, and "A" pushes three elemnents in a
single call, we needed to propagate an LPUSH with a missing argument
in the AOF and replication link. We also needed to make sure to
replicate the LPUSH side of BRPOPLPUSH, but only if in turn did not
happened to serve another blocking client into another list ;)
This were complex but with a few of mutually recursive functions
everything worked as expected... until one day we introduced scripting
in Redis.
Scripting + synchronous blocking operations = Issue #614.
Basically you can't "rewrite" a script to have just a partial effect on
the replicas and AOF file if the script happened to serve a few blocked
clients.
The solution to all this problems, implemented by this commit, is to
change the way we serve blocked clients. Instead of serving the blocked
clients synchronously, in the context of the command performing the PUSH
operation, it is now an asynchronous and iterative process:
1) If a key that has clients blocked waiting for data is the subject of
a list push operation, We simply mark keys as "ready" and put it into a
queue.
2) Every command pushing stuff on lists, as a variadic LPUSH, a script,
or whatever it is, is replicated verbatim without any rewriting.
3) Every time a Redis command, a MULTI/EXEC block, or a script,
completed its execution, we run the list of keys ready to serve blocked
clients (as more data arrived), and process this list serving the
blocked clients.
4) As a result of "3" maybe more keys are ready again for other clients
(as a result of BRPOPLPUSH we may have push operations), so we iterate
back to step "3" if it's needed.
The new code has a much simpler semantics, and a simpler to understand
implementation, with the disadvantage of not being able to "optmize out"
a PUSH+BPOP as a No OP.
This commit will be tested with care before the final merge, more tests
will be added likely.
2012-09-04 10:37:49 +02:00
if ( listLength ( server . ready_keys ) )
2017-09-06 15:43:28 +02:00
handleClientsBlockedOnKeys ( ) ;
2010-06-22 00:07:48 +02:00
}
2015-07-26 23:17:55 +02:00
return C_OK ;
2010-06-22 00:07:48 +02:00
}
/*================================== Shutdown =============================== */
2013-07-05 11:47:20 +02:00
/* Close listening sockets. Also unlink the unix domain socket if
* unlink_unix_socket is non - zero . */
void closeListeningSockets ( int unlink_unix_socket ) {
int j ;
for ( j = 0 ; j < server . ipfd_count ; j + + ) close ( server . ipfd [ j ] ) ;
2019-09-12 10:56:54 +03:00
for ( j = 0 ; j < server . tlsfd_count ; j + + ) close ( server . tlsfd [ j ] ) ;
2013-07-05 11:47:20 +02:00
if ( server . sofd ! = - 1 ) close ( server . sofd ) ;
if ( server . cluster_enabled )
for ( j = 0 ; j < server . cfd_count ; j + + ) close ( server . cfd [ j ] ) ;
if ( unlink_unix_socket & & server . unixsocket ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " Removing the unix socket file. " ) ;
2013-07-05 11:47:20 +02:00
unlink ( server . unixsocket ) ; /* don't care if this fails */
}
}
2011-11-18 14:10:48 +01:00
int prepareForShutdown ( int flags ) {
2020-06-17 22:22:49 +02:00
/* When SHUTDOWN is called while the server is loading a dataset in
* memory we need to make sure no attempt is performed to save
* the dataset on shutdown ( otherwise it could overwrite the current DB
* with half - read data ) .
*
* Also when in Sentinel mode clear the SAVE flag and force NOSAVE . */
if ( server . loading | | server . sentinel_mode )
flags = ( flags & ~ SHUTDOWN_SAVE ) | SHUTDOWN_NOSAVE ;
2015-07-27 09:41:48 +02:00
int save = flags & SHUTDOWN_SAVE ;
int nosave = flags & SHUTDOWN_NOSAVE ;
2011-11-18 14:10:48 +01:00
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " User requested shutdown... " ) ;
2019-04-27 18:07:30 +02:00
if ( server . supervised_mode = = SUPERVISED_SYSTEMD )
redisCommunicateSystemd ( " STOPPING=1 \n " ) ;
2015-11-09 17:26:56 +01:00
2015-11-13 09:31:01 +01:00
/* Kill all the Lua debugger forked sessions. */
ldbKillForkedSessions ( ) ;
2010-06-22 00:07:48 +02:00
/* Kill the saving child if there is a background saving in progress.
We want to avoid race conditions , for instance our saving child may
overwrite the synchronous saving did by SHUTDOWN . */
2011-12-21 12:22:13 +01:00
if ( server . rdb_child_pid ! = - 1 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " There is a child saving an .rdb. Killing it! " ) ;
2020-09-17 23:20:10 +08:00
/* Note that, in killRDBChild, we call rdbRemoveTempFile that will
* do close fd ( in order to unlink file actully ) in background thread .
* The temp rdb file fd may won ' t be closed when redis exits quickly ,
* but OS will close this fd when process exits . */
2019-01-21 11:28:44 +01:00
killRDBChild ( ) ;
2010-06-22 00:07:48 +02:00
}
2015-11-09 17:26:56 +01:00
2019-08-25 10:11:48 +03:00
/* Kill module child if there is one. */
if ( server . module_child_pid ! = - 1 ) {
serverLog ( LL_WARNING , " There is a module fork child. Killing it! " ) ;
2019-09-27 12:17:47 +02:00
TerminateModuleForkChild ( server . module_child_pid , 0 ) ;
2019-08-25 10:11:48 +03:00
}
2015-07-27 09:41:48 +02:00
if ( server . aof_state ! = AOF_OFF ) {
2011-07-22 11:52:21 +02:00
/* Kill the AOF saving child as the AOF we already have may be longer
* but contains the full dataset anyway . */
2011-12-21 12:17:02 +01:00
if ( server . aof_child_pid ! = - 1 ) {
2014-06-21 11:14:05 -04:00
/* If we have AOF enabled but haven't written the AOF yet, don't
* shutdown or else the dataset will be lost . */
2015-07-27 09:41:48 +02:00
if ( server . aof_state = = AOF_WAIT_REWRITE ) {
serverLog ( LL_WARNING , " Writing initial AOF, can't exit. " ) ;
2015-07-26 23:17:55 +02:00
return C_ERR ;
2014-06-21 11:14:05 -04:00
}
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2011-07-22 11:52:21 +02:00
" There is a child rewriting the AOF. Killing it! " ) ;
2019-01-21 11:28:44 +01:00
killAppendOnlyChild ( ) ;
2011-07-22 11:52:21 +02:00
}
2017-09-17 07:22:16 +03:00
/* Append only file: flush buffers and fsync() the AOF at exit */
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " Calling fsync() on the AOF file. " ) ;
2017-09-17 07:22:16 +03:00
flushAppendOnlyFile ( 1 ) ;
2018-03-16 00:44:50 +08:00
redis_fsync ( server . aof_fd ) ;
2011-07-22 11:52:21 +02:00
}
2015-11-09 17:26:56 +01:00
/* Create a new RDB file before exiting. */
2011-11-18 14:10:48 +01:00
if ( ( server . saveparamslen > 0 & & ! nosave ) | | save ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " Saving the final RDB snapshot before exiting. " ) ;
2019-04-27 18:07:30 +02:00
if ( server . supervised_mode = = SUPERVISED_SYSTEMD )
redisCommunicateSystemd ( " STATUS=Saving the final RDB snapshot \n " ) ;
2010-06-22 00:07:48 +02:00
/* Snapshotting. Perform a SYNC SAVE and exit */
2017-09-19 23:03:39 +02:00
rdbSaveInfo rsi , * rsiptr ;
rsiptr = rdbPopulateSaveInfo ( & rsi ) ;
if ( rdbSave ( server . rdb_filename , rsiptr ) ! = C_OK ) {
2010-06-22 00:07:48 +02:00
/* Ooops.. error saving! The best we can do is to continue
* operating . Note that if there was a background saving process ,
* in the next cron ( ) Redis will be notified that the background
* saving aborted , handling special stuff like slaves pending for
* synchronization . . . */
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Error trying to save the DB, can't exit. " ) ;
2019-04-27 18:07:30 +02:00
if ( server . supervised_mode = = SUPERVISED_SYSTEMD )
redisCommunicateSystemd ( " STATUS=Error trying to save the DB, can't exit. \n " ) ;
2015-07-26 23:17:55 +02:00
return C_ERR ;
2010-06-22 00:07:48 +02:00
}
}
2015-11-09 17:26:56 +01:00
2019-10-29 17:59:09 +02:00
/* Fire the shutdown modules event. */
moduleFireServerEvent ( REDISMODULE_EVENT_SHUTDOWN , 0 , NULL ) ;
2015-11-09 17:26:56 +01:00
/* Remove the pid file if possible and needed. */
2012-04-18 11:04:37 +12:00
if ( server . daemonize | | server . pidfile ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " Removing the pid file. " ) ;
2011-07-22 11:52:21 +02:00
unlink ( server . pidfile ) ;
}
2015-11-09 17:26:56 +01:00
/* Best effort flush of slave output buffers, so that we hopefully
* send them pending writes . */
flushSlavesOutputBuffers ( ) ;
2011-07-22 12:11:40 +02:00
/* Close the listening sockets. Apparently this allows faster restarts. */
2013-07-05 11:47:20 +02:00
closeListeningSockets ( 1 ) ;
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " %s is now ready to exit, bye bye... " ,
2014-02-07 11:22:24 +01:00
server . sentinel_mode ? " Sentinel " : " Redis " ) ;
2015-07-26 23:17:55 +02:00
return C_OK ;
2010-06-22 00:07:48 +02:00
}
/*================================== Commands =============================== */
Squash merging 125 typo/grammar/comment/doc PRs (#7773)
List of squashed commits or PRs
===============================
commit 66801ea
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Jan 13 00:54:31 2020 -0500
typo fix in acl.c
commit 46f55db
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun Sep 6 18:24:11 2020 +0300
Updates a couple of comments
Specifically:
* RM_AutoMemory completed instead of pointing to docs
* Updated link to custom type doc
commit 61a2aa0
Author: xindoo <xindoo@qq.com>
Date: Tue Sep 1 19:24:59 2020 +0800
Correct errors in code comments
commit a5871d1
Author: yz1509 <pro-756@qq.com>
Date: Tue Sep 1 18:36:06 2020 +0800
fix typos in module.c
commit 41eede7
Author: bookug <bookug@qq.com>
Date: Sat Aug 15 01:11:33 2020 +0800
docs: fix typos in comments
commit c303c84
Author: lazy-snail <ws.niu@outlook.com>
Date: Fri Aug 7 11:15:44 2020 +0800
fix spelling in redis.conf
commit 1eb76bf
Author: zhujian <zhujianxyz@gmail.com>
Date: Thu Aug 6 15:22:10 2020 +0800
add a missing 'n' in comment
commit 1530ec2
Author: Daniel Dai <764122422@qq.com>
Date: Mon Jul 27 00:46:35 2020 -0400
fix spelling in tracking.c
commit e517b31
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:32 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit c300eff
Author: Hunter-Chen <huntcool001@gmail.com>
Date: Fri Jul 17 22:33:23 2020 +0800
Update redis.conf
Co-authored-by: Itamar Haber <itamar@redislabs.com>
commit 4c058a8
Author: 陈浩鹏 <chenhaopeng@heytea.com>
Date: Thu Jun 25 19:00:56 2020 +0800
Grammar fix and clarification
commit 5fcaa81
Author: bodong.ybd <bodong.ybd@alibaba-inc.com>
Date: Fri Jun 19 10:09:00 2020 +0800
Fix typos
commit 4caca9a
Author: Pruthvi P <pruthvi@ixigo.com>
Date: Fri May 22 00:33:22 2020 +0530
Fix typo eviciton => eviction
commit b2a25f6
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Sun May 17 12:39:59 2020 -0400
Fix a typo.
commit 12842ae
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun May 3 17:16:59 2020 -0400
fix spelling in redis conf
commit ddba07c
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Sat May 2 23:25:34 2020 +0100
Correct a "conflicts" spelling error.
commit 8fc7bf2
Author: Nao YONASHIRO <yonashiro@r.recruit.co.jp>
Date: Thu Apr 30 10:25:27 2020 +0900
docs: fix EXPIRE_FAST_CYCLE_DURATION to ACTIVE_EXPIRE_CYCLE_FAST_DURATION
commit 9b2b67a
Author: Brad Dunbar <dunbarb2@gmail.com>
Date: Fri Apr 24 11:46:22 2020 -0400
Fix a typo.
commit 0746f10
Author: devilinrust <63737265+devilinrust@users.noreply.github.com>
Date: Thu Apr 16 00:17:53 2020 +0200
Fix typos in server.c
commit 92b588d
Author: benjessop12 <56115861+benjessop12@users.noreply.github.com>
Date: Mon Apr 13 13:43:55 2020 +0100
Fix spelling mistake in lazyfree.c
commit 1da37aa
Merge: 2d4ba28 af347a8
Author: hwware <wen.hui.ware@gmail.com>
Date: Thu Mar 5 22:41:31 2020 -0500
Merge remote-tracking branch 'upstream/unstable' into expiretypofix
commit 2d4ba28
Author: hwware <wen.hui.ware@gmail.com>
Date: Mon Mar 2 00:09:40 2020 -0500
fix typo in expire.c
commit 1a746f7
Author: SennoYuki <minakami1yuki@gmail.com>
Date: Thu Feb 27 16:54:32 2020 +0800
fix typo
commit 8599b1a
Author: dongheejeong <donghee950403@gmail.com>
Date: Sun Feb 16 20:31:43 2020 +0000
Fix typo in server.c
commit f38d4e8
Author: hwware <wen.hui.ware@gmail.com>
Date: Sun Feb 2 22:58:38 2020 -0500
fix typo in evict.c
commit fe143fc
Author: Leo Murillo <leonardo.murillo@gmail.com>
Date: Sun Feb 2 01:57:22 2020 -0600
Fix a few typos in redis.conf
commit 1ab4d21
Author: viraja1 <anchan.viraj@gmail.com>
Date: Fri Dec 27 17:15:58 2019 +0530
Fix typo in Latency API docstring
commit ca1f70e
Author: gosth <danxuedexing@qq.com>
Date: Wed Dec 18 15:18:02 2019 +0800
fix typo in sort.c
commit a57c06b
Author: ZYunH <zyunhjob@163.com>
Date: Mon Dec 16 22:28:46 2019 +0800
fix-zset-typo
commit b8c92b5
Author: git-hulk <hulk.website@gmail.com>
Date: Mon Dec 16 15:51:42 2019 +0800
FIX: typo in cluster.c, onformation->information
commit 9dd981c
Author: wujm2007 <jim.wujm@gmail.com>
Date: Mon Dec 16 09:37:52 2019 +0800
Fix typo
commit e132d7a
Author: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
Date: Fri Nov 15 00:14:07 2019 +0000
Minor typo change
commit 47f44d5
Author: happynote3966 <01ssrmikururudevice01@gmail.com>
Date: Mon Nov 11 22:08:48 2019 +0900
fix comment typo in redis-cli.c
commit b8bdb0d
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 18:00:17 2019 +0800
Fix a spelling mistake of comments in defragDictBucketCallback
commit 0def46a
Author: fulei <fulei@kuaishou.com>
Date: Wed Oct 16 13:09:27 2019 +0800
fix some spelling mistakes of comments in defrag.c
commit f3596fd
Author: Phil Rajchgot <tophil@outlook.com>
Date: Sun Oct 13 02:02:32 2019 -0400
Typo and grammar fixes
Redis and its documentation are great -- just wanted to submit a few corrections in the spirit of Hacktoberfest. Thanks for all your work on this project. I use it all the time and it works beautifully.
commit 2b928cd
Author: KangZhiDong <worldkzd@gmail.com>
Date: Sun Sep 1 07:03:11 2019 +0800
fix typos
commit 33aea14
Author: Axlgrep <axlgrep@gmail.com>
Date: Tue Aug 27 11:02:18 2019 +0800
Fixed eviction spelling issues
commit e282a80
Author: Simen Flatby <simen@oms.no>
Date: Tue Aug 20 15:25:51 2019 +0200
Update comments to reflect prop name
In the comments the prop is referenced as replica-validity-factor,
but it is really named cluster-replica-validity-factor.
commit 74d1f9a
Author: Jim Green <jimgreen2013@qq.com>
Date: Tue Aug 20 20:00:31 2019 +0800
fix comment error, the code is ok
commit eea1407
Author: Liao Tonglang <liaotonglang@gmail.com>
Date: Fri May 31 10:16:18 2019 +0800
typo fix
fix cna't to can't
commit 0da553c
Author: KAWACHI Takashi <tkawachi@gmail.com>
Date: Wed Jul 17 00:38:16 2019 +0900
Fix typo
commit 7fc8fb6
Author: Michael Prokop <mika@grml.org>
Date: Tue May 28 17:58:42 2019 +0200
Typo fixes
s/familar/familiar/
s/compatiblity/compatibility/
s/ ot / to /
s/itsef/itself/
commit 5f46c9d
Author: zhumoing <34539422+zhumoing@users.noreply.github.com>
Date: Tue May 21 21:16:50 2019 +0800
typo-fixes
typo-fixes
commit 321dfe1
Author: wxisme <850885154@qq.com>
Date: Sat Mar 16 15:10:55 2019 +0800
typo fix
commit b4fb131
Merge: 267e0e6 3df1eb8
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Fri Feb 8 22:55:45 2019 +0200
Merge branch 'unstable' of antirez/redis into unstable
commit 267e0e6
Author: Nikitas Bastas <nikitasbst@gmail.com>
Date: Wed Jan 30 21:26:04 2019 +0200
Minor typo fix
commit 30544e7
Author: inshal96 <39904558+inshal96@users.noreply.github.com>
Date: Fri Jan 4 16:54:50 2019 +0500
remove an extra 'a' in the comments
commit 337969d
Author: BrotherGao <yangdongheng11@gmail.com>
Date: Sat Dec 29 12:37:29 2018 +0800
fix typo in redis.conf
commit 9f4b121
Merge: 423a030 e504583
Author: BrotherGao <yangdongheng@xiaomi.com>
Date: Sat Dec 29 11:41:12 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 423a030
Merge: 42b02b7 46a51cd
Author: 杨东衡 <yangdongheng@xiaomi.com>
Date: Tue Dec 4 23:56:11 2018 +0800
Merge branch 'unstable' of antirez/redis into unstable
commit 42b02b7
Merge: 68c0e6e b8febe6
Author: Dongheng Yang <yangdongheng11@gmail.com>
Date: Sun Oct 28 15:54:23 2018 +0800
Merge pull request #1 from antirez/unstable
update local data
commit 714b589
Author: Christian <crifei93@gmail.com>
Date: Fri Dec 28 01:17:26 2018 +0100
fix typo "resulution"
commit e23259d
Author: garenchan <1412950785@qq.com>
Date: Wed Dec 26 09:58:35 2018 +0800
fix typo: segfauls -> segfault
commit a9359f8
Author: xjp <jianping_xie@aliyun.com>
Date: Tue Dec 18 17:31:44 2018 +0800
Fixed REDISMODULE_H spell bug
commit a12c3e4
Author: jdiaz <jrd.palacios@gmail.com>
Date: Sat Dec 15 23:39:52 2018 -0600
Fixes hyperloglog hash function comment block description
commit 770eb11
Author: 林上耀 <1210tom@163.com>
Date: Sun Nov 25 17:16:10 2018 +0800
fix typo
commit fd97fbb
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date: Fri Nov 23 17:14:01 2018 +0100
Correct "unsupported" typo.
commit a85522d
Author: Jungnam Lee <jungnam.lee@oracle.com>
Date: Thu Nov 8 23:01:29 2018 +0900
fix typo in test comments
commit ade8007
Author: Arun Kumar <palerdot@users.noreply.github.com>
Date: Tue Oct 23 16:56:35 2018 +0530
Fixed grammatical typo
Fixed typo for word 'dictionary'
commit 869ee39
Author: Hamid Alaei <hamid.a85@gmail.com>
Date: Sun Aug 12 16:40:02 2018 +0430
fix documentations: (ThreadSafeContextStart/Stop -> ThreadSafeContextLock/Unlock), minor typo
commit f89d158
Author: Mayank Jain <mayankjain255@gmail.com>
Date: Tue Jul 31 23:01:21 2018 +0530
Updated README.md with some spelling corrections.
Made correction in spelling of some misspelled words.
commit 892198e
Author: dsomeshwar <someshwar.dhayalan@gmail.com>
Date: Sat Jul 21 23:23:04 2018 +0530
typo fix
commit 8a4d780
Author: Itamar Haber <itamar@redislabs.com>
Date: Mon Apr 30 02:06:52 2018 +0300
Fixes some typos
commit e3acef6
Author: Noah Rosamilia <ivoahivoah@gmail.com>
Date: Sat Mar 3 23:41:21 2018 -0500
Fix typo in /deps/README.md
commit 04442fb
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:32:42 2018 +0800
Fix typo in readSyncBulkPayload() comment.
commit 9f36880
Author: WuYunlong <xzsyeb@126.com>
Date: Sat Mar 3 10:20:37 2018 +0800
replication.c comment: run_id -> replid.
commit f866b4a
Author: Francesco 'makevoid' Canessa <makevoid@gmail.com>
Date: Thu Feb 22 22:01:56 2018 +0000
fix comment typo in server.c
commit 0ebc69b
Author: 줍 <jubee0124@gmail.com>
Date: Mon Feb 12 16:38:48 2018 +0900
Fix typo in redis.conf
Fix `five behaviors` to `eight behaviors` in [this sentence ](antirez/redis@unstable/redis.conf#L564)
commit b50a620
Author: martinbroadhurst <martinbroadhurst@users.noreply.github.com>
Date: Thu Dec 28 12:07:30 2017 +0000
Fix typo in valgrind.sup
commit 7d8f349
Author: Peter Boughton <peter@sorcerersisle.com>
Date: Mon Nov 27 19:52:19 2017 +0000
Update CONTRIBUTING; refer doc updates to redis-doc repo.
commit 02dec7e
Author: Klauswk <klauswk1@hotmail.com>
Date: Tue Oct 24 16:18:38 2017 -0200
Fix typo in comment
commit e1efbc8
Author: chenshi <baiwfg2@gmail.com>
Date: Tue Oct 3 18:26:30 2017 +0800
Correct two spelling errors of comments
commit 93327d8
Author: spacewander <spacewanderlzx@gmail.com>
Date: Wed Sep 13 16:47:24 2017 +0800
Update the comment for OBJ_ENCODING_EMBSTR_SIZE_LIMIT's value
The value of OBJ_ENCODING_EMBSTR_SIZE_LIMIT is 44 now instead of 39.
commit 63d361f
Author: spacewander <spacewanderlzx@gmail.com>
Date: Tue Sep 12 15:06:42 2017 +0800
Fix <prevlen> related doc in ziplist.c
According to the definition of ZIP_BIG_PREVLEN and other related code,
the guard of single byte <prevlen> should be 254 instead of 255.
commit ebe228d
Author: hanael80 <hanael80@gmail.com>
Date: Tue Aug 15 09:09:40 2017 +0900
Fix typo
commit 6b696e6
Author: Matt Robenolt <matt@ydekproductions.com>
Date: Mon Aug 14 14:50:47 2017 -0700
Fix typo in LATENCY DOCTOR output
commit a2ec6ae
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 15 14:15:16 2017 +0800
Fix a typo: form => from
commit 3ab7699
Author: caosiyang <caosiyang@qiyi.com>
Date: Thu Aug 10 18:40:33 2017 +0800
Fix a typo: replicationFeedSlavesFromMaster() => replicationFeedSlavesFromMasterStream()
commit 72d43ef
Author: caosiyang <caosiyang@qiyi.com>
Date: Tue Aug 8 15:57:25 2017 +0800
fix a typo: servewr => server
commit 707c958
Author: Bo Cai <charpty@gmail.com>
Date: Wed Jul 26 21:49:42 2017 +0800
redis-cli.c typo: conut -> count.
Signed-off-by: Bo Cai <charpty@gmail.com>
commit b9385b2
Author: JackDrogon <jack.xsuperman@gmail.com>
Date: Fri Jun 30 14:22:31 2017 +0800
Fix some spell problems
commit 20d9230
Author: akosel <aaronjkosel@gmail.com>
Date: Sun Jun 4 19:35:13 2017 -0500
Fix typo
commit b167bfc
Author: Krzysiek Witkowicz <krzysiekwitkowicz@gmail.com>
Date: Mon May 22 21:32:27 2017 +0100
Fix #4008 small typo in comment
commit 2b78ac8
Author: Jake Clarkson <jacobwclarkson@gmail.com>
Date: Wed Apr 26 15:49:50 2017 +0100
Correct typo in tests/unit/hyperloglog.tcl
commit b0f1cdb
Author: Qi Luo <qiluo-msft@users.noreply.github.com>
Date: Wed Apr 19 14:25:18 2017 -0700
Fix typo
commit a90b0f9
Author: charsyam <charsyam@naver.com>
Date: Thu Mar 16 18:19:53 2017 +0900
fix typos
fix typos
fix typos
commit 8430a79
Author: Richard Hart <richardhart92@gmail.com>
Date: Mon Mar 13 22:17:41 2017 -0400
Fixed log message typo in listenToPort.
commit 481a1c2
Author: Vinod Kumar <kumar003vinod@gmail.com>
Date: Sun Jan 15 23:04:51 2017 +0530
src/db.c: Correct "save" -> "safe" typo
commit 586b4d3
Author: wangshaonan <wshn13@gmail.com>
Date: Wed Dec 21 20:28:27 2016 +0800
Fix typo they->the in helloworld.c
commit c1c4b5e
Author: Jenner <hypxm@qq.com>
Date: Mon Dec 19 16:39:46 2016 +0800
typo error
commit 1ee1a3f
Author: tielei <43289893@qq.com>
Date: Mon Jul 18 13:52:25 2016 +0800
fix some comments
commit 11a41fb
Author: Otto Kekäläinen <otto@seravo.fi>
Date: Sun Jul 3 10:23:55 2016 +0100
Fix spelling in documentation and comments
commit 5fb5d82
Author: francischan <f1ancis621@gmail.com>
Date: Tue Jun 28 00:19:33 2016 +0800
Fix outdated comments about redis.c file.
It should now refer to server.c file.
commit 6b254bc
Author: lmatt-bit <lmatt123n@gmail.com>
Date: Thu Apr 21 21:45:58 2016 +0800
Refine the comment of dictRehashMilliseconds func
SLAVECONF->REPLCONF in comment - by andyli029
commit ee9869f
Author: clark.kang <charsyam@naver.com>
Date: Tue Mar 22 11:09:51 2016 +0900
fix typos
commit f7b3b11
Author: Harisankar H <harisankarh@gmail.com>
Date: Wed Mar 9 11:49:42 2016 +0530
Typo correction: "faield" --> "failed"
Typo correction: "faield" --> "failed"
commit 3fd40fc
Author: Itamar Haber <itamar@redislabs.com>
Date: Thu Feb 25 10:31:51 2016 +0200
Fixes a typo in comments
commit 621c160
Author: Prayag Verma <prayag.verma@gmail.com>
Date: Mon Feb 1 12:36:20 2016 +0530
Fix typo in Readme.md
Spelling mistakes -
`eviciton` > `eviction`
`familar` > `familiar`
commit d7d07d6
Author: WonCheol Lee <toctoc21c@gmail.com>
Date: Wed Dec 30 15:11:34 2015 +0900
Typo fixed
commit a4dade7
Author: Felix Bünemann <buenemann@louis.info>
Date: Mon Dec 28 11:02:55 2015 +0100
[ci skip] Improve supervised upstart config docs
This mentions that "expect stop" is required for supervised upstart
to work correctly. See http://upstart.ubuntu.com/cookbook/#expect-stop
for an explanation.
commit d9caba9
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:30:03 2015 +1100
README: Remove trailing whitespace
commit 72d42e5
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:32 2015 +1100
README: Fix typo. th => the
commit dd6e957
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:29:20 2015 +1100
README: Fix typo. familar => familiar
commit 3a12b23
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:28:54 2015 +1100
README: Fix typo. eviciton => eviction
commit 2d1d03b
Author: daurnimator <quae@daurnimator.com>
Date: Mon Dec 21 18:21:45 2015 +1100
README: Fix typo. sever => server
commit 3973b06
Author: Itamar Haber <itamar@garantiadata.com>
Date: Sat Dec 19 17:01:20 2015 +0200
Typo fix
commit 4f2e460
Author: Steve Gao <fu@2token.com>
Date: Fri Dec 4 10:22:05 2015 +0800
Update README - fix typos
commit b21667c
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:48:37 2015 +0800
delete redundancy color judge in sdscatcolor
commit 88894c7
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 22:14:42 2015 +0800
the example output shoule be HelloWorld
commit 2763470
Author: binyan <binbin.yan@nokia.com>
Date: Wed Dec 2 17:41:39 2015 +0800
modify error word keyevente
Signed-off-by: binyan <binbin.yan@nokia.com>
commit 0847b3d
Author: Bruno Martins <bscmartins@gmail.com>
Date: Wed Nov 4 11:37:01 2015 +0000
typo
commit bbb9e9e
Author: dawedawe <dawedawe@gmx.de>
Date: Fri Mar 27 00:46:41 2015 +0100
typo: zimap -> zipmap
commit 5ed297e
Author: Axel Advento <badwolf.bloodseeker.rev@gmail.com>
Date: Tue Mar 3 15:58:29 2015 +0800
Fix 'salve' typos to 'slave'
commit edec9d6
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Wed Jun 12 14:12:47 2019 +0200
Update README.md
Co-Authored-By: Qix <Qix-@users.noreply.github.com>
commit 692a7af
Author: LudwikJaniuk <ludvig.janiuk@gmail.com>
Date: Tue May 28 14:32:04 2019 +0200
grammar
commit d962b0a
Author: Nick Frost <nickfrostatx@gmail.com>
Date: Wed Jul 20 15:17:12 2016 -0700
Minor grammar fix
commit 24fff01aaccaf5956973ada8c50ceb1462e211c6 (typos)
Author: Chad Miller <chadm@squareup.com>
Date: Tue Sep 8 13:46:11 2020 -0400
Fix faulty comment about operation of unlink()
commit 3cd5c1f3326c52aa552ada7ec797c6bb16452355
Author: Kevin <kevin.xgr@gmail.com>
Date: Wed Nov 20 00:13:50 2019 +0800
Fix typo in server.c.
From a83af59 Mon Sep 17 00:00:00 2001
From: wuwo <wuwo@wacai.com>
Date: Fri, 17 Mar 2017 20:37:45 +0800
Subject: [PATCH] falure to failure
From c961896 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B7=A6=E6=87=B6?= <veficos@gmail.com>
Date: Sat, 27 May 2017 15:33:04 +0800
Subject: [PATCH] fix typo
From e600ef2 Mon Sep 17 00:00:00 2001
From: "rui.zou" <rui.zou@yunify.com>
Date: Sat, 30 Sep 2017 12:38:15 +0800
Subject: [PATCH] fix a typo
From c7d07fa Mon Sep 17 00:00:00 2001
From: Alexandre Perrin <alex@kaworu.ch>
Date: Thu, 16 Aug 2018 10:35:31 +0200
Subject: [PATCH] deps README.md typo
From b25cb67 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 10:55:37 +0300
Subject: [PATCH 1/2] fix typos in header
From ad28ca6 Mon Sep 17 00:00:00 2001
From: Guy Korland <gkorland@gmail.com>
Date: Wed, 26 Sep 2018 11:02:36 +0300
Subject: [PATCH 2/2] fix typos
commit 34924cdedd8552466fc22c1168d49236cb7ee915
Author: Adrian Lynch <adi_ady_ade@hotmail.com>
Date: Sat Apr 4 21:59:15 2015 +0100
Typos fixed
commit fd2a1e7
Author: Jan <jsteemann@users.noreply.github.com>
Date: Sat Oct 27 19:13:01 2018 +0200
Fix typos
Fix typos
commit e14e47c1a234b53b0e103c5f6a1c61481cbcbb02
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:30:07 2019 -0500
Fix multiple misspellings of "following"
commit 79b948ce2dac6b453fe80995abbcaac04c213d5a
Author: Andy Lester <andy@petdance.com>
Date: Fri Aug 2 22:24:28 2019 -0500
Fix misspelling of create-cluster
commit 1fffde52666dc99ab35efbd31071a4c008cb5a71
Author: Andy Lester <andy@petdance.com>
Date: Wed Jul 31 17:57:56 2019 -0500
Fix typos
commit 204c9ba9651e9e05fd73936b452b9a30be456cfe
Author: Xiaobo Zhu <xiaobo.zhu@shopee.com>
Date: Tue Aug 13 22:19:25 2019 +0800
fix typos
Squashed commit of the following:
commit 1d9aaf8
Author: danmedani <danmedani@gmail.com>
Date: Sun Aug 2 11:40:26 2015 -0700
README typo fix.
Squashed commit of the following:
commit 32bfa7c
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Jul 6 21:15:08 2015 +0200
Fixed grammer
Squashed commit of the following:
commit b24f69c
Author: Sisir Koppaka <sisir.koppaka@gmail.com>
Date: Mon Mar 2 22:38:45 2015 -0500
utils/hashtable/rehashing.c: Fix typos
Squashed commit of the following:
commit 4e04082
Author: Erik Dubbelboer <erik@dubbelboer.com>
Date: Mon Mar 23 08:22:21 2015 +0000
Small config file documentation improvements
Squashed commit of the following:
commit acb8773
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:52:48 2015 -0700
Typo and grammar fixes in readme
commit 2eb75b6
Author: ctd1500 <ctd1500@gmail.com>
Date: Fri May 8 01:36:18 2015 -0700
fixed redis.conf comment
Squashed commit of the following:
commit a8249a2
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri Dec 11 11:39:52 2015 +0530
Revise correction of typos.
Squashed commit of the following:
commit 3c02028
Author: zhaojun11 <zhaojun11@jd.com>
Date: Wed Jan 17 19:05:28 2018 +0800
Fix typos include two code typos in cluster.c and latency.c
Squashed commit of the following:
commit 9dba47c
Author: q191201771 <191201771@qq.com>
Date: Sat Jan 4 11:31:04 2020 +0800
fix function listCreate comment in adlist.c
Update src/server.c
commit 2c7c2cb536e78dd211b1ac6f7bda00f0f54faaeb
Author: charpty <charpty@gmail.com>
Date: Tue May 1 23:16:59 2018 +0800
server.c typo: modules system dictionary type comment
Signed-off-by: charpty <charpty@gmail.com>
commit a8395323fb63cb59cb3591cb0f0c8edb7c29a680
Author: Itamar Haber <itamar@redislabs.com>
Date: Sun May 6 00:25:18 2018 +0300
Updates test_helper.tcl's help with undocumented options
Specifically:
* Host
* Port
* Client
commit bde6f9ced15755cd6407b4af7d601b030f36d60b
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 15:19:19 2018 +0800
fix comments in deps files
commit 3172474ba991532ab799ee1873439f3402412331
Author: wxisme <850885154@qq.com>
Date: Wed Aug 8 14:33:49 2018 +0800
fix some comments
commit 01b6f2b6858b5cf2ce4ad5092d2c746e755f53f0
Author: Thor Juhasz <thor@juhasz.pro>
Date: Sun Nov 18 14:37:41 2018 +0100
Minor fixes to comments
Found some parts a little unclear on a first read, which prompted me to have a better look at the file and fix some minor things I noticed.
Fixing minor typos and grammar. There are no changes to configuration options.
These changes are only meant to help the user better understand the explanations to the various configuration options
2020-09-10 13:43:38 +03:00
/* Sometimes Redis cannot accept write commands because there is a persistence
2018-07-31 13:09:38 +02:00
* error with the RDB or AOF file , and Redis is configured in order to stop
* accepting writes in such situation . This function returns if such a
2018-07-31 13:10:37 +02:00
* condition is active , and the type of the condition .
*
* Function return values :
*
* DISK_ERROR_TYPE_NONE : No problems , we can accept writes .
* DISK_ERROR_TYPE_AOF : Don ' t accept writes : AOF errors .
* DISK_ERROR_TYPE_RDB : Don ' t accept writes : RDB errors .
*/
2018-07-31 13:09:38 +02:00
int writeCommandsDeniedByDiskError ( void ) {
if ( server . stop_writes_on_bgsave_err & &
server . saveparamslen > 0 & &
server . lastbgsave_status = = C_ERR )
{
2018-07-31 13:14:24 +02:00
return DISK_ERROR_TYPE_RDB ;
2018-07-31 13:09:38 +02:00
} else if ( server . aof_state ! = AOF_OFF & &
server . aof_last_write_status = = C_ERR )
{
2018-07-31 13:14:24 +02:00
return DISK_ERROR_TYPE_AOF ;
2018-07-31 13:09:38 +02:00
} else {
return DISK_ERROR_TYPE_NONE ;
}
}
2014-07-16 17:47:17 +02:00
/* The PING command. It works in a different way if the client is in
* in Pub / Sub mode . */
2015-07-26 15:20:46 +02:00
void pingCommand ( client * c ) {
2014-07-16 17:47:17 +02:00
/* The command takes zero or one arguments. */
if ( c - > argc > 2 ) {
2014-07-18 10:15:51 +02:00
addReplyErrorFormat ( c , " wrong number of arguments for '%s' command " ,
c - > cmd - > name ) ;
2014-07-16 17:47:17 +02:00
return ;
}
2018-12-19 17:55:07 +01:00
if ( c - > flags & CLIENT_PUBSUB & & c - > resp = = 2 ) {
2014-07-16 17:47:17 +02:00
addReply ( c , shared . mbulkhdr [ 2 ] ) ;
addReplyBulkCBuffer ( c , " pong " , 4 ) ;
if ( c - > argc = = 1 )
addReplyBulkCBuffer ( c , " " , 0 ) ;
else
addReplyBulk ( c , c - > argv [ 1 ] ) ;
} else {
if ( c - > argc = = 1 )
addReply ( c , shared . pong ) ;
else
addReplyBulk ( c , c - > argv [ 1 ] ) ;
}
2010-06-22 00:07:48 +02:00
}
2015-07-26 15:20:46 +02:00
void echoCommand ( client * c ) {
2010-06-22 00:07:48 +02:00
addReplyBulk ( c , c - > argv [ 1 ] ) ;
}
2015-07-26 15:20:46 +02:00
void timeCommand ( client * c ) {
2012-03-07 10:38:01 +01:00
struct timeval tv ;
2013-01-17 01:00:20 +08:00
/* gettimeofday() can only fail if &tv is a bad address so we
2012-03-07 10:38:01 +01:00
* don ' t check for errors . */
gettimeofday ( & tv , NULL ) ;
2018-11-08 13:05:50 +01:00
addReplyArrayLen ( c , 2 ) ;
2012-03-07 10:38:01 +01:00
addReplyBulkLongLong ( c , tv . tv_sec ) ;
addReplyBulkLongLong ( c , tv . tv_usec ) ;
}
2014-06-27 12:05:54 +02:00
/* Helper function for addReplyCommand() to output flags. */
2015-07-26 15:20:46 +02:00
int addReplyCommandFlag ( client * c , struct redisCommand * cmd , int f , char * reply ) {
2014-06-16 23:35:45 -04:00
if ( cmd - > flags & f ) {
addReplyStatus ( c , reply ) ;
return 1 ;
}
return 0 ;
}
2014-06-27 11:59:48 +02:00
2014-06-27 12:05:54 +02:00
/* Output the representation of a Redis command. Used by the COMMAND command. */
2015-07-26 15:20:46 +02:00
void addReplyCommand ( client * c , struct redisCommand * cmd ) {
2014-06-16 23:35:45 -04:00
if ( ! cmd ) {
2018-11-27 11:58:55 +01:00
addReplyNull ( c ) ;
2014-06-16 23:35:45 -04:00
} else {
2019-02-14 00:12:10 +08:00
/* We are adding: command name, arg count, flags, first, last, offset, categories */
addReplyArrayLen ( c , 7 ) ;
2014-06-16 23:35:45 -04:00
addReplyBulkCString ( c , cmd - > name ) ;
addReplyLongLong ( c , cmd - > arity ) ;
int flagcount = 0 ;
2018-11-08 13:05:50 +01:00
void * flaglen = addReplyDeferredLen ( c ) ;
2015-07-27 09:41:48 +02:00
flagcount + = addReplyCommandFlag ( c , cmd , CMD_WRITE , " write " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_READONLY , " readonly " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_DENYOOM , " denyoom " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_ADMIN , " admin " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_PUBSUB , " pubsub " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_NOSCRIPT , " noscript " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_RANDOM , " random " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_SORT_FOR_SCRIPT , " sort_for_script " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_LOADING , " loading " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_STALE , " stale " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_SKIP_MONITOR , " skip_monitor " ) ;
2019-07-19 10:22:40 -07:00
flagcount + = addReplyCommandFlag ( c , cmd , CMD_SKIP_SLOWLOG , " skip_slowlog " ) ;
2015-07-27 09:41:48 +02:00
flagcount + = addReplyCommandFlag ( c , cmd , CMD_ASKING , " asking " ) ;
flagcount + = addReplyCommandFlag ( c , cmd , CMD_FAST , " fast " ) ;
2020-02-06 14:53:33 +02:00
flagcount + = addReplyCommandFlag ( c , cmd , CMD_NO_AUTH , " no_auth " ) ;
2020-07-20 20:33:06 +08:00
if ( cmdHasMovableKeys ( cmd ) ) {
2014-06-16 23:35:45 -04:00
addReplyStatus ( c , " movablekeys " ) ;
flagcount + = 1 ;
}
2018-11-08 13:05:50 +01:00
setDeferredSetLen ( c , flaglen , flagcount ) ;
2014-06-16 23:35:45 -04:00
addReplyLongLong ( c , cmd - > firstkey ) ;
addReplyLongLong ( c , cmd - > lastkey ) ;
addReplyLongLong ( c , cmd - > keystep ) ;
2019-02-14 00:12:10 +08:00
addReplyCommandCategories ( c , cmd ) ;
2014-06-16 23:35:45 -04:00
}
}
2014-06-27 11:59:48 +02:00
2014-06-27 12:05:54 +02:00
/* COMMAND <subcommand> <args> */
2015-07-26 15:20:46 +02:00
void commandCommand ( client * c ) {
2014-06-16 23:35:45 -04:00
dictIterator * di ;
dictEntry * de ;
2017-11-27 17:57:44 +02:00
if ( c - > argc = = 2 & & ! strcasecmp ( c - > argv [ 1 ] - > ptr , " help " ) ) {
const char * help [ ] = {
2017-12-06 12:05:11 +01:00
" (no subcommand) -- Return details about all Redis commands. " ,
2018-06-09 21:03:52 +03:00
" COUNT -- Return the total number of commands in this Redis server. " ,
" GETKEYS <full-command> -- Return the keys from a full Redis command. " ,
" INFO [command-name ...] -- Return details about multiple Redis commands. " ,
2017-12-06 12:05:11 +01:00
NULL
2017-11-27 17:57:44 +02:00
} ;
addReplyHelp ( c , help ) ;
} else if ( c - > argc = = 1 ) {
2018-11-08 13:05:50 +01:00
addReplyArrayLen ( c , dictSize ( server . commands ) ) ;
2014-06-27 12:05:54 +02:00
di = dictGetIterator ( server . commands ) ;
while ( ( de = dictNext ( di ) ) ! = NULL ) {
addReplyCommand ( c , dictGetVal ( de ) ) ;
}
dictReleaseIterator ( di ) ;
} else if ( ! strcasecmp ( c - > argv [ 1 ] - > ptr , " info " ) ) {
2014-06-16 23:35:45 -04:00
int i ;
2018-11-08 13:05:50 +01:00
addReplyArrayLen ( c , c - > argc - 2 ) ;
2014-06-16 23:35:45 -04:00
for ( i = 2 ; i < c - > argc ; i + + ) {
2014-06-27 11:59:48 +02:00
addReplyCommand ( c , dictFetchValue ( server . commands , c - > argv [ i ] - > ptr ) ) ;
2014-06-16 23:35:45 -04:00
}
2014-06-27 12:11:15 +02:00
} else if ( ! strcasecmp ( c - > argv [ 1 ] - > ptr , " count " ) & & c - > argc = = 2 ) {
addReplyLongLong ( c , dictSize ( server . commands ) ) ;
2014-06-27 12:22:15 +02:00
} else if ( ! strcasecmp ( c - > argv [ 1 ] - > ptr , " getkeys " ) & & c - > argc > = 3 ) {
struct redisCommand * cmd = lookupCommand ( c - > argv [ 2 ] - > ptr ) ;
int * keys , numkeys , j ;
if ( ! cmd ) {
2018-04-20 20:19:03 +08:00
addReplyError ( c , " Invalid command specified " ) ;
return ;
} else if ( cmd - > getkeys_proc = = NULL & & cmd - > firstkey = = 0 ) {
addReplyError ( c , " The command has no key arguments " ) ;
2014-06-27 12:22:15 +02:00
return ;
} else if ( ( cmd - > arity > 0 & & cmd - > arity ! = c - > argc - 2 ) | |
( ( c - > argc - 2 ) < - cmd - > arity ) )
{
addReplyError ( c , " Invalid number of arguments specified for command " ) ;
return ;
}
keys = getKeysFromCommand ( cmd , c - > argv + 2 , c - > argc - 2 , & numkeys ) ;
2018-04-20 20:19:03 +08:00
if ( ! keys ) {
addReplyError ( c , " Invalid arguments specified for command " ) ;
} else {
2018-11-08 13:05:50 +01:00
addReplyArrayLen ( c , numkeys ) ;
2018-04-20 20:19:03 +08:00
for ( j = 0 ; j < numkeys ; j + + ) addReplyBulk ( c , c - > argv [ keys [ j ] + 2 ] ) ;
getKeysFreeResult ( keys ) ;
}
2014-06-27 12:05:54 +02:00
} else {
2018-07-02 18:49:34 +02:00
addReplySubcommandSyntaxError ( c ) ;
2014-06-16 23:35:45 -04:00
}
}
2010-06-22 00:07:48 +02:00
/* Convert an amount of bytes into a human readable string in the form
* of 100 B , 2 G , 100 M , 4 K , and so forth . */
void bytesToHuman ( char * s , unsigned long long n ) {
double d ;
if ( n < 1024 ) {
/* Bytes */
sprintf ( s , " %lluB " , n ) ;
} else if ( n < ( 1024 * 1024 ) ) {
d = ( double ) n / ( 1024 ) ;
sprintf ( s , " %.2fK " , d ) ;
} else if ( n < ( 1024LL * 1024 * 1024 ) ) {
d = ( double ) n / ( 1024 * 1024 ) ;
sprintf ( s , " %.2fM " , d ) ;
} else if ( n < ( 1024LL * 1024 * 1024 * 1024 ) ) {
d = ( double ) n / ( 1024LL * 1024 * 1024 ) ;
sprintf ( s , " %.2fG " , d ) ;
2013-01-02 20:22:26 +01:00
} else if ( n < ( 1024LL * 1024 * 1024 * 1024 * 1024 ) ) {
d = ( double ) n / ( 1024LL * 1024 * 1024 * 1024 ) ;
sprintf ( s , " %.2fT " , d ) ;
} else if ( n < ( 1024LL * 1024 * 1024 * 1024 * 1024 * 1024 ) ) {
d = ( double ) n / ( 1024LL * 1024 * 1024 * 1024 * 1024 ) ;
sprintf ( s , " %.2fP " , d ) ;
} else {
/* Let's hope we never need this */
sprintf ( s , " %lluB " , n ) ;
2010-06-22 00:07:48 +02:00
}
}
/* Create the string returned by the INFO command. This is decoupled
* by the INFO command itself as we need to report the same information
* on memory corruption problems . */
2019-11-03 15:02:25 +02:00
sds genRedisInfoString ( const char * section ) {
2011-01-23 16:41:07 +01:00
sds info = sdsempty ( ) ;
2012-03-27 17:39:58 +02:00
time_t uptime = server . unixtime - server . stat_starttime ;
2017-04-13 17:03:46 +03:00
int j ;
2010-09-16 13:28:58 +02:00
struct rusage self_ru , c_ru ;
2019-07-24 12:58:15 +03:00
int allsections = 0 , defsections = 0 , everything = 0 , modules = 0 ;
2011-01-23 16:41:07 +01:00
int sections = 0 ;
2012-08-29 11:44:01 +02:00
2014-04-04 10:25:40 +02:00
if ( section = = NULL ) section = " default " ;
allsections = strcasecmp ( section , " all " ) = = 0 ;
defsections = strcasecmp ( section , " default " ) = = 0 ;
2019-07-24 12:58:15 +03:00
everything = strcasecmp ( section , " everything " ) = = 0 ;
modules = strcasecmp ( section , " modules " ) = = 0 ;
if ( everything ) allsections = 1 ;
2010-09-16 13:28:58 +02:00
getrusage ( RUSAGE_SELF , & self_ru ) ;
getrusage ( RUSAGE_CHILDREN , & c_ru ) ;
2011-01-23 16:41:07 +01:00
/* Server */
if ( allsections | | defsections | | ! strcasecmp ( section , " server " ) ) {
2014-03-24 10:00:08 +01:00
static int call_uname = 1 ;
static struct utsname name ;
2012-08-29 11:44:01 +02:00
char * mode ;
2012-04-04 15:38:13 +02:00
2012-08-29 11:44:01 +02:00
if ( server . cluster_enabled ) mode = " cluster " ;
else if ( server . sentinel_mode ) mode = " sentinel " ;
else mode = " standalone " ;
2014-06-26 18:48:40 +02:00
2011-01-23 16:41:07 +01:00
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
2014-03-24 10:00:08 +01:00
if ( call_uname ) {
/* Uname can be slow and is always the same output. Cache it. */
uname ( & name ) ;
call_uname = 0 ;
}
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
unsigned int lruclock ;
atomicGet ( server . lruclock , lruclock ) ;
2019-10-02 11:21:24 +02:00
info = sdscatfmt ( info ,
2011-01-23 16:41:07 +01:00
" # Server \r \n "
" redis_version:%s \r \n "
" redis_git_sha1:%s \r \n "
2019-10-02 11:21:24 +02:00
" redis_git_dirty:%i \r \n "
" redis_build_id:%s \r \n "
2012-08-29 11:44:01 +02:00
" redis_mode:%s \r \n "
2012-04-04 15:38:13 +02:00
" os:%s %s %s \r \n "
2019-10-02 11:21:24 +02:00
" arch_bits:%i \r \n "
2011-01-23 16:41:07 +01:00
" multiplexing_api:%s \r \n "
2017-05-10 09:33:49 +02:00
" atomicvar_api:%s \r \n "
2019-10-02 11:21:24 +02:00
" gcc_version:%i.%i.%i \r \n "
" process_id:%I \r \n "
2012-03-08 10:13:12 +01:00
" run_id:%s \r \n "
2019-10-02 11:21:24 +02:00
" tcp_port:%i \r \n "
" uptime_in_seconds:%I \r \n "
" uptime_in_days:%I \r \n "
" hz:%i \r \n "
" configured_hz:%i \r \n "
" lru_clock:%u \r \n "
2015-10-13 10:58:08 +02:00
" executable:%s \r \n "
2020-07-29 01:46:44 -04:00
" config_file:%s \r \n "
2020-08-25 03:59:56 +08:00
" io_threads_active:%i \r \n " ,
2011-01-23 16:41:07 +01:00
REDIS_VERSION ,
redisGitSHA1 ( ) ,
strtol ( redisGitDirty ( ) , NULL , 10 ) > 0 ,
2019-10-02 11:21:24 +02:00
redisBuildIdString ( ) ,
2012-08-29 11:44:01 +02:00
mode ,
2012-04-04 15:38:13 +02:00
name . sysname , name . release , name . machine ,
2012-02-02 10:02:40 +01:00
server . arch_bits ,
2011-01-23 16:41:07 +01:00
aeGetApiName ( ) ,
2017-05-10 09:33:49 +02:00
REDIS_ATOMIC_API ,
2012-01-10 18:37:16 +01:00
# ifdef __GNUC__
__GNUC__ , __GNUC_MINOR__ , __GNUC_PATCHLEVEL__ ,
# else
0 , 0 , 0 ,
# endif
2019-10-02 11:21:24 +02:00
( int64_t ) getpid ( ) ,
2012-03-08 10:13:12 +01:00
server . runid ,
2019-09-12 11:10:22 +03:00
server . port ? server . port : server . tls_port ,
2019-10-02 11:21:24 +02:00
( int64_t ) uptime ,
( int64_t ) ( uptime / ( 3600 * 24 ) ) ,
2012-12-14 17:10:40 +01:00
server . hz ,
2018-07-23 14:13:58 +02:00
server . config_hz ,
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
lruclock ,
2015-10-13 10:58:08 +02:00
server . executable ? server . executable : " " ,
2020-07-29 01:46:44 -04:00
server . configfile ? server . configfile : " " ,
server . io_threads_active ) ;
2011-01-23 16:41:07 +01:00
}
/* Clients */
if ( allsections | | defsections | | ! strcasecmp ( section , " clients " ) ) {
2018-07-19 17:16:19 +02:00
size_t maxin , maxout ;
getExpansiveClientsInfo ( & maxin , & maxout ) ;
2011-01-23 16:41:07 +01:00
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info ,
" # Clients \r \n "
2012-01-31 10:35:52 +01:00
" connected_clients:%lu \r \n "
2018-07-19 17:38:17 +02:00
" client_recent_max_input_buffer:%zu \r \n "
" client_recent_max_output_buffer:%zu \r \n "
2019-07-10 18:08:31 +02:00
" blocked_clients:%d \r \n "
2020-03-26 16:02:26 +01:00
" tracking_clients:%d \r \n "
2020-03-31 17:10:09 +02:00
" clients_in_timeout_table:%llu \r \n " ,
2011-01-23 16:41:07 +01:00
listLength ( server . clients ) - listLength ( server . slaves ) ,
2018-07-19 17:16:19 +02:00
maxin , maxout ,
2019-07-10 18:08:31 +02:00
server . blocked_clients ,
2020-03-26 16:02:26 +01:00
server . tracking_clients ,
2020-03-31 17:41:23 +02:00
( unsigned long long ) raxSize ( server . clients_timeout_table ) ) ;
2011-01-23 16:41:07 +01:00
}
/* Memory */
if ( allsections | | defsections | | ! strcasecmp ( section , " memory " ) ) {
2011-04-21 10:49:52 +02:00
char hmem [ 64 ] ;
char peak_hmem [ 64 ] ;
2014-06-17 23:05:30 -04:00
char total_system_hmem [ 64 ] ;
2015-01-09 17:00:43 -05:00
char used_memory_lua_hmem [ 64 ] ;
2018-04-30 19:33:01 +03:00
char used_memory_scripts_hmem [ 64 ] ;
2015-01-09 17:00:43 -05:00
char used_memory_rss_hmem [ 64 ] ;
2015-01-09 17:01:05 -05:00
char maxmemory_hmem [ 64 ] ;
2014-02-28 17:47:41 -05:00
size_t zmalloc_used = zmalloc_used_memory ( ) ;
2014-06-17 23:05:30 -04:00
size_t total_system_mem = server . system_memory_size ;
2016-04-22 10:43:48 -05:00
const char * evict_policy = evictPolicyToString ( ) ;
2020-04-20 16:34:36 -07:00
long long memory_lua = server . lua ? ( long long ) lua_gc ( server . lua , LUA_GCCOUNT , 0 ) * 1024 : 0 ;
2016-09-15 10:33:23 +02:00
struct redisMemOverhead * mh = getMemoryOverheadData ( ) ;
2011-04-21 10:49:52 +02:00
2014-03-03 11:19:54 +01:00
/* Peak memory is updated from time to time by serverCron() so it
* may happen that the instantaneous value is slightly bigger than
* the peak value . This may confuse users , so we update the peak
* if found smaller than the current memory usage . */
if ( zmalloc_used > server . stat_peak_memory )
2014-02-28 17:47:41 -05:00
server . stat_peak_memory = zmalloc_used ;
bytesToHuman ( hmem , zmalloc_used ) ;
2011-04-21 10:49:52 +02:00
bytesToHuman ( peak_hmem , server . stat_peak_memory ) ;
2014-06-17 23:05:30 -04:00
bytesToHuman ( total_system_hmem , total_system_mem ) ;
2015-01-09 17:00:43 -05:00
bytesToHuman ( used_memory_lua_hmem , memory_lua ) ;
2018-08-13 17:36:54 +03:00
bytesToHuman ( used_memory_scripts_hmem , mh - > lua_caches ) ;
2018-02-18 17:36:21 +02:00
bytesToHuman ( used_memory_rss_hmem , server . cron_malloc_stats . process_rss ) ;
2015-01-09 17:01:05 -05:00
bytesToHuman ( maxmemory_hmem , server . maxmemory ) ;
2014-06-17 23:05:30 -04:00
2011-01-23 16:41:07 +01:00
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info ,
" # Memory \r \n "
" used_memory:%zu \r \n "
" used_memory_human:%s \r \n "
" used_memory_rss:%zu \r \n "
2015-01-09 17:00:43 -05:00
" used_memory_rss_human:%s \r \n "
2011-04-21 10:49:52 +02:00
" used_memory_peak:%zu \r \n "
" used_memory_peak_human:%s \r \n "
2016-09-16 10:43:19 +02:00
" used_memory_peak_perc:%.2f%% \r \n "
2016-09-15 10:33:23 +02:00
" used_memory_overhead:%zu \r \n "
" used_memory_startup:%zu \r \n "
" used_memory_dataset:%zu \r \n "
" used_memory_dataset_perc:%.2f%% \r \n "
2018-02-18 17:36:21 +02:00
" allocator_allocated:%zu \r \n "
" allocator_active:%zu \r \n "
" allocator_resident:%zu \r \n "
2014-06-17 23:05:30 -04:00
" total_system_memory:%lu \r \n "
" total_system_memory_human:%s \r \n "
2011-05-07 11:40:29 +02:00
" used_memory_lua:%lld \r \n "
2015-01-09 17:00:43 -05:00
" used_memory_lua_human:%s \r \n "
2018-04-30 19:33:01 +03:00
" used_memory_scripts:%lld \r \n "
" used_memory_scripts_human:%s \r \n "
" number_of_cached_scripts:%lu \r \n "
2015-01-09 17:01:05 -05:00
" maxmemory:%lld \r \n "
" maxmemory_human:%s \r \n "
" maxmemory_policy:%s \r \n "
2018-02-18 17:36:21 +02:00
" allocator_frag_ratio:%.2f \r \n "
" allocator_frag_bytes:%zu \r \n "
" allocator_rss_ratio:%.2f \r \n "
2018-12-02 15:29:20 +02:00
" allocator_rss_bytes:%zd \r \n "
2018-02-18 17:36:21 +02:00
" rss_overhead_ratio:%.2f \r \n "
2018-12-02 15:29:20 +02:00
" rss_overhead_bytes:%zd \r \n "
2011-01-23 16:41:07 +01:00
" mem_fragmentation_ratio:%.2f \r \n "
2018-12-02 15:29:20 +02:00
" mem_fragmentation_bytes:%zd \r \n "
2018-02-21 20:18:34 +02:00
" mem_not_counted_for_evict:%zu \r \n "
" mem_replication_backlog:%zu \r \n "
" mem_clients_slaves:%zu \r \n "
" mem_clients_normal:%zu \r \n "
" mem_aof_buffer:%zu \r \n "
2015-09-28 10:51:25 +02:00
" mem_allocator:%s \r \n "
2016-12-30 03:37:52 +02:00
" active_defrag_running:%d \r \n "
2015-09-28 10:51:25 +02:00
" lazyfree_pending_objects:%zu \r \n " ,
2014-02-28 17:47:41 -05:00
zmalloc_used ,
2011-01-23 16:41:07 +01:00
hmem ,
2018-02-18 17:36:21 +02:00
server . cron_malloc_stats . process_rss ,
2015-01-09 17:00:43 -05:00
used_memory_rss_hmem ,
2011-04-21 10:49:52 +02:00
server . stat_peak_memory ,
peak_hmem ,
2016-09-16 10:43:19 +02:00
mh - > peak_perc ,
2016-09-15 10:33:23 +02:00
mh - > overhead_total ,
mh - > startup_allocated ,
mh - > dataset ,
2016-09-15 17:33:11 +02:00
mh - > dataset_perc ,
2018-02-18 17:36:21 +02:00
server . cron_malloc_stats . allocator_allocated ,
server . cron_malloc_stats . allocator_active ,
server . cron_malloc_stats . allocator_resident ,
2014-06-17 23:05:30 -04:00
( unsigned long ) total_system_mem ,
total_system_hmem ,
2015-01-09 17:00:43 -05:00
memory_lua ,
used_memory_lua_hmem ,
2018-10-02 16:26:30 +02:00
( long long ) mh - > lua_caches ,
2018-04-30 19:33:01 +03:00
used_memory_scripts_hmem ,
dictSize ( server . lua_scripts ) ,
2015-01-09 17:01:05 -05:00
server . maxmemory ,
maxmemory_hmem ,
evict_policy ,
2018-02-18 17:36:21 +02:00
mh - > allocator_frag ,
mh - > allocator_frag_bytes ,
mh - > allocator_rss ,
mh - > allocator_rss_bytes ,
mh - > rss_extra ,
mh - > rss_extra_bytes ,
2019-09-30 18:37:59 +02:00
mh - > total_frag , /* This is the total RSS overhead, including
fragmentation , but not just it . This field
( and the next one ) is named like that just
for backward compatibility . */
mh - > total_frag_bytes ,
2018-02-21 20:18:34 +02:00
freeMemoryGetNotCountedMemory ( ) ,
mh - > repl_backlog ,
mh - > clients_slaves ,
mh - > clients_normal ,
mh - > aof_buffer ,
2015-09-28 10:51:25 +02:00
ZMALLOC_LIB ,
2016-12-30 03:37:52 +02:00
server . active_defrag_running ,
2015-09-28 10:51:25 +02:00
lazyfreeGetPendingObjectsCount ( )
2016-09-15 10:33:23 +02:00
) ;
freeMemoryOverheadData ( mh ) ;
2011-01-23 22:14:15 +01:00
}
2011-01-23 16:41:07 +01:00
/* Persistence */
if ( allsections | | defsections | | ! strcasecmp ( section , " persistence " ) ) {
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
2010-06-22 00:07:48 +02:00
info = sdscatprintf ( info ,
2011-01-23 16:41:07 +01:00
" # Persistence \r \n "
" loading:%d \r \n "
2012-05-25 12:11:30 +02:00
" rdb_changes_since_last_save:%lld \r \n "
" rdb_bgsave_in_progress:%d \r \n "
2012-10-28 13:33:04 +09:00
" rdb_last_save_time:%jd \r \n "
2012-05-25 12:11:30 +02:00
" rdb_last_bgsave_status:%s \r \n "
2012-10-28 13:33:04 +09:00
" rdb_last_bgsave_time_sec:%jd \r \n "
" rdb_current_bgsave_time_sec:%jd \r \n "
2016-09-19 13:45:20 +02:00
" rdb_last_cow_size:%zu \r \n "
2011-01-23 16:41:07 +01:00
" aof_enabled:%d \r \n "
2012-05-25 12:11:30 +02:00
" aof_rewrite_in_progress:%d \r \n "
" aof_rewrite_scheduled:%d \r \n "
2012-10-28 13:33:04 +09:00
" aof_last_rewrite_time_sec:%jd \r \n "
" aof_current_rewrite_time_sec:%jd \r \n "
2014-02-12 12:47:10 +01:00
" aof_last_bgrewrite_status:%s \r \n "
2016-09-19 13:45:20 +02:00
" aof_last_write_status:%s \r \n "
2019-07-17 08:51:02 +03:00
" aof_last_cow_size:%zu \r \n "
" module_fork_in_progress:%d \r \n "
" module_fork_last_cow_size:%zu \r \n " ,
2011-01-23 16:41:07 +01:00
server . loading ,
server . dirty ,
2011-12-21 12:22:13 +01:00
server . rdb_child_pid ! = - 1 ,
2012-10-28 13:33:04 +09:00
( intmax_t ) server . lastsave ,
2015-07-26 23:17:55 +02:00
( server . lastbgsave_status = = C_OK ) ? " ok " : " err " ,
2012-10-28 13:33:04 +09:00
( intmax_t ) server . rdb_save_time_last ,
( intmax_t ) ( ( server . rdb_child_pid = = - 1 ) ?
- 1 : time ( NULL ) - server . rdb_save_time_start ) ,
2016-09-19 13:45:20 +02:00
server . stat_rdb_cow_bytes ,
2015-07-27 09:41:48 +02:00
server . aof_state ! = AOF_OFF ,
2012-04-06 21:12:50 +02:00
server . aof_child_pid ! = - 1 ,
2012-05-25 12:11:30 +02:00
server . aof_rewrite_scheduled ,
2012-10-28 13:33:04 +09:00
( intmax_t ) server . aof_rewrite_time_last ,
( intmax_t ) ( ( server . aof_child_pid = = - 1 ) ?
- 1 : time ( NULL ) - server . aof_rewrite_time_start ) ,
2015-07-26 23:17:55 +02:00
( server . aof_lastbgrewrite_status = = C_OK ) ? " ok " : " err " ,
2016-09-19 13:45:20 +02:00
( server . aof_last_write_status = = C_OK ) ? " ok " : " err " ,
2019-07-17 08:51:02 +03:00
server . stat_aof_cow_bytes ,
server . module_child_pid ! = - 1 ,
server . stat_module_cow_bytes ) ;
2011-01-23 16:41:07 +01:00
2019-07-01 15:22:29 +03:00
if ( server . aof_enabled ) {
2011-06-10 14:52:47 +02:00
info = sdscatprintf ( info ,
" aof_current_size:%lld \r \n "
" aof_base_size:%lld \r \n "
2011-11-28 11:04:03 +01:00
" aof_pending_rewrite:%d \r \n "
" aof_buffer_length:%zu \r \n "
2012-09-10 12:42:55 +02:00
" aof_rewrite_buffer_length:%lu \r \n "
2012-03-25 11:27:35 +02:00
" aof_pending_bio_fsync:%llu \r \n "
" aof_delayed_fsync:%lu \r \n " ,
2011-12-21 11:58:42 +01:00
( long long ) server . aof_current_size ,
( long long ) server . aof_rewrite_base_size ,
server . aof_rewrite_scheduled ,
2011-12-21 12:17:02 +01:00
sdslen ( server . aof_buf ) ,
2012-05-24 15:03:23 +02:00
aofRewriteBufferSize ( ) ,
2015-07-27 14:55:45 +02:00
bioPendingJobsOfType ( BIO_AOF_FSYNC ) ,
2012-03-25 11:27:35 +02:00
server . aof_delayed_fsync ) ;
2011-06-10 14:52:47 +02:00
}
2011-01-23 16:41:07 +01:00
if ( server . loading ) {
double perc ;
time_t eta , elapsed ;
off_t remaining_bytes = server . loading_total_bytes -
server . loading_loaded_bytes ;
perc = ( ( double ) server . loading_loaded_bytes /
2014-12-23 14:52:57 +01:00
( server . loading_total_bytes + 1 ) ) * 100 ;
2011-01-23 16:41:07 +01:00
2014-12-23 14:52:57 +01:00
elapsed = time ( NULL ) - server . loading_start_time ;
2011-01-23 16:41:07 +01:00
if ( elapsed = = 0 ) {
eta = 1 ; /* A fake 1 second figure if we don't have
enough info */
} else {
2014-12-23 14:52:57 +01:00
eta = ( elapsed * remaining_bytes ) / ( server . loading_loaded_bytes + 1 ) ;
2011-01-23 16:41:07 +01:00
}
info = sdscatprintf ( info ,
2012-10-28 13:33:04 +09:00
" loading_start_time:%jd \r \n "
2011-01-23 16:41:07 +01:00
" loading_total_bytes:%llu \r \n "
" loading_loaded_bytes:%llu \r \n "
" loading_loaded_perc:%.2f \r \n "
2012-10-28 13:33:04 +09:00
" loading_eta_seconds:%jd \r \n " ,
( intmax_t ) server . loading_start_time ,
2011-01-23 16:41:07 +01:00
( unsigned long long ) server . loading_total_bytes ,
( unsigned long long ) server . loading_loaded_bytes ,
perc ,
2012-10-28 13:33:04 +09:00
( intmax_t ) eta
2011-01-23 16:41:07 +01:00
) ;
}
2010-06-22 00:07:48 +02:00
}
2011-01-23 16:41:07 +01:00
/* Stats */
if ( allsections | | defsections | | ! strcasecmp ( section , " stats " ) ) {
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
long long stat_total_reads_processed , stat_total_writes_processed ;
long long stat_net_input_bytes , stat_net_output_bytes ;
atomicGet ( server . stat_total_reads_processed , stat_total_reads_processed ) ;
atomicGet ( server . stat_total_writes_processed , stat_total_writes_processed ) ;
atomicGet ( server . stat_net_input_bytes , stat_net_input_bytes ) ;
atomicGet ( server . stat_net_output_bytes , stat_net_output_bytes ) ;
2011-01-23 16:41:07 +01:00
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
2010-11-08 11:52:03 +01:00
info = sdscatprintf ( info ,
2011-01-23 16:41:07 +01:00
" # Stats \r \n "
" total_connections_received:%lld \r \n "
" total_commands_processed:%lld \r \n "
2012-03-08 16:15:37 +01:00
" instantaneous_ops_per_sec:%lld \r \n "
2014-12-03 12:06:54 +01:00
" total_net_input_bytes:%lld \r \n "
" total_net_output_bytes:%lld \r \n "
" instantaneous_input_kbps:%.2f \r \n "
" instantaneous_output_kbps:%.2f \r \n "
2011-11-23 18:38:12 +01:00
" rejected_connections:%lld \r \n "
2013-02-12 15:24:25 +01:00
" sync_full:%lld \r \n "
" sync_partial_ok:%lld \r \n "
" sync_partial_err:%lld \r \n "
2011-01-23 16:41:07 +01:00
" expired_keys:%lld \r \n "
Track number of logically expired keys still in memory.
This commit adds two new fields in the INFO output, stats section:
expired_stale_perc:0.34
expired_time_cap_reached_count:58
The first field is an estimate of the number of keys that are yet in
memory but are already logically expired. They reason why those keys are
yet not reclaimed is because the active expire cycle can't spend more
time on the process of reclaiming the keys, and at the same time nobody
is accessing such keys. However as the active expire cycle runs, while
it will eventually have to return to the caller, because of time limit
or because there are less than 25% of keys logically expired in each
given database, it collects the stats in order to populate this INFO
field.
Note that expired_stale_perc is a running average, where the current
sample accounts for 5% and the history for 95%, so you'll see it
changing smoothly over time.
The other field, expired_time_cap_reached_count, counts the number
of times the expire cycle had to stop, even if still it was finding a
sizeable number of keys yet to expire, because of the time limit.
This allows people handling operations to understand if the Redis
server, during mass-expiration events, is able to collect keys fast
enough usually. It is normal for this field to increment during mass
expires, but normally it should very rarely increment. When instead it
constantly increments, it means that the current workloads is using
a very important percentage of CPU time to expire keys.
This feature was created thanks to the hints of Rashmi Ramesh and
Bart Robinson from Twitter. In private email exchanges, they noted how
it was important to improve the observability of this parameter in the
Redis server. Actually in big deployments, the amount of keys that are
yet to expire in each server, even if they are logically expired, may
account for a very big amount of wasted memory.
2018-02-19 11:12:49 +01:00
" expired_stale_perc:%.2f \r \n "
" expired_time_cap_reached_count:%lld \r \n "
2019-11-15 11:08:03 +01:00
" expire_cycle_cpu_milliseconds:%lld \r \n "
2011-01-23 16:41:07 +01:00
" evicted_keys:%lld \r \n "
" keyspace_hits:%lld \r \n "
" keyspace_misses:%lld \r \n "
" pubsub_channels:%ld \r \n "
2012-01-31 10:35:52 +01:00
" pubsub_patterns:%lu \r \n "
2012-11-12 14:01:56 +01:00
" latest_fork_usec:%lld \r \n "
2016-12-13 16:02:29 +01:00
" migrate_cached_sockets:%ld \r \n "
2016-12-30 03:37:52 +02:00
" slave_expires_tracked_keys:%zu \r \n "
" active_defrag_hits:%lld \r \n "
" active_defrag_misses:%lld \r \n "
" active_defrag_key_hits:%lld \r \n "
2019-07-23 11:02:14 +02:00
" active_defrag_key_misses:%lld \r \n "
2020-02-07 18:12:45 +01:00
" tracking_total_keys:%lld \r \n "
2020-03-29 13:08:21 +03:00
" tracking_total_items:%lld \r \n "
2020-05-02 19:20:44 -04:00
" tracking_total_prefixes:%lld \r \n "
2020-07-29 01:46:44 -04:00
" unexpected_error_replies:%lld \r \n "
" total_reads_processed:%lld \r \n "
" total_writes_processed:%lld \r \n "
" io_threaded_reads_processed:%lld \r \n "
" io_threaded_writes_processed:%lld \r \n " ,
2011-01-23 16:41:07 +01:00
server . stat_numconnections ,
server . stat_numcommands ,
2015-07-27 09:41:48 +02:00
getInstantaneousMetric ( STATS_METRIC_COMMAND ) ,
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
stat_net_input_bytes ,
stat_net_output_bytes ,
2015-07-27 09:41:48 +02:00
( float ) getInstantaneousMetric ( STATS_METRIC_NET_INPUT ) / 1024 ,
( float ) getInstantaneousMetric ( STATS_METRIC_NET_OUTPUT ) / 1024 ,
2011-11-23 18:38:12 +01:00
server . stat_rejected_conn ,
2013-02-12 15:24:25 +01:00
server . stat_sync_full ,
server . stat_sync_partial_ok ,
server . stat_sync_partial_err ,
2011-01-23 16:41:07 +01:00
server . stat_expiredkeys ,
Track number of logically expired keys still in memory.
This commit adds two new fields in the INFO output, stats section:
expired_stale_perc:0.34
expired_time_cap_reached_count:58
The first field is an estimate of the number of keys that are yet in
memory but are already logically expired. They reason why those keys are
yet not reclaimed is because the active expire cycle can't spend more
time on the process of reclaiming the keys, and at the same time nobody
is accessing such keys. However as the active expire cycle runs, while
it will eventually have to return to the caller, because of time limit
or because there are less than 25% of keys logically expired in each
given database, it collects the stats in order to populate this INFO
field.
Note that expired_stale_perc is a running average, where the current
sample accounts for 5% and the history for 95%, so you'll see it
changing smoothly over time.
The other field, expired_time_cap_reached_count, counts the number
of times the expire cycle had to stop, even if still it was finding a
sizeable number of keys yet to expire, because of the time limit.
This allows people handling operations to understand if the Redis
server, during mass-expiration events, is able to collect keys fast
enough usually. It is normal for this field to increment during mass
expires, but normally it should very rarely increment. When instead it
constantly increments, it means that the current workloads is using
a very important percentage of CPU time to expire keys.
This feature was created thanks to the hints of Rashmi Ramesh and
Bart Robinson from Twitter. In private email exchanges, they noted how
it was important to improve the observability of this parameter in the
Redis server. Actually in big deployments, the amount of keys that are
yet to expire in each server, even if they are logically expired, may
account for a very big amount of wasted memory.
2018-02-19 11:12:49 +01:00
server . stat_expired_stale_perc * 100 ,
server . stat_expired_time_cap_reached_count ,
2019-11-15 11:08:03 +01:00
server . stat_expire_cycle_time_used / 1000 ,
2011-01-23 16:41:07 +01:00
server . stat_evictedkeys ,
server . stat_keyspace_hits ,
server . stat_keyspace_misses ,
dictSize ( server . pubsub_channels ) ,
2011-05-29 15:17:29 +02:00
listLength ( server . pubsub_patterns ) ,
2012-11-12 14:01:56 +01:00
server . stat_fork_time ,
2016-12-13 16:02:29 +01:00
dictSize ( server . migrate_cached_sockets ) ,
2016-12-30 03:37:52 +02:00
getSlaveKeyWithExpireCount ( ) ,
server . stat_active_defrag_hits ,
server . stat_active_defrag_misses ,
server . stat_active_defrag_key_hits ,
2019-07-23 11:02:14 +02:00
server . stat_active_defrag_key_misses ,
2020-02-07 18:12:45 +01:00
( unsigned long long ) trackingGetTotalKeys ( ) ,
2020-03-29 13:08:21 +03:00
( unsigned long long ) trackingGetTotalItems ( ) ,
2020-05-02 19:20:44 -04:00
( unsigned long long ) trackingGetTotalPrefixes ( ) ,
2020-07-29 01:46:44 -04:00
server . stat_unexpected_error_replies ,
Implement redisAtomic to replace _Atomic C11 builtin (#7707)
Redis 6.0 introduces I/O threads, it is so cool and efficient, we use C11
_Atomic to establish inter-thread synchronization without mutex. But the
compiler that must supports C11 _Atomic can compile redis code, that brings a
lot of inconvenience since some common platforms can't support by default such
as CentOS7, so we want to implement redis atomic type to make it more portable.
We have implemented our atomic variable for redis that only has 'relaxed'
operations in src/atomicvar.h, so we implement some operations with
'sequentially-consistent', just like the default behavior of C11 _Atomic that
can establish inter-thread synchronization. And we replace all uses of C11
_Atomic with redis atomic variable.
Our implementation of redis atomic variable uses C11 _Atomic, __atomic or
__sync macros if available, it supports most common platforms, and we will
detect automatically which feature we use. In Makefile we use a dummy file to
detect if the compiler supports C11 _Atomic. Now for gcc, we can compile redis
code theoretically if your gcc version is not less than 4.1.2(starts to support
__sync_xxx operations). Otherwise, we remove use mutex fallback to implement
redis atomic variable for performance and test. You will get compiling errors
if your compiler doesn't support all features of above.
For cover redis atomic variable tests, we add other CI jobs that build redis on
CentOS6 and CentOS7 and workflow daily jobs that run the tests on them.
For them, we just install gcc by default in order to cover different compiler
versions, gcc is 4.4.7 by default installation on CentOS6 and 4.8.5 on CentOS7.
We restore the feature that we can test redis with Helgrind to find data race
errors. But you need install Valgrind in the default path configuration firstly
before running your tests, since we use macros in helgrind.h to tell Helgrind
inter-thread happens-before relationship explicitly for avoiding false positives.
Please open an issue on github if you find data race errors relate to this commit.
Unrelated:
- Fix redefinition of typedef 'RedisModuleUserChangedFunc'
For some old version compilers, they will report errors or warnings, if we
re-define function type.
2020-09-17 21:01:45 +08:00
stat_total_reads_processed ,
stat_total_writes_processed ,
2020-07-29 01:46:44 -04:00
server . stat_io_reads_processed ,
server . stat_io_writes_processed ) ;
2010-11-08 11:52:03 +01:00
}
2011-01-09 15:56:50 +01:00
2011-01-23 16:41:07 +01:00
/* Replication */
if ( allsections | | defsections | | ! strcasecmp ( section , " replication " ) ) {
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info ,
" # Replication \r \n "
" role:%s \r \n " ,
server . masterhost = = NULL ? " master " : " slave " ) ;
if ( server . masterhost ) {
2013-12-11 15:23:10 +01:00
long long slave_repl_offset = 1 ;
if ( server . master )
slave_repl_offset = server . master - > reploff ;
else if ( server . cached_master )
slave_repl_offset = server . cached_master - > reploff ;
2011-01-23 16:41:07 +01:00
info = sdscatprintf ( info ,
" master_host:%s \r \n "
" master_port:%d \r \n "
" master_link_status:%s \r \n "
" master_last_io_seconds_ago:%d \r \n "
" master_sync_in_progress:%d \r \n "
2013-01-30 18:33:16 +01:00
" slave_repl_offset:%lld \r \n "
2011-01-23 16:41:07 +01:00
, server . masterhost ,
server . masterport ,
2015-07-27 09:41:48 +02:00
( server . repl_state = = REPL_STATE_CONNECTED ) ?
2011-01-23 16:41:07 +01:00
" up " : " down " ,
server . master ?
2012-03-27 17:39:58 +02:00
( ( int ) ( server . unixtime - server . master - > lastinteraction ) ) : - 1 ,
2015-07-27 09:41:48 +02:00
server . repl_state = = REPL_STATE_TRANSFER ,
2013-12-11 15:23:10 +01:00
slave_repl_offset
2011-01-23 16:41:07 +01:00
) ;
2015-07-27 09:41:48 +02:00
if ( server . repl_state = = REPL_STATE_TRANSFER ) {
2011-01-23 16:41:07 +01:00
info = sdscatprintf ( info ,
2012-08-24 19:28:44 +02:00
" master_sync_left_bytes:%lld \r \n "
2011-01-23 16:41:07 +01:00
" master_sync_last_io_seconds_ago:%d \r \n "
2012-08-24 19:28:44 +02:00
, ( long long )
( server . repl_transfer_size - server . repl_transfer_read ) ,
2012-03-27 17:39:58 +02:00
( int ) ( server . unixtime - server . repl_transfer_lastio )
2011-01-23 16:41:07 +01:00
) ;
}
2011-06-17 16:13:22 +02:00
2015-07-27 09:41:48 +02:00
if ( server . repl_state ! = REPL_STATE_CONNECTED ) {
2011-06-17 16:13:22 +02:00
info = sdscatprintf ( info ,
2012-10-28 13:33:04 +09:00
" master_link_down_since_seconds:%jd \r \n " ,
2019-10-06 13:55:21 +03:00
( intmax_t ) ( server . unixtime - server . repl_down_since ) ) ;
2011-06-17 16:13:22 +02:00
}
2012-08-28 17:20:26 +02:00
info = sdscatprintf ( info ,
2012-10-22 19:21:47 +02:00
" slave_priority:%d \r \n "
" slave_read_only:%d \r \n " ,
server . slave_priority ,
server . repl_slave_ro ) ;
2011-01-09 15:56:50 +01:00
}
2013-05-30 12:18:31 +02:00
2011-01-23 16:41:07 +01:00
info = sdscatprintf ( info ,
2012-01-31 10:35:52 +01:00
" connected_slaves:%lu \r \n " ,
2011-01-23 16:41:07 +01:00
listLength ( server . slaves ) ) ;
2013-05-30 12:18:31 +02:00
/* If min-slaves-to-write is active, write the number of slaves
* currently considered ' good ' . */
if ( server . repl_min_slaves_to_write & &
server . repl_min_slaves_max_lag ) {
info = sdscatprintf ( info ,
" min_slaves_good_slaves:%d \r \n " ,
server . repl_good_slaves_count ) ;
}
2011-12-14 15:11:11 +01:00
if ( listLength ( server . slaves ) ) {
int slaveid = 0 ;
listNode * ln ;
listIter li ;
listRewind ( server . slaves , & li ) ;
while ( ( ln = listNext ( & li ) ) ) {
2015-07-26 15:20:46 +02:00
client * slave = listNodeValue ( ln ) ;
2011-12-14 15:11:11 +01:00
char * state = NULL ;
2016-07-27 16:41:20 +02:00
char ip [ NET_IP_STR_LEN ] , * slaveip = slave - > slave_ip ;
2011-12-14 15:11:11 +01:00
int port ;
2013-05-29 19:52:54 +02:00
long lag = 0 ;
2011-12-14 15:11:11 +01:00
2016-07-27 16:41:20 +02:00
if ( slaveip [ 0 ] = = ' \0 ' ) {
2019-09-12 10:56:54 +03:00
if ( connPeerToString ( slave - > conn , ip , sizeof ( ip ) , & port ) = = - 1 )
2016-07-27 16:41:20 +02:00
continue ;
slaveip = ip ;
}
2011-12-14 15:11:11 +01:00
switch ( slave - > replstate ) {
2015-07-27 09:41:48 +02:00
case SLAVE_STATE_WAIT_BGSAVE_START :
case SLAVE_STATE_WAIT_BGSAVE_END :
2011-12-14 15:11:11 +01:00
state = " wait_bgsave " ;
break ;
2015-07-27 09:41:48 +02:00
case SLAVE_STATE_SEND_BULK :
2011-12-14 15:11:11 +01:00
state = " send_bulk " ;
break ;
2015-07-27 09:41:48 +02:00
case SLAVE_STATE_ONLINE :
2011-12-14 15:11:11 +01:00
state = " online " ;
break ;
}
if ( state = = NULL ) continue ;
2015-07-27 09:41:48 +02:00
if ( slave - > replstate = = SLAVE_STATE_ONLINE )
2013-05-29 19:52:54 +02:00
lag = time ( NULL ) - slave - > repl_ack_time ;
info = sdscatprintf ( info ,
" slave%d:ip=%s,port=%d,state=%s, "
2013-05-29 19:56:33 +02:00
" offset=%lld,lag=%ld \r \n " ,
2016-07-27 16:41:20 +02:00
slaveid , slaveip , slave - > slave_listening_port , state ,
2013-05-29 19:52:54 +02:00
slave - > repl_ack_off , lag ) ;
2011-12-14 15:11:11 +01:00
slaveid + + ;
}
}
2013-01-30 18:33:16 +01:00
info = sdscatprintf ( info ,
PSYNC2: different improvements to Redis replication.
The gist of the changes is that now, partial resynchronizations between
slaves and masters (without the need of a full resync with RDB transfer
and so forth), work in a number of cases when it was impossible
in the past. For instance:
1. When a slave is promoted to mastrer, the slaves of the old master can
partially resynchronize with the new master.
2. Chained slalves (slaves of slaves) can be moved to replicate to other
slaves or the master itsef, without requiring a full resync.
3. The master itself, after being turned into a slave, is able to
partially resynchronize with the new master, when it joins replication
again.
In order to obtain this, the following main changes were operated:
* Slaves also take a replication backlog, not just masters.
* Same stream replication for all the slaves and sub slaves. The
replication stream is identical from the top level master to its slaves
and is also the same from the slaves to their sub-slaves and so forth.
This means that if a slave is later promoted to master, it has the
same replication backlong, and can partially resynchronize with its
slaves (that were previously slaves of the old master).
* A given replication history is no longer identified by the `runid` of
a Redis node. There is instead a `replication ID` which changes every
time the instance has a new history no longer coherent with the past
one. So, for example, slaves publish the same replication history of
their master, however when they are turned into masters, they publish
a new replication ID, but still remember the old ID, so that they are
able to partially resynchronize with slaves of the old master (up to a
given offset).
* The replication protocol was slightly modified so that a new extended
+CONTINUE reply from the master is able to inform the slave of a
replication ID change.
* REPLCONF CAPA is used in order to notify masters that a slave is able
to understand the new +CONTINUE reply.
* The RDB file was extended with an auxiliary field that is able to
select a given DB after loading in the slave, so that the slave can
continue receiving the replication stream from the point it was
disconnected without requiring the master to insert "SELECT" statements.
This is useful in order to guarantee the "same stream" property, because
the slave must be able to accumulate an identical backlog.
* Slave pings to sub-slaves are now sent in a special form, when the
top-level master is disconnected, in order to don't interfer with the
replication stream. We just use out of band "\n" bytes as in other parts
of the Redis protocol.
An old design document is available here:
https://gist.github.com/antirez/ae068f95c0d084891305
However the implementation is not identical to the description because
during the work to implement it, different changes were needed in order
to make things working well.
2016-11-09 11:31:06 +01:00
" master_replid:%s \r \n "
" master_replid2:%s \r \n "
2013-01-30 18:33:16 +01:00
" master_repl_offset:%lld \r \n "
PSYNC2: different improvements to Redis replication.
The gist of the changes is that now, partial resynchronizations between
slaves and masters (without the need of a full resync with RDB transfer
and so forth), work in a number of cases when it was impossible
in the past. For instance:
1. When a slave is promoted to mastrer, the slaves of the old master can
partially resynchronize with the new master.
2. Chained slalves (slaves of slaves) can be moved to replicate to other
slaves or the master itsef, without requiring a full resync.
3. The master itself, after being turned into a slave, is able to
partially resynchronize with the new master, when it joins replication
again.
In order to obtain this, the following main changes were operated:
* Slaves also take a replication backlog, not just masters.
* Same stream replication for all the slaves and sub slaves. The
replication stream is identical from the top level master to its slaves
and is also the same from the slaves to their sub-slaves and so forth.
This means that if a slave is later promoted to master, it has the
same replication backlong, and can partially resynchronize with its
slaves (that were previously slaves of the old master).
* A given replication history is no longer identified by the `runid` of
a Redis node. There is instead a `replication ID` which changes every
time the instance has a new history no longer coherent with the past
one. So, for example, slaves publish the same replication history of
their master, however when they are turned into masters, they publish
a new replication ID, but still remember the old ID, so that they are
able to partially resynchronize with slaves of the old master (up to a
given offset).
* The replication protocol was slightly modified so that a new extended
+CONTINUE reply from the master is able to inform the slave of a
replication ID change.
* REPLCONF CAPA is used in order to notify masters that a slave is able
to understand the new +CONTINUE reply.
* The RDB file was extended with an auxiliary field that is able to
select a given DB after loading in the slave, so that the slave can
continue receiving the replication stream from the point it was
disconnected without requiring the master to insert "SELECT" statements.
This is useful in order to guarantee the "same stream" property, because
the slave must be able to accumulate an identical backlog.
* Slave pings to sub-slaves are now sent in a special form, when the
top-level master is disconnected, in order to don't interfer with the
replication stream. We just use out of band "\n" bytes as in other parts
of the Redis protocol.
An old design document is available here:
https://gist.github.com/antirez/ae068f95c0d084891305
However the implementation is not identical to the description because
during the work to implement it, different changes were needed in order
to make things working well.
2016-11-09 11:31:06 +01:00
" second_repl_offset:%lld \r \n "
2013-01-30 18:33:16 +01:00
" repl_backlog_active:%d \r \n "
" repl_backlog_size:%lld \r \n "
" repl_backlog_first_byte_offset:%lld \r \n "
" repl_backlog_histlen:%lld \r \n " ,
PSYNC2: different improvements to Redis replication.
The gist of the changes is that now, partial resynchronizations between
slaves and masters (without the need of a full resync with RDB transfer
and so forth), work in a number of cases when it was impossible
in the past. For instance:
1. When a slave is promoted to mastrer, the slaves of the old master can
partially resynchronize with the new master.
2. Chained slalves (slaves of slaves) can be moved to replicate to other
slaves or the master itsef, without requiring a full resync.
3. The master itself, after being turned into a slave, is able to
partially resynchronize with the new master, when it joins replication
again.
In order to obtain this, the following main changes were operated:
* Slaves also take a replication backlog, not just masters.
* Same stream replication for all the slaves and sub slaves. The
replication stream is identical from the top level master to its slaves
and is also the same from the slaves to their sub-slaves and so forth.
This means that if a slave is later promoted to master, it has the
same replication backlong, and can partially resynchronize with its
slaves (that were previously slaves of the old master).
* A given replication history is no longer identified by the `runid` of
a Redis node. There is instead a `replication ID` which changes every
time the instance has a new history no longer coherent with the past
one. So, for example, slaves publish the same replication history of
their master, however when they are turned into masters, they publish
a new replication ID, but still remember the old ID, so that they are
able to partially resynchronize with slaves of the old master (up to a
given offset).
* The replication protocol was slightly modified so that a new extended
+CONTINUE reply from the master is able to inform the slave of a
replication ID change.
* REPLCONF CAPA is used in order to notify masters that a slave is able
to understand the new +CONTINUE reply.
* The RDB file was extended with an auxiliary field that is able to
select a given DB after loading in the slave, so that the slave can
continue receiving the replication stream from the point it was
disconnected without requiring the master to insert "SELECT" statements.
This is useful in order to guarantee the "same stream" property, because
the slave must be able to accumulate an identical backlog.
* Slave pings to sub-slaves are now sent in a special form, when the
top-level master is disconnected, in order to don't interfer with the
replication stream. We just use out of band "\n" bytes as in other parts
of the Redis protocol.
An old design document is available here:
https://gist.github.com/antirez/ae068f95c0d084891305
However the implementation is not identical to the description because
during the work to implement it, different changes were needed in order
to make things working well.
2016-11-09 11:31:06 +01:00
server . replid ,
server . replid2 ,
2013-01-30 18:33:16 +01:00
server . master_repl_offset ,
PSYNC2: different improvements to Redis replication.
The gist of the changes is that now, partial resynchronizations between
slaves and masters (without the need of a full resync with RDB transfer
and so forth), work in a number of cases when it was impossible
in the past. For instance:
1. When a slave is promoted to mastrer, the slaves of the old master can
partially resynchronize with the new master.
2. Chained slalves (slaves of slaves) can be moved to replicate to other
slaves or the master itsef, without requiring a full resync.
3. The master itself, after being turned into a slave, is able to
partially resynchronize with the new master, when it joins replication
again.
In order to obtain this, the following main changes were operated:
* Slaves also take a replication backlog, not just masters.
* Same stream replication for all the slaves and sub slaves. The
replication stream is identical from the top level master to its slaves
and is also the same from the slaves to their sub-slaves and so forth.
This means that if a slave is later promoted to master, it has the
same replication backlong, and can partially resynchronize with its
slaves (that were previously slaves of the old master).
* A given replication history is no longer identified by the `runid` of
a Redis node. There is instead a `replication ID` which changes every
time the instance has a new history no longer coherent with the past
one. So, for example, slaves publish the same replication history of
their master, however when they are turned into masters, they publish
a new replication ID, but still remember the old ID, so that they are
able to partially resynchronize with slaves of the old master (up to a
given offset).
* The replication protocol was slightly modified so that a new extended
+CONTINUE reply from the master is able to inform the slave of a
replication ID change.
* REPLCONF CAPA is used in order to notify masters that a slave is able
to understand the new +CONTINUE reply.
* The RDB file was extended with an auxiliary field that is able to
select a given DB after loading in the slave, so that the slave can
continue receiving the replication stream from the point it was
disconnected without requiring the master to insert "SELECT" statements.
This is useful in order to guarantee the "same stream" property, because
the slave must be able to accumulate an identical backlog.
* Slave pings to sub-slaves are now sent in a special form, when the
top-level master is disconnected, in order to don't interfer with the
replication stream. We just use out of band "\n" bytes as in other parts
of the Redis protocol.
An old design document is available here:
https://gist.github.com/antirez/ae068f95c0d084891305
However the implementation is not identical to the description because
during the work to implement it, different changes were needed in order
to make things working well.
2016-11-09 11:31:06 +01:00
server . second_replid_offset ,
2013-01-30 18:33:16 +01:00
server . repl_backlog ! = NULL ,
server . repl_backlog_size ,
server . repl_backlog_off ,
server . repl_backlog_histlen ) ;
2011-01-09 15:56:50 +01:00
}
2011-01-23 22:14:15 +01:00
/* CPU */
if ( allsections | | defsections | | ! strcasecmp ( section , " cpu " ) ) {
2011-01-23 16:41:07 +01:00
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info ,
2011-01-23 22:14:15 +01:00
" # CPU \r \n "
2018-07-25 21:50:24 +07:00
" used_cpu_sys:%ld.%06ld \r \n "
" used_cpu_user:%ld.%06ld \r \n "
" used_cpu_sys_children:%ld.%06ld \r \n "
" used_cpu_user_children:%ld.%06ld \r \n " ,
( long ) self_ru . ru_stime . tv_sec , ( long ) self_ru . ru_stime . tv_usec ,
( long ) self_ru . ru_utime . tv_sec , ( long ) self_ru . ru_utime . tv_usec ,
( long ) c_ru . ru_stime . tv_sec , ( long ) c_ru . ru_stime . tv_usec ,
( long ) c_ru . ru_utime . tv_sec , ( long ) c_ru . ru_utime . tv_usec ) ;
2011-01-23 22:14:15 +01:00
}
2011-01-23 16:41:07 +01:00
2019-04-16 22:16:12 +03:00
/* Modules */
if ( allsections | | defsections | | ! strcasecmp ( section , " modules " ) ) {
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info , " # Modules \r \n " ) ;
info = genModulesInfoString ( info ) ;
}
2017-04-13 17:03:46 +03:00
/* Command statistics */
2011-01-23 22:14:15 +01:00
if ( allsections | | ! strcasecmp ( section , " commandstats " ) ) {
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info , " # Commandstats \r \n " ) ;
2017-04-13 17:03:46 +03:00
struct redisCommand * c ;
dictEntry * de ;
dictIterator * di ;
di = dictGetSafeIterator ( server . commands ) ;
while ( ( de = dictNext ( di ) ) ! = NULL ) {
c = ( struct redisCommand * ) dictGetVal ( de ) ;
2011-01-24 10:56:06 +01:00
if ( ! c - > calls ) continue ;
info = sdscatprintf ( info ,
" cmdstat_%s:calls=%lld,usec=%lld,usec_per_call=%.2f \r \n " ,
c - > name , c - > calls , c - > microseconds ,
( c - > calls = = 0 ) ? 0 : ( ( float ) c - > microseconds / c - > calls ) ) ;
2011-01-23 16:41:07 +01:00
}
2017-04-13 17:03:46 +03:00
dictReleaseIterator ( di ) ;
2011-01-23 11:46:34 +01:00
}
2012-04-11 10:56:55 +02:00
/* Cluster */
2011-04-11 16:39:39 +02:00
if ( allsections | | defsections | | ! strcasecmp ( section , " cluster " ) ) {
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info ,
" # Cluster \r \n "
" cluster_enabled:%d \r \n " ,
server . cluster_enabled ) ;
}
2011-01-23 16:41:07 +01:00
/* Key space */
if ( allsections | | defsections | | ! strcasecmp ( section , " keyspace " ) ) {
if ( sections + + ) info = sdscat ( info , " \r \n " ) ;
info = sdscatprintf ( info , " # Keyspace \r \n " ) ;
for ( j = 0 ; j < server . dbnum ; j + + ) {
long long keys , vkeys ;
2010-06-22 00:07:48 +02:00
2011-01-23 16:41:07 +01:00
keys = dictSize ( server . db [ j ] . dict ) ;
vkeys = dictSize ( server . db [ j ] . expires ) ;
if ( keys | | vkeys ) {
2013-08-06 15:00:43 +02:00
info = sdscatprintf ( info ,
" db%d:keys=%lld,expires=%lld,avg_ttl=%lld \r \n " ,
j , keys , vkeys , server . db [ j ] . avg_ttl ) ;
2011-01-23 16:41:07 +01:00
}
2010-06-22 00:07:48 +02:00
}
}
2019-07-24 12:58:15 +03:00
/* Get info from modules.
* if user asked for " everything " or " modules " , or a specific section
* that ' s not found yet . */
if ( everything | | modules | |
( ! allsections & & ! defsections & & sections = = 0 ) ) {
info = modulesCollectInfo ( info ,
everything | | modules ? NULL : section ,
0 , /* not a crash report */
sections ) ;
}
2010-06-22 00:07:48 +02:00
return info ;
}
2015-07-26 15:20:46 +02:00
void infoCommand ( client * c ) {
2011-01-23 16:41:07 +01:00
char * section = c - > argc = = 2 ? c - > argv [ 1 ] - > ptr : " default " ;
if ( c - > argc > 2 ) {
addReply ( c , shared . syntaxerr ) ;
return ;
}
2019-09-18 18:33:01 +02:00
sds info = genRedisInfoString ( section ) ;
addReplyVerbatim ( c , info , sdslen ( info ) , " txt " ) ;
sdsfree ( info ) ;
2010-06-22 00:07:48 +02:00
}
2015-07-26 15:20:46 +02:00
void monitorCommand ( client * c ) {
2012-11-01 18:14:55 +08:00
/* ignore MONITOR if already slave or in monitor mode */
2015-07-27 09:41:48 +02:00
if ( c - > flags & CLIENT_SLAVE ) return ;
2010-06-22 00:07:48 +02:00
2015-07-27 09:41:48 +02:00
c - > flags | = ( CLIENT_SLAVE | CLIENT_MONITOR ) ;
2010-06-22 00:07:48 +02:00
listAddNodeTail ( server . monitors , c ) ;
addReply ( c , shared . ok ) ;
}
/* =================================== Main! ================================ */
# ifdef __linux__
int linuxOvercommitMemoryValue ( void ) {
FILE * fp = fopen ( " /proc/sys/vm/overcommit_memory " , " r " ) ;
char buf [ 64 ] ;
if ( ! fp ) return - 1 ;
if ( fgets ( buf , 64 , fp ) = = NULL ) {
fclose ( fp ) ;
return - 1 ;
}
fclose ( fp ) ;
return atoi ( buf ) ;
}
2014-11-12 10:55:47 +01:00
void linuxMemoryWarnings ( void ) {
2010-06-22 00:07:48 +02:00
if ( linuxOvercommitMemoryValue ( ) = = 0 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect. " ) ;
2010-06-22 00:07:48 +02:00
}
2014-11-12 10:55:47 +01:00
if ( THPIsEnabled ( ) ) {
2020-09-09 15:39:57 +03:00
serverLog ( LL_WARNING , " WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo madvise > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled (set to 'madvise' or 'never'). " ) ;
2014-11-12 10:55:47 +01:00
}
2010-06-22 00:07:48 +02:00
}
# endif /* __linux__ */
2010-08-24 17:09:25 +02:00
void createPidFile ( void ) {
2014-08-25 17:07:37 -04:00
/* If pidfile requested, but no pidfile defined, use
* default pidfile path */
2015-07-26 15:14:57 +02:00
if ( ! server . pidfile ) server . pidfile = zstrdup ( CONFIG_DEFAULT_PID_FILE ) ;
2014-08-25 17:07:37 -04:00
2010-08-24 17:09:25 +02:00
/* Try to write the pid file in a best-effort way. */
FILE * fp = fopen ( server . pidfile , " w " ) ;
if ( fp ) {
2010-12-23 11:25:56 +00:00
fprintf ( fp , " %d \n " , ( int ) getpid ( ) ) ;
2010-08-24 17:09:25 +02:00
fclose ( fp ) ;
}
}
2010-06-22 00:07:48 +02:00
void daemonize ( void ) {
int fd ;
if ( fork ( ) ! = 0 ) exit ( 0 ) ; /* parent exits */
setsid ( ) ; /* create a new session */
/* Every output goes to /dev/null. If Redis is daemonized but
* the ' logfile ' is set to ' stdout ' in the configuration file
* it will not log at all . */
if ( ( fd = open ( " /dev/null " , O_RDWR , 0 ) ) ! = - 1 ) {
dup2 ( fd , STDIN_FILENO ) ;
dup2 ( fd , STDOUT_FILENO ) ;
dup2 ( fd , STDERR_FILENO ) ;
if ( fd > STDERR_FILENO ) close ( fd ) ;
}
}
2014-03-16 08:51:54 +09:00
void version ( void ) {
2012-11-29 14:20:08 +01:00
printf ( " Redis server v=%s sha=%s:%d malloc=%s bits=%d build=%llx \n " ,
2012-04-12 11:50:18 +02:00
REDIS_VERSION ,
redisGitSHA1 ( ) ,
atoi ( redisGitDirty ( ) ) > 0 ,
ZMALLOC_LIB ,
2012-11-29 14:20:08 +01:00
sizeof ( long ) = = 4 ? 32 : 64 ,
2013-02-27 12:33:27 +01:00
( unsigned long long ) redisBuildId ( ) ) ;
2010-06-22 00:07:48 +02:00
exit ( 0 ) ;
}
2014-03-16 08:51:54 +09:00
void usage ( void ) {
2011-12-01 13:50:36 +01:00
fprintf ( stderr , " Usage: ./redis-server [/path/to/redis.conf] [options] \n " ) ;
2010-06-22 00:07:48 +02:00
fprintf ( stderr , " ./redis-server - (read config from stdin) \n " ) ;
2011-12-01 13:50:36 +01:00
fprintf ( stderr , " ./redis-server -v or --version \n " ) ;
2012-03-16 17:17:39 +01:00
fprintf ( stderr , " ./redis-server -h or --help \n " ) ;
fprintf ( stderr , " ./redis-server --test-memory <megabytes> \n \n " ) ;
2011-12-01 13:50:36 +01:00
fprintf ( stderr , " Examples: \n " ) ;
fprintf ( stderr , " ./redis-server (run the server with default conf) \n " ) ;
fprintf ( stderr , " ./redis-server /etc/redis/6379.conf \n " ) ;
fprintf ( stderr , " ./redis-server --port 7777 \n " ) ;
2018-09-11 10:39:24 +02:00
fprintf ( stderr , " ./redis-server --port 7777 --replicaof 127.0.0.1 8888 \n " ) ;
2012-07-23 12:54:52 +02:00
fprintf ( stderr , " ./redis-server /etc/myredis.conf --loglevel verbose \n \n " ) ;
fprintf ( stderr , " Sentinel mode: \n " ) ;
fprintf ( stderr , " ./redis-server /etc/sentinel.conf --sentinel \n " ) ;
2010-06-22 00:07:48 +02:00
exit ( 1 ) ;
}
2011-04-13 10:58:21 +02:00
void redisAsciiArt ( void ) {
# include "asciilogo.h"
char * buf = zmalloc ( 1024 * 16 ) ;
2014-07-28 00:30:12 -07:00
char * mode ;
2012-07-23 12:54:52 +02:00
if ( server . cluster_enabled ) mode = " cluster " ;
else if ( server . sentinel_mode ) mode = " sentinel " ;
2014-07-28 00:30:12 -07:00
else mode = " standalone " ;
2011-04-13 10:58:21 +02:00
2016-12-19 16:41:47 +01:00
/* Show the ASCII logo if: log file is stdout AND stdout is a
* tty AND syslog logging is disabled . Also show logo if the user
* forced us to do so via redis . conf . */
int show_logo = ( ( ! server . syslog_enabled & &
server . logfile [ 0 ] = = ' \0 ' & &
isatty ( fileno ( stdout ) ) ) | |
server . always_show_logo ) ;
if ( ! show_logo ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE ,
2016-12-19 16:41:47 +01:00
" Running mode=%s, port=%d. " ,
2019-09-12 11:10:22 +03:00
mode , server . port ? server . port : server . tls_port
2014-12-03 10:50:47 +01:00
) ;
} else {
snprintf ( buf , 1024 * 16 , ascii_logo ,
REDIS_VERSION ,
redisGitSHA1 ( ) ,
strtol ( redisGitDirty ( ) , NULL , 10 ) > 0 ,
( sizeof ( long ) = = 8 ) ? " 64 " : " 32 " ,
2019-09-12 10:56:54 +03:00
mode , server . port ? server . port : server . tls_port ,
2014-12-03 10:50:47 +01:00
( long ) getpid ( )
) ;
2015-07-27 09:41:48 +02:00
serverLogRaw ( LL_NOTICE | LL_RAW , buf ) ;
2014-12-03 10:50:47 +01:00
}
2011-04-13 10:58:21 +02:00
zfree ( buf ) ;
}
2014-03-26 22:15:44 -04:00
static void sigShutdownHandler ( int sig ) {
char * msg ;
switch ( sig ) {
case SIGINT :
msg = " Received SIGINT scheduling shutdown... " ;
break ;
case SIGTERM :
msg = " Received SIGTERM scheduling shutdown... " ;
break ;
default :
msg = " Received shutdown signal, scheduling shutdown... " ;
} ;
2014-08-07 16:32:50 +02:00
/* SIGINT is often delivered via Ctrl+C in an interactive session.
* If we receive the signal the second time , we interpret this as
* the user really wanting to quit ASAP without waiting to persist
* on disk . */
if ( server . shutdown_asap & & sig = = SIGINT ) {
2015-07-27 09:41:48 +02:00
serverLogFromHandler ( LL_WARNING , " You insist... exiting now. " ) ;
2020-09-17 23:20:10 +08:00
rdbRemoveTempFile ( getpid ( ) , 1 ) ;
2014-08-07 16:32:50 +02:00
exit ( 1 ) ; /* Exit with an error since this was not a clean shutdown. */
} else if ( server . loading ) {
2018-08-13 17:43:29 +03:00
serverLogFromHandler ( LL_WARNING , " Received shutdown signal during loading, exiting now. " ) ;
2014-08-07 16:32:50 +02:00
exit ( 0 ) ;
}
2015-07-27 09:41:48 +02:00
serverLogFromHandler ( LL_WARNING , msg ) ;
2010-06-22 00:07:48 +02:00
server . shutdown_asap = 1 ;
}
2011-03-06 17:49:22 +01:00
void setupSignalHandlers ( void ) {
2010-06-22 00:07:48 +02:00
struct sigaction act ;
2011-03-06 17:49:22 +01:00
/* When the SA_SIGINFO flag is set in sa_flags then sa_sigaction is used.
* Otherwise , sa_handler is used . */
sigemptyset ( & act . sa_mask ) ;
2012-04-03 17:40:31 +02:00
act . sa_flags = 0 ;
2014-03-26 22:15:44 -04:00
act . sa_handler = sigShutdownHandler ;
2011-03-06 17:49:22 +01:00
sigaction ( SIGTERM , & act , NULL ) ;
2014-08-07 16:32:50 +02:00
sigaction ( SIGINT , & act , NULL ) ;
2010-06-22 00:07:48 +02:00
2011-03-06 17:49:22 +01:00
sigemptyset ( & act . sa_mask ) ;
2012-04-26 16:21:19 +02:00
act . sa_flags = SA_NODEFER | SA_RESETHAND | SA_SIGINFO ;
2011-03-06 17:49:22 +01:00
act . sa_sigaction = sigsegvHandler ;
2020-07-29 17:05:14 +03:00
if ( server . crashlog_enabled ) {
sigaction ( SIGSEGV , & act , NULL ) ;
sigaction ( SIGBUS , & act , NULL ) ;
sigaction ( SIGFPE , & act , NULL ) ;
sigaction ( SIGILL , & act , NULL ) ;
}
return ;
}
void removeSignalHandlers ( void ) {
struct sigaction act ;
sigemptyset ( & act . sa_mask ) ;
act . sa_flags = SA_NODEFER | SA_RESETHAND ;
act . sa_handler = SIG_DFL ;
2011-03-06 17:49:22 +01:00
sigaction ( SIGSEGV , & act , NULL ) ;
sigaction ( SIGBUS , & act , NULL ) ;
sigaction ( SIGFPE , & act , NULL ) ;
sigaction ( SIGILL , & act , NULL ) ;
2010-06-22 00:07:48 +02:00
}
2019-09-27 11:39:40 +02:00
/* This is the signal handler for children process. It is currently useful
* in order to track the SIGUSR1 , that we send to a child in order to terminate
* it in a clean way , without the parent detecting an error and stop
* accepting writes because of a write error condition . */
2019-07-17 08:51:02 +03:00
static void sigKillChildHandler ( int sig ) {
UNUSED ( sig ) ;
2020-09-20 13:43:28 +03:00
int level = server . in_fork_child = = CHILD_TYPE_MODULE ? LL_VERBOSE : LL_WARNING ;
serverLogFromHandler ( level , " Received SIGUSR1 in child, exiting now. " ) ;
2019-09-27 11:39:40 +02:00
exitFromChild ( SERVER_CHILD_NOERROR_RETVAL ) ;
2019-07-17 08:51:02 +03:00
}
void setupChildSignalHandlers ( void ) {
struct sigaction act ;
/* When the SA_SIGINFO flag is set in sa_flags then sa_sigaction is used.
* Otherwise , sa_handler is used . */
sigemptyset ( & act . sa_mask ) ;
act . sa_flags = 0 ;
act . sa_handler = sigKillChildHandler ;
sigaction ( SIGUSR1 , & act , NULL ) ;
return ;
}
2020-08-20 13:59:02 +08:00
/* After fork, the child process will inherit the resources
* of the parent process , e . g . fd ( socket or flock ) etc .
* should close the resources not used by the child process , so that if the
* parent restarts it can bind / lock despite the child possibly still running . */
void closeClildUnusedResourceAfterFork ( ) {
closeListeningSockets ( 0 ) ;
if ( server . cluster_enabled & & server . cluster_config_file_lock_fd ! = - 1 )
close ( server . cluster_config_file_lock_fd ) ; /* don't care if this fails */
}
2020-09-20 13:43:28 +03:00
/* purpose is one of CHILD_TYPE_ types */
int redisFork ( int purpose ) {
2019-07-17 08:51:02 +03:00
int childpid ;
long long start = ustime ( ) ;
if ( ( childpid = fork ( ) ) = = 0 ) {
/* Child */
2020-09-20 13:43:28 +03:00
server . in_fork_child = purpose ;
2020-08-12 17:58:56 +03:00
setOOMScoreAdj ( CONFIG_OOM_BGCHILD ) ;
2019-07-17 08:51:02 +03:00
setupChildSignalHandlers ( ) ;
2020-08-20 13:59:02 +08:00
closeClildUnusedResourceAfterFork ( ) ;
2019-07-17 08:51:02 +03:00
} else {
/* Parent */
server . stat_fork_time = ustime ( ) - start ;
server . stat_fork_rate = ( double ) zmalloc_used_memory ( ) * 1000000 / server . stat_fork_time / ( 1024 * 1024 * 1024 ) ; /* GB per second. */
latencyAddSampleIfNeeded ( " fork " , server . stat_fork_time / 1000 ) ;
if ( childpid = = - 1 ) {
return - 1 ;
}
updateDictResizePolicy ( ) ;
}
return childpid ;
}
void sendChildCOWInfo ( int ptype , char * pname ) {
size_t private_dirty = zmalloc_get_private_dirty ( - 1 ) ;
if ( private_dirty ) {
serverLog ( LL_NOTICE ,
" %s: %zu MB of memory used by copy-on-write " ,
pname , private_dirty / ( 1024 * 1024 ) ) ;
}
server . child_info_data . cow_size = private_dirty ;
sendChildInfo ( ptype ) ;
}
2012-03-16 17:17:39 +01:00
void memtest ( size_t megabytes , int passes ) ;
2012-07-23 12:54:52 +02:00
/* Returns 1 if there is --sentinel among the arguments or if
2016-06-16 16:50:53 -07:00
* argv [ 0 ] contains " redis-sentinel " . */
2012-07-23 12:54:52 +02:00
int checkForSentinelMode ( int argc , char * * argv ) {
int j ;
if ( strstr ( argv [ 0 ] , " redis-sentinel " ) ! = NULL ) return 1 ;
for ( j = 1 ; j < argc ; j + + )
if ( ! strcmp ( argv [ j ] , " --sentinel " ) ) return 1 ;
return 0 ;
}
/* Function called at startup to load RDB or AOF file in memory. */
void loadDataFromDisk ( void ) {
long long start = ustime ( ) ;
2015-07-27 09:41:48 +02:00
if ( server . aof_state = = AOF_ON ) {
2015-07-26 23:17:55 +02:00
if ( loadAppendOnlyFile ( server . aof_filename ) = = C_OK )
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " DB loaded from append only file: %.3f seconds " , ( float ) ( ustime ( ) - start ) / 1000000 ) ;
2012-07-23 12:54:52 +02:00
} else {
2016-11-10 12:35:29 +01:00
rdbSaveInfo rsi = RDB_SAVE_INFO_INIT ;
2020-07-21 17:00:13 -07:00
errno = 0 ; /* Prevent a stale value from affecting error checking */
2019-10-29 17:59:09 +02:00
if ( rdbLoad ( server . rdb_filename , & rsi , RDBFLAGS_NONE ) = = C_OK ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " DB loaded from disk: %.3f seconds " ,
2012-07-23 12:54:52 +02:00
( float ) ( ustime ( ) - start ) / 1000000 ) ;
2016-11-10 12:35:29 +01:00
/* Restore the replication ID / offset from the RDB file. */
2019-10-10 10:23:34 +02:00
if ( ( server . masterhost | |
( server . cluster_enabled & &
nodeIsSlave ( server . cluster - > myself ) ) ) & &
2017-09-19 23:03:39 +02:00
rsi . repl_id_is_set & &
rsi . repl_offset ! = - 1 & &
/* Note that older implementations may save a repl_stream_db
2019-10-10 10:23:34 +02:00
* of - 1 inside the RDB file in a wrong way , see more
* information in function rdbPopulateSaveInfo . */
2017-09-19 23:03:39 +02:00
rsi . repl_stream_db ! = - 1 )
{
2016-11-10 12:35:29 +01:00
memcpy ( server . replid , rsi . repl_id , sizeof ( server . replid ) ) ;
server . master_repl_offset = rsi . repl_offset ;
/* If we are a slave, create a cached master from this
* information , in order to allow partial resynchronizations
* with masters . */
2017-09-19 23:03:39 +02:00
replicationCacheMasterUsingMyself ( ) ;
selectDb ( server . cached_master , rsi . repl_stream_db ) ;
2016-11-10 12:35:29 +01:00
}
2012-07-23 12:54:52 +02:00
} else if ( errno ! = ENOENT ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Fatal error loading the DB: %s. Exiting. " , strerror ( errno ) ) ;
2012-07-23 12:54:52 +02:00
exit ( 1 ) ;
}
}
}
2012-08-24 12:55:37 +02:00
void redisOutOfMemoryHandler ( size_t allocation_size ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Out Of Memory allocating %zu bytes! " ,
2012-08-24 12:55:37 +02:00
allocation_size ) ;
2020-08-18 09:53:59 +03:00
serverPanic ( " Redis aborting for OUT OF MEMORY. Allocating %zu bytes! " ,
allocation_size ) ;
2012-08-24 12:55:37 +02:00
}
2013-02-26 11:52:12 +01:00
void redisSetProcTitle ( char * title ) {
2013-02-27 11:53:11 +08:00
# ifdef USE_SETPROCTITLE
2014-02-20 23:45:56 -05:00
char * server_mode = " " ;
if ( server . cluster_enabled ) server_mode = " [cluster] " ;
else if ( server . sentinel_mode ) server_mode = " [sentinel] " ;
setproctitle ( " %s %s:%d%s " ,
2013-02-26 11:52:12 +01:00
title ,
2013-07-04 18:50:15 +02:00
server . bindaddr_count ? server . bindaddr [ 0 ] : " * " ,
2019-09-12 10:56:54 +03:00
server . port ? server . port : server . tls_port ,
2014-02-20 23:45:56 -05:00
server_mode ) ;
2013-02-27 11:53:11 +08:00
# else
2015-07-27 09:41:48 +02:00
UNUSED ( title ) ;
2013-02-27 11:53:11 +08:00
# endif
2013-02-26 11:52:12 +01:00
}
Support setcpuaffinity on linux/bsd
Currently, there are several types of threads/child processes of a
redis server. Sometimes we need deeply optimise the performance of
redis, so we would like to isolate threads/processes.
There were some discussion about cpu affinity cases in the issue:
https://github.com/antirez/redis/issues/2863
So implement cpu affinity setting by redis.conf in this patch, then
we can config server_cpulist/bio_cpulist/aof_rewrite_cpulist/
bgsave_cpulist by cpu list.
Examples of cpulist in redis.conf:
server_cpulist 0-7:2 means cpu affinity 0,2,4,6
bio_cpulist 1,3 means cpu affinity 1,3
aof_rewrite_cpulist 8-11 means cpu affinity 8,9,10,11
bgsave_cpulist 1,10-11 means cpu affinity 1,10,11
Test on linux/freebsd, both work fine.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2020-05-02 20:05:39 +08:00
void redisSetCpuAffinity ( const char * cpulist ) {
# ifdef USE_SETCPUAFFINITY
setcpuaffinity ( cpulist ) ;
# else
UNUSED ( cpulist ) ;
# endif
}
2014-11-11 11:05:10 +01:00
/*
* Check whether systemd or upstart have been used to start redis .
*/
2015-01-08 15:22:33 -05:00
int redisSupervisedUpstart ( void ) {
2014-11-11 11:05:10 +01:00
const char * upstart_job = getenv ( " UPSTART_JOB " ) ;
2015-01-08 15:22:33 -05:00
if ( ! upstart_job ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2015-01-08 15:22:33 -05:00
" upstart supervision requested, but UPSTART_JOB not found " ) ;
return 0 ;
}
2016-02-03 11:04:09 -08:00
serverLog ( LL_NOTICE , " supervised by upstart, will stop to signal readiness " ) ;
2015-01-08 15:22:33 -05:00
raise ( SIGSTOP ) ;
unsetenv ( " UPSTART_JOB " ) ;
return 1 ;
}
2019-04-27 18:07:30 +02:00
int redisCommunicateSystemd ( const char * sd_notify_msg ) {
2014-11-11 11:05:10 +01:00
const char * notify_socket = getenv ( " NOTIFY_SOCKET " ) ;
2015-01-08 15:22:33 -05:00
if ( ! notify_socket ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2015-01-08 15:22:33 -05:00
" systemd supervision requested, but NOTIFY_SOCKET not found " ) ;
2014-11-11 11:05:10 +01:00
}
Auto-detect and link libsystemd at compile-time
This adds Makefile/build-system support for USE_SYSTEMD=(yes|no|*). This
variable's value determines whether or not libsystemd will be linked at
build-time.
If USE_SYSTEMD is set to "yes", make will use PKG_CONFIG to check for
libsystemd's presence, and fail the build early if it isn't
installed/detected properly.
If USE_SYSTEM is set to "no", libsystemd will *not* be linked, even if
support for it is available on the system redis is being built on.
For any other value that USE_SYSTEM might assume (e.g. "auto"),
PKG_CONFIG will try to determine libsystemd's presence, and set up the
build process to link against it, if it was indicated as being
installed/available.
This approach has a number of repercussions of its own, most importantly
the following: If you build redis on a system that actually has systemd
support, but no libsystemd-dev package(s) installed, you'll end up
*without* support for systemd notification/status reporting support in
redis-server. This changes established runtime behaviour.
I'm not sure if the build system and/or the server binary should
indicate this. I'm also wondering if not actually having
systemd-notify-support, but requesting it via the server's config,
should result in a fatal error now.
2019-05-30 18:44:17 +02:00
# ifdef HAVE_LIBSYSTEMD
( void ) sd_notify ( 0 , sd_notify_msg ) ;
# else
UNUSED ( sd_notify_msg ) ;
# endif
2019-04-27 18:07:30 +02:00
return 0 ;
2014-11-11 11:05:10 +01:00
}
2015-01-08 15:22:33 -05:00
int redisIsSupervised ( int mode ) {
2015-07-27 09:41:48 +02:00
if ( mode = = SUPERVISED_AUTODETECT ) {
2015-01-08 15:22:33 -05:00
const char * upstart_job = getenv ( " UPSTART_JOB " ) ;
const char * notify_socket = getenv ( " NOTIFY_SOCKET " ) ;
if ( upstart_job ) {
redisSupervisedUpstart ( ) ;
} else if ( notify_socket ) {
2019-04-27 18:07:30 +02:00
server . supervised_mode = SUPERVISED_SYSTEMD ;
serverLog ( LL_WARNING ,
" WARNING auto-supervised by systemd - you MUST set appropriate values for TimeoutStartSec and TimeoutStopSec in your service unit. " ) ;
return redisCommunicateSystemd ( " STATUS=Redis is loading... \n " ) ;
2015-01-08 15:22:33 -05:00
}
2015-07-27 09:41:48 +02:00
} else if ( mode = = SUPERVISED_UPSTART ) {
2015-01-08 15:22:33 -05:00
return redisSupervisedUpstart ( ) ;
2015-07-27 09:41:48 +02:00
} else if ( mode = = SUPERVISED_SYSTEMD ) {
2019-04-27 18:07:30 +02:00
serverLog ( LL_WARNING ,
" WARNING supervised by systemd - you MUST set appropriate values for TimeoutStartSec and TimeoutStopSec in your service unit. " ) ;
return redisCommunicateSystemd ( " STATUS=Redis is loading... \n " ) ;
2015-01-08 15:22:33 -05:00
}
return 0 ;
}
Fix master replica inconsistency for upgrading scenario.
Before this commit, when upgrading a replica, expired keys will not
be loaded, thus causing replica having less keys in db. To this point,
master and replica's keys is logically consistent. However, before
the keys in master and replica are physically consistent, that is,
they have the same dbsize, if master got a problem and the replica
got promoted and becomes new master of that partition, and master
updates a key which does not exist on master, but physically exists
on the old master(new replica), the old master would refuse to update
the key, thus causing master and replica data inconsistent.
How could this happen?
That's all because of the wrong judgement of roles while starting up
the server. We can not use server.masterhost to judge if the server
is master or replica, since it fails in cluster mode.
When we start the server, we load rdb and do want to load expired keys,
and do not want to have the ability to active expire keys, if it is
a replica.
2020-03-18 16:20:10 +08:00
int iAmMaster ( void ) {
return ( ( ! server . cluster_enabled & & server . masterhost = = NULL ) | |
( server . cluster_enabled & & nodeIsMaster ( server . cluster - > myself ) ) ) ;
}
2011-12-01 12:15:44 +01:00
int main ( int argc , char * * argv ) {
2012-01-21 23:05:32 +01:00
struct timeval tv ;
2015-10-13 10:58:08 +02:00
int j ;
2011-12-01 12:15:44 +01:00
2014-11-12 21:58:57 -05:00
# ifdef REDIS_TEST
if ( argc = = 3 & & ! strcasecmp ( argv [ 1 ] , " test " ) ) {
if ( ! strcasecmp ( argv [ 2 ] , " ziplist " ) ) {
return ziplistTest ( argc , argv ) ;
2014-11-13 14:11:47 -05:00
} else if ( ! strcasecmp ( argv [ 2 ] , " quicklist " ) ) {
quicklistTest ( argc , argv ) ;
2014-11-12 21:58:57 -05:00
} else if ( ! strcasecmp ( argv [ 2 ] , " intset " ) ) {
return intsetTest ( argc , argv ) ;
} else if ( ! strcasecmp ( argv [ 2 ] , " zipmap " ) ) {
return zipmapTest ( argc , argv ) ;
} else if ( ! strcasecmp ( argv [ 2 ] , " sha1test " ) ) {
return sha1Test ( argc , argv ) ;
} else if ( ! strcasecmp ( argv [ 2 ] , " util " ) ) {
return utilTest ( argc , argv ) ;
} else if ( ! strcasecmp ( argv [ 2 ] , " endianconv " ) ) {
return endianconvTest ( argc , argv ) ;
} else if ( ! strcasecmp ( argv [ 2 ] , " crc64 " ) ) {
return crc64Test ( argc , argv ) ;
2018-09-30 11:49:03 +02:00
} else if ( ! strcasecmp ( argv [ 2 ] , " zmalloc " ) ) {
return zmalloc_test ( argc , argv ) ;
2014-11-12 21:58:57 -05:00
}
return - 1 ; /* test not found */
}
# endif
2012-01-21 23:34:06 +01:00
/* We need to initialize our libraries, and the server configuration. */
2013-02-27 11:53:11 +08:00
# ifdef INIT_SETPROCTITLE_REPLACEMENT
spt_init ( argc , argv ) ;
# endif
2013-07-12 12:06:05 +02:00
setlocale ( LC_COLLATE , " " ) ;
2018-07-04 16:44:57 +02:00
tzset ( ) ; /* Populates 'timezone' global. */
2012-08-24 12:55:37 +02:00
zmalloc_set_oom_handler ( redisOutOfMemoryHandler ) ;
2012-01-21 23:05:32 +01:00
srand ( time ( NULL ) ^ getpid ( ) ) ;
2020-08-13 04:15:58 +08:00
srandom ( time ( NULL ) ^ getpid ( ) ) ;
2012-01-21 23:05:32 +01:00
gettimeofday ( & tv , NULL ) ;
2020-05-05 10:20:48 +02:00
crc64_init ( ) ;
2018-07-04 16:44:57 +02:00
2019-09-23 19:24:09 -04:00
uint8_t hashseed [ 16 ] ;
getRandomBytes ( hashseed , sizeof ( hashseed ) ) ;
dictSetHashFunctionSeed ( hashseed ) ;
2012-07-23 12:54:52 +02:00
server . sentinel_mode = checkForSentinelMode ( argc , argv ) ;
2011-12-01 12:15:44 +01:00
initServerConfig ( ) ;
2019-01-11 11:30:09 +01:00
ACLInit ( ) ; /* The ACL subsystem must be initialized ASAP because the
basic networking code and client creation depends on it . */
2016-03-06 13:44:24 +01:00
moduleInitModulesSystem ( ) ;
2019-09-12 10:56:54 +03:00
tlsInit ( ) ;
2012-01-21 23:05:32 +01:00
2015-10-13 10:58:08 +02:00
/* Store the executable path and arguments in a safe place in order
* to be able to restart the server later . */
server . executable = getAbsolutePath ( argv [ 0 ] ) ;
server . exec_argv = zmalloc ( sizeof ( char * ) * ( argc + 1 ) ) ;
server . exec_argv [ argc ] = NULL ;
for ( j = 0 ; j < argc ; j + + ) server . exec_argv [ j ] = zstrdup ( argv [ j ] ) ;
2012-07-23 12:54:52 +02:00
/* We need to init sentinel right now as parsing the configuration file
* in sentinel mode will have the effect of populating the sentinel
* data structures with master nodes to monitor . */
if ( server . sentinel_mode ) {
initSentinelConfig ( ) ;
initSentinel ( ) ;
}
2017-07-10 13:38:23 +02:00
/* Check if we need to start in redis-check-rdb/aof mode. We just execute
2015-02-03 10:25:01 +01:00
* the program main . However the program is part of the Redis executable
* so that we can easily execute an RDB check on loading errors . */
if ( strstr ( argv [ 0 ] , " redis-check-rdb " ) ! = NULL )
2017-07-10 13:38:23 +02:00
redis_check_rdb_main ( argc , argv , NULL ) ;
else if ( strstr ( argv [ 0 ] , " redis-check-aof " ) ! = NULL )
redis_check_aof_main ( argc , argv ) ;
2015-02-03 10:25:01 +01:00
2011-12-01 13:44:53 +01:00
if ( argc > = 2 ) {
2015-10-13 10:58:08 +02:00
j = 1 ; /* First option to parse in argv[] */
2011-12-01 13:44:53 +01:00
sds options = sdsempty ( ) ;
char * configfile = NULL ;
/* Handle special options --help and --version */
2011-12-01 12:15:44 +01:00
if ( strcmp ( argv [ 1 ] , " -v " ) = = 0 | |
strcmp ( argv [ 1 ] , " --version " ) = = 0 ) version ( ) ;
2011-12-01 12:18:22 +01:00
if ( strcmp ( argv [ 1 ] , " --help " ) = = 0 | |
strcmp ( argv [ 1 ] , " -h " ) = = 0 ) usage ( ) ;
2012-03-16 17:17:39 +01:00
if ( strcmp ( argv [ 1 ] , " --test-memory " ) = = 0 ) {
if ( argc = = 3 ) {
2012-03-18 18:03:27 +01:00
memtest ( atoi ( argv [ 2 ] ) , 50 ) ;
2012-03-16 17:17:39 +01:00
exit ( 0 ) ;
} else {
fprintf ( stderr , " Please specify the amount of memory to test in megabytes. \n " ) ;
fprintf ( stderr , " Example: ./redis-server --test-memory 4096 \n \n " ) ;
exit ( 1 ) ;
}
}
2011-12-01 13:44:53 +01:00
/* First argument is the config file name? */
2015-10-13 10:58:08 +02:00
if ( argv [ j ] [ 0 ] ! = ' - ' | | argv [ j ] [ 1 ] ! = ' - ' ) {
configfile = argv [ j ] ;
server . configfile = getAbsolutePath ( configfile ) ;
/* Replace the config file in server.exec_argv with
2018-07-01 13:24:50 +08:00
* its absolute path . */
2015-10-13 10:58:08 +02:00
zfree ( server . exec_argv [ j ] ) ;
server . exec_argv [ j ] = zstrdup ( server . configfile ) ;
j + + ;
}
2011-12-01 13:44:53 +01:00
/* All the other options are parsed and conceptually appended to the
* configuration file . For instance - - port 6380 will generate the
* string " port 6380 \n " to be parsed after the actual file name
* is parsed , if any . */
while ( j ! = argc ) {
if ( argv [ j ] [ 0 ] = = ' - ' & & argv [ j ] [ 1 ] = = ' - ' ) {
/* Option name */
2014-05-09 12:06:06 -04:00
if ( ! strcmp ( argv [ j ] , " --check-rdb " ) ) {
/* Argument has no options, need to skip for parsing. */
j + + ;
continue ;
}
2011-12-01 13:44:53 +01:00
if ( sdslen ( options ) ) options = sdscat ( options , " \n " ) ;
options = sdscat ( options , argv [ j ] + 2 ) ;
options = sdscat ( options , " " ) ;
} else {
/* Option argument */
options = sdscatrepr ( options , argv [ j ] , strlen ( argv [ j ] ) ) ;
options = sdscat ( options , " " ) ;
}
j + + ;
}
2014-08-04 12:28:45 -04:00
if ( server . sentinel_mode & & configfile & & * configfile = = ' - ' ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2014-08-04 12:28:45 -04:00
" Sentinel config from STDIN not allowed. " ) ;
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2014-08-04 12:28:45 -04:00
" Sentinel needs config file on disk to save state. Exiting... " ) ;
exit ( 1 ) ;
}
2011-12-01 13:44:53 +01:00
loadServerConfig ( configfile , options ) ;
sdsfree ( options ) ;
2016-12-19 16:41:47 +01:00
}
2020-09-02 17:18:09 +03:00
server . supervised = redisIsSupervised ( server . supervised_mode ) ;
int background = server . daemonize & & ! server . supervised ;
if ( background ) daemonize ( ) ;
2016-12-19 16:41:47 +01:00
serverLog ( LL_WARNING , " oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo " ) ;
serverLog ( LL_WARNING ,
" Redis version=%s, bits=%d, commit=%s, modified=%d, pid=%d, just started " ,
REDIS_VERSION ,
( sizeof ( long ) = = 8 ) ? 64 : 32 ,
redisGitSHA1 ( ) ,
strtol ( redisGitDirty ( ) , NULL , 10 ) > 0 ,
( int ) getpid ( ) ) ;
if ( argc = = 1 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " Warning: no config file specified, using the default config. In order to specify a config file use %s /path/to/%s.conf " , argv [ 0 ] , server . sentinel_mode ? " sentinel " : " redis " ) ;
2016-12-19 16:41:47 +01:00
} else {
serverLog ( LL_WARNING , " Configuration loaded " ) ;
2011-12-01 12:15:44 +01:00
}
2014-11-11 11:05:10 +01:00
2020-08-12 17:58:56 +03:00
readOOMScoreAdj ( ) ;
2011-12-01 12:15:44 +01:00
initServer ( ) ;
2012-04-18 11:04:37 +12:00
if ( background | | server . pidfile ) createPidFile ( ) ;
2013-02-26 11:52:12 +01:00
redisSetProcTitle ( argv [ 0 ] ) ;
2011-12-01 12:15:44 +01:00
redisAsciiArt ( ) ;
2015-07-29 12:13:20 +02:00
checkTcpBacklogSettings ( ) ;
2012-07-23 12:54:52 +02:00
if ( ! server . sentinel_mode ) {
2013-02-25 11:40:21 +01:00
/* Things not needed when running in Sentinel mode. */
2016-12-19 16:41:47 +01:00
serverLog ( LL_WARNING , " Server initialized " ) ;
2012-07-23 12:54:52 +02:00
# ifdef __linux__
2014-11-12 10:55:47 +01:00
linuxMemoryWarnings ( ) ;
2012-07-23 12:54:52 +02:00
# endif
2020-08-08 19:36:41 +08:00
moduleInitModulesSystemLast ( ) ;
2016-03-06 13:44:24 +01:00
moduleLoadFromQueue ( ) ;
2019-02-07 17:20:03 +01:00
ACLLoadUsersAtStartup ( ) ;
2019-09-09 14:35:06 +03:00
InitServerLast ( ) ;
2012-07-23 12:54:52 +02:00
loadDataFromDisk ( ) ;
2013-02-25 11:20:17 +01:00
if ( server . cluster_enabled ) {
2015-07-26 23:17:55 +02:00
if ( verifyClusterConfigWithData ( ) = = C_ERR ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING ,
2013-02-25 11:20:17 +01:00
" You can't have keys in a DB different than DB 0 when in "
" Cluster mode. Exiting. " ) ;
exit ( 1 ) ;
}
}
2019-09-12 10:56:54 +03:00
if ( server . ipfd_count > 0 | | server . tlsfd_count > 0 )
2016-12-19 16:41:47 +01:00
serverLog ( LL_NOTICE , " Ready to accept connections " ) ;
2012-07-23 12:54:52 +02:00
if ( server . sofd > 0 )
2015-07-27 09:41:48 +02:00
serverLog ( LL_NOTICE , " The server is now ready to accept connections at %s " , server . unixsocket ) ;
2019-04-27 18:07:30 +02:00
if ( server . supervised_mode = = SUPERVISED_SYSTEMD ) {
if ( ! server . masterhost ) {
redisCommunicateSystemd ( " STATUS=Ready to accept connections \n " ) ;
redisCommunicateSystemd ( " READY=1 \n " ) ;
} else {
redisCommunicateSystemd ( " STATUS=Waiting for MASTER <-> REPLICA sync \n " ) ;
}
}
2013-11-19 16:50:04 +01:00
} else {
2019-09-09 14:35:06 +03:00
InitServerLast ( ) ;
2013-11-21 12:27:14 +01:00
sentinelIsRunning ( ) ;
2020-07-15 06:29:26 -04:00
if ( server . supervised_mode = = SUPERVISED_SYSTEMD ) {
redisCommunicateSystemd ( " STATUS=Ready to accept connections \n " ) ;
redisCommunicateSystemd ( " READY=1 \n " ) ;
}
2011-12-01 12:15:44 +01:00
}
2012-07-23 12:54:52 +02:00
2012-10-05 10:48:49 +02:00
/* Warning the user about suspicious maxmemory setting. */
if ( server . maxmemory > 0 & & server . maxmemory < 1024 * 1024 ) {
2015-07-27 09:41:48 +02:00
serverLog ( LL_WARNING , " WARNING: You specified a maxmemory value that is less than 1MB (current value is %llu bytes). Are you sure this is what you really want? " , server . maxmemory ) ;
2012-10-05 10:48:49 +02:00
}
Support setcpuaffinity on linux/bsd
Currently, there are several types of threads/child processes of a
redis server. Sometimes we need deeply optimise the performance of
redis, so we would like to isolate threads/processes.
There were some discussion about cpu affinity cases in the issue:
https://github.com/antirez/redis/issues/2863
So implement cpu affinity setting by redis.conf in this patch, then
we can config server_cpulist/bio_cpulist/aof_rewrite_cpulist/
bgsave_cpulist by cpu list.
Examples of cpulist in redis.conf:
server_cpulist 0-7:2 means cpu affinity 0,2,4,6
bio_cpulist 1,3 means cpu affinity 1,3
aof_rewrite_cpulist 8-11 means cpu affinity 8,9,10,11
bgsave_cpulist 1,10-11 means cpu affinity 1,10,11
Test on linux/freebsd, both work fine.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
2020-05-02 20:05:39 +08:00
redisSetCpuAffinity ( server . server_cpulist ) ;
2020-08-12 17:58:56 +03:00
setOOMScoreAdj ( - 1 ) ;
2011-12-01 12:15:44 +01:00
aeMain ( server . el ) ;
aeDeleteEventLoop ( server . el ) ;
return 0 ;
}
2010-06-22 00:07:48 +02:00
/* The End */