2021-01-17 08:48:48 -05:00
|
|
|
start_server {tags {"pubsub network"}} {
|
2021-06-09 08:13:24 -04:00
|
|
|
if {$::singledb} {
|
|
|
|
set db 0
|
|
|
|
} else {
|
|
|
|
set db 9
|
|
|
|
}
|
|
|
|
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 03:14:16 -05:00
|
|
|
foreach resp {2 3} {
|
2014-07-18 06:03:31 -04:00
|
|
|
set rd1 [redis_deferring_client]
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 03:14:16 -05:00
|
|
|
if {[lsearch $::denytags "resp3"] >= 0} {
|
|
|
|
if {$resp == 3} {continue}
|
|
|
|
} elseif {$::force_resp3} {
|
|
|
|
if {$resp == 2} {continue}
|
|
|
|
}
|
|
|
|
|
|
|
|
$rd1 hello $resp
|
|
|
|
$rd1 read
|
|
|
|
|
|
|
|
test "Pub/Sub PING on RESP$resp" {
|
|
|
|
subscribe $rd1 somechannel
|
|
|
|
# While subscribed to non-zero channels PING works in Pub/Sub mode.
|
|
|
|
$rd1 ping
|
|
|
|
$rd1 ping "foo"
|
|
|
|
# In RESP3, the SUBSCRIBEd client can issue any command and get a reply, so the PINGs are standard
|
|
|
|
# In RESP2, only a handful of commands are allowed after a client is SUBSCRIBED (PING is one of them).
|
|
|
|
# For some reason, the reply in that case is an array with two elements: "pong" and argv[1] or an empty string
|
|
|
|
# God knows why. Done in commit 2264b981
|
|
|
|
if {$resp == 3} {
|
|
|
|
assert_equal {PONG} [$rd1 read]
|
|
|
|
assert_equal {foo} [$rd1 read]
|
|
|
|
} else {
|
|
|
|
assert_equal {pong {}} [$rd1 read]
|
|
|
|
assert_equal {pong foo} [$rd1 read]
|
|
|
|
}
|
|
|
|
unsubscribe $rd1 somechannel
|
|
|
|
# Now we are unsubscribed, PING should just return PONG.
|
|
|
|
$rd1 ping
|
|
|
|
assert_equal {PONG} [$rd1 read]
|
|
|
|
|
|
|
|
}
|
2014-07-18 06:03:31 -04:00
|
|
|
$rd1 close
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 03:14:16 -05:00
|
|
|
}
|
2014-07-18 06:03:31 -04:00
|
|
|
|
2010-06-16 05:03:23 -04:00
|
|
|
test "PUBLISH/SUBSCRIBE basics" {
|
|
|
|
set rd1 [redis_deferring_client]
|
2010-06-15 16:40:21 -04:00
|
|
|
|
2010-06-16 05:03:23 -04:00
|
|
|
# subscribe to two channels
|
|
|
|
assert_equal {1 2} [subscribe $rd1 {chan1 chan2}]
|
2010-06-15 16:40:21 -04:00
|
|
|
assert_equal 1 [r publish chan1 hello]
|
|
|
|
assert_equal 1 [r publish chan2 world]
|
|
|
|
assert_equal {message chan1 hello} [$rd1 read]
|
|
|
|
assert_equal {message chan2 world} [$rd1 read]
|
|
|
|
|
2010-06-16 05:03:23 -04:00
|
|
|
# unsubscribe from one of the channels
|
|
|
|
unsubscribe $rd1 {chan1}
|
|
|
|
assert_equal 0 [r publish chan1 hello]
|
|
|
|
assert_equal 1 [r publish chan2 world]
|
|
|
|
assert_equal {message chan2 world} [$rd1 read]
|
2010-06-15 16:40:21 -04:00
|
|
|
|
2010-06-16 05:03:23 -04:00
|
|
|
# unsubscribe from the remaining channel
|
|
|
|
unsubscribe $rd1 {chan2}
|
|
|
|
assert_equal 0 [r publish chan1 hello]
|
|
|
|
assert_equal 0 [r publish chan2 world]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "PUBLISH/SUBSCRIBE with two clients" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
set rd2 [redis_deferring_client]
|
|
|
|
|
|
|
|
assert_equal {1} [subscribe $rd1 {chan1}]
|
|
|
|
assert_equal {1} [subscribe $rd2 {chan1}]
|
2010-06-15 16:40:21 -04:00
|
|
|
assert_equal 2 [r publish chan1 hello]
|
|
|
|
assert_equal {message chan1 hello} [$rd1 read]
|
|
|
|
assert_equal {message chan1 hello} [$rd2 read]
|
|
|
|
|
2010-06-16 05:03:23 -04:00
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
$rd2 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "PUBLISH/SUBSCRIBE after UNSUBSCRIBE without arguments" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1 2 3} [subscribe $rd1 {chan1 chan2 chan3}]
|
|
|
|
unsubscribe $rd1
|
|
|
|
assert_equal 0 [r publish chan1 hello]
|
|
|
|
assert_equal 0 [r publish chan2 hello]
|
|
|
|
assert_equal 0 [r publish chan3 hello]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "SUBSCRIBE to one channel more than once" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1 1 1} [subscribe $rd1 {chan1 chan1 chan1}]
|
2010-06-15 16:40:21 -04:00
|
|
|
assert_equal 1 [r publish chan1 hello]
|
2010-06-16 05:03:23 -04:00
|
|
|
assert_equal {message chan1 hello} [$rd1 read]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "UNSUBSCRIBE from non-subscribed channels" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {0 0 0} [unsubscribe $rd1 {foo bar quux}]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "PUBLISH/PSUBSCRIBE basics" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
|
|
|
|
# subscribe to two patterns
|
|
|
|
assert_equal {1 2} [psubscribe $rd1 {foo.* bar.*}]
|
|
|
|
assert_equal 1 [r publish foo.1 hello]
|
|
|
|
assert_equal 1 [r publish bar.1 hello]
|
|
|
|
assert_equal 0 [r publish foo1 hello]
|
|
|
|
assert_equal 0 [r publish barfoo.1 hello]
|
|
|
|
assert_equal 0 [r publish qux.1 hello]
|
|
|
|
assert_equal {pmessage foo.* foo.1 hello} [$rd1 read]
|
|
|
|
assert_equal {pmessage bar.* bar.1 hello} [$rd1 read]
|
|
|
|
|
|
|
|
# unsubscribe from one of the patterns
|
|
|
|
assert_equal {1} [punsubscribe $rd1 {foo.*}]
|
|
|
|
assert_equal 0 [r publish foo.1 hello]
|
|
|
|
assert_equal 1 [r publish bar.1 hello]
|
|
|
|
assert_equal {pmessage bar.* bar.1 hello} [$rd1 read]
|
|
|
|
|
|
|
|
# unsubscribe from the remaining pattern
|
|
|
|
assert_equal {0} [punsubscribe $rd1 {bar.*}]
|
|
|
|
assert_equal 0 [r publish foo.1 hello]
|
|
|
|
assert_equal 0 [r publish bar.1 hello]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "PUBLISH/PSUBSCRIBE with two clients" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
set rd2 [redis_deferring_client]
|
|
|
|
|
|
|
|
assert_equal {1} [psubscribe $rd1 {chan.*}]
|
|
|
|
assert_equal {1} [psubscribe $rd2 {chan.*}]
|
|
|
|
assert_equal 2 [r publish chan.foo hello]
|
|
|
|
assert_equal {pmessage chan.* chan.foo hello} [$rd1 read]
|
|
|
|
assert_equal {pmessage chan.* chan.foo hello} [$rd2 read]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
$rd2 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "PUBLISH/PSUBSCRIBE after PUNSUBSCRIBE without arguments" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1 2 3} [psubscribe $rd1 {chan1.* chan2.* chan3.*}]
|
|
|
|
punsubscribe $rd1
|
|
|
|
assert_equal 0 [r publish chan1.hi hello]
|
|
|
|
assert_equal 0 [r publish chan2.hi hello]
|
|
|
|
assert_equal 0 [r publish chan3.hi hello]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "PUNSUBSCRIBE from non-subscribed channels" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {0 0 0} [punsubscribe $rd1 {foo.* bar.* quux.*}]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
2014-08-01 13:57:30 -04:00
|
|
|
test "NUMSUB returns numbers, not strings (#1561)" {
|
|
|
|
r pubsub numsub abc def
|
|
|
|
} {abc 0 def 0}
|
|
|
|
|
2021-09-03 18:52:39 -04:00
|
|
|
test "NUMPATs returns the number of unique patterns" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
set rd2 [redis_deferring_client]
|
|
|
|
|
|
|
|
# Three unique patterns and one that overlaps
|
|
|
|
psubscribe $rd1 "foo*"
|
|
|
|
psubscribe $rd2 "foo*"
|
|
|
|
psubscribe $rd1 "bar*"
|
|
|
|
psubscribe $rd2 "baz*"
|
|
|
|
|
|
|
|
set patterns [r pubsub numpat]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
punsubscribe $rd1
|
|
|
|
punsubscribe $rd2
|
|
|
|
assert_equal 3 $patterns
|
2021-11-15 04:07:43 -05:00
|
|
|
$rd1 close
|
|
|
|
$rd2 close
|
2021-09-03 18:52:39 -04:00
|
|
|
}
|
|
|
|
|
2010-06-16 05:03:23 -04:00
|
|
|
test "Mix SUBSCRIBE and PSUBSCRIBE" {
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [subscribe $rd1 {foo.bar}]
|
|
|
|
assert_equal {2} [psubscribe $rd1 {foo.*}]
|
|
|
|
|
|
|
|
assert_equal 2 [r publish foo.bar hello]
|
|
|
|
assert_equal {message foo.bar hello} [$rd1 read]
|
|
|
|
assert_equal {pmessage foo.* foo.bar hello} [$rd1 read]
|
|
|
|
|
|
|
|
# clean up clients
|
|
|
|
$rd1 close
|
2010-06-15 16:40:21 -04:00
|
|
|
}
|
2013-01-21 12:50:16 -05:00
|
|
|
|
2013-01-28 07:04:23 -05:00
|
|
|
test "PUNSUBSCRIBE and UNSUBSCRIBE should always reply" {
|
2013-01-21 12:50:16 -05:00
|
|
|
# Make sure we are not subscribed to any channel at all.
|
|
|
|
r punsubscribe
|
|
|
|
r unsubscribe
|
|
|
|
# Now check if the commands still reply correctly.
|
|
|
|
set reply1 [r punsubscribe]
|
|
|
|
set reply2 [r unsubscribe]
|
|
|
|
concat $reply1 $reply2
|
|
|
|
} {punsubscribe {} 0 unsubscribe {} 0}
|
2013-01-28 07:04:23 -05:00
|
|
|
|
|
|
|
### Keyspace events notification tests
|
|
|
|
|
|
|
|
test "Keyspace notifications: we receive keyspace notifications" {
|
|
|
|
r config set notify-keyspace-events KA
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:foo set" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: we receive keyevent notifications" {
|
|
|
|
r config set notify-keyspace-events EA
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyevent@${db}__:set foo" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: we can receive both kind of events" {
|
|
|
|
r config set notify-keyspace-events KEA
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:foo set" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:set foo" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: we are able to mask events" {
|
|
|
|
r config set notify-keyspace-events KEl
|
|
|
|
r del mylist
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
|
|
|
r lpush mylist a
|
|
|
|
# No notification for set, because only list commands are enabled.
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mylist lpush" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:lpush mylist" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: general events test" {
|
|
|
|
r config set notify-keyspace-events KEg
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
|
|
|
r expire foo 1
|
|
|
|
r del foo
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:foo expire" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:expire foo" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:foo del" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:del foo" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: list events test" {
|
|
|
|
r config set notify-keyspace-events KEl
|
|
|
|
r del mylist
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r lpush mylist a
|
|
|
|
r rpush mylist a
|
|
|
|
r rpop mylist
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mylist lpush" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:lpush mylist" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mylist rpush" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:rpush mylist" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mylist rpop" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:rpop mylist" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: set events test" {
|
|
|
|
r config set notify-keyspace-events Ks
|
|
|
|
r del myset
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r sadd myset a b c d
|
|
|
|
r srem myset x
|
|
|
|
r sadd myset x y z
|
|
|
|
r srem myset x
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myset sadd" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myset sadd" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myset srem" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: zset events test" {
|
|
|
|
r config set notify-keyspace-events Kz
|
|
|
|
r del myzset
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r zadd myzset 1 a 2 b
|
|
|
|
r zrem myzset x
|
|
|
|
r zadd myzset 3 x 4 y 5 z
|
|
|
|
r zrem myzset x
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myzset zadd" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myzset zadd" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myzset zrem" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: hash events test" {
|
|
|
|
r config set notify-keyspace-events Kh
|
|
|
|
r del myhash
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r hmset myhash yes 1 no 0
|
|
|
|
r hincrby myhash yes 10
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myhash hset" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:myhash hincrby" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
2021-08-02 01:31:33 -04:00
|
|
|
test "Keyspace notifications: stream events test" {
|
|
|
|
r config set notify-keyspace-events Kt
|
|
|
|
r del mystream
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r xgroup create mystream mygroup $ mkstream
|
|
|
|
r xgroup createconsumer mystream mygroup Bob
|
|
|
|
set id [r xadd mystream 1 field1 A]
|
|
|
|
r xreadgroup group mygroup Alice STREAMS mystream >
|
|
|
|
r xclaim mystream mygroup Mike 0 $id force
|
|
|
|
# Not notify because of "Lee" not exists.
|
|
|
|
r xgroup delconsumer mystream mygroup Lee
|
|
|
|
# Not notify because of "Bob" exists.
|
|
|
|
r xautoclaim mystream mygroup Bob 0 $id
|
|
|
|
r xgroup delconsumer mystream mygroup Bob
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mystream xgroup-create" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mystream xgroup-createconsumer" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mystream xadd" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mystream xgroup-createconsumer" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mystream xgroup-createconsumer" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyspace@${db}__:mystream xgroup-delconsumer" [$rd1 read]
|
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
2013-01-28 07:04:23 -05:00
|
|
|
test "Keyspace notifications: expired events (triggered expire)" {
|
|
|
|
r config set notify-keyspace-events Ex
|
|
|
|
r del foo
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r psetex foo 100 1
|
|
|
|
wait_for_condition 50 100 {
|
|
|
|
[r exists foo] == 0
|
|
|
|
} else {
|
|
|
|
fail "Key does not expire?!"
|
|
|
|
}
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyevent@${db}__:expired foo" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: expired events (background expire)" {
|
|
|
|
r config set notify-keyspace-events Ex
|
|
|
|
r del foo
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r psetex foo 100 1
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyevent@${db}__:expired foo" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
$rd1 close
|
|
|
|
}
|
|
|
|
|
|
|
|
test "Keyspace notifications: evicted events" {
|
|
|
|
r config set notify-keyspace-events Ee
|
|
|
|
r config set maxmemory-policy allkeys-lru
|
|
|
|
r flushdb
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
|
|
|
r config set maxmemory 1
|
2021-06-09 08:13:24 -04:00
|
|
|
assert_equal "pmessage * __keyevent@${db}__:evicted foo" [$rd1 read]
|
2013-01-28 07:04:23 -05:00
|
|
|
r config set maxmemory 0
|
|
|
|
$rd1 close
|
2021-06-09 08:13:24 -04:00
|
|
|
r config set maxmemory-policy noeviction
|
|
|
|
} {OK} {needs:config-maxmemory}
|
2014-01-08 11:16:04 -05:00
|
|
|
|
|
|
|
test "Keyspace notifications: test CONFIG GET/SET of event flags" {
|
|
|
|
r config set notify-keyspace-events gKE
|
|
|
|
assert_equal {gKE} [lindex [r config get notify-keyspace-events] 1]
|
|
|
|
r config set notify-keyspace-events {$lshzxeKE}
|
|
|
|
assert_equal {$lshzxeKE} [lindex [r config get notify-keyspace-events] 1]
|
|
|
|
r config set notify-keyspace-events KA
|
|
|
|
assert_equal {AK} [lindex [r config get notify-keyspace-events] 1]
|
|
|
|
r config set notify-keyspace-events EA
|
|
|
|
assert_equal {AE} [lindex [r config get notify-keyspace-events] 1]
|
|
|
|
}
|
2022-04-13 04:36:38 -04:00
|
|
|
|
|
|
|
test "Keyspace notifications: new key test" {
|
|
|
|
r config set notify-keyspace-events En
|
|
|
|
set rd1 [redis_deferring_client]
|
|
|
|
assert_equal {1} [psubscribe $rd1 *]
|
|
|
|
r set foo bar
|
|
|
|
# second set of foo should not cause a 'new' event
|
|
|
|
r set foo baz
|
|
|
|
r set bar bar
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:new foo" [$rd1 read]
|
|
|
|
assert_equal "pmessage * __keyevent@${db}__:new bar" [$rd1 read]
|
|
|
|
$rd1 close
|
|
|
|
}
|
2013-01-21 12:50:16 -05:00
|
|
|
}
|