2021-06-09 08:13:24 -04:00
|
|
|
start_server {tags {"other"}} {
|
2011-07-11 06:56:00 -04:00
|
|
|
if {$::force_failure} {
|
|
|
|
# This is used just for test suite development purposes.
|
|
|
|
test {Failing test} {
|
|
|
|
format err
|
|
|
|
} {ok}
|
|
|
|
}
|
|
|
|
|
Add reply_schema to command json files (internal for now) (#10273)
Work in progress towards implementing a reply schema as part of COMMAND DOCS, see #9845
Since ironing the details of the reply schema of each and every command can take a long time, we
would like to merge this PR when the infrastructure is ready, and let this mature in the unstable branch.
Meanwhile the changes of this PR are internal, they are part of the repo, but do not affect the produced build.
### Background
In #9656 we add a lot of information about Redis commands, but we are missing information about the replies
### Motivation
1. Documentation. This is the primary goal.
2. It should be possible, based on the output of COMMAND, to be able to generate client code in typed
languages. In order to do that, we need Redis to tell us, in detail, what each reply looks like.
3. We would like to build a fuzzer that verifies the reply structure (for now we use the existing
testsuite, see the "Testing" section)
### Schema
The idea is to supply some sort of schema for the various replies of each command.
The schema will describe the conceptual structure of the reply (for generated clients), as defined in RESP3.
Note that the reply structure itself may change, depending on the arguments (e.g. `XINFO STREAM`, with
and without the `FULL` modifier)
We decided to use the standard json-schema (see https://json-schema.org/) as the reply-schema.
Example for `BZPOPMIN`:
```
"reply_schema": {
"oneOf": [
{
"description": "Timeout reached and no elements were popped.",
"type": "null"
},
{
"description": "The keyname, popped member, and its score.",
"type": "array",
"minItems": 3,
"maxItems": 3,
"items": [
{
"description": "Keyname",
"type": "string"
},
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
]
}
```
#### Notes
1. It is ok that some commands' reply structure depends on the arguments and it's the caller's responsibility
to know which is the relevant one. this comes after looking at other request-reply systems like OpenAPI,
where the reply schema can also be oneOf and the caller is responsible to know which schema is the relevant one.
2. The reply schemas will describe RESP3 replies only. even though RESP3 is structured, we want to use reply
schema for documentation (and possibly to create a fuzzer that validates the replies)
3. For documentation, the description field will include an explanation of the scenario in which the reply is sent,
including any relation to arguments. for example, for `ZRANGE`'s two schemas we will need to state that one
is with `WITHSCORES` and the other is without.
4. For documentation, there will be another optional field "notes" in which we will add a short description of
the representation in RESP2, in case it's not trivial (RESP3's `ZRANGE`'s nested array vs. RESP2's flat
array, for example)
Given the above:
1. We can generate the "return" section of all commands in [redis-doc](https://redis.io/commands/)
(given that "description" and "notes" are comprehensive enough)
2. We can generate a client in a strongly typed language (but the return type could be a conceptual
`union` and the caller needs to know which schema is relevant). see the section below for RESP2 support.
3. We can create a fuzzer for RESP3.
### Limitations (because we are using the standard json-schema)
The problem is that Redis' replies are more diverse than what the json format allows. This means that,
when we convert the reply to a json (in order to validate the schema against it), we lose information (see
the "Testing" section below).
The other option would have been to extend the standard json-schema (and json format) to include stuff
like sets, bulk-strings, error-string, etc. but that would mean also extending the schema-validator - and that
seemed like too much work, so we decided to compromise.
Examples:
1. We cannot tell the difference between an "array" and a "set"
2. We cannot tell the difference between simple-string and bulk-string
3. we cannot verify true uniqueness of items in commands like ZRANGE: json-schema doesn't cover the
case of two identical members with different scores (e.g. `[["m1",6],["m1",7]]`) because `uniqueItems`
compares (member,score) tuples and not just the member name.
### Testing
This commit includes some changes inside Redis in order to verify the schemas (existing and future ones)
are indeed correct (i.e. describe the actual response of Redis).
To do that, we added a debugging feature to Redis that causes it to produce a log of all the commands
it executed and their replies.
For that, Redis needs to be compiled with `-DLOG_REQ_RES` and run with
`--reg-res-logfile <file> --client-default-resp 3` (the testsuite already does that if you run it with
`--log-req-res --force-resp3`)
You should run the testsuite with the above args (and `--dont-clean`) in order to make Redis generate
`.reqres` files (same dir as the `stdout` files) which contain request-response pairs.
These files are later on processed by `./utils/req-res-log-validator.py` which does:
1. Goes over req-res files, generated by redis-servers, spawned by the testsuite (see logreqres.c)
2. For each request-response pair, it validates the response against the request's reply_schema
(obtained from the extended COMMAND DOCS)
5. In order to get good coverage of the Redis commands, and all their different replies, we chose to use
the existing redis test suite, rather than attempt to write a fuzzer.
#### Notes about RESP2
1. We will not be able to use the testing tool to verify RESP2 replies (we are ok with that, it's time to
accept RESP3 as the future RESP)
2. Since the majority of the test suite is using RESP2, and we want the server to reply with RESP3
so that we can validate it, we will need to know how to convert the actual reply to the one expected.
- number and boolean are always strings in RESP2 so the conversion is easy
- objects (maps) are always a flat array in RESP2
- others (nested array in RESP3's `ZRANGE` and others) will need some special per-command
handling (so the client will not be totally auto-generated)
Example for ZRANGE:
```
"reply_schema": {
"anyOf": [
{
"description": "A list of member elements",
"type": "array",
"uniqueItems": true,
"items": {
"type": "string"
}
},
{
"description": "Members and their scores. Returned in case `WITHSCORES` was used.",
"notes": "In RESP2 this is returned as a flat array",
"type": "array",
"uniqueItems": true,
"items": {
"type": "array",
"minItems": 2,
"maxItems": 2,
"items": [
{
"description": "Member",
"type": "string"
},
{
"description": "Score",
"type": "number"
}
]
}
}
]
}
```
### Other changes
1. Some tests that behave differently depending on the RESP are now being tested for both RESP,
regardless of the special log-req-res mode ("Pub/Sub PING" for example)
2. Update the history field of CLIENT LIST
3. Added basic tests for commands that were not covered at all by the testsuite
### TODO
- [x] (maybe a different PR) add a "condition" field to anyOf/oneOf schemas that refers to args. e.g.
when `SET` return NULL, the condition is `arguments.get||arguments.condition`, for `OK` the condition
is `!arguments.get`, and for `string` the condition is `arguments.get` - https://github.com/redis/redis/issues/11896
- [x] (maybe a different PR) also run `runtest-cluster` in the req-res logging mode
- [x] add the new tests to GH actions (i.e. compile with `-DLOG_REQ_RES`, run the tests, and run the validator)
- [x] (maybe a different PR) figure out a way to warn about (sub)schemas that are uncovered by the output
of the tests - https://github.com/redis/redis/issues/11897
- [x] (probably a separate PR) add all missing schemas
- [x] check why "SDOWN is triggered by misconfigured instance replying with errors" fails with --log-req-res
- [x] move the response transformers to their own file (run both regular, cluster, and sentinel tests - need to
fight with the tcl including mechanism a bit)
- [x] issue: module API - https://github.com/redis/redis/issues/11898
- [x] (probably a separate PR): improve schemas: add `required` to `object`s - https://github.com/redis/redis/issues/11899
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
Co-authored-by: Hanna Fadida <hanna.fadida@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Shaya Potter <shaya@redislabs.com>
2023-03-11 03:14:16 -05:00
|
|
|
test {Coverage: HELP commands} {
|
|
|
|
assert_match "*OBJECT <subcommand> *" [r OBJECT HELP]
|
|
|
|
assert_match "*MEMORY <subcommand> *" [r MEMORY HELP]
|
|
|
|
assert_match "*PUBSUB <subcommand> *" [r PUBSUB HELP]
|
|
|
|
assert_match "*SLOWLOG <subcommand> *" [r SLOWLOG HELP]
|
|
|
|
assert_match "*CLIENT <subcommand> *" [r CLIENT HELP]
|
|
|
|
assert_match "*COMMAND <subcommand> *" [r COMMAND HELP]
|
|
|
|
assert_match "*CONFIG <subcommand> *" [r CONFIG HELP]
|
|
|
|
assert_match "*FUNCTION <subcommand> *" [r FUNCTION HELP]
|
|
|
|
assert_match "*MODULE <subcommand> *" [r MODULE HELP]
|
|
|
|
}
|
|
|
|
|
|
|
|
test {Coverage: MEMORY MALLOC-STATS} {
|
|
|
|
if {[string match {*jemalloc*} [s mem_allocator]]} {
|
|
|
|
assert_match "*jemalloc*" [r memory malloc-stats]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
test {Coverage: MEMORY PURGE} {
|
|
|
|
if {[string match {*jemalloc*} [s mem_allocator]]} {
|
|
|
|
assert_equal {OK} [r memory purge]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-14 11:31:11 -04:00
|
|
|
test {SAVE - make sure there are all the types as values} {
|
|
|
|
# Wait for a background saving in progress to terminate
|
|
|
|
waitForBgsave r
|
|
|
|
r lpush mysavelist hello
|
|
|
|
r lpush mysavelist world
|
|
|
|
r set myemptykey {}
|
|
|
|
r set mynormalkey {blablablba}
|
|
|
|
r zadd mytestzset 10 a
|
|
|
|
r zadd mytestzset 20 b
|
|
|
|
r zadd mytestzset 30 c
|
|
|
|
r save
|
2021-06-09 08:13:24 -04:00
|
|
|
} {OK} {needs:save}
|
2010-05-14 11:31:11 -04:00
|
|
|
|
2011-07-10 17:25:48 -04:00
|
|
|
tags {slow} {
|
2011-07-11 06:15:35 -04:00
|
|
|
if {$::accurate} {set iterations 10000} else {set iterations 1000}
|
2010-06-02 18:16:10 -04:00
|
|
|
foreach fuzztype {binary alpha compr} {
|
|
|
|
test "FUZZ stresser with data model $fuzztype" {
|
|
|
|
set err 0
|
2011-07-11 06:15:35 -04:00
|
|
|
for {set i 0} {$i < $iterations} {incr i} {
|
2010-06-02 18:16:10 -04:00
|
|
|
set fuzz [randstring 0 512 $fuzztype]
|
|
|
|
r set foo $fuzz
|
|
|
|
set got [r get foo]
|
|
|
|
if {$got ne $fuzz} {
|
|
|
|
set err [list $fuzz $got]
|
|
|
|
break
|
|
|
|
}
|
2010-05-14 11:31:11 -04:00
|
|
|
}
|
2010-06-02 18:16:10 -04:00
|
|
|
set _ $err
|
|
|
|
} {0}
|
|
|
|
}
|
2010-05-14 11:31:11 -04:00
|
|
|
}
|
|
|
|
|
FLUSHDB and FLUSHALL add call forceCommandPropagation / FLUSHALL reset dirty counter to 0 if we enable save (#10691)
## FLUSHALL
We used to restore the dirty counter after `rdbSave` zeroed it if we enable save.
Otherwise FLUSHALL will not be replicated nor put into the AOF.
And then we do increment it again below.
Without that extra dirty++, when db was already empty, FLUSHALL
will not be replicated nor put into the AOF.
We now gonna replace all that dirty counter magic with a call
to forceCommandPropagation (REPL and AOF), instead of all the
messing around with the dirty counter.
Added tests to cover three part (dirty counter, REPL, AOF).
One benefit other than cleaner code is that the `rdb_changes_since_last_save` is correct in this case.
## FLUSHDB
FLUSHDB was not replicated nor put into the AOF when db was already empty.
Unlike DEL on a non-existing key, FLUSHDB always does something, and that's to call the module hook.
So basically FLUSHDB is never a NOP, and thus it should always be propagated.
Not doing that, could mean that if a module does something in that hook, and wants to
avoid issues of that hook being missing on the replica if the db is empty, it'll need to do complicated things.
So now FLUSHDB add call forceCommandPropagation, we will always propagate FLUSHDB.
Always propagating FLUSHDB seems like a safe approach that shouldn't have any drawbacks (other than looking odd)
This was mentioned in #8972
## Test section:
We actually found it while solving a race condition in the BGSAVE test (other.tcl).
It was found in extra_ci Daily Arm64 (test-libc-malloc).
```
[exception]: Executing test client: ERR Background save already in progress.
ERR Background save already in progress
```
It look like `r flushdb` trigger (schedule) a bgsave right after `waitForBgsave r` and before `r save`.
Changing flushdb to flushall, FLUSHALL will do a foreground save and then set the dirty counter to 0.
2022-05-11 04:21:16 -04:00
|
|
|
start_server {overrides {save ""} tags {external:skip}} {
|
|
|
|
test {FLUSHALL should not reset the dirty counter if we disable save} {
|
|
|
|
r set key value
|
|
|
|
r flushall
|
|
|
|
assert_morethan [s rdb_changes_since_last_save] 0
|
|
|
|
}
|
|
|
|
|
|
|
|
test {FLUSHALL should reset the dirty counter to 0 if we enable save} {
|
|
|
|
r config set save "3600 1 300 100 60 10000"
|
|
|
|
r set key value
|
|
|
|
r flushall
|
|
|
|
assert_equal [s rdb_changes_since_last_save] 0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-14 11:31:11 -04:00
|
|
|
test {BGSAVE} {
|
FLUSHDB and FLUSHALL add call forceCommandPropagation / FLUSHALL reset dirty counter to 0 if we enable save (#10691)
## FLUSHALL
We used to restore the dirty counter after `rdbSave` zeroed it if we enable save.
Otherwise FLUSHALL will not be replicated nor put into the AOF.
And then we do increment it again below.
Without that extra dirty++, when db was already empty, FLUSHALL
will not be replicated nor put into the AOF.
We now gonna replace all that dirty counter magic with a call
to forceCommandPropagation (REPL and AOF), instead of all the
messing around with the dirty counter.
Added tests to cover three part (dirty counter, REPL, AOF).
One benefit other than cleaner code is that the `rdb_changes_since_last_save` is correct in this case.
## FLUSHDB
FLUSHDB was not replicated nor put into the AOF when db was already empty.
Unlike DEL on a non-existing key, FLUSHDB always does something, and that's to call the module hook.
So basically FLUSHDB is never a NOP, and thus it should always be propagated.
Not doing that, could mean that if a module does something in that hook, and wants to
avoid issues of that hook being missing on the replica if the db is empty, it'll need to do complicated things.
So now FLUSHDB add call forceCommandPropagation, we will always propagate FLUSHDB.
Always propagating FLUSHDB seems like a safe approach that shouldn't have any drawbacks (other than looking odd)
This was mentioned in #8972
## Test section:
We actually found it while solving a race condition in the BGSAVE test (other.tcl).
It was found in extra_ci Daily Arm64 (test-libc-malloc).
```
[exception]: Executing test client: ERR Background save already in progress.
ERR Background save already in progress
```
It look like `r flushdb` trigger (schedule) a bgsave right after `waitForBgsave r` and before `r save`.
Changing flushdb to flushall, FLUSHALL will do a foreground save and then set the dirty counter to 0.
2022-05-11 04:21:16 -04:00
|
|
|
# Use FLUSHALL instead of FLUSHDB, FLUSHALL do a foreground save
|
|
|
|
# and reset the dirty counter to 0, so we won't trigger an unexpected bgsave.
|
|
|
|
r flushall
|
2010-05-14 11:31:11 -04:00
|
|
|
r save
|
|
|
|
r set x 10
|
|
|
|
r bgsave
|
|
|
|
waitForBgsave r
|
|
|
|
r debug reload
|
|
|
|
r get x
|
2021-12-19 10:41:51 -05:00
|
|
|
} {10} {needs:debug needs:save}
|
2010-05-14 11:31:11 -04:00
|
|
|
|
|
|
|
test {SELECT an out of range DB} {
|
|
|
|
catch {r select 1000000} err
|
|
|
|
set _ $err
|
2021-06-09 08:13:24 -04:00
|
|
|
} {*index is out of range*} {cluster:skip}
|
2010-05-14 11:31:11 -04:00
|
|
|
|
2011-07-10 17:25:48 -04:00
|
|
|
tags {consistency} {
|
2021-06-09 08:13:24 -04:00
|
|
|
proc check_consistency {dumpname code} {
|
|
|
|
set dump [csvdump r]
|
2021-12-19 10:41:51 -05:00
|
|
|
set sha1 [debug_digest]
|
2021-06-09 08:13:24 -04:00
|
|
|
|
|
|
|
uplevel 1 $code
|
|
|
|
|
2021-12-19 10:41:51 -05:00
|
|
|
set sha1_after [debug_digest]
|
2021-06-09 08:13:24 -04:00
|
|
|
if {$sha1 eq $sha1_after} {
|
|
|
|
return 1
|
|
|
|
}
|
|
|
|
|
|
|
|
# Failed
|
|
|
|
set newdump [csvdump r]
|
|
|
|
puts "Consistency test failed!"
|
|
|
|
puts "You can inspect the two dumps in /tmp/${dumpname}*.txt"
|
|
|
|
|
|
|
|
set fd [open /tmp/${dumpname}1.txt w]
|
|
|
|
puts $fd $dump
|
|
|
|
close $fd
|
|
|
|
set fd [open /tmp/${dumpname}2.txt w]
|
|
|
|
puts $fd $newdump
|
|
|
|
close $fd
|
|
|
|
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
|
|
|
|
if {$::accurate} {set numops 10000} else {set numops 1000}
|
|
|
|
test {Check consistency of different data types after a reload} {
|
|
|
|
r flushdb
|
|
|
|
createComplexDataset r $numops usetag
|
|
|
|
if {$::ignoredigest} {
|
|
|
|
set _ 1
|
|
|
|
} else {
|
|
|
|
check_consistency {repldump} {
|
|
|
|
r debug reload
|
2010-07-27 08:42:11 -04:00
|
|
|
}
|
2021-06-09 08:13:24 -04:00
|
|
|
}
|
2021-12-19 10:41:51 -05:00
|
|
|
} {1} {needs:debug}
|
2021-06-09 08:13:24 -04:00
|
|
|
|
|
|
|
test {Same dataset digest if saving/reloading as AOF?} {
|
|
|
|
if {$::ignoredigest} {
|
|
|
|
set _ 1
|
|
|
|
} else {
|
|
|
|
check_consistency {aofdump} {
|
|
|
|
r config set aof-use-rdb-preamble no
|
|
|
|
r bgrewriteaof
|
|
|
|
waitForBgrewriteaof r
|
|
|
|
r debug loadaof
|
2010-07-27 08:42:11 -04:00
|
|
|
}
|
2021-06-09 08:13:24 -04:00
|
|
|
}
|
|
|
|
} {1} {needs:debug}
|
2010-05-14 11:31:11 -04:00
|
|
|
}
|
|
|
|
|
2011-11-11 09:11:50 -05:00
|
|
|
test {EXPIRES after a reload (snapshot + append only file rewrite)} {
|
2010-05-14 11:31:11 -04:00
|
|
|
r flushdb
|
|
|
|
r set x 10
|
|
|
|
r expire x 1000
|
2011-07-10 17:25:48 -04:00
|
|
|
r save
|
|
|
|
r debug reload
|
2010-05-14 11:31:11 -04:00
|
|
|
set ttl [r ttl x]
|
|
|
|
set e1 [expr {$ttl > 900 && $ttl <= 1000}]
|
2011-07-10 17:25:48 -04:00
|
|
|
r bgrewriteaof
|
|
|
|
waitForBgrewriteaof r
|
|
|
|
r debug loadaof
|
2010-05-14 11:31:11 -04:00
|
|
|
set ttl [r ttl x]
|
|
|
|
set e2 [expr {$ttl > 900 && $ttl <= 1000}]
|
|
|
|
list $e1 $e2
|
2021-06-09 08:13:24 -04:00
|
|
|
} {1 1} {needs:debug needs:save}
|
2010-05-14 11:31:11 -04:00
|
|
|
|
2011-11-11 09:11:50 -05:00
|
|
|
test {EXPIRES after AOF reload (without rewrite)} {
|
|
|
|
r flushdb
|
|
|
|
r config set appendonly yes
|
2018-03-25 07:03:38 -04:00
|
|
|
r config set aof-use-rdb-preamble no
|
2011-11-11 09:11:50 -05:00
|
|
|
r set x somevalue
|
|
|
|
r expire x 1000
|
|
|
|
r setex y 2000 somevalue
|
|
|
|
r set z somevalue
|
|
|
|
r expireat z [expr {[clock seconds]+3000}]
|
|
|
|
|
|
|
|
# Milliseconds variants
|
|
|
|
r set px somevalue
|
|
|
|
r pexpire px 1000000
|
|
|
|
r psetex py 2000000 somevalue
|
|
|
|
r set pz somevalue
|
|
|
|
r pexpireat pz [expr {([clock seconds]+3000)*1000}]
|
|
|
|
|
|
|
|
# Reload and check
|
2011-12-21 03:24:14 -05:00
|
|
|
waitForBgrewriteaof r
|
2012-01-26 10:45:08 -05:00
|
|
|
# We need to wait two seconds to avoid false positives here, otherwise
|
|
|
|
# the DEBUG LOADAOF command may read a partial file.
|
|
|
|
# Another solution would be to set the fsync policy to no, since this
|
|
|
|
# prevents write() to be delayed by the completion of fsync().
|
|
|
|
after 2000
|
2011-11-11 09:11:50 -05:00
|
|
|
r debug loadaof
|
|
|
|
set ttl [r ttl x]
|
|
|
|
assert {$ttl > 900 && $ttl <= 1000}
|
|
|
|
set ttl [r ttl y]
|
|
|
|
assert {$ttl > 1900 && $ttl <= 2000}
|
|
|
|
set ttl [r ttl z]
|
|
|
|
assert {$ttl > 2900 && $ttl <= 3000}
|
|
|
|
set ttl [r ttl px]
|
|
|
|
assert {$ttl > 900 && $ttl <= 1000}
|
|
|
|
set ttl [r ttl py]
|
|
|
|
assert {$ttl > 1900 && $ttl <= 2000}
|
|
|
|
set ttl [r ttl pz]
|
|
|
|
assert {$ttl > 2900 && $ttl <= 3000}
|
|
|
|
r config set appendonly no
|
2021-06-09 08:13:24 -04:00
|
|
|
} {OK} {needs:debug}
|
2011-11-11 09:11:50 -05:00
|
|
|
|
2011-07-10 17:25:48 -04:00
|
|
|
tags {protocol} {
|
2011-01-09 13:42:56 -05:00
|
|
|
test {PIPELINING stresser (also a regression for the old epoll bug)} {
|
2019-09-12 03:56:54 -04:00
|
|
|
if {$::tls} {
|
2020-05-26 04:00:48 -04:00
|
|
|
set fd2 [::tls::socket [srv host] [srv port]]
|
2019-09-12 03:56:54 -04:00
|
|
|
} else {
|
2020-05-26 04:00:48 -04:00
|
|
|
set fd2 [socket [srv host] [srv port]]
|
2019-09-12 03:56:54 -04:00
|
|
|
}
|
2011-01-09 13:42:56 -05:00
|
|
|
fconfigure $fd2 -encoding binary -translation binary
|
2021-12-19 10:41:51 -05:00
|
|
|
if {!$::singledb} {
|
|
|
|
puts -nonewline $fd2 "SELECT 9\r\n"
|
|
|
|
flush $fd2
|
|
|
|
gets $fd2
|
|
|
|
}
|
2010-05-14 11:31:11 -04:00
|
|
|
|
2011-01-09 13:42:56 -05:00
|
|
|
for {set i 0} {$i < 100000} {incr i} {
|
|
|
|
set q {}
|
|
|
|
set val "0000${i}0000"
|
|
|
|
append q "SET key:$i $val\r\n"
|
|
|
|
puts -nonewline $fd2 $q
|
|
|
|
set q {}
|
|
|
|
append q "GET key:$i\r\n"
|
|
|
|
puts -nonewline $fd2 $q
|
|
|
|
}
|
|
|
|
flush $fd2
|
2010-05-14 11:31:11 -04:00
|
|
|
|
2011-01-09 13:42:56 -05:00
|
|
|
for {set i 0} {$i < 100000} {incr i} {
|
|
|
|
gets $fd2 line
|
|
|
|
gets $fd2 count
|
|
|
|
set count [string range $count 1 end]
|
|
|
|
set val [read $fd2 $count]
|
|
|
|
read $fd2 2
|
|
|
|
}
|
|
|
|
close $fd2
|
|
|
|
set _ 1
|
|
|
|
} {1}
|
|
|
|
}
|
2010-05-14 11:31:11 -04:00
|
|
|
|
|
|
|
test {APPEND basics} {
|
2016-04-25 09:49:57 -04:00
|
|
|
r del foo
|
2010-05-14 11:31:11 -04:00
|
|
|
list [r append foo bar] [r get foo] \
|
|
|
|
[r append foo 100] [r get foo]
|
|
|
|
} {3 bar 6 bar100}
|
|
|
|
|
|
|
|
test {APPEND basics, integer encoded values} {
|
|
|
|
set res {}
|
|
|
|
r del foo
|
|
|
|
r append foo 1
|
|
|
|
r append foo 2
|
|
|
|
lappend res [r get foo]
|
|
|
|
r set foo 1
|
|
|
|
r append foo 2
|
|
|
|
lappend res [r get foo]
|
|
|
|
} {12 12}
|
|
|
|
|
|
|
|
test {APPEND fuzzing} {
|
|
|
|
set err {}
|
|
|
|
foreach type {binary alpha compr} {
|
|
|
|
set buf {}
|
|
|
|
r del x
|
|
|
|
for {set i 0} {$i < 1000} {incr i} {
|
|
|
|
set bin [randstring 0 10 $type]
|
|
|
|
append buf $bin
|
|
|
|
r append x $bin
|
|
|
|
}
|
|
|
|
if {$buf != [r get x]} {
|
|
|
|
set err "Expected '$buf' found '[r get x]'"
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
set _ $err
|
|
|
|
} {}
|
|
|
|
|
|
|
|
# Leave the user with a clean DB before to exit
|
|
|
|
test {FLUSHDB} {
|
|
|
|
set aux {}
|
2021-06-09 08:13:24 -04:00
|
|
|
if {$::singledb} {
|
|
|
|
r flushdb
|
|
|
|
lappend aux 0 [r dbsize]
|
|
|
|
} else {
|
|
|
|
r select 9
|
|
|
|
r flushdb
|
|
|
|
lappend aux [r dbsize]
|
|
|
|
r select 10
|
|
|
|
r flushdb
|
|
|
|
lappend aux [r dbsize]
|
|
|
|
}
|
2010-05-14 11:31:11 -04:00
|
|
|
} {0 0}
|
|
|
|
|
|
|
|
test {Perform a final SAVE to leave a clean DB on disk} {
|
2011-07-11 09:44:38 -04:00
|
|
|
waitForBgsave r
|
2010-05-14 11:31:11 -04:00
|
|
|
r save
|
2021-06-09 08:13:24 -04:00
|
|
|
} {OK} {needs:save}
|
2020-11-05 03:51:26 -05:00
|
|
|
|
|
|
|
test {RESET clears client state} {
|
|
|
|
r client setname test-client
|
|
|
|
r client tracking on
|
|
|
|
|
|
|
|
assert_equal [r reset] "RESET"
|
|
|
|
set client [r client list]
|
|
|
|
assert_match {*name= *} $client
|
|
|
|
assert_match {*flags=N *} $client
|
2021-06-09 08:13:24 -04:00
|
|
|
} {} {needs:reset}
|
2020-11-05 03:51:26 -05:00
|
|
|
|
|
|
|
test {RESET clears MONITOR state} {
|
|
|
|
set rd [redis_deferring_client]
|
|
|
|
$rd monitor
|
|
|
|
assert_equal [$rd read] "OK"
|
|
|
|
|
|
|
|
$rd reset
|
|
|
|
assert_equal [$rd read] "RESET"
|
2021-11-15 04:07:43 -05:00
|
|
|
$rd close
|
2020-11-05 03:51:26 -05:00
|
|
|
|
|
|
|
assert_no_match {*flags=O*} [r client list]
|
2021-06-09 08:13:24 -04:00
|
|
|
} {} {needs:reset}
|
2020-11-05 03:51:26 -05:00
|
|
|
|
|
|
|
test {RESET clears and discards MULTI state} {
|
|
|
|
r multi
|
|
|
|
r set key-a a
|
|
|
|
|
|
|
|
r reset
|
|
|
|
catch {r exec} err
|
|
|
|
assert_match {*EXEC without MULTI*} $err
|
2021-06-09 08:13:24 -04:00
|
|
|
} {} {needs:reset}
|
2020-11-05 03:51:26 -05:00
|
|
|
|
|
|
|
test {RESET clears Pub/Sub state} {
|
|
|
|
r subscribe channel-1
|
|
|
|
r reset
|
|
|
|
|
|
|
|
# confirm we're not subscribed by executing another command
|
|
|
|
r set key val
|
2021-06-09 08:13:24 -04:00
|
|
|
} {OK} {needs:reset}
|
2020-11-05 03:51:26 -05:00
|
|
|
|
|
|
|
test {RESET clears authenticated state} {
|
|
|
|
r acl setuser user1 on >secret +@all
|
|
|
|
r auth user1 secret
|
|
|
|
assert_equal [r acl whoami] user1
|
|
|
|
|
|
|
|
r reset
|
|
|
|
|
|
|
|
assert_equal [r acl whoami] default
|
2021-06-09 08:13:24 -04:00
|
|
|
} {} {needs:reset}
|
2022-01-09 06:06:51 -05:00
|
|
|
|
|
|
|
test "Subcommand syntax error crash (issue #10070)" {
|
|
|
|
assert_error {*unknown command*} {r GET|}
|
|
|
|
assert_error {*unknown command*} {r GET|SET}
|
|
|
|
assert_error {*unknown command*} {r GET|SET|OTHER}
|
|
|
|
assert_error {*unknown command*} {r CONFIG|GET GET_XX}
|
2022-04-25 06:08:13 -04:00
|
|
|
assert_error {*unknown subcommand*} {r CONFIG GET_XX}
|
2022-01-09 06:06:51 -05:00
|
|
|
}
|
2010-05-14 11:31:11 -04:00
|
|
|
}
|
2020-11-03 10:16:11 -05:00
|
|
|
|
2021-06-09 08:13:24 -04:00
|
|
|
start_server {tags {"other external:skip"}} {
|
2022-01-09 06:06:51 -05:00
|
|
|
test {Don't rehash if redis has child process} {
|
2020-11-03 10:16:11 -05:00
|
|
|
r config set save ""
|
|
|
|
r config set rdb-key-save-delay 1000000
|
|
|
|
|
|
|
|
populate 4096 "" 1
|
|
|
|
r bgsave
|
2021-03-08 14:22:08 -05:00
|
|
|
wait_for_condition 10 100 {
|
|
|
|
[s rdb_bgsave_in_progress] eq 1
|
|
|
|
} else {
|
|
|
|
fail "bgsave did not start in time"
|
|
|
|
}
|
|
|
|
|
2020-11-03 10:16:11 -05:00
|
|
|
r mset k1 v1 k2 v2
|
|
|
|
# Hash table should not rehash
|
|
|
|
assert_no_match "*table size: 8192*" [r debug HTSTATS 9]
|
|
|
|
exec kill -9 [get_child_pid 0]
|
2022-03-07 06:44:07 -05:00
|
|
|
waitForBgsave r
|
|
|
|
after 200 ;# waiting for serverCron
|
2020-11-03 10:16:11 -05:00
|
|
|
|
|
|
|
# Hash table should rehash since there is no child process,
|
Limit the main db and expires dictionaries to expand (#7954)
As we know, redis may reject user's requests or evict some keys if
used memory is over maxmemory. Dictionaries expanding may make
things worse, some big dictionaries, such as main db and expires dict,
may eat huge memory at once for allocating a new big hash table and be
far more than maxmemory after expanding.
There are related issues: #4213 #4583
More details, when expand dict in redis, we will allocate a new big
ht[1] that generally is double of ht[0], The size of ht[1] will be
very big if ht[0] already is big. For db dict, if we have more than
64 million keys, we need to cost 1GB for ht[1] when dict expands.
If the sum of used memory and new hash table of dict needed exceeds
maxmemory, we shouldn't allow the dict to expand. Because, if we
enable keys eviction, we still couldn't add much more keys after
eviction and rehashing, what's worse, redis will keep less keys when
redis only remains a little memory for storing new hash table instead
of users' data. Moreover users can't write data in redis if disable
keys eviction.
What this commit changed ?
Add a new member function expandAllowed for dict type, it provide a way
for caller to allow expand or not. We expose two parameters for this
function: more memory needed for expanding and dict current load factor,
users can implement a function to make a decision by them.
For main db dict and expires dict type, these dictionaries may be very
big and cost huge memory for expanding, so we implement a judgement
function: we can stop dict to expand provisionally if used memory will
be over maxmemory after dict expands, but to guarantee the performance
of redis, we still allow dict to expand if dict load factor exceeds the
safe load factor.
Add test cases to verify we don't allow main db to expand when left
memory is not enough, so that avoid keys eviction.
Other changes:
For new hash table size when expand. Before this commit, the size is
that double used of dict and later _dictNextPower. Actually we aim to
control a dict load factor between 0.5 and 1.0. Now we replace *2 with
+1, since the first check is that used >= size, the outcome of before
will usually be the same as _dictNextPower(used+1). The only case where
it'll differ is when dict_can_resize is false during fork, so that later
the _dictNextPower(used*2) will cause the dict to jump to *4 (i.e.
_dictNextPower(1025*2) will return 4096).
Fix rehash test cases due to changing algorithm of new hash table size
when expand.
2020-12-06 04:53:04 -05:00
|
|
|
# size is power of two and over 4098, so it is 8192
|
2020-11-03 10:16:11 -05:00
|
|
|
r set k3 v3
|
Limit the main db and expires dictionaries to expand (#7954)
As we know, redis may reject user's requests or evict some keys if
used memory is over maxmemory. Dictionaries expanding may make
things worse, some big dictionaries, such as main db and expires dict,
may eat huge memory at once for allocating a new big hash table and be
far more than maxmemory after expanding.
There are related issues: #4213 #4583
More details, when expand dict in redis, we will allocate a new big
ht[1] that generally is double of ht[0], The size of ht[1] will be
very big if ht[0] already is big. For db dict, if we have more than
64 million keys, we need to cost 1GB for ht[1] when dict expands.
If the sum of used memory and new hash table of dict needed exceeds
maxmemory, we shouldn't allow the dict to expand. Because, if we
enable keys eviction, we still couldn't add much more keys after
eviction and rehashing, what's worse, redis will keep less keys when
redis only remains a little memory for storing new hash table instead
of users' data. Moreover users can't write data in redis if disable
keys eviction.
What this commit changed ?
Add a new member function expandAllowed for dict type, it provide a way
for caller to allow expand or not. We expose two parameters for this
function: more memory needed for expanding and dict current load factor,
users can implement a function to make a decision by them.
For main db dict and expires dict type, these dictionaries may be very
big and cost huge memory for expanding, so we implement a judgement
function: we can stop dict to expand provisionally if used memory will
be over maxmemory after dict expands, but to guarantee the performance
of redis, we still allow dict to expand if dict load factor exceeds the
safe load factor.
Add test cases to verify we don't allow main db to expand when left
memory is not enough, so that avoid keys eviction.
Other changes:
For new hash table size when expand. Before this commit, the size is
that double used of dict and later _dictNextPower. Actually we aim to
control a dict load factor between 0.5 and 1.0. Now we replace *2 with
+1, since the first check is that used >= size, the outcome of before
will usually be the same as _dictNextPower(used+1). The only case where
it'll differ is when dict_can_resize is false during fork, so that later
the _dictNextPower(used*2) will cause the dict to jump to *4 (i.e.
_dictNextPower(1025*2) will return 4096).
Fix rehash test cases due to changing algorithm of new hash table size
when expand.
2020-12-06 04:53:04 -05:00
|
|
|
assert_match "*table size: 8192*" [r debug HTSTATS 9]
|
2021-12-19 10:41:51 -05:00
|
|
|
} {} {needs:debug needs:local-process}
|
2020-11-03 10:16:11 -05:00
|
|
|
}
|
2021-01-28 11:17:39 -05:00
|
|
|
|
|
|
|
proc read_proc_title {pid} {
|
|
|
|
set fd [open "/proc/$pid/cmdline" "r"]
|
|
|
|
set cmdline [read $fd 1024]
|
|
|
|
close $fd
|
|
|
|
|
|
|
|
return $cmdline
|
|
|
|
}
|
|
|
|
|
2021-06-09 08:13:24 -04:00
|
|
|
start_server {tags {"other external:skip"}} {
|
2021-01-28 11:17:39 -05:00
|
|
|
test {Process title set as expected} {
|
|
|
|
# Test only on Linux where it's easy to get cmdline without relying on tools.
|
|
|
|
# Skip valgrind as it messes up the arguments.
|
|
|
|
set os [exec uname]
|
|
|
|
if {$os == "Linux" && !$::valgrind} {
|
|
|
|
# Set a custom template
|
|
|
|
r config set "proc-title-template" "TEST {title} {listen-addr} {port} {tls-port} {unixsocket} {config-file}"
|
|
|
|
set cmdline [read_proc_title [srv 0 pid]]
|
|
|
|
|
|
|
|
assert_equal "TEST" [lindex $cmdline 0]
|
|
|
|
assert_match "*/redis-server" [lindex $cmdline 1]
|
|
|
|
|
|
|
|
if {$::tls} {
|
|
|
|
set expect_port 0
|
|
|
|
set expect_tls_port [srv 0 port]
|
|
|
|
} else {
|
|
|
|
set expect_port [srv 0 port]
|
|
|
|
set expect_tls_port 0
|
|
|
|
}
|
|
|
|
set port [srv 0 port]
|
|
|
|
|
|
|
|
assert_equal "$::host:$port" [lindex $cmdline 2]
|
|
|
|
assert_equal $expect_port [lindex $cmdline 3]
|
|
|
|
assert_equal $expect_tls_port [lindex $cmdline 4]
|
|
|
|
assert_match "*/tests/tmp/server.*/socket" [lindex $cmdline 5]
|
|
|
|
assert_match "*/tests/tmp/redis.conf.*" [lindex $cmdline 6]
|
|
|
|
|
|
|
|
# Try setting a bad template
|
|
|
|
catch {r config set "proc-title-template" "{invalid-var}"} err
|
|
|
|
assert_match {*template format is invalid*} $err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|